Commit Graph

8873 Commits

Author SHA1 Message Date
Gogs
fbb2b1650f Core/Accounts: prevent existing account ban from being updated
Signed-off-by: jackpoz <giacomopoz@gmail.com>
2017-12-17 19:11:06 +01:00
jackpoz
657683df7e Core/Misc: Fix clang 6 warnings 2017-12-17 16:42:43 +01:00
Wyreth
ae878e18ef Core/Creature: implement school immunity for creatures in creature_template (#20709) 2017-12-17 16:29:22 +01:00
Léo Gautheron
e96cf0b242 Core/Unit: make neutral guards attack players involved in PvP
Fix https://github.com/TrinityCore/TrinityCore/issues/17635
2017-12-17 15:29:30 +01:00
ariel-
484c681e43 Core/Entities: fixed rage gain from attacking script-invincible targets
Closes #3856
2017-12-16 21:04:20 -03:00
ariel-
98236dfa88 Core/GameObject: refactor dismounting on use 2017-12-16 18:00:02 -03:00
jackpoz
72e97d330b Core/Spells: Fixed Naxx Anub Scarab Summoning Spell
Reduce spell radius of 28864 and 29105 from 100 yards to 10 yards to spawn scarabs closer
2017-12-16 19:00:19 +01:00
ariel-
3722a96f4f Core/Spells: allow auras to proc from partial blocks
Closes #21065
2017-12-16 06:04:14 -03:00
ariel-
2ce3f3a7b8 Core/GameObject: implement dismount on use of certain GOs
- The fact of player dismounting was entirely client-sided, with no server code enforcing it.

Closes #19979
2017-12-16 05:01:37 -03:00
Gustavo
51c4196acf Core/Entities: add extra use of UPDATETYPE_CREATE_OBJECT2 (#20955) 2017-12-15 21:11:02 -03:00
ariel-
7d39ed8119 Core/Auras: travis 2017-12-15 19:22:48 -03:00
ariel-
e6d529a75a Core/Auras: implemented SPELL_AURA_MOD_ATTACK_POWER_OF_ARMOR delay mechanic 2017-12-15 13:26:34 -03:00
ariel-
7dff0e3246 Core/Auras: fixed off by one error in counting SPELL_ATTR5_START_PERIODIC_AT_APPLY ticks
- Made SpellInfo::GetMaxTicks and AuraEffect::GetTotalTicks return the same number without mods (dumped arbitrary default return value of 6 and arbitrary 30 sec limit)
- They should be streamlined whenever SPELL_AURA_48 is implemented
2017-12-15 03:40:36 -03:00
ariel-
a36e804ae4 Core/Auras: periodics refactor part 5: ported periodic trigger spell auras to scripts 2017-12-15 01:46:52 -03:00
ariel-
193bd3b452 Core/Auras: periodics refactor part 4: ported periodic dummy auras to scripts 2017-12-15 01:46:51 -03:00
ariel-
16e20711d2 Core/Auras: periodics refactor part 3: move more switch hacks to scripts
- Incidentally fixed some spells which were supposed to be removed by proc instead of healing to full
2017-12-15 00:37:12 -03:00
ariel-
0510bf7afe Core/Auras: periodics refactor part 2: Move UpdatePeriodic to AuraScripts 2017-12-15 00:35:28 -03:00
ariel-
5d91beb1db Core/Auras: periodics refactor part 1:
- Don't skip ticks if diff is greater than amplitude
- Fixed spells without ampltude in DBC
2017-12-15 00:25:58 -03:00
Golrag
95456ab5d8 Core/Entities: Some changes to LoS z checking & MotionMaster::MoveJumpTo (PR #20970)
- Use Midsection height for LoS checking.
- Changed MotionMaster::MoveJumpTo to use correct z. This change also makes sure the _owner will jump towards the given angle. Instead of jumping to a unintended angle if the first one is not in LoS.
2017-12-14 16:56:30 +01:00
Shauren
6122006b0c Core/Spells: Changed channel triggered spells to inherit positive/negative status from main spells
Closes #18259
Closes #21041
2017-12-13 21:46:42 +01:00
ariel-
78a1c687a2 Core/Misc: minor typo and codestyle fixes
- Replace NULL uses in new code with nullptr
- Fix wrong (accumulated) load time log when loading calendar invites
- Make Creature::CanRegenerateHealth const as its just a getter
- Mark OnlyOnceAreaTriggerScript::OnTrigger as final in case someone wants to override that (you are supposed to use protected _OnTrigger hook)
2017-12-13 14:43:12 -03:00
Shauren
e19bb7a1a5 Core/Misc: Really fixed nopch MSVC build 2017-12-11 23:14:01 +01:00
ccrs
daef1493f2 Core/Movement: correction on header use on some generators 2017-12-11 23:01:00 +01:00
Shauren
e977bb4c4d Core/Misc: Fixed nopch MSVC build 2017-12-11 22:15:52 +01:00
ccrs
0db5516a1a Core/AI: reorder methods in ScriptedEscortAI
plus ninja rename
2017-12-11 21:00:04 +01:00
joschiwald
842a65ac15 Core/Spells: Spells with TARGET_SELECT_CATEGORY_NEARBY requires a valid target (#20954) 2017-12-10 11:16:43 +01:00
Ovah
51bcd1a918 Core/Spells: Gathering no longer fails after patch 3.1.0 (#21039)
* Core/Skills: gathering items with orange skill level will no longer fail as it has been removed with patch 3.1.0

Closes #21038
2017-12-09 22:58:22 +01:00
xinef1
2286da2166 Move some packets processing to map context (#18638)
Core/Network: Allow some packets to be processied in map context
2017-12-09 16:14:10 +01:00
jackpoz
24e82fe83d Core/Misc: Fix static analysis issues
Fix static analysis issues reported by 3rd party tools
2017-12-08 23:27:30 +01:00
jackpoz
925557d1c0 Core/Misc: Fix static analysis issues
Fix various coverity reported issues
2017-12-08 15:14:51 +01:00
jackpoz
19e99478a7 Core/Misc: Fix static analysis issues
Fix coverity id 1382860
2017-12-08 12:47:36 +01:00
Ovah
869affa893 Core/Creatures: Implemented extra flag to use offhand attacks (#21008)
* Fixed initial offhand attack timer so the main and offhand attacks will now act blizzlike instead of getting executed at the same time

Note: since some creature equipment items cannot be identified as weapon since they are only visual items there is no way to detect this automaticly
2017-12-07 17:41:11 +01:00
Shauren
d011097ab0 Core/Spells: Fixed accessing freed memory after reloading spell_area 2017-12-02 20:59:21 +01:00
jackpoz
8e1c74d95a Core/Spell: Validate spell_dbc DB data on startup
Validate spell_dbc DB data on startup (max effect type, max aura type, max target type).
Delete some invalid spells from spell_dbc table. Make sure to apply the SQL script or worldserver will assert on startup.
2017-12-02 16:08:48 +01:00
jackpoz
3d1ba42f42 Core/Misc: Fix out of bounds access on startup
Fix out of bound access on startup trying to access SpellEffects with ID greater than max allowed/known.
Reported by AddressSanitizer .
2017-12-02 12:56:23 +01:00
Ovah
abc4b48fe9 Core/Auras: Implemented PROC_HIT_INTERRUPT (#21015) 2017-12-02 08:12:30 +01:00
jackpoz
072c884ed8 Core/CreatureAI: Disable TotemAI from database
Disable TotemAI set in creature_template, triggering an assert when spawning the creature
2017-12-01 21:50:37 +01:00
Aokromes
e4398fa1da Misc: Move startup error to DBErrors 2017-12-01 14:52:30 +01:00
Treeston
b4df977ca6 woops (ref 76a4c7d) 2017-11-30 21:11:32 +01:00
Treeston
76a4c7d974 Some misc streamlining/cleanup:
- std::chrono overloads for SummonCreature
- Removed misleading const qualifier from SummonCreature (it wasn't being honored)
- Rename parameters of SummonCreature to follow convention
- EventProcessor has a new method (AddEventAtOffset) that adds an event...at an offset. Genius.

PS: Hi there Keader.
2017-11-30 20:55:53 +01:00
jackpoz
032194099e Core/WorldSession: Fix idle WorldSessions getting kicked twice as fast as supposed
Fix SocketTimeOutTime and SocketTimeOutTimeActive settings being effectively halved by reducing the timeout time twice every update instead of just once, causing much faster kicks (i.e. after 30 seconds with 60 seconds set in the configs).
2017-11-30 20:35:57 +01:00
iridinite
9d454eb3df [3.3.5] Core/AuctionHouse: Auction bidders (#18328)
* Save more auction bidders than the highest bidder only
2017-11-27 23:00:30 +01:00
Shauren
463ed5e1ac Core/Items: Fixed sending unlocked items by mail
Closes #20976
2017-11-26 23:34:20 +01:00
jackpoz
724499cf9c Core/Maps: Fix memory leak in BoundaryUnionBoundary
Add missing destructor in BoundaryUnionBoundary to avoid reporting a memory leak (even if it's used only in a global variable)
2017-11-26 12:30:02 +01:00
jackpoz
6dda09818d Core/Quests: Fix memory leak in Quest Greeting 2017-11-26 11:52:45 +01:00
Killyana
e85a48179e Core/Reputation: Fix reaction with rival factions
Closes #9469
Ref #20661
2017-11-25 19:35:44 +01:00
Aokromes
6c9c106d39 Misc: More cleanup 2017-11-25 03:00:05 +01:00
Aokromes
59e94fd9bb Misc: More cleanup 2017-11-25 02:39:27 +01:00
Aokromes
5f2c5f2ed3 Misc: Kill trailing white spaces 2017-11-25 01:05:15 +01:00
Killyana
f3a00a1822 Spell: Remove a phase hack for The Eye of Acherus
Npcs are now spawned on phase 2, some spawns still missing on phase 1 and 2, need to wait for future commits.
2017-11-24 17:21:10 +01:00