jackpoz
f26a028d97
Core/Misc: Fix some static analysis issues
...
Fix some static analysis issues about uninitialized values. Most of them are false positives, always initialized before being accessed.
2014-03-16 14:18:33 +01:00
untaught
5f7e0f6929
Instance Script/Stratholme: Correct logic in Baron Run event and add SAI for Ysida Harmon
2014-03-16 08:47:27 +02:00
jackpoz
a1aa4547b3
Scripts/Krikthir the Gatewatcher: Fix EVENT_ANUBAR_CHARGE event not being triggered
...
Fix EVENT_ANUBAR_CHARGE not being triggered due to value 0 being set to the EVENT_ANUBAR_CHARGE enum, even if 0 is a special value for EventMap to specify no event was triggered.
Issue added in a127c0e1a7
2014-03-15 20:08:55 +01:00
jackpoz
e30b471f8e
Scripts/AhnKahet: Fix some uninitialized values
...
Initialize all class fields in the constructor, even if they are set in Reset() and they shouldn't be accessed before Reset() is called.
This fixes 2 Coverity reports.
2014-03-15 20:04:59 +01:00
jackpoz
3b247f6bca
Scripts/ZulGurub/Jeklik: Add missing "break"
2014-03-15 19:45:44 +01:00
jackpoz
ba28b16d2e
Scripts/TheStormPeaks: Possible crash fix
...
Apply safe NULL checks added in 7d881a0739
2014-03-09 17:17:12 +01:00
jackpoz
d357597270
Scripts/Commands: Fix crash in ".kick" command
...
Fix a NULL dereference exception happening when using .kick command caused by a strtok(NULL) call without a previous call to the string to be tokenized.
Issue added in 101cad1f28
2014-03-09 17:09:15 +01:00
joschiwald
3a40d8a887
Core/Player: delete queststatus (weekly/monthly/seasonal) on deleting character thx @Expecto
...
- also rename some prepared statements
Closes #11658
2014-03-02 00:00:39 +01:00
jackpoz
61890bce7c
Scripts/Onyxia Lair: Fix debug assertions about iterators
2014-02-26 21:44:51 +01:00
w1sht0l1v3
50d99005a5
Scripts/Ulduar: Fix Algalon the Observer outro phase(fixes kill credit and some achieves).
2014-02-16 02:27:44 +02:00
MitchesD
6907d51b6b
Scripts/Kelthuzad: move spells into spelldifficulty_dbc and cleanup
2014-02-15 23:18:54 +01:00
joschiwald
b72273014f
Core/DB/Achievements:
...
- fixed arena season title achievements and rewards
- added mailtemplate support for `achievement_reward` table
- fixed typo in GetBattleMasterBG which causes achievement reward mail expire in 1 day
Ref #8777
2014-02-10 00:14:29 +01:00
Vincent_Michael
a5a6799b4e
Scripts: Added missing stuff in 1d1aeda86c
2014-02-09 19:15:17 +01:00
Vincent_Michael
1d1aeda86c
Core: Fix build
2014-02-09 19:01:56 +01:00
joschiwald
6688370513
Merge pull request #11457 from MitchesD/krikthir
...
Scripts/Krikthir the Gatewatcher: converted to EventMap and small optimalization
2014-02-09 18:46:26 +01:00
MitchesD
a127c0e1a7
Scripts/Krikthir the Gatewatcher: converted to EventMap and small optimization
2014-02-09 18:41:37 +01:00
jackpoz
aaa4b3a124
Scripts/Eastern Plaguelands: Fix flypath exploit
...
Fix npc id 17209 in Eastern Plaguelands enabling taxi cheat to players just by talking to it.
2014-02-08 17:22:29 +01:00
joschiwald
b000fdca70
Core/Entities: allow interaction with gameobject questgivers if player can take or return quests
...
Closes #11269
Closes #8898
Closes #10204
Closes #11410
Closes #7053
Closes #6189
Closes #9474
2014-02-06 21:23:18 +01:00
w1sht0l1v3
2df3fe3a00
Core/Scripts: Fix quest The Totem of Kar'dash alliance version.
...
Remove some hungarian notation for horde side version.
Closes #11035
2014-02-01 19:07:48 +02:00
Discover-
a242662ae6
Core/Spells: Fix DK Ghoul's damage after ad8eb434c0. I misread 'SpellScript::m_damage' for 'SpellScript::damage'.
...
By @joschiwald
2014-01-31 10:37:55 +01:00
jackpoz
856e0933b5
Scripts/HoR: Fix log error
...
Fix "DoZoneInCombat called for creature that has empty threat list" error caused by DoZoneInCombat() called by IsSummonedBy() in a script before the Creature is allowed to enter combat.
2014-01-30 21:29:37 +01:00
Discover-
ad8eb434c0
Core/Misc: Missing changes and get rid of useless method in acd46085d1
2014-01-30 10:28:05 +01:00
joschiwald
acd46085d1
Core/Spells: drop last leftovers of hardcoded spell target selection and move it into spellscripts
...
Closes #1719
Closes #3186
2014-01-30 02:40:12 +01:00
joschiwald
166f7d41da
Core/Spells: addition to 96060bf007
2014-01-27 23:01:37 +01:00
joschiwald
6dc15294e2
Core/Spells: move paladins judgements to spellscripts
2014-01-26 23:56:53 +01:00
Vincent_Michael
79a2a0c434
Core/Spell: Fix logic fail in 96ae4caf62
2014-01-26 16:42:02 +01:00
Vincent_Michael
96ae4caf62
Core/Spells: Fix typo in 955fb907c5
2014-01-26 03:56:41 +01:00
Vincent_Michael
955fb907c5
Core: Fix warnings
2014-01-26 03:48:33 +01:00
joschiwald
fbddda52e7
Core/Spells: move more spells to spellscripts
2014-01-26 02:24:57 +01:00
joschiwald
96060bf007
Core/Spells: move some spells so spellscripts
2014-01-26 01:02:20 +01:00
Vincent_Michael
c6650ecc71
Core/Spells: Move Pilgrims Bounty BuffFood in AuraScript (mimimi)
2014-01-25 16:28:29 +01:00
Vincent_Michael
9531073b77
Scripts: Gossip can crash with null instance
2014-01-24 17:08:17 +01:00
joschiwald
b169d6bafb
Fix build
2014-01-24 01:47:24 +01:00
joschiwald
f0c4224603
Core/Spells: move killing spree to spellscript
...
Closes #10597
Closes #11468
2014-01-24 01:32:15 +01:00
Vincent_Michael
46e1b93c2b
Scripts: A lots of changes here and there (maybe useless?!?)
2014-01-23 22:54:01 +01:00
joschiwald
d6c5307a81
Scripts/Spells: use new hook in some spellscripts
2014-01-23 20:55:47 +01:00
joschiwald
f731116766
Scripts/AhnKahet: fix some issues on prince taldaram script
2014-01-23 18:21:17 +01:00
MitchesD
57e599fa02
Scripts/ZulGurub/Jeklik: fixed flying in first phase, reworked spawn and rewritten to EventMap
...
Closes #11277
2014-01-22 23:46:45 +01:00
Vincent_Michael
516a6344fe
Misc: Fix warnings
2014-01-22 07:31:37 +01:00
Vincent_Michael
101ac7f511
Misc: Minor cosmetic changes here and there
2014-01-21 20:20:38 +01:00
Discover-
f6264169d8
Merge pull request #11299 from Carbenium/MailboxCmd
...
Core/Command: Add mailbox command
2014-01-19 07:29:11 -08:00
Discover-
c7b78a2b4e
Core/Commands: Using the '.gm vis off' command now instantly makes the GM invisible to non-GM players, instead of waiting until Player::UpdateObjectVisibility was called from a different method.
...
Ref. #11467
2014-01-19 14:03:09 +01:00
w1sht0l1v3
c18fd0378d
Core/Scripts: Fix the cleanup in 54dbf870b8.
2014-01-19 03:20:36 +02:00
w1sht0l1v3
8367944171
Core/Scripts: Fix kill credit for quest The Hunter and the Prince(13400).
2014-01-19 00:30:25 +02:00
Discover-
735cebf7a3
Core/Commands: The .setskill command is now usable even if the player doesn't already have the skill learned.
2014-01-18 01:05:03 +01:00
Zabustak
101cad1f28
Show Kick, Mute and Ban in world
2014-01-17 12:23:36 +01:00
zengwf
23acf75d3b
Core/Movement: Add LOS check for fleeingmovement target point.
...
Prevents fleeing or feared units from going to upper floor ignoring walls/ceilings with mmaps on(and usually get stucked).
Current implementation just randomly selects a distance and angle against the frighting unit, when in narrow circumstance such as underground caves, such targeting point would be at another floor.
Closes #11300
Ref #9475 (needs fixed confirmation)
2014-01-12 00:33:33 +00:00
Duarte Duarte
65c941b88d
Merge pull request #11342 from Carbenium/Svala
...
Scripting/Utgarde Pinnaccle: Fix visual during Svala's transformation
2014-01-11 16:20:16 -08:00
Dr-J
b83c252851
Scripts/NPCs: Remove core script for rogue trainers which was overriding db conditions
...
SAI and conditions for rogue trainers to provide elegant leter to rogues provided that is level 24 or higher, does not have elegant letter and does not have taken, rewarded or complete the quest which elegant letter starts
Closes #11378
Signed-off-by: DDuarte <dnpd.dd@gmail.com >
2014-01-12 00:17:21 +00:00
joschiwald
7378baee49
Scripts/PoS/Garfrost: cleanup saronit blocks after death
2014-01-10 17:37:03 +01:00
