Alan Deutscher e11a13c755 Core/Players: Improve trade exchange calculations (#24435)
* Add some comments to Player::CanStoreItems to help me wrap my head around how the method works.

* Experimental fix for incoming trade-stack problem.

* Only add to stacks that aren't already full.

* Use remaining_count instead of static 1.

* Remove debug logging from exploration.

* More uses of remaining_count for consistency.

* Correct space count check

* Correct overflow problem.

* Remove redundant check, handled in existing for statement.

* Store Item pointers in order to be able to merge in multiple incoming stacks.

* Build fix - was continually working locally, but failing in CI.

* Break build in order to keep PR focused on Player.cpp changes.

* Adjust phrasing of how arrays are initialized.

* Fix phrasing of comments to avoid sounding like a ToDo item

* In the spirit of b649273d5f, rephrase an old comment to be a statement rather than a question.
2020-04-16 20:21:01 +02:00
2020-04-10 18:08:18 +02:00
2020-03-20 21:53:20 +01:00
2020-01-02 06:25:50 +01:00
2017-10-16 21:35:00 +02:00
2019-12-08 17:35:25 +01:00
2020-01-04 14:11:51 +01:00
2020-04-05 15:17:02 +02:00
2018-01-01 01:55:29 +01:00
2013-01-21 02:47:51 +00:00
2018-03-07 00:21:08 +01:00
2020-01-02 06:25:50 +01:00
2020-01-04 18:58:55 +01:00

logo TrinityCore (3.3.5)

Average time to resolve an issue Percentage of issues still open

Build Status

master 3.3.5
master Build Status 3.3.5 Build Status
master Build status Build status
Coverity Scan Build Status Coverity Scan Build Status

Introduction

TrinityCore is a MMORPG Framework based mostly in C++.

It is derived from MaNGOS, the Massive Network Game Object Server, and is based on the code of that project with extensive changes over time to optimize, improve and cleanup the codebase at the same time as improving the in-game mechanics and functionality.

It is completely open source; community involvement is highly encouraged.

If you wish to contribute ideas or code please visit our site linked below or make pull requests to our Github repository.

For further information on the TrinityCore project, please visit our project website at TrinityCore.org.

Requirements

Software requirements are available in the wiki for Windows, Linux and OS X.

Install

Detailed installation guides are available in the wiki for Windows, Linux and OS X.

Reporting issues

Issues can be reported via the Github issue tracker.

Please take the time to review existing issues before submitting your own to prevent duplicates.

In addition, thoroughly read through the issue tracker guide to ensure your report contains the required information. Incorrect or poorly formed reports are wasteful and are subject to deletion.

Submitting fixes

C++ fixes are submitted as pull requests via Github. For more information on how to properly submit a pull request, read the how-to: maintain a remote fork. For SQL only fixes open a ticket or if a bug report exists for the bug post on existing ticket.

License: GPL 2.0

Read file COPYING.

Authors & Contributors

Read file AUTHORS.

Description
Server emulator for World of Warcraft 3.3.5.12340 and other versions
Readme 10 GiB
Languages
C++ 89%
C 10.4%
CMake 0.4%