aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorShauren <shauren.trinity@gmail.com>2023-02-25 21:12:28 +0100
committerShauren <shauren.trinity@gmail.com>2023-08-23 18:46:35 +0200
commitdce71612efa11bad7f25c65962d455843bd79baf (patch)
tree703a91e192a7f8472c2cc6da16d9ab7b17b7d296
parent0728d194d9d8fa6c91e6c7dfbc9e06c02963d7fe (diff)
Core/Spells: Prevent rerolling gathering skillups until success when mining or gathering herbs
(cherry picked from commit 92b7c98c018c1b950a45fb639e70871dca739ebd)
-rw-r--r--src/server/game/Spells/SpellEffects.cpp6
1 files changed, 4 insertions, 2 deletions
diff --git a/src/server/game/Spells/SpellEffects.cpp b/src/server/game/Spells/SpellEffects.cpp
index 578a8d635b8..3b247b74095 100644
--- a/src/server/game/Spells/SpellEffects.cpp
+++ b/src/server/game/Spells/SpellEffects.cpp
@@ -1668,9 +1668,11 @@ void Spell::EffectOpenLock()
if (gameObjTarget)
{
// Allow one skill-up until respawned
- if (!gameObjTarget->IsInSkillupList(player->GetGUID()) &&
- player->UpdateGatherSkill(skillId, pureSkillValue, reqSkillValue, 1, gameObjTarget))
+ if (!gameObjTarget->IsInSkillupList(player->GetGUID()))
+ {
+ player->UpdateGatherSkill(skillId, pureSkillValue, reqSkillValue, 1, gameObjTarget);
gameObjTarget->AddToSkillupList(player->GetGUID());
+ }
}
else if (itemTarget)
{