diff options
author | Naios <naios-dev@live.de> | 2015-03-18 19:08:45 +0100 |
---|---|---|
committer | Naios <naios-dev@live.de> | 2015-03-18 20:20:04 +0100 |
commit | 433bc289c2c82b7377ad0189e415a3ca070d220f (patch) | |
tree | 649dd7ebb7d6a63bb599d9a1aeae87d693f220ab /src/server/bnetserver/Server/ModuleManager.h | |
parent | e40a5bf0b1483ce4275464a0a75a3d99035ca71c (diff) |
Core/Misc: Fix some issues detected by static analysis
* Assignment of function parameter has no effect outside the function. Did you forget dereferencing it?
-> This argument is passed by value, it makes no sence so set it to null here.
* Member variable 'instance_violet_hold_InstanceMapScript::bWiped' is not initialized in the constructor.
* Mismatching allocation and deallocation: Data
Diffstat (limited to 'src/server/bnetserver/Server/ModuleManager.h')
-rw-r--r-- | src/server/bnetserver/Server/ModuleManager.h | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/src/server/bnetserver/Server/ModuleManager.h b/src/server/bnetserver/Server/ModuleManager.h index 05a7298e27c..68d5b2a1e78 100644 --- a/src/server/bnetserver/Server/ModuleManager.h +++ b/src/server/bnetserver/Server/ModuleManager.h @@ -54,9 +54,10 @@ namespace Battlenet memcpy(Data, right.Data, DataSize); } } + ~ModuleInfo() { - delete Data; + delete[] Data; } std::string Type; |