Core: Combat/threat system rewrite (PR #19930)

- PvE combat is now always mutual. UNIT_FLAG_IN_COMBAT is backed by actual references to the units we're in combat with.
- PvP combat is now also tracked, and almost always mutual; spells like Vanish and Feign Death can break this rule. That means we can easily determine a list of players we're fighting.
- By extension, IsInCombatWith now has sensible behavior when invoked on nonplayers.
- Threat and combat systems are no longer the same.
  - They still have an enforced relationship (threat implies combat - clearing combat clears threat)...
  - ...but we can have combat without threat. A creature (with threat list) isn't considered to be engaged until it has an entry on its threat list...
  - ...which means we can now faithfully replicate retail engage behavior. Combat on projectile launch - engagement start on projectile impact. Yay for progress!
- AI method refactor, as already ported in 6113b9d - `JustEngagedWith`, `JustEnteredCombat` and `JustExitedCombat`.
- Vehicle threat is now properly pooled on the main vehicle body (fixes #16542).
- Various edge case bug fixes for threat redirects (Misdirection "cancelling" Vigilance and similar).
- Target re-selection is now significantly faster.
- Fixed a ton of other smaller edge case bugs, probably.

Closes #7951 and #19998.

(cherry picked from commit 532ab1c7f8653d1a2e48aa1f1f8a9ba1041d4bb7)

1 files changed, 0 insertions, 216 deletions

diff --git a/src/server/game/Combat/HostileRefManager.cpp b/src/server/game/Combat/HostileRefManager.cpp
deleted file mode 100644
index 503091cf573..00000000000
--- a/src/server/game/Combat/HostileRefManager.cpp
+++ /dev/null
@@ -1,216 +0,0 @@
-/*
- * This file is part of the TrinityCore Project. See AUTHORS file for Copyright information
- *
- * This program is free software; you can redistribute it and/or modify it
- * under the terms of the GNU General Public License as published by the
- * Free Software Foundation; either version 2 of the License, or (at your
- * option) any later version.
- *
- * This program is distributed in the hope that it will be useful, but WITHOUT
- * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
- * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for
- * more details.
- *
- * You should have received a copy of the GNU General Public License along
- * with this program. If not, see <http://www.gnu.org/licenses/>.
- */
-
-#include "HostileRefManager.h"
-#include "DB2Structure.h"
-#include "SpellInfo.h"
-#include "ThreatManager.h"
-#include "Unit.h"
-
-HostileRefManager::~HostileRefManager()
-{
-    deleteReferences();
-}
-
-//=================================================
-// send threat to all my haters for the victim
-// The victim is then hated by them as well
-// use for buffs and healing threat functionality
-
-void HostileRefManager::threatAssist(Unit* victim, float baseThreat, SpellInfo const* threatSpell)
-{
-    if (getSize() == 0)
-        return;
-
-    float threat = ThreatCalcHelper::calcThreat(victim, iOwner, baseThreat, (threatSpell ? threatSpell->GetSchoolMask() : SPELL_SCHOOL_MASK_NORMAL), threatSpell);
-    threat /= getSize();
-
-    HostileReference* ref = getFirst();
-    while (ref)
-    {
-        if (ThreatCalcHelper::isValidProcess(victim, ref->GetSource()->GetOwner(), threatSpell))
-            ref->GetSource()->doAddThreat(victim, threat);
-
-        ref = ref->next();
-    }
-}
-
-//=================================================
-
-void HostileRefManager::addTempThreat(float threat, bool apply)
-{
-    HostileReference* ref = getFirst();
-    while (ref)
-    {
-        if (apply)
-        {
-            if (ref->getTempThreatModifier() == 0.0f)
-                ref->addTempThreat(threat);
-        }
-        else
-            ref->resetTempThreat();
-
-        ref = ref->next();
-    }
-}
-
-//=================================================
-
-void HostileRefManager::addThreatPercent(int32 percent)
-{
-    HostileReference* ref = getFirst();
-    while (ref)
-    {
-        ref->addThreatPercent(percent);
-        ref = ref->next();
-    }
-}
-
-//=================================================
-// The online / offline status is given to the method. The calculation has to be done before
-
-void HostileRefManager::setOnlineOfflineState(bool isOnline)
-{
-    HostileReference* ref = getFirst();
-    while (ref)
-    {
-        ref->setOnlineOfflineState(isOnline);
-        ref = ref->next();
-    }
-}
-
-//=================================================
-// The online / offline status is calculated and set
-
-void HostileRefManager::updateThreatTables()
-{
-    HostileReference* ref = getFirst();
-    while (ref)
-    {
-        ref->updateOnlineStatus();
-        ref = ref->next();
-    }
-}
-
-//=================================================
-// The references are not needed anymore
-// tell the source to remove them from the list and free the mem
-
-void HostileRefManager::deleteReferences()
-{
-    HostileReference* ref = getFirst();
-    while (ref)
-    {
-        HostileReference* nextRef = ref->next();
-        ref->removeReference();
-        delete ref;
-        ref = nextRef;
-    }
-}
-
-//=================================================
-// delete one reference, defined by faction
-
-void HostileRefManager::deleteReferencesForFaction(uint32 faction)
-{
-    HostileReference* ref = getFirst();
-    while (ref)
-    {
-        HostileReference* nextRef = ref->next();
-        if (ref->GetSource()->GetOwner()->GetFactionTemplateEntry()->Faction == faction)
-        {
-            ref->removeReference();
-            delete ref;
-        }
-        ref = nextRef;
-    }
-}
-
-//=================================================
-// delete all references out of specified range
-
-void HostileRefManager::deleteReferencesOutOfRange(float range)
-{
-    HostileReference* ref = getFirst();
-    range = range*range;
-    while (ref)
-    {
-        HostileReference* nextRef = ref->next();
-        Unit* owner = ref->GetSource()->GetOwner();
-        if (!owner->isActiveObject() && owner->GetExactDist2dSq(GetOwner()) > range)
-        {
-            ref->removeReference();
-            delete ref;
-        }
-        ref = nextRef;
-    }
-}
-
-//=================================================
-// delete one reference, defined by Unit
-
-void HostileRefManager::deleteReference(Unit* creature)
-{
-    HostileReference* ref = getFirst();
-    while (ref)
-    {
-        HostileReference* nextRef = ref->next();
-        if (ref->GetSource()->GetOwner() == creature)
-        {
-            ref->removeReference();
-            delete ref;
-            break;
-        }
-        ref = nextRef;
-    }
-}
-
-//=================================================
-// set state for one reference, defined by Unit
-
-void HostileRefManager::setOnlineOfflineState(Unit* creature, bool isOnline)
-{
-    HostileReference* ref = getFirst();
-    while (ref)
-    {
-        HostileReference* nextRef = ref->next();
-        if (ref->GetSource()->GetOwner() == creature)
-        {
-            ref->setOnlineOfflineState(isOnline);
-            break;
-        }
-        ref = nextRef;
-    }
-}
-
-//=================================================
-
-void HostileRefManager::UpdateVisibility()
-{
-    HostileReference* ref = getFirst();
-    while (ref)
-    {
-        HostileReference* nextRef = ref->next();
-        if (!ref->GetSource()->GetOwner()->CanSeeOrDetect(GetOwner()))
-        {
-            nextRef = ref->next();
-            ref->removeReference();
-            delete ref;
-        }
-        ref = nextRef;
-    }
-}