diff options
| author | Shauren <shauren.trinity@gmail.com> | 2024-10-25 15:36:11 +0200 |
|---|---|---|
| committer | Shauren <shauren.trinity@gmail.com> | 2024-10-25 15:36:11 +0200 |
| commit | 067fa31d152ecb10e5bea0419f84f7b79b96abf5 (patch) | |
| tree | 9b5921a62ff86259f613f6e8f1e3e9b294be14a8 /src/server/game/Entities/Player | |
| parent | 6dab3791ae7c810114ac1d5dbdd3b018813e2a97 (diff) | |
Core/PacketIO: Move writing data sizes in SMSG_UPDATE_OBJECT to shared functions instead of spreading it in all overrides
Diffstat (limited to 'src/server/game/Entities/Player')
| -rw-r--r-- | src/server/game/Entities/Player/Player.cpp | 12 |
1 files changed, 0 insertions, 12 deletions
diff --git a/src/server/game/Entities/Player/Player.cpp b/src/server/game/Entities/Player/Player.cpp index fa15f098ec8..468c611d30a 100644 --- a/src/server/game/Entities/Player/Player.cpp +++ b/src/server/game/Entities/Player/Player.cpp @@ -3647,23 +3647,17 @@ UF::UpdateFieldFlag Player::GetUpdateFieldFlagsFor(Player const* target) const void Player::BuildValuesCreate(ByteBuffer* data, Player const* target) const { UF::UpdateFieldFlag flags = GetUpdateFieldFlagsFor(target); - std::size_t sizePos = data->wpos(); - *data << uint32(0); *data << uint8(flags); m_objectData->WriteCreate(*data, flags, this, target); m_unitData->WriteCreate(*data, flags, this, target); m_playerData->WriteCreate(*data, flags, this, target); if (target == this) m_activePlayerData->WriteCreate(*data, flags, this, target); - - data->put<uint32>(sizePos, data->wpos() - sizePos - 4); } void Player::BuildValuesUpdate(ByteBuffer* data, Player const* target) const { UF::UpdateFieldFlag flags = GetUpdateFieldFlagsFor(target); - std::size_t sizePos = data->wpos(); - *data << uint32(0); *data << uint32(m_values.GetChangedObjectTypeMask() & ~(uint32(target != this) << TYPEID_ACTIVE_PLAYER)); if (m_values.HasChanged(TYPEID_OBJECT)) @@ -3677,8 +3671,6 @@ void Player::BuildValuesUpdate(ByteBuffer* data, Player const* target) const if (target == this && m_values.HasChanged(TYPEID_ACTIVE_PLAYER)) m_activePlayerData->WriteUpdate(*data, flags, this, target); - - data->put<uint32>(sizePos, data->wpos() - sizePos - 4); } void Player::BuildValuesUpdateWithFlag(ByteBuffer* data, UF::UpdateFieldFlag flags, Player const* target) const @@ -3687,8 +3679,6 @@ void Player::BuildValuesUpdateWithFlag(ByteBuffer* data, UF::UpdateFieldFlag fla valuesMask.Set(TYPEID_UNIT); valuesMask.Set(TYPEID_PLAYER); - std::size_t sizePos = data->wpos(); - *data << uint32(0); *data << uint32(valuesMask.GetBlock(0)); UF::UnitData::Mask mask; @@ -3698,8 +3688,6 @@ void Player::BuildValuesUpdateWithFlag(ByteBuffer* data, UF::UpdateFieldFlag fla UF::PlayerData::Mask mask2; m_playerData->AppendAllowedFieldsMaskForFlag(mask2, flags); m_playerData->WriteUpdate(*data, mask2, true, this, target); - - data->put<uint32>(sizePos, data->wpos() - sizePos - 4); } void Player::BuildValuesUpdateForPlayerWithMask(UpdateData* data, UF::ObjectData::Mask const& requestedObjectMask, |