diff options
| author | Shauren <shauren.trinity@gmail.com> | 2025-07-11 17:40:34 +0200 |
|---|---|---|
| committer | Shauren <shauren.trinity@gmail.com> | 2025-07-11 17:40:34 +0200 |
| commit | cbb532e4bec11d59f2072441a43b7c797de6d16d (patch) | |
| tree | 27a0dc63805e527d2f47744963fc2f341493ce27 /src/server/game/Handlers/QuestHandler.cpp | |
| parent | ae197a62b77cd93799571b16756c372081704929 (diff) | |
Core/Groups: Use iterators instead of raw LinkedListElement to interact with group members
Diffstat (limited to 'src/server/game/Handlers/QuestHandler.cpp')
| -rw-r--r-- | src/server/game/Handlers/QuestHandler.cpp | 12 |
1 files changed, 6 insertions, 6 deletions
diff --git a/src/server/game/Handlers/QuestHandler.cpp b/src/server/game/Handlers/QuestHandler.cpp index d86bbf17cb1..085ec2e1ff9 100644 --- a/src/server/game/Handlers/QuestHandler.cpp +++ b/src/server/game/Handlers/QuestHandler.cpp @@ -152,11 +152,11 @@ void WorldSession::HandleQuestgiverAcceptQuestOpcode(WorldPackets::Quest::QuestG { if (Group* group = _player->GetGroup()) { - for (GroupReference* itr = group->GetFirstMember(); itr != nullptr; itr = itr->next()) + for (GroupReference const& itr : group->GetMembers()) { - Player* player = itr->GetSource(); + Player* player = itr.GetSource(); - if (!player || player == _player || !player->IsInMap(_player)) // not self and in same map + if (player == _player || !player->IsInMap(_player)) // not self and in same map continue; if (player->CanTakeQuest(quest, true)) @@ -595,11 +595,11 @@ void WorldSession::HandlePushQuestToParty(WorldPackets::Quest::PushQuestToParty& return; } - for (GroupReference* itr = group->GetFirstMember(); itr != nullptr; itr = itr->next()) + for (GroupReference const& itr : group->GetMembers()) { - Player* receiver = itr->GetSource(); + Player* receiver = itr.GetSource(); - if (!receiver || receiver == sender) + if (receiver == sender) continue; if (!receiver->GetPlayerSharingQuest().IsEmpty()) |