Core/PacketIO: Fixed object update failures caused by bad data in fall info

1 files changed, 75 insertions, 81 deletions

diff --git a/src/server/game/Movement/MovementStructures.cpp b/src/server/game/Movement/MovementStructures.cpp
index a0f70c7b96c..db305e52454 100644
--- a/src/server/game/Movement/MovementStructures.cpp
+++ b/src/server/game/Movement/MovementStructures.cpp
@@ -54,8 +54,8 @@ MovementStatusElements const PlayerMove[] =
     MSEHasPitch,
     MSEGuidByte5,
     MSEFallHorizontalSpeed,
-    MSEFallCosAngle,
     MSEFallSinAngle,
+    MSEFallCosAngle,
     MSEFallVerticalSpeed,
     MSEFallTime,
     MSESplineElevation,
@@ -153,9 +153,9 @@ MovementStatusElements const MovementFallLand[] =
     MSETransportGuidByte2,
     MSEFallVerticalSpeed,
     MSEFallTime,
-    MSEFallCosAngle,
-    MSEFallHorizontalSpeed,
     MSEFallSinAngle,
+    MSEFallHorizontalSpeed,
+    MSEFallCosAngle,
     MSESplineElevation,
     MSETimestamp,
     MSEPitch,
@@ -227,8 +227,8 @@ MovementStatusElements const MovementHeartBeat[] =
     MSEFallVerticalSpeed,
     MSEFallTime,
     MSEFallHorizontalSpeed,
-    MSEFallSinAngle,
     MSEFallCosAngle,
+    MSEFallSinAngle,
     MSEPitch,
     MSESplineElevation,
     MSETimestamp,
@@ -297,8 +297,8 @@ MovementStatusElements const MovementJump[] =
     MSETransportGuidByte5,
     MSEPitch,
     MSETimestamp,
-    MSEFallCosAngle,
     MSEFallSinAngle,
+    MSEFallCosAngle,
     MSEFallHorizontalSpeed,
     MSEFallVerticalSpeed,
     MSEFallTime,
@@ -368,8 +368,8 @@ MovementStatusElements const MovementSetFacing[] =
     MSETransportTime,
     MSETransportGuidByte7,
     MSEFallHorizontalSpeed,
-    MSEFallSinAngle,
     MSEFallCosAngle,
+    MSEFallSinAngle,
     MSEFallTime,
     MSEFallVerticalSpeed,
     MSESplineElevation,
@@ -442,8 +442,8 @@ MovementStatusElements const MovementSetPitch[] =
     MSEFallVerticalSpeed,
     MSEFallTime,
     MSEFallHorizontalSpeed,
-    MSEFallCosAngle,
     MSEFallSinAngle,
+    MSEFallCosAngle,
     MSEPitch,
     MSESplineElevation,
     MSETimestamp,
@@ -514,8 +514,8 @@ MovementStatusElements const MovementStartBackward[] =
     MSEPitch,
     MSETimestamp,
     MSEFallHorizontalSpeed,
-    MSEFallSinAngle,
     MSEFallCosAngle,
+    MSEFallSinAngle,
     MSEFallVerticalSpeed,
     MSEFallTime,
     MSEOrientation,
@@ -569,8 +569,8 @@ MovementStatusElements const MovementStartForward[] =
     MSEGuidByte0,
     MSEFallVerticalSpeed,
     MSEFallHorizontalSpeed,
-    MSEFallCosAngle,
     MSEFallSinAngle,
+    MSEFallCosAngle,
     MSEFallTime,
     MSETransportGuidByte3,
     MSETransportPositionY,
@@ -640,9 +640,9 @@ MovementStatusElements const MovementStartStrafeLeft[] =
     MSEGuidByte7,
     MSEGuidByte4,
     MSEGuidByte5,
-    MSEFallSinAngle,
-    MSEFallHorizontalSpeed,
     MSEFallCosAngle,
+    MSEFallHorizontalSpeed,
+    MSEFallSinAngle,
     MSEFallTime,
     MSEFallVerticalSpeed,
     MSETransportSeat,
@@ -730,8 +730,8 @@ MovementStatusElements const MovementStartStrafeRight[] =
     MSETransportGuidByte3,
     MSEPitch,
     MSEOrientation,
-    MSEFallCosAngle,
     MSEFallSinAngle,
+    MSEFallCosAngle,
     MSEFallHorizontalSpeed,
     MSEFallTime,
     MSEFallVerticalSpeed,
@@ -784,8 +784,8 @@ MovementStatusElements const MovementStartTurnLeft[] =
     MSEGuidByte3,
     MSEGuidByte2,
     MSEGuidByte1,
-    MSEFallSinAngle,
     MSEFallCosAngle,
+    MSEFallSinAngle,
     MSEFallHorizontalSpeed,
     MSEFallVerticalSpeed,
     MSEFallTime,
@@ -873,8 +873,8 @@ MovementStatusElements const MovementStartTurnRight[] =
     MSETransportGuidByte3,
     MSETransportTime2,
     MSEFallHorizontalSpeed,
-    MSEFallSinAngle,
     MSEFallCosAngle,
+    MSEFallSinAngle,
     MSEFallTime,
     MSEFallVerticalSpeed,
     MSEPitch,
@@ -948,8 +948,8 @@ MovementStatusElements const MovementStop[] =
     MSEOrientation,
     MSEPitch,
     MSESplineElevation,
-    MSEFallCosAngle,
     MSEFallSinAngle,
+    MSEFallCosAngle,
     MSEFallHorizontalSpeed,
     MSEFallVerticalSpeed,
     MSEFallTime,
@@ -1016,9 +1016,9 @@ MovementStatusElements const MovementStopStrafe[] =
     MSETransportPositionY,
     MSETransportTime2,
     MSETransportGuidByte7,
-    MSEFallCosAngle,
-    MSEFallHorizontalSpeed,
     MSEFallSinAngle,
+    MSEFallHorizontalSpeed,
+    MSEFallCosAngle,
     MSEFallTime,
     MSEFallVerticalSpeed,
     MSESplineElevation,
@@ -1091,8 +1091,8 @@ MovementStatusElements const MovementStopTurn[] =
     MSETransportGuidByte6,
     MSEFallTime,
     MSEFallHorizontalSpeed,
-    MSEFallCosAngle,
     MSEFallSinAngle,
+    MSEFallCosAngle,
     MSEFallVerticalSpeed,
     MSETimestamp,
     MSEPitch,
@@ -1160,8 +1160,8 @@ MovementStatusElements const MovementStartAscend[] =
     MSETransportGuidByte0,
     MSETransportGuidByte1,
     MSETransportPositionX,
-    MSEFallCosAngle,
     MSEFallSinAngle,
+    MSEFallCosAngle,
     MSEFallHorizontalSpeed,
     MSEFallTime,
     MSEFallVerticalSpeed,
@@ -1234,8 +1234,8 @@ MovementStatusElements const MovementStartDescend[] =
     MSETransportOrientation,
     MSETransportGuidByte0,
     MSEFallTime,
-    MSEFallSinAngle,
     MSEFallCosAngle,
+    MSEFallSinAngle,
     MSEFallHorizontalSpeed,
     MSEFallVerticalSpeed,
     MSETimestamp,
@@ -1305,9 +1305,9 @@ MovementStatusElements const MovementStartSwim[] =
     MSETransportGuidByte7,
     MSETransportGuidByte0,
     MSETransportSeat,
-    MSEFallCosAngle,
-    MSEFallHorizontalSpeed,
     MSEFallSinAngle,
+    MSEFallHorizontalSpeed,
+    MSEFallCosAngle,
     MSEFallVerticalSpeed,
     MSEFallTime,
     MSEOrientation,
@@ -1377,9 +1377,9 @@ MovementStatusElements const MovementStopSwim[] =
     MSETransportGuidByte0,
     MSETransportOrientation,
     MSEFallVerticalSpeed,
-    MSEFallCosAngle,
-    MSEFallHorizontalSpeed,
     MSEFallSinAngle,
+    MSEFallHorizontalSpeed,
+    MSEFallCosAngle,
     MSEFallTime,
     MSETimestamp,
     MSEPitch,
@@ -1450,8 +1450,8 @@ MovementStatusElements const MovementStopAscend[] =
     MSETransportPositionZ,
     MSEFallTime,
     MSEFallVerticalSpeed,
-    MSEFallCosAngle,
     MSEFallSinAngle,
+    MSEFallCosAngle,
     MSEFallHorizontalSpeed,
     MSEPitch,
     MSESplineElevation,
@@ -1506,8 +1506,8 @@ MovementStatusElements const MovementStopPitch[] =
     MSEGuidByte2,
     MSETimestamp,
     MSEFallHorizontalSpeed,
-    MSEFallSinAngle,
     MSEFallCosAngle,
+    MSEFallSinAngle,
     MSEFallVerticalSpeed,
     MSEFallTime,
     MSETransportGuidByte5,
@@ -1592,9 +1592,9 @@ MovementStatusElements const MovementStartPitchDown[] =
     MSETransportGuidByte2,
     MSETransportGuidByte7,
     MSETransportOrientation,
-    MSEFallSinAngle,
-    MSEFallHorizontalSpeed,
     MSEFallCosAngle,
+    MSEFallHorizontalSpeed,
+    MSEFallSinAngle,
     MSEFallVerticalSpeed,
     MSEFallTime,
     MSEPitch,
@@ -1665,8 +1665,8 @@ MovementStatusElements const MovementStartPitchUp[] =
     MSETransportPositionY,
     MSETransportGuidByte4,
     MSEFallTime,
-    MSEFallCosAngle,
     MSEFallSinAngle,
+    MSEFallCosAngle,
     MSEFallHorizontalSpeed,
     MSEFallVerticalSpeed,
     MSEOrientation,
@@ -1699,7 +1699,6 @@ MovementStatusElements const MoveChngTransport[]=
     MSEHasFallData,
     MSEHasMovementFlags,
     MSEHasMovementFlags2,
-
     MSEHasTransportGuidByte3,
     MSEHasTransportTime3,
     MSEHasTransportGuidByte4,
@@ -1710,11 +1709,9 @@ MovementStatusElements const MoveChngTransport[]=
     MSEHasTransportGuidByte0,
     MSEHasTransportGuidByte7,
     MSEHasTransportGuidByte5,
-
     MSEMovementFlags,
     MSEMovementFlags2,
     MSEHasFallDirection,
-
     MSEGuidByte7,
     MSEGuidByte5,
     MSEGuidByte1,
@@ -1723,7 +1720,6 @@ MovementStatusElements const MoveChngTransport[]=
     MSEGuidByte4,
     MSEGuidByte0,
     MSEGuidByte3,
-
     MSETransportPositionY,
     MSETransportSeat,
     MSETransportGuidByte1,
@@ -1740,13 +1736,11 @@ MovementStatusElements const MoveChngTransport[]=
     MSETransportGuidByte4,
     MSETransportOrientation,
     MSETransportTime2,
-
     MSEFallTime,
     MSEFallHorizontalSpeed,
-    MSEFallCosAngle,
     MSEFallSinAngle,
+    MSEFallCosAngle,
     MSEFallVerticalSpeed,
-
     MSEOrientation,
     MSEPitch,
     MSESplineElevation,
@@ -1803,8 +1797,8 @@ MovementStatusElements const MoveSplineDone[] =
     MSEGuidByte3,
 
     MSEFallVerticalSpeed,
-    MSEFallSinAngle,
     MSEFallCosAngle,
+    MSEFallSinAngle,
     MSEFallHorizontalSpeed,
     MSEFallTime,
 
@@ -1882,8 +1876,8 @@ MovementStatusElements const MoveNotActiveMover[] =
     MSEGuidByte3,
 
     MSEFallVerticalSpeed,
-    MSEFallCosAngle,
     MSEFallSinAngle,
+    MSEFallCosAngle,
     MSEFallHorizontalSpeed,
     MSEFallTime,
 
@@ -1981,8 +1975,8 @@ MovementStatusElements const DismissControlledVehicle[] =
 
     MSEFallTime,
     MSEFallHorizontalSpeed,
-    MSEFallSinAngle,
     MSEFallCosAngle,
+    MSEFallSinAngle,
     MSEFallVerticalSpeed,
 
     MSEOrientation,
@@ -2061,8 +2055,8 @@ MovementStatusElements const MoveUpdateTeleport[] =
 
     MSEFallTime,
     MSEFallHorizontalSpeed,
-    MSEFallSinAngle,
     MSEFallCosAngle,
+    MSEFallSinAngle,
     MSEFallVerticalSpeed,
 
     MSEGuidByte5,
@@ -2134,9 +2128,9 @@ MovementStatusElements const MovementSetRunMode[] =
     MSETransportGuidByte0,
     MSETransportPositionY,
     MSETransportGuidByte6,
-    MSEFallSinAngle,
-    MSEFallHorizontalSpeed,
     MSEFallCosAngle,
+    MSEFallHorizontalSpeed,
+    MSEFallSinAngle,
     MSEFallTime,
     MSEFallVerticalSpeed,
     MSESplineElevation,
@@ -2205,9 +2199,9 @@ MovementStatusElements const MovementSetWalkMode[] =
     MSETransportGuidByte7,
     MSETransportPositionY,
     MSETransportGuidByte1,
-    MSEFallCosAngle,
-    MSEFallHorizontalSpeed,
     MSEFallSinAngle,
+    MSEFallHorizontalSpeed,
+    MSEFallCosAngle,
     MSEFallVerticalSpeed,
     MSEFallTime,
     MSESplineElevation,
@@ -2278,8 +2272,8 @@ MovementStatusElements const MovementSetCanFly[] =
     MSETransportGuidByte6,
     MSETransportTime3,
     MSESplineElevation,
-    MSEFallCosAngle,
     MSEFallSinAngle,
+    MSEFallCosAngle,
     MSEFallHorizontalSpeed,
     MSEFallVerticalSpeed,
     MSEFallTime,
@@ -2336,8 +2330,8 @@ MovementStatusElements const MovementSetCanTransitionBetweenSwimAndFlyAck[] =
     MSEGuidByte6,
     MSEFallTime,
     MSEFallHorizontalSpeed,
-    MSEFallSinAngle,
     MSEFallCosAngle,
+    MSEFallSinAngle,
     MSEFallVerticalSpeed,
     MSETransportPositionY,
     MSETransportPositionZ,
@@ -2400,9 +2394,9 @@ MovementStatusElements const MovementUpdateSwimSpeed[] =
     MSETransportGuidByte3,
     MSETransportGuidByte5,
     MSEPositionX,
-    MSEFallCosAngle,
-    MSEFallHorizontalSpeed,
     MSEFallSinAngle,
+    MSEFallHorizontalSpeed,
+    MSEFallCosAngle,
     MSEFallTime,
     MSEFallVerticalSpeed,
     MSEGuidByte7,
@@ -2476,9 +2470,9 @@ MovementStatusElements const MovementUpdateRunSpeed[] =
     MSETransportTime3,
     MSETransportPositionZ,
     MSETimestamp,
-    MSEFallSinAngle,
-    MSEFallHorizontalSpeed,
     MSEFallCosAngle,
+    MSEFallHorizontalSpeed,
+    MSEFallSinAngle,
     MSEFallVerticalSpeed,
     MSEFallTime,
     MSEPitch,
@@ -2539,9 +2533,9 @@ MovementStatusElements const MovementUpdateFlightSpeed[] =
     MSETransportGuidByte1,
     MSETransportSeat,
     MSETransportPositionX,
-    MSEFallCosAngle,
-    MSEFallHorizontalSpeed,
     MSEFallSinAngle,
+    MSEFallHorizontalSpeed,
+    MSEFallCosAngle,
     MSEFallVerticalSpeed,
     MSEFallTime,
     MSEGuidByte1,
@@ -2599,8 +2593,8 @@ MovementStatusElements const MovementUpdateCollisionHeight[] =
     MSETransportSeat,
     MSEPitch,
     MSEGuidByte6,
-    MSEFallCosAngle,
     MSEFallSinAngle,
+    MSEFallCosAngle,
     MSEFallHorizontalSpeed,
     MSEFallVerticalSpeed,
     MSEFallTime,
@@ -2679,8 +2673,8 @@ MovementStatusElements const MovementForceRunSpeedChangeAck[] =
     MSETransportGuidByte4,
     MSEFallVerticalSpeed,
     MSEFallHorizontalSpeed,
-    MSEFallCosAngle,
     MSEFallSinAngle,
+    MSEFallCosAngle,
     MSEFallTime,
     MSESplineElevation,
     MSEPitch,
@@ -2755,8 +2749,8 @@ MovementStatusElements const MovementSetCollisionHeightAck[] =
     MSETransportPositionZ,
     MSEFallVerticalSpeed,
     MSEFallTime,
-    MSEFallSinAngle,
     MSEFallCosAngle,
+    MSEFallSinAngle,
     MSEFallHorizontalSpeed,
     MSETimestamp,
     MSESplineElevation,
@@ -2829,8 +2823,8 @@ MovementStatusElements const MovementForceFlightSpeedChangeAck[] =
     MSETransportPositionY,
     MSETimestamp,
     MSESplineElevation,
-    MSEFallCosAngle,
     MSEFallSinAngle,
+    MSEFallCosAngle,
     MSEFallHorizontalSpeed,
     MSEFallTime,
     MSEFallVerticalSpeed,
@@ -2901,9 +2895,9 @@ MovementStatusElements const MovementSetCanFlyAck[] =
     MSETransportGuidByte0,
     MSETransportGuidByte4,
     MSEFallTime,
-    MSEFallCosAngle,
-    MSEFallHorizontalSpeed,
     MSEFallSinAngle,
+    MSEFallHorizontalSpeed,
+    MSEFallCosAngle,
     MSEFallVerticalSpeed,
     MSEPitch,
     MSEOrientation,
@@ -2975,8 +2969,8 @@ MovementStatusElements const MovementForceSwimSpeedChangeAck[] =
     MSETransportGuidByte1,
     MSETransportGuidByte4,
     MSEFallTime,
-    MSEFallCosAngle,
     MSEFallSinAngle,
+    MSEFallCosAngle,
     MSEFallHorizontalSpeed,
     MSEFallVerticalSpeed,
     MSEOrientation,
@@ -3033,9 +3027,9 @@ MovementStatusElements const MovementForceWalkSpeedChangeAck[] =
     MSEGuidByte4,
     MSEGuidByte0,
     MSEFallVerticalSpeed,
-    MSEFallSinAngle,
-    MSEFallHorizontalSpeed,
     MSEFallCosAngle,
+    MSEFallHorizontalSpeed,
+    MSEFallSinAngle,
     MSEFallTime,
     MSETransportPositionZ,
     MSETransportGuidByte7,
@@ -3108,8 +3102,8 @@ MovementStatusElements const MovementForceRunBackSpeedChangeAck[] =
     MSEGuidByte1,
     MSEFallTime,
     MSEFallHorizontalSpeed,
-    MSEFallCosAngle,
     MSEFallSinAngle,
+    MSEFallCosAngle,
     MSEFallVerticalSpeed,
     MSETransportGuidByte5,
     MSETransportSeat,
@@ -3174,8 +3168,8 @@ MovementStatusElements const MovementUpdateRunBackSpeed[] =
     MSEGuidByte4,
     MSEFallTime,
     MSEFallHorizontalSpeed,
-    MSEFallCosAngle,
     MSEFallSinAngle,
+    MSEFallCosAngle,
     MSEFallVerticalSpeed,
     MSETimestamp,
     MSEGuidByte1,
@@ -3234,8 +3228,8 @@ MovementStatusElements const MovementUpdateWalkSpeed[] =
     MSETransportGuidByte3,
     MSEFallVerticalSpeed,
     MSEFallHorizontalSpeed,
-    MSEFallCosAngle,
     MSEFallSinAngle,
+    MSEFallCosAngle,
     MSEFallTime,
     MSEGuidByte1,
     MSEGuidByte4,
@@ -3318,8 +3312,8 @@ MovementStatusElements const ForceMoveRootAck[] =
     MSETimestamp,
     MSEFallVerticalSpeed,
     MSEFallHorizontalSpeed,
-    MSEFallSinAngle,
     MSEFallCosAngle,
+    MSEFallSinAngle,
     MSEFallTime,
     MSEOrientation,
     MSESplineElevation,
@@ -3388,9 +3382,9 @@ MovementStatusElements const ForceMoveUnrootAck[] =
     MSETransportPositionX,
     MSETransportGuidByte1,
     MSETransportGuidByte7,
-    MSEFallCosAngle,
-    MSEFallHorizontalSpeed,
     MSEFallSinAngle,
+    MSEFallHorizontalSpeed,
+    MSEFallCosAngle,
     MSEFallVerticalSpeed,
     MSEFallTime,
     MSETimestamp,
@@ -3461,8 +3455,8 @@ MovementStatusElements const MovementFallReset[] =
     MSETransportGuidByte4,
     MSETransportGuidByte1,
     MSEFallVerticalSpeed,
-    MSEFallCosAngle,
     MSEFallSinAngle,
+    MSEFallCosAngle,
     MSEFallHorizontalSpeed,
     MSEFallTime,
     MSEOrientation,
@@ -3537,9 +3531,9 @@ MovementStatusElements const MovementFeatherFallAck[] =
     MSESplineElevation,
     MSEOrientation,
     MSEFallVerticalSpeed,
-    MSEFallCosAngle,
-    MSEFallHorizontalSpeed,
     MSEFallSinAngle,
+    MSEFallHorizontalSpeed,
+    MSEFallCosAngle,
     MSEFallTime,
     MSEPitch,
     MSEEnd,
@@ -3606,8 +3600,8 @@ MovementStatusElements const MovementGravityDisableAck[] =
     MSETransportPositionX,
     MSETransportGuidByte7,
     MSETransportTime3,
-    MSEFallCosAngle,
     MSEFallSinAngle,
+    MSEFallCosAngle,
     MSEFallHorizontalSpeed,
     MSEFallTime,
     MSEFallVerticalSpeed,
@@ -3665,8 +3659,8 @@ MovementStatusElements const MovementGravityEnableAck[] =
     MSEGuidByte6,
     MSEFallTime,
     MSEFallHorizontalSpeed,
-    MSEFallSinAngle,
     MSEFallCosAngle,
+    MSEFallSinAngle,
     MSEFallVerticalSpeed,
     MSETransportGuidByte1,
     MSETransportPositionX,
@@ -3737,8 +3731,8 @@ MovementStatusElements const MovementHoverAck[] =
     MSEGuidByte3,
     MSEGuidByte0,
     MSETimestamp,
-    MSEFallCosAngle,
     MSEFallSinAngle,
+    MSEFallCosAngle,
     MSEFallHorizontalSpeed,
     MSEFallTime,
     MSEFallVerticalSpeed,
@@ -3809,9 +3803,9 @@ MovementStatusElements const MovementKnockBackAck[] =
     MSEGuidByte3,
     MSEGuidByte2,
     MSEGuidByte7,
-    MSEFallCosAngle,
-    MSEFallHorizontalSpeed,
     MSEFallSinAngle,
+    MSEFallHorizontalSpeed,
+    MSEFallCosAngle,
     MSEFallTime,
     MSEFallVerticalSpeed,
     MSETimestamp,
@@ -3899,9 +3893,9 @@ MovementStatusElements const MovementWaterWalkAck[] =
     MSETransportGuidByte6,
     MSETransportGuidByte4,
     MSESplineElevation,
-    MSEFallCosAngle,
-    MSEFallHorizontalSpeed,
     MSEFallSinAngle,
+    MSEFallHorizontalSpeed,
+    MSEFallCosAngle,
     MSEFallVerticalSpeed,
     MSEFallTime,
     MSEOrientation,
@@ -3934,9 +3928,9 @@ MovementStatusElements const MovementUpdateKnockBack[] =
     MSEHasFallDirection,
     MSEHasOrientation,
     MSEOrientation,
-    MSEFallCosAngle,
-    MSEFallHorizontalSpeed,
     MSEFallSinAngle,
+    MSEFallHorizontalSpeed,
+    MSEFallCosAngle,
     MSEFallTime,
     MSEFallVerticalSpeed,
     MSEGuidByte3,
@@ -5017,8 +5011,8 @@ MovementStatusElements const ChangeSeatsOnControlledVehicle[] =
     MSEExtraElement,
     MSEGuidByte2,
     MSEPitch,
-    MSEFallSinAngle,
     MSEFallCosAngle,
+    MSEFallSinAngle,
     MSEFallHorizontalSpeed,
     MSEFallTime,
     MSEFallVerticalSpeed,
@@ -5108,8 +5102,8 @@ MovementStatusElements const CastSpellEmbeddedMovement[] =
     MSESplineElevation,
     MSEFallTime,
     MSEFallHorizontalSpeed,
-    MSEFallCosAngle,
     MSEFallSinAngle,
+    MSEFallCosAngle,
     MSEFallVerticalSpeed,
     MSETimestamp,
     MSEPitch,