diff options
| author | Ujp8LfXBJ6wCPR <github@lillecarl.com> | 2020-02-08 20:29:18 +0100 |
|---|---|---|
| committer | Shauren <shauren.trinity@gmail.com> | 2021-12-21 15:21:39 +0100 |
| commit | 91a0fbbd7145d6fb966231689c369d641da06f9b (patch) | |
| tree | f7ca752f52b78b37fa98ad73725b123b4ca42908 /src/server/game/Spells/SpellEffects.cpp | |
| parent | 94a79bac7a06aa0f931e9d651928de7eea0a8b5c (diff) | |
Use boost::optional and boost::none instead of smelly pointer (#24134)
* Remove bad pointer usage from CharacterCache
Use TrinityCore Option type instead which is intended for this purpose. (Wrapper around boost::option until C++17 bump is finalised)
* Unify codestyle regarding TC optional type
Based upon advice from @Shauren
(cherry picked from commit 76831f1f467efe4aa26a38dc58c9eab2229bce71)
Diffstat (limited to 'src/server/game/Spells/SpellEffects.cpp')
| -rw-r--r-- | src/server/game/Spells/SpellEffects.cpp | 4 |
1 files changed, 0 insertions, 4 deletions
diff --git a/src/server/game/Spells/SpellEffects.cpp b/src/server/game/Spells/SpellEffects.cpp index e3297b1407d..a127167b186 100644 --- a/src/server/game/Spells/SpellEffects.cpp +++ b/src/server/game/Spells/SpellEffects.cpp @@ -2148,8 +2148,6 @@ void Spell::EffectDispel() WorldPackets::CombatLog::SpellDispellData dispellData; dispellData.SpellID = dispelableAura.GetAura()->GetId(); dispellData.Harmful = false; // TODO: use me - dispellData.Rolled = boost::none; // TODO: use me - dispellData.Needed = boost::none; // TODO: use me unitTarget->RemoveAurasDueToSpellByDispel(dispelableAura.GetAura()->GetId(), m_spellInfo->Id, dispelableAura.GetAura()->GetCasterGUID(), m_caster, dispelableAura.GetDispelCharges()); @@ -4568,8 +4566,6 @@ void Spell::EffectStealBeneficialBuff() WorldPackets::CombatLog::SpellDispellData dispellData; dispellData.SpellID = dispell.first; dispellData.Harmful = false; // TODO: use me - dispellData.Rolled = boost::none; // TODO: use me - dispellData.Needed = boost::none; // TODO: use me unitTarget->RemoveAurasDueToSpellBySteal(dispell.first, dispell.second, m_caster); |