diff options
| author | jackpoz <giacomopoz@gmail.com> | 2015-12-06 21:02:52 +0100 |
|---|---|---|
| committer | jackpoz <giacomopoz@gmail.com> | 2015-12-06 21:37:58 +0100 |
| commit | f1f4005ad8a17ea5fdd2b66f8ed3d0bd7c4c1efb (patch) | |
| tree | 3e1c1779951d51f366c27e0ae0aeabd618c6380e /src/server/game/Spells/SpellEffects.cpp | |
| parent | e60bbaa7d39c690a759c96ee83ab8311e700a8e1 (diff) | |
Core/Quest: Fix issues reported by static analysis
Diffstat (limited to 'src/server/game/Spells/SpellEffects.cpp')
| -rw-r--r-- | src/server/game/Spells/SpellEffects.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/server/game/Spells/SpellEffects.cpp b/src/server/game/Spells/SpellEffects.cpp index b345c5affea..b3ab72dcbff 100644 --- a/src/server/game/Spells/SpellEffects.cpp +++ b/src/server/game/Spells/SpellEffects.cpp @@ -5638,7 +5638,7 @@ void Spell::EffectGameObjectDamage(SpellEffIndex /*effIndex*/) FactionTemplateEntry const* casterFaction = caster->GetFactionTemplateEntry(); FactionTemplateEntry const* targetFaction = sFactionTemplateStore.LookupEntry(gameObjTarget->GetUInt32Value(GAMEOBJECT_FACTION)); // Do not allow to damage GO's of friendly factions (ie: Wintergrasp Walls/Ulduar Storm Beacons) - if ((casterFaction && targetFaction && !casterFaction->IsFriendlyTo(*targetFaction)) || !targetFaction) + if (!targetFaction || (casterFaction && targetFaction && !casterFaction->IsFriendlyTo(*targetFaction))) gameObjTarget->ModifyHealth(-damage, caster, GetSpellInfo()->Id); } |