Scripts: Minimize duplicated enum names in header files (#18346)

This reduces the number of cache resets with the Zapcc compiler

Standard followed is instance/raid TLA + DataTypes/CreaturesIds/etc

18 files changed, 64 insertions, 63 deletions

diff --git a/src/server/scripts/EasternKingdoms/BaradinHold/baradin_hold.h b/src/server/scripts/EasternKingdoms/BaradinHold/baradin_hold.h
index 176d0c677c2..42d13704cfd 100644
--- a/src/server/scripts/EasternKingdoms/BaradinHold/baradin_hold.h
+++ b/src/server/scripts/EasternKingdoms/BaradinHold/baradin_hold.h
@@ -27,14 +27,14 @@
 
 uint32 const EncounterCount = 3;
 
-enum DataTypes
+enum BHDataTypes
 {
     DATA_ARGALOTH           = 0,
     DATA_OCCUTHAR           = 1,
     DATA_ALIZABAL           = 2
 };
 
-enum CreatureIds
+enum BHCreatureIds
 {
     BOSS_ARGALOTH           = 47120,
     BOSS_OCCUTHAR           = 52363,
@@ -45,7 +45,7 @@ enum CreatureIds
     NPC_OCCUTHAR_EYE        = 52368
 };
 
-enum GameObjectIds
+enum BHGameObjectIds
 {
     GO_ARGALOTH_DOOR        = 207619,
     GO_OCCUTHAR_DOOR        = 208953,
diff --git a/src/server/scripts/EasternKingdoms/BlackrockMountain/BlackrockCaverns/blackrock_caverns.h b/src/server/scripts/EasternKingdoms/BlackrockMountain/BlackrockCaverns/blackrock_caverns.h
index 809e23d1b48..7f4fa846cf1 100644
--- a/src/server/scripts/EasternKingdoms/BlackrockMountain/BlackrockCaverns/blackrock_caverns.h
+++ b/src/server/scripts/EasternKingdoms/BlackrockMountain/BlackrockCaverns/blackrock_caverns.h
@@ -23,7 +23,7 @@
 
 uint32 const EncounterCount             = 5;
 
-enum DataTypes
+enum BRCDataTypes
 {
     // Encounter States // Boss GUIDs
     DATA_ROMOGG_BONECRUSHER             = 0,
@@ -36,7 +36,7 @@ enum DataTypes
     DATA_RAZ_THE_CRAZED                 = 5
 };
 
-enum CreatureIds
+enum BRCCreatureIds
 {
     NPC_TWILIGHT_FLAME_CALLER           = 39708,
     NPC_RAZ_THE_CRAZED                  = 39670,
diff --git a/src/server/scripts/EasternKingdoms/BlackrockMountain/BlackrockDepths/blackrock_depths.h b/src/server/scripts/EasternKingdoms/BlackrockMountain/BlackrockDepths/blackrock_depths.h
index 0cb25d3a2a3..6e3650e1685 100644
--- a/src/server/scripts/EasternKingdoms/BlackrockMountain/BlackrockDepths/blackrock_depths.h
+++ b/src/server/scripts/EasternKingdoms/BlackrockMountain/BlackrockDepths/blackrock_depths.h
@@ -21,14 +21,14 @@
 
 #define DataHeader "BRD"
 
-enum FactionIds
+enum BRDFactionIds
 {
     FACTION_NEUTRAL            = 734,
     FACTION_HOSTILE            = 754,
     FACTION_FRIEND             = 35
 };
 
-enum DataTypes
+enum BRDDataTypes
 {
     TYPE_RING_OF_LAW        = 1,
     TYPE_VAULT              = 2,
diff --git a/src/server/scripts/EasternKingdoms/BlackrockMountain/BlackrockSpire/blackrock_spire.h b/src/server/scripts/EasternKingdoms/BlackrockMountain/BlackrockSpire/blackrock_spire.h
index 446cc48d2f7..84657970727 100644
--- a/src/server/scripts/EasternKingdoms/BlackrockMountain/BlackrockSpire/blackrock_spire.h
+++ b/src/server/scripts/EasternKingdoms/BlackrockMountain/BlackrockSpire/blackrock_spire.h
@@ -23,7 +23,7 @@ uint32 const EncounterCount         = 23;
 #define BRSScriptName "instance_blackrock_spire"
 #define DataHeader    "BRS"
 
-enum DataTypes
+enum BRSDataTypes
 {
     DATA_HIGHLORD_OMOKK             = 0,
     DATA_SHADOW_HUNTER_VOSHGAJIN    = 1,
@@ -51,7 +51,7 @@ enum DataTypes
     DATA_HALL_RUNE_7                = 22
 };
 
-enum CreaturesIds
+enum BRSCreaturesIds
 {
     NPC_HIGHLORD_OMOKK              = 9196,
     NPC_SHADOW_HUNTER_VOSHGAJIN     = 9236,
@@ -74,7 +74,7 @@ enum CreaturesIds
     NPC_LORD_VICTOR_NEFARIUS        = 10162
 };
 
-enum AdditionalData
+enum BRSAdditionalData
 {
     SPELL_SUMMON_ROOKERY_WHELP      = 15745,
     EVENT_UROK_DOOMHOWL             = 4845,
@@ -84,7 +84,7 @@ enum AdditionalData
     AREATRIGGER_BLACKROCK_STADIUM   = 2026
 };
 
-enum GameObjectsIds
+enum BRSGameObjectsIds
 {
     GO_WHELP_SPAWNER                = 175622, // trap spawned by go id 175124
     // Doors
diff --git a/src/server/scripts/EasternKingdoms/BlackrockMountain/BlackwingLair/blackwing_lair.h b/src/server/scripts/EasternKingdoms/BlackrockMountain/BlackwingLair/blackwing_lair.h
index 9fce132ea7e..2d8bce12ba6 100644
--- a/src/server/scripts/EasternKingdoms/BlackrockMountain/BlackwingLair/blackwing_lair.h
+++ b/src/server/scripts/EasternKingdoms/BlackrockMountain/BlackwingLair/blackwing_lair.h
@@ -39,7 +39,7 @@ enum BWLEncounter
     DATA_LORD_VICTOR_NEFARIUS   = 8
 };
 
-enum CreatureIds
+enum BWLCreatureIds
 {
     NPC_RAZORGORE               = 12435,
     NPC_BLACKWING_DRAGON        = 12422,
@@ -56,7 +56,7 @@ enum CreatureIds
     NPC_NEFARIAN                = 11583
 };
 
-enum GameObjectIds
+enum BWLGameObjectIds
 {
     GO_BLACK_DRAGON_EGG         = 177807,
     GO_PORTCULLIS               = 176965,
diff --git a/src/server/scripts/EasternKingdoms/BlackrockMountain/MoltenCore/molten_core.h b/src/server/scripts/EasternKingdoms/BlackrockMountain/MoltenCore/molten_core.h
index de890ee3b39..d5c40e7254b 100644
--- a/src/server/scripts/EasternKingdoms/BlackrockMountain/MoltenCore/molten_core.h
+++ b/src/server/scripts/EasternKingdoms/BlackrockMountain/MoltenCore/molten_core.h
@@ -21,7 +21,7 @@
 
 #define DataHeader "MC"
 
-enum Encounters
+enum MCEncounters
 {
     BOSS_LUCIFRON                   = 0,
     BOSS_MAGMADAR                   = 1,
@@ -36,7 +36,7 @@ enum Encounters
     MAX_ENCOUNTER,
 };
 
-enum Actions
+enum MCActions
 {
     ACTION_START_RAGNAROS       = 0,
     ACTION_START_RAGNAROS_ALT   = 1,
@@ -45,7 +45,7 @@ enum Actions
 Position const RagnarosTelePos   = {829.159f, -815.773f, -228.972f, 5.30500f};
 Position const RagnarosSummonPos = {838.510f, -829.840f, -232.000f, 2.00000f};
 
-enum Creatures
+enum MCCreatures
 {
     NPC_LUCIFRON                    = 12118,
     NPC_MAGMADAR                    = 11982,
@@ -61,12 +61,12 @@ enum Creatures
     NPC_FLAMEWAKER_ELITE            = 11664,
 };
 
-enum GameObjects
+enum MCGameObjects
 {
     GO_CACHE_OF_THE_FIRELORD        = 179703,
 };
 
-enum Data
+enum MCData
 {
     DATA_RAGNAROS_ADDS  = 0,
 };
diff --git a/src/server/scripts/EasternKingdoms/Deadmines/deadmines.h b/src/server/scripts/EasternKingdoms/Deadmines/deadmines.h
index dff4243617e..173fc20530f 100644
--- a/src/server/scripts/EasternKingdoms/Deadmines/deadmines.h
+++ b/src/server/scripts/EasternKingdoms/Deadmines/deadmines.h
@@ -20,7 +20,7 @@
 
 #define DataHeader "DM"
 
-enum CannonState
+enum DMCannonState
 {
     CANNON_NOT_USED,
     CANNON_GUNPOWDER_USED,
@@ -29,18 +29,18 @@ enum CannonState
     EVENT_DONE
 };
 
-enum Data
+enum DMData
 {
     EVENT_STATE,
     EVENT_RHAHKZOR
 };
 
-enum Data64
+enum DMData64
 {
     DATA_SMITE_CHEST
 };
 
-enum GameObjects
+enum DMGameObjects
 {
     GO_FACTORY_DOOR                                        = 13965,
     GO_IRONCLAD_DOOR                                       = 16397,
@@ -48,4 +48,5 @@ enum GameObjects
     GO_DOOR_LEVER                                          = 101833,
     GO_MR_SMITE_CHEST                                      = 144111
 };
+
 #endif
diff --git a/src/server/scripts/EasternKingdoms/Gnomeregan/gnomeregan.h b/src/server/scripts/EasternKingdoms/Gnomeregan/gnomeregan.h
index bbfea6a2567..7d2a23c7e52 100644
--- a/src/server/scripts/EasternKingdoms/Gnomeregan/gnomeregan.h
+++ b/src/server/scripts/EasternKingdoms/Gnomeregan/gnomeregan.h
@@ -20,14 +20,14 @@
 
 #define DataHeader "GNO"
 
-enum GameObjectIds
+enum GNOGameObjectIds
 {
     GO_CAVE_IN_LEFT     = 146085,
     GO_CAVE_IN_RIGHT    = 146086,
     GO_RED_ROCKET       = 103820
 };
 
-enum CreatureIds
+enum GNOCreatureIds
 {
     NPC_BLASTMASTER_EMI_SHORTFUSE   = 7998,
     NPC_CAVERNDEEP_AMBUSHER         = 6207,
@@ -35,12 +35,12 @@ enum CreatureIds
     NPC_CHOMPER                     = 6215
 };
 
-enum Data
+enum GNOData
 {
     TYPE_EVENT = 1
 };
 
-enum Data64
+enum GNOData64
 {
     DATA_GO_CAVE_IN_LEFT,
     DATA_GO_CAVE_IN_RIGHT,
diff --git a/src/server/scripts/EasternKingdoms/Karazhan/karazhan.h b/src/server/scripts/EasternKingdoms/Karazhan/karazhan.h
index 05de9e43a91..65970af50dc 100644
--- a/src/server/scripts/EasternKingdoms/Karazhan/karazhan.h
+++ b/src/server/scripts/EasternKingdoms/Karazhan/karazhan.h
@@ -23,7 +23,7 @@
 
 uint32 const EncounterCount = 12;
 
-enum DataTypes
+enum KZDataTypes
 {
     DATA_ATTUMEN                    = 0,
     DATA_MOROES                     = 1,
@@ -56,14 +56,14 @@ enum DataTypes
     DATA_GO_SIDE_ENTRANCE_DOOR      = 29
 };
 
-enum OperaEvents
+enum KZOperaEvents
 {
     EVENT_OZ                        = 1,
     EVENT_HOOD                      = 2,
     EVENT_RAJ                       = 3
 };
 
-enum MiscCreatures
+enum KZMiscCreatures
 {
     NPC_HYAKISS_THE_LURKER          = 16179,
     NPC_ROKAD_THE_RAVAGER           = 16181,
@@ -83,7 +83,7 @@ enum MiscCreatures
     NPC_KILREK                      = 17229
 };
 
-enum GameObjectIds
+enum KZGameObjectIds
 {
     GO_STAGE_CURTAIN                = 183932,
     GO_STAGE_DOOR_LEFT              = 184278,
@@ -99,7 +99,7 @@ enum GameObjectIds
     GO_DUST_COVERED_CHEST           = 185119
 };
 
-enum Misc
+enum KZMisc
 {
     OPTIONAL_BOSS_REQUIRED_DEATH_COUNT = 50
 };
diff --git a/src/server/scripts/EasternKingdoms/MagistersTerrace/magisters_terrace.h b/src/server/scripts/EasternKingdoms/MagistersTerrace/magisters_terrace.h
index 05718dfc1dd..197303bb32f 100644
--- a/src/server/scripts/EasternKingdoms/MagistersTerrace/magisters_terrace.h
+++ b/src/server/scripts/EasternKingdoms/MagistersTerrace/magisters_terrace.h
@@ -23,7 +23,7 @@
 
 uint32 const EncounterCount = 4;
 
-enum DataTypes
+enum MTDataTypes
 {
     DATA_SELIN,
     DATA_VEXALLUS,
@@ -38,7 +38,7 @@ enum DataTypes
     DATA_ESCAPE_ORB
 };
 
-enum CreatureIds
+enum MTCreatureIds
 {
     NPC_SELIN               = 24723,
     NPC_DELRISSA            = 24560,
@@ -47,7 +47,7 @@ enum CreatureIds
     NPC_HUMAN_KALECGOS      = 24848
 };
 
-enum GameObjectIds
+enum MTGameObjectIds
 {
     GO_VEXALLUS_DOOR        = 187896,
     GO_SELIN_DOOR           = 187979,
@@ -59,17 +59,17 @@ enum GameObjectIds
     GO_ESCAPE_ORB           = 188173
 };
 
-enum InstanceEventIds
+enum MTInstanceEventIds
 {
     EVENT_SPAWN_KALECGOS    = 16547
 };
 
-enum InstanceText
+enum MTInstanceText
 {
     SAY_KALECGOS_SPAWN      = 0
 };
 
-enum MovementData
+enum MTMovementData
 {
     PATH_KALECGOS_FLIGHT    = 248440
 };
diff --git a/src/server/scripts/EasternKingdoms/ScarletMonastery/scarlet_monastery.h b/src/server/scripts/EasternKingdoms/ScarletMonastery/scarlet_monastery.h
index aa1bcebacfc..12ecb6cf76f 100644
--- a/src/server/scripts/EasternKingdoms/ScarletMonastery/scarlet_monastery.h
+++ b/src/server/scripts/EasternKingdoms/ScarletMonastery/scarlet_monastery.h
@@ -23,7 +23,7 @@
 
 uint32 const EncounterCount = 10;
 
-enum DataTypes
+enum SMDataTypes
 {
     DATA_MOGRAINE_AND_WHITE_EVENT   = 1,
     DATA_MOGRAINE                   = 2,
@@ -43,7 +43,7 @@ enum DataTypes
     DATA_SCORN                      = 14
 };
 
-enum CreatureIds
+enum SMCreatureIds
 {
     NPC_MOGRAINE                    = 3976,
     NPC_WHITEMANE                   = 3977,
@@ -54,7 +54,7 @@ enum CreatureIds
     NPC_PUMPKIN                     = 23694
 };
 
-enum GameObjectIds
+enum SMGameObjectIds
 {
     GO_HIGH_INQUISITORS_DOOR        = 104600,
     GO_PUMPKIN_SHRINE               = 186267
diff --git a/src/server/scripts/EasternKingdoms/Scholomance/scholomance.h b/src/server/scripts/EasternKingdoms/Scholomance/scholomance.h
index 1ada609a1ce..c6a5b9f6554 100644
--- a/src/server/scripts/EasternKingdoms/Scholomance/scholomance.h
+++ b/src/server/scripts/EasternKingdoms/Scholomance/scholomance.h
@@ -22,7 +22,7 @@
 
 uint32 const EncounterCount             = 8;
 
-enum DataTypes
+enum SCDataTypes
 {
     DATA_DOCTORTHEOLENKRASTINOV         = 0,
     DATA_INSTRUCTORMALICIA              = 1,
@@ -34,13 +34,13 @@ enum DataTypes
     DATA_KIRTONOS                       = 7
 };
 
-enum CreatureIds
+enum SCCreatureIds
 {
     NPC_DARKMASTER_GANDLING             = 1853,
     NPC_BONE_MINION                     = 16119
 };
 
-enum GameobjectIds
+enum SCGameobjectIds
 {
     GO_GATE_KIRTONOS                    = 175570,
     GO_GATE_GANDLING                    = 177374,
diff --git a/src/server/scripts/EasternKingdoms/ShadowfangKeep/shadowfang_keep.h b/src/server/scripts/EasternKingdoms/ShadowfangKeep/shadowfang_keep.h
index 88edc3f1ee1..581205a1d63 100644
--- a/src/server/scripts/EasternKingdoms/ShadowfangKeep/shadowfang_keep.h
+++ b/src/server/scripts/EasternKingdoms/ShadowfangKeep/shadowfang_keep.h
@@ -21,7 +21,7 @@
 
 #define DataHeader "SK"
 
-enum DataTypes
+enum SKDataTypes
 {
     TYPE_FREE_NPC               = 1,
     TYPE_RETHILGORE             = 2,
diff --git a/src/server/scripts/EasternKingdoms/Stratholme/stratholme.h b/src/server/scripts/EasternKingdoms/Stratholme/stratholme.h
index 9237149c184..c1753340d2c 100644
--- a/src/server/scripts/EasternKingdoms/Stratholme/stratholme.h
+++ b/src/server/scripts/EasternKingdoms/Stratholme/stratholme.h
@@ -21,7 +21,7 @@
 
 #define DataHeader "STR"
 
-enum DataTypes
+enum STRDataTypes
 {
     TYPE_BARON_RUN                      = 1,
     TYPE_BARONESS                       = 2,
@@ -43,7 +43,7 @@ enum DataTypes
     TYPE_SH_AELMAR                      = 25
 };
 
-enum CreatureIds
+enum STRCreatureIds
 {
     NPC_CRYSTAL                         = 10415, // ziggurat crystal
     NPC_BARON                           = 10440, // ziggurat crystal
@@ -56,7 +56,7 @@ enum CreatureIds
     NPC_YSIDA                           = 16031,
 };
 
-enum GameobjectIds
+enum STRGameobjectIds
 {
     GO_DOOR_HALAZZI                     = 186303,
     GO_SERVICE_ENTRANCE                 = 175368,
@@ -71,12 +71,12 @@ enum GameobjectIds
     GO_PORT_ELDERS                      = 175377   // port at elders square
 };
 
-enum QuestIds
+enum STRQuestIds
 {
     QUEST_DEAD_MAN_PLEA                 = 8945
 };
 
-enum SpellIds
+enum STRSpellIds
 {
     SPELL_BARON_ULTIMATUM               = 27861
 };
diff --git a/src/server/scripts/EasternKingdoms/SunwellPlateau/sunwell_plateau.h b/src/server/scripts/EasternKingdoms/SunwellPlateau/sunwell_plateau.h
index c6b4ae753a5..d0e8c188ebf 100644
--- a/src/server/scripts/EasternKingdoms/SunwellPlateau/sunwell_plateau.h
+++ b/src/server/scripts/EasternKingdoms/SunwellPlateau/sunwell_plateau.h
@@ -23,7 +23,7 @@
 
 uint32 const EncounterCount = 6;
 
-enum DataTypes
+enum SWPDataTypes
 {
     // Encounter States/Boss GUIDs
     DATA_KALECGOS                            = 0,
@@ -53,7 +53,7 @@ enum DataTypes
     DATA_PLAYER_GUID
 };
 
-enum CreatureIds
+enum SWPCreatureIds
 {
     NPC_MURU                                 = 25741,
     NPC_ENTROPIUS                            = 25840,
@@ -100,7 +100,7 @@ enum CreatureIds
     NPC_BLACK_HOLE                           = 25855
 };
 
-enum GameObjectIds
+enum SWPGameObjectIds
 {
     GO_ORB_OF_THE_BLUE_DRAGONFLIGHT          = 188415,
     GO_FORCE_FIELD                           = 188421,
diff --git a/src/server/scripts/EasternKingdoms/Uldaman/uldaman.h b/src/server/scripts/EasternKingdoms/Uldaman/uldaman.h
index 24fba425e48..c9cc77ca6e5 100644
--- a/src/server/scripts/EasternKingdoms/Uldaman/uldaman.h
+++ b/src/server/scripts/EasternKingdoms/Uldaman/uldaman.h
@@ -23,7 +23,7 @@
 
 #define MAX_ENCOUNTER                   3
 
-enum DataTypes
+enum UDDataTypes
 {
     DATA_ALTAR_DOORS                    = 1,
     DATA_ANCIENT_DOOR                   = 2,
@@ -33,7 +33,7 @@ enum DataTypes
     DATA_IRONAYA_SEAL                   = 6,
 };
 
-enum GameObjectIds
+enum UDGameObjectIds
 {
     GO_ARCHAEDAS_TEMPLE_DOOR            = 141869,
     GO_ALTAR_OF_THE_KEEPER_TEMPLE_DOOR  = 124367,
diff --git a/src/server/scripts/EasternKingdoms/ZulAman/zulaman.h b/src/server/scripts/EasternKingdoms/ZulAman/zulaman.h
index 13032b74bed..4aae753fe69 100644
--- a/src/server/scripts/EasternKingdoms/ZulAman/zulaman.h
+++ b/src/server/scripts/EasternKingdoms/ZulAman/zulaman.h
@@ -22,7 +22,7 @@ uint32 const EncounterCount = 6;
 #define ZulAmanScriptName "instance_zulaman"
 #define DataHeader "ZA"
 
-enum DataTypes
+enum ZADataTypes
 {
     // BossState
     DATA_AKILZON                = 0,
@@ -42,7 +42,7 @@ enum DataTypes
     DATA_ZULAMAN_STATE
 };
 
-enum CreatureIds
+enum ZACreatureIds
 {
     NPC_AKILZON                 = 23574,
     NPC_NALORAKK                = 23576,
@@ -55,24 +55,24 @@ enum CreatureIds
     NPC_HEXLORD_TRIGGER         = 24363
 };
 
-enum GameObjectIds
+enum ZAGameObjectIds
 {
     GO_STRANGE_GONG             = 187359,
     GO_MASSIVE_GATE             = 186728,
 };
 
-enum ZulAmanEvents
+enum ZAEvents
 {
     EVENT_START_ZULAMAN         = 15897,
     EVENT_UPDATE_ZULAMAN_TIMER  = 1,
 };
 
-enum ZulAmanAction
+enum ZAAction
 {
     ACTION_START_ZULAMAN        = 1
 };
 
-enum ZulAmanWorldStates
+enum ZAWorldStates
 {
     WORLD_STATE_ZULAMAN_TIMER_ENABLED   = 3104,
     WORLD_STATE_ZULAMAN_TIMER           = 3106,
diff --git a/src/server/scripts/EasternKingdoms/ZulGurub/zulgurub.h b/src/server/scripts/EasternKingdoms/ZulGurub/zulgurub.h
index 5a54d6dbfae..91ece60711c 100644
--- a/src/server/scripts/EasternKingdoms/ZulGurub/zulgurub.h
+++ b/src/server/scripts/EasternKingdoms/ZulGurub/zulgurub.h
@@ -24,7 +24,7 @@
 
 uint32 const EncounterCount = 5;
 
-enum DataTypes
+enum ZGDataTypes
 {
     DATA_VENOXIS                    = 0,
     DATA_MANDOKIR                   = 1,
@@ -42,7 +42,7 @@ enum DataTypes
     DATA_JINDOR_TRIGGER,
 };
 
-enum CreatureIds
+enum ZGCreatureIds
 {
     NPC_VENOXIS                     = 52155,
     NPC_MANDOKIR                    = 52151,
@@ -66,7 +66,7 @@ enum CreatureIds
     NPC_SHADOW_OF_HAKKAR            = 52650
 };
 
-enum GameObjectIds
+enum ZGGameObjectIds
 {
     // High Priest Venoxis
     GO_VENOXIS_COIL                 = 208844,