diff options
| author | Keader <keader.android@gmail.com> | 2017-12-27 18:17:13 -0300 |
|---|---|---|
| committer | funjoker <funjoker109@gmail.com> | 2021-04-15 05:53:27 +0200 |
| commit | a7883380ce4c827db103b0c43faca6632c3d1f66 (patch) | |
| tree | 701c2b6cf51e9d983c8f642f77bc111f8deda85d /src/server/scripts/EasternKingdoms | |
| parent | 0a460e3af75dace69c2b65f20cb923a6f624685d (diff) | |
Core/AI: Making guid const& in SetGUID method (#21128)
(cherry picked from commit 465b43fabef1727432ddda27f04b882b29fd2c7f)
Diffstat (limited to 'src/server/scripts/EasternKingdoms')
5 files changed, 10 insertions, 10 deletions
diff --git a/src/server/scripts/EasternKingdoms/BlackrockMountain/BlackrockDepths/boss_coren_direbrew.cpp b/src/server/scripts/EasternKingdoms/BlackrockMountain/BlackrockDepths/boss_coren_direbrew.cpp index 73759c87843..fffc3981f5a 100644 --- a/src/server/scripts/EasternKingdoms/BlackrockMountain/BlackrockDepths/boss_coren_direbrew.cpp +++ b/src/server/scripts/EasternKingdoms/BlackrockMountain/BlackrockDepths/boss_coren_direbrew.cpp @@ -282,9 +282,9 @@ struct npc_coren_direbrew_sisters : public ScriptedAI { npc_coren_direbrew_sisters(Creature* creature) : ScriptedAI(creature) { } - void SetGUID(ObjectGuid guid, int32 data) override + void SetGUID(ObjectGuid const& guid, int32 id) override { - if (data == DATA_TARGET_GUID) + if (id == DATA_TARGET_GUID) _targetGUID = guid; } diff --git a/src/server/scripts/EasternKingdoms/Karazhan/boss_midnight.cpp b/src/server/scripts/EasternKingdoms/Karazhan/boss_midnight.cpp index 282e1a56ecd..c967a4804d6 100644 --- a/src/server/scripts/EasternKingdoms/Karazhan/boss_midnight.cpp +++ b/src/server/scripts/EasternKingdoms/Karazhan/boss_midnight.cpp @@ -207,9 +207,9 @@ public: BossAI::JustDied(killer); } - void SetGUID(ObjectGuid guid, int32 data) override + void SetGUID(ObjectGuid const& guid, int32 id) override { - if (data == NPC_MIDNIGHT) + if (id == NPC_MIDNIGHT) _midnightGUID = guid; } diff --git a/src/server/scripts/EasternKingdoms/ScarletEnclave/chapter1.cpp b/src/server/scripts/EasternKingdoms/ScarletEnclave/chapter1.cpp index d4869fb0d10..2b3bb2e066b 100644 --- a/src/server/scripts/EasternKingdoms/ScarletEnclave/chapter1.cpp +++ b/src/server/scripts/EasternKingdoms/ScarletEnclave/chapter1.cpp @@ -308,7 +308,7 @@ public: ObjectGuid prisonerGUID; - void SetGUID(ObjectGuid guid, int32 /*id*/) override + void SetGUID(ObjectGuid const& guid, int32 /*id*/) override { if (!prisonerGUID) prisonerGUID = guid; @@ -1166,7 +1166,7 @@ class npc_scarlet_miner : public CreatureScript } } - void SetGUID(ObjectGuid guid, int32 /*id = 0*/) override + void SetGUID(ObjectGuid const& guid, int32 /*id*/) override { InitWaypoint(); Start(false, false, guid); diff --git a/src/server/scripts/EasternKingdoms/ZulGurub/boss_mandokir.cpp b/src/server/scripts/EasternKingdoms/ZulGurub/boss_mandokir.cpp index b292851b8db..bf70c9d7da7 100644 --- a/src/server/scripts/EasternKingdoms/ZulGurub/boss_mandokir.cpp +++ b/src/server/scripts/EasternKingdoms/ZulGurub/boss_mandokir.cpp @@ -224,7 +224,7 @@ class boss_mandokir : public CreatureScript return 0; } - void SetGUID(ObjectGuid guid, int32 /*type = 0 */) override + void SetGUID(ObjectGuid const& guid, int32 /*type = 0 */) override { _reviveGUID = guid; } @@ -380,7 +380,7 @@ class npc_chained_spirit : public CreatureScript _revivePlayerGUID.Clear(); } - void SetGUID(ObjectGuid guid, int32 /*type = 0 */) override + void SetGUID(ObjectGuid const& guid, int32 /*type = 0 */) override { _revivePlayerGUID = guid; } diff --git a/src/server/scripts/EasternKingdoms/zone_undercity.cpp b/src/server/scripts/EasternKingdoms/zone_undercity.cpp index 870f66a3dd4..3d025a6935f 100644 --- a/src/server/scripts/EasternKingdoms/zone_undercity.cpp +++ b/src/server/scripts/EasternKingdoms/zone_undercity.cpp @@ -131,9 +131,9 @@ public: _events.ScheduleEvent(EVENT_MULTI_SHOT, 10000); } - void SetGUID(ObjectGuid guid, int32 type) override + void SetGUID(ObjectGuid const& guid, int32 id) override { - if (type == GUID_EVENT_INVOKER) + if (id == GUID_EVENT_INVOKER) { Talk(EMOTE_LAMENT); DoPlaySoundToSet(me, SOUND_CREDIT); |
