diff options
| author | jackpoz <giacomopoz@gmail.com> | 2015-01-20 22:55:06 +0100 |
|---|---|---|
| committer | jackpoz <giacomopoz@gmail.com> | 2015-01-20 22:55:06 +0100 |
| commit | 0edc35b9219da35566e018f2354315957bb07667 (patch) | |
| tree | 4789f6e2b4c00a8cc3a547b0457a6fd3bdf76f8d /src/server | |
| parent | 0ceb8003ee40d3766e217749aca86bc6a301537a (diff) | |
Core/Misc: Fix static analysis issues
Fix some static analysis issues reported by Coverity
Diffstat (limited to 'src/server')
| -rw-r--r-- | src/server/game/Entities/Unit/Unit.cpp | 1 | ||||
| -rw-r--r-- | src/server/game/Server/Packets/MiscPackets.h | 12 | ||||
| -rw-r--r-- | src/server/shared/DataStores/DB2StorageLoader.cpp | 4 |
3 files changed, 11 insertions, 6 deletions
diff --git a/src/server/game/Entities/Unit/Unit.cpp b/src/server/game/Entities/Unit/Unit.cpp index 0232c6de900..27ecbc10dc6 100644 --- a/src/server/game/Entities/Unit/Unit.cpp +++ b/src/server/game/Entities/Unit/Unit.cpp @@ -12180,6 +12180,7 @@ void Unit::ProcDamageAndSpellFor(bool isVictim, Unit* target, uint32 procFlag, u uint32 Id = i->aura->GetId(); AuraApplication* aurApp = i->aura->GetApplicationOfTarget(GetGUID()); + ASSERT(aurApp); bool prepare = i->aura->CallScriptPrepareProcHandlers(aurApp, eventInfo); diff --git a/src/server/game/Server/Packets/MiscPackets.h b/src/server/game/Server/Packets/MiscPackets.h index acfb3115d50..b1da6e504a2 100644 --- a/src/server/game/Server/Packets/MiscPackets.h +++ b/src/server/game/Server/Packets/MiscPackets.h @@ -229,7 +229,7 @@ namespace WorldPackets void Read() override; - int32 DifficultyID; + int32 DifficultyID = 0; }; class SetRaidDifficulty final : public ClientPacket @@ -239,8 +239,8 @@ namespace WorldPackets void Read() override; - int32 DifficultyID; - uint8 Legacy; + int32 DifficultyID = 0; + uint8 Legacy = 0; }; class DungeonDifficultySet final : public ServerPacket @@ -250,7 +250,7 @@ namespace WorldPackets WorldPacket const* Write() override; - int32 DifficultyID; + int32 DifficultyID = 0; }; class RaidDifficultySet final : public ServerPacket @@ -260,8 +260,8 @@ namespace WorldPackets WorldPacket const* Write() override; - int32 DifficultyID; - uint8 Legacy; + int32 DifficultyID = 0; + uint8 Legacy = 0; }; class CorpseReclaimDelay : public ServerPacket diff --git a/src/server/shared/DataStores/DB2StorageLoader.cpp b/src/server/shared/DataStores/DB2StorageLoader.cpp index fa8a12bb9b4..75cb01d00cd 100644 --- a/src/server/shared/DataStores/DB2StorageLoader.cpp +++ b/src/server/shared/DataStores/DB2StorageLoader.cpp @@ -545,7 +545,11 @@ char* DB2DatabaseLoader::Load(const char* format, int32 preparedStatement, uint3 } while (result->NextRow()); if (!newRecords) + { + delete[] tempDataTable; + delete[] newIndexes; return nullptr; + } // Compact new data table to only contain new records not previously loaded from file char* dataTable = new char[newRecords * recordSize]; |