diff options
author | Naios <naios-dev@live.de> | 2015-03-18 20:23:47 +0100 |
---|---|---|
committer | Naios <naios-dev@live.de> | 2015-03-18 20:23:47 +0100 |
commit | e96676aeddb4763f6353675724fd6a033d60fbcb (patch) | |
tree | 03c6074d1a327a7c3da55fe11a46fd0d2ce8c1c0 /src | |
parent | f25666375e07f32e427e996b2043fef10870c3ae (diff) |
Core/Misc: Fix some issues detected by static analysis
* Assignment of function parameter has no effect outside the function. Did you forget dereferencing it?
-> This argument is passed by value, it makes no sence so set it to null here.
* Member variable 'instance_violet_hold_InstanceMapScript::bWiped' is not initialized in the constructor.
(cherry picked from commit 433bc289c2c82b7377ad0189e415a3ca070d220f)
Diffstat (limited to 'src')
-rw-r--r-- | src/server/game/AuctionHouse/AuctionHouseMgr.cpp | 2 | ||||
-rw-r--r-- | src/server/scripts/Northrend/VioletHold/instance_violet_hold.cpp | 1 |
2 files changed, 1 insertions, 2 deletions
diff --git a/src/server/game/AuctionHouse/AuctionHouseMgr.cpp b/src/server/game/AuctionHouse/AuctionHouseMgr.cpp index e8c91479cc2..0235aa7e8b6 100644 --- a/src/server/game/AuctionHouse/AuctionHouseMgr.cpp +++ b/src/server/game/AuctionHouse/AuctionHouseMgr.cpp @@ -440,8 +440,6 @@ bool AuctionHouseObject::RemoveAuction(AuctionEntry* auction) // we need to delete the entry, it is not referenced any more delete auction; - auction = NULL; - return wasInMap; } diff --git a/src/server/scripts/Northrend/VioletHold/instance_violet_hold.cpp b/src/server/scripts/Northrend/VioletHold/instance_violet_hold.cpp index 3e3ce5cde75..a462c68e084 100644 --- a/src/server/scripts/Northrend/VioletHold/instance_violet_hold.cpp +++ b/src/server/scripts/Northrend/VioletHold/instance_violet_hold.cpp @@ -133,6 +133,7 @@ public: uiCyanigosaEventTimer = 3 * IN_MILLISECONDS; bActive = false; + bWiped = false; bIsDoorSpellCast = false; bCrystalActivated = false; defenseless = true; |