aboutsummaryrefslogtreecommitdiff
path: root/src
diff options
context:
space:
mode:
authorShauren <shauren.trinity@gmail.com>2015-07-15 16:51:12 +0200
committerDDuarte <dnpd.dd@gmail.com>2015-07-19 00:48:17 +0100
commitf880f2e778f5db6ecebf3321d48404c89f5b277f (patch)
tree03a29a4d5e17032408f83762363ac8d8aa1bf215 /src
parent5ceb3fd0ab3644f9515e11dea36f7b00316e4136 (diff)
Core/Threading: Clarified comment on ProducerConsumerQueue::WaitAndPop
(cherry picked from commit 08316552b5b176e8209d7e8f15c53053d049743d)
Diffstat (limited to 'src')
-rw-r--r--src/server/shared/Threading/ProducerConsumerQueue.h3
1 files changed, 2 insertions, 1 deletions
diff --git a/src/server/shared/Threading/ProducerConsumerQueue.h b/src/server/shared/Threading/ProducerConsumerQueue.h
index e2f13e5c339..96546960393 100644
--- a/src/server/shared/Threading/ProducerConsumerQueue.h
+++ b/src/server/shared/Threading/ProducerConsumerQueue.h
@@ -70,7 +70,8 @@ public:
{
std::unique_lock<std::mutex> lock(_queueLock);
- // we could be using .wait(lock, predicate) overload here but some threading error analysis tools produce false positives
+ // we could be using .wait(lock, predicate) overload here but it is broken
+ // https://connect.microsoft.com/VisualStudio/feedback/details/1098841
while (_queue.empty() && !_shutdown)
_condition.wait(lock);