diff options
Diffstat (limited to 'src/server/game/Handlers/CharacterHandler.cpp')
-rw-r--r-- | src/server/game/Handlers/CharacterHandler.cpp | 15 |
1 files changed, 7 insertions, 8 deletions
diff --git a/src/server/game/Handlers/CharacterHandler.cpp b/src/server/game/Handlers/CharacterHandler.cpp index 9410cc7174b..e1f6bafa238 100644 --- a/src/server/game/Handlers/CharacterHandler.cpp +++ b/src/server/game/Handlers/CharacterHandler.cpp @@ -704,14 +704,6 @@ void WorldSession::HandleCharCreateOpcode(WorldPackets::Character::CreateCharact } std::shared_ptr<WorldPackets::Character::CharacterCreateInfo> createInfo = charCreate.CreateInfo; - // Reserve the name for the duration of callback chain - createInfo->NameToken = sCharacterCache->TryCreateCharacterWithName(createInfo->Name); - if (!createInfo->NameToken) - { - SendCharCreate(CHAR_CREATE_NAME_IN_USE); - return; - } - CharacterDatabasePreparedStatement* stmt = CharacterDatabase.GetPreparedStatement(CHAR_SEL_CHECK_NAME); stmt->setString(0, charCreate.CreateInfo->Name); @@ -836,6 +828,13 @@ void WorldSession::HandleCharCreateOpcode(WorldPackets::Character::CreateCharact return; } + // Check name uniqueness in the same step as saving to database + if (sCharacterCache->GetCharacterCacheByName(createInfo->Name)) + { + SendCharCreate(CHAR_CREATE_NAME_IN_USE); + return; + } + std::shared_ptr<Player> newChar(new Player(this), [](Player* ptr) { ptr->CleanupsBeforeDelete(); |