aboutsummaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2021-12-18Core/Pet: Fix guardians low damage (#23840)Giacomo Pozzoni
Fix guardians low damage for unhandled cases in Guardian::InitStatsForLevel() (cherry picked from commit b3b8ec811daab65d4b94cad950a460240b02390b)
2021-12-18Scripts: Fix crossfaction combat issue (#23818)Giacomo Pozzoni
* Scripts/PitOfSaron: Fix Martin Victus combat in crossfaction groups Fix Martin Victus attacking players in crossfaction groups because it was spawned as summon of the boss, triggering DoCombatInZone() * Scripts/ForgeOfSouls: Fix guards combat in crossfaction groups Fix Devourer of Souls guardians attacking players in crossfaction groups because they were spawned as summons of the boss, triggering DoCombatInZone() * Scripts/Misc: Fix no PCH build (cherry picked from commit ef694cc251844d34a64ae03f79d28a5c76719f6b)
2021-12-18Core/Movement: fixed taxi pathings getting finalized earlier than intended ↵Ovah
(#23830) * Core/Movement: fixed taxi pathings getting finalized earlier than intended Since we handle the intial starting point of a spline properly now the update logic was still expecting the old handling which resulted in incrementing the current node index earlier than intended * apply a missing change (cherry picked from commit c1e3d79a4fb5b7b1a9bca36ecd16b9bb902ced92)
2021-12-18Core/Misc: Fix static analysis issuesGiacomo Pozzoni
Fix static analysis issues reported by Coverity (cherry picked from commit ca8953a0ec8356345147b2bbc7bbdf0fa97cd625)
2021-12-18DB/Creature: Remove wrong SAI from guardsForesterDev
Closes #23824 (cherry picked from commit 176f51d1e80dc116c5a16bc6aad295016ad8b6cd)
2021-12-18Scripts/Tempest Keep: Fixed a typo in Nethermancer SepethreaKeader
Closes #23828 Ty Rizztazz (cherry picked from commit 746a1d89b34984f31ab66ef00e93a648dc42af5d)
2021-12-18Core/Misc: Fix static analysis issueGiacomo Pozzoni
Fix static analysis issue (cherry picked from commit ed087546635331e4cff4e97772a9f9978f4b1833)
2021-12-18Fix inconsistent NPC aggro on spell miss (#23816)tarwyn
(cherry picked from commit c8dc9fdc418d9703893e21603b7593b015f08fea)
2021-12-18Core/Movement: provide an extra spline path vertex for taxi pathings … ↵Ovah
(#23817) * Core/Movement: provide an extra spline path vertex for taxi pathings so the first path point wont get lost. * Update FlightPathMovementGenerator.cpp (cherry picked from commit cf3277c641bd877b9fa1939da5da7cde1778561b)
2021-12-18Instance/Script: Gorkun Ironskull & Martin VictusKillyana
(cherry picked from commit 8e3862cfbd9ee677866fbbee60c3b96ee3f4868a)
2021-12-18Core/Map: Move a log from ERROR to WARNjackpoz
Move "Could not load MMAP" log from ERROR to WARN as 99% of times is a false positive (cherry picked from commit 42ab6010f862e530517e2acd347ef6230bcf1c3b)
2021-12-18DB/Creature: Avatar of SathalKillyana
Closes #23805 (cherry picked from commit acedd840fa4886d4dfa5a76a9e7ad0a214389265)
2021-12-18Scripts/Icecrown Citadel: Remove duplicated Spell enum (#23810)Gildor
(cherry picked from commit a392216d209c6c4184581eca58e014c8babe24e1)
2021-12-18Core/Calendar: Add some additional validation when creating events (#23797)Giacomo Pozzoni
* Core/Calendar: Add some additional validation when creating events Allow only 30 player events and 100 guild events to be created. Don't allow to create guild events if player is not in guild. Send some more error messages to the client (not blizzlike errors but better than nothing). * Core/Calendar: Add some additional validation/checks Add guild id check in GetPlayerEvents(). Change error message in HandleCalendarCopyEvent() to be the same as in HandleCalendarAddEvent() when creating an event in the past. * Core/Calendar: Add some additional validation/checks Reduce the number of CMSG_CALENDAR_ADD_EVENT packets a seconds allowed from 10 to 3. * Core/Calendar: Add some additional validation/checks Implement 5 seconds cooldown between the creation of calendar events * Core/Calendar: Add some additional validation/checks Don't allow to copy events of a different player/guild * Core/Calendar: Implement automatic deletion of old events Implement automatic deletion of events older than 1 month (30 days). Fix debug assertion triggered when deleting a character with calendar events. Avoid double std::set lookup when deleting events when deleting a character. NB: The whole CalendarMgr/CalendarHandler code should be checked line by line for bugs/crashes/exploits. (cherry picked from commit fb059722fdb18a94d47b3f44a5b2d7f183bf5a29)
2021-12-18Core/Commands: Fixed wrong permissions for .lookup map commands (#23800)Kelno
(cherry picked from commit 6fc7ab3448850199835f9ee9dca6991b511eba09)
2021-12-18Core/Movement: Fix LoS issue of NPCs chasing targetsjackpoz
Add Line of Sight checks to ChaseMovementGenerator::Update(), fixing to ChaseMovementGenerator not reaching a point with valid LoS to the target. Fix re-implements 8927a042536d4671e94ad901e9209efcf78ffa2c after 2a84562dc85516f432bb1e5de9add23c28b26ce4 partially removed it. Fix #23724 (cherry picked from commit 215a6cee24896f2def2a5af390c089ac1d947e65)
2021-12-18DB/Creature: Fix some flagsKillyana
(cherry picked from commit 537c4d1208384f924a144180abd3f7c3cf305a6d)
2021-12-18DB/Creature: Gorkun Ironskull & Martin VictusKillyana
(cherry picked from commit c9aeff3bf96e88d88af6fe9e0011a3794fb194c2)
2021-12-18DB/Creature: O'Mally's Instrument BunnyTerrorBringer
Closes #23790 (cherry picked from commit b6c2baf5f690794fb4a8de930f0047e4373c39fb)
2021-12-18DB/Creature: Vision Guide Kill Credit TriggerKillyana
Closes #23784 (cherry picked from commit e300eed3d70334eb74b7c4084e7c3a052d67e4c2)
2021-12-18DB/Quest: Forge Camp: AnnihilatedKillyana
Closes #23778 (cherry picked from commit 546bd0f6fb4afa52e4434da0f7faf2f1a6bbb6ee)
2021-12-18DB/Conditions: Remove wrong condition related to Sal'salabim gossip textKillyana
Closes #23780 (cherry picked from commit e8ab60955d822363a23dff8a3d0947c1c1c4fd3d)
2021-12-18DB/Quest: Garments of the Moongenion18
Closes #23777 (cherry picked from commit 5b7b8f868fd26b0e26895bf42dfc4d499e94f816)
2021-12-18DB/Quest: Tainted Parchmentgenion18
Closes #23776 (cherry picked from commit 56a219de2043534abaea023fc6dd9f80b5a2592d)
2021-12-18Core/MovementGenerator: 680e1cbd6cf7c52abe104fb87d8fa6dba83fb633 follow-upjackpoz
(cherry picked from commit 7c0b31b8b52903ec233ad863597965594196a8e8)
2021-12-18DB: Missing change in the last commit (The Ring of Blood: The Blue Brothers ↵Killyana
on quest taken text) (cherry picked from commit 0918e7eb13cdadb6d774737fdf1429c12a843c13)
2021-12-18DB/SAI: Fix Texts related to The Ring of BloodKillyana
Closes #23774 (cherry picked from commit c907ab4381088939b001ae5e0d275cfb923849de)
2021-12-18DB/Quest: Slaves to Saronite RewardTextillfated
Closes #23707 (cherry picked from commit e2e62aa77430a83b4b0f0b1c611a6be19230d926)
2021-12-18DB/Creature: TorekKillyana
Closes #23742 (cherry picked from commit eb9d27660b9da3652f0257587aa3bf1650adb229)
2021-12-18Core/MovementGenerator: Fix crash in taxi pathsjackpoz
Fix a crash in taxi paths happening when joining a battleground/dungeon while on a taxi path after second last node but close to last node, then leaving/finishing the battleground. (cherry picked from commit 680e1cbd6cf7c52abe104fb87d8fa6dba83fb633)
2021-12-18DB/Quest: Fix chaining an DB errorsKillyana
(cherry picked from commit c892f867d578a0d847979135c9191fbdb8be805b)
2021-12-18Core/Misc: Fix parry-haste mechanic. (#23773)Gildor
* Should check victim that do a parry instead of the unit that deal the damage (Wrong implementation of this commit: 4a46fee03ef204289bbd96e8e1e07117b3bebd9f ) Closes #23754 (cherry picked from commit f8d7b260476c69e09ab0329cb7cd6c277f5473a7)
2021-12-18Scripts/Pet: Fix npc_pet_gen_soul_trader not following owner (#23772)Artamedes
(cherry picked from commit 8ecc45cd1aac1c33c8b4cb2f269ac24d728570cc)
2021-12-18Scripts/PitOfSaron: Make sure ick stops moving when casting Explosive ↵Artamedes
Barrage (#23768) (cherry picked from commit 88e74ac3855ebd5ba818c3b12899337829ce2999)
2021-12-18Scripts/PitOfSaron: Fix Krick sometimes stuck in combat after finish kill ↵Artamedes
Ick (#23767) (cherry picked from commit a17c83bde84a9f54ad5702f40ff9dd8b54e0afe0)
2021-12-18Scripts/Ulduar: Fix Stormcaller Brundir walking into walls (#23755)Artamedes
* Scripts/Ulduar: Fix Stormcaller Brundir walking into walls * Cleanup and fix logic + review * Review: remove autos (cherry picked from commit 876a8487301088fec1580e7c9ef6bf98783d9d7d)
2021-12-18Scripts/ScarletMonastery: Rewrite Mograine and Whitemane encounter (#23761)Artamedes
* Scripts/ScarletMonastery: Rewrite Mograine and Whitemane encounter * qq * qq 2 * tryfix circleci build * review suggestions (cherry picked from commit 832c95fa4f3bb8897481b0c65975b14674bbf7ee)
2021-12-18Scripts/Outland: Change auto to TempSummon* (#23764)Artamedes
(cherry picked from commit 1b095811b82e7bf390e3a3e522e768fc2b42d2b0)
2021-12-18Scripts/Outland: Fix npc_ancestral_wolf not starting waypoint (#23763)Artamedes
* Scripts/Outlands: Fix npc_ancestral_wolf not starting waypoint, and also add a way to not follow owner automatically in CreatureAI::JustAppeared() for tempsummons * fix nopch (cherry picked from commit 0b3a9e2a2b2537e7224d103947ad6028c6d2e5fe)
2021-12-18Core/Handlers: Handle CMSG_REQUEST_PET_INFO - this fixes when you /reload ↵Artamedes
and the pet bar disappears (#23762) (cherry picked from commit 6ebe1afeeccb847702c12e522bddaa7b5694dc38)
2021-12-18Core/Creature: Fix another pet assertjackpoz
Fix an assert triggered when dismissing a Warlock pet while it's casting a spell (cherry picked from commit 4074cb0f01d106c69546c3cb944d6fcf92ade456)
2021-12-18DB/Creature: Professor PutricideKillyana
Updates #23727 (cherry picked from commit 6e2e55bc38e28c5868096ebb7c49d0ce8c0d5044)
2021-12-18Scripts/ICC: Professor Putricide no longer tries to add threat on units it ↵Treeston
cannot add threat on because of immunity flags. Instead, its AI manually controls the engagement state. Should close #23727. (cherry picked from commit 23fd193e4e489bb5f231653987e98ba24448832b)
2021-12-18[3.3.5] Fix spell_area not checking for zoneID for quests (#23719)AlιAѕѕaѕѕιN
* Fix spell_area not checking for zoneID for quests * Addendum to bdffe0a4a641414fe26c9b75b00f8e70ff0f1cb8 * Fix spell_area handle same spell with the same quests Also fix not checking for quest_end at all. * Addendum to 2d6b0545e3762b3a25005726d4093cf4a7945a8d * Better commenting for 7a50189de3104f000d8b31fa6c415bb69cf1a3e7 * Addendum to 2d6b0545e3762b3a25005726d4093cf4a7945a8d (cherry picked from commit 92d83c3c2eaba3f5b58dc98472318872f3a54706)
2021-12-18nopch fixKeader
(cherry picked from commit 10f6e3818578410246750c6fce53d189ad05bee4)
2021-12-18Core/Scripts: Proper fix Gal'Darah Puncture removeKeader
(cherry picked from commit cbc01f35b6b80c1069b2274a619c8f7a3ff730c7)
2021-12-18Fix nopch buildKeader
(cherry picked from commit 1886507e7f91249a335978e2fa1a859e93d56ffa)
2021-12-18Scripts/Gundrak: Fixed Puncture when Gal'darah dieKeader
(cherry picked from commit 130a3859ecdcb0ad9eba180641b2e4ffbca83613)
2021-12-18Scripts/Gundrak: Added a missing entry in Gal Darah Stampede Charge scriptKeader
Noob Keader, Shame ! (cherry picked from commit 61ad87d1069a1ed44f7ae50f3c0646102b3ccb9a)
2021-12-18Scripts/Spells: Code style adjustments for druid scripts (#23725)Sorikoff
(cherry picked from commit 63bbf4a4bee03a3ca5e73eafcef4976c76d86f5d)