aboutsummaryrefslogtreecommitdiff
path: root/src
AgeCommit message (Collapse)Author
2016-11-20Core/Player: fix regression with EquippedItemClass requiring spellsariel-
2016-11-20Revert "Core/Spell: add EquipedItemClass/EquippedItemSubClass check to ↵ariel-
passive spell casts" This reverts commit f188ff1ce47905d7a81dff987a66b3d72152ae7c. Was breaking Titan's Grip. Spells are loaded before items, and they CAST the spell on the player. When items are then loaded, Player::ApplyItemDependentAuras only has AddAura on it. Titan's Grip is an effect, no auras involved. In turn reverting this commit will now allow Two-handed weapon specialization and similar from spells load. Which is the lesser of two evils.
2016-11-20Core/Player: fix build pt. 2ariel-
2016-11-20Core/Player: fix buildariel-
2016-11-20Core/Spell: add EquipedItemClass/EquippedItemSubClass check to passive spell ↵ariel-
casts - Was adding auras on login that didn't satisfy requirements (like Two-Handed Weapon Specialization)
2016-11-20Core/Auras: Rewritten conditionally applying ↵Shauren
SPELL_AURA_MOD_WEAPON_CRIT_PERCENT, SPELL_AURA_MOD_DAMAGE_DONE and SPELL_AURA_MOD_DAMAGE_PERCENT_DONE auras * Now the entire aura is removed when changing equipment * All aura types can now depend on equipped items (cherry picked from commit b9f7b500a362736235fc917ce4f34aa8520eb651)
2016-11-19Core/Spells: Updated spell required items check, ↵Shauren
EquippedItemInventoryTypeMask should only be used for enchantments (cherry picked from commit 28fd8a424d828f36a2b05ed016b12c4b8cf2607c)
2016-11-19Core/Guild: avoid data integrity problems wrapping delete+insert statements ↵ariel-
in a transaction
2016-11-19Core/Guild: fix indentation and codestyleariel-
2016-11-19Core/Unit: do not allow judgement spells to bypass damage immunityariel-
3f19eea5e41fd47b571c17529e08d9f8caa91705 follow-up. Without the #16658 regression
2016-11-19Core/Scripts: fixed Imp. Leader of the Packariel-
Closes #12830
2016-11-19Core/Player: recheck shapeshift bonus auras when switching spec.ariel-
- Fixes Leader of the Pack stuck when switching specs while shapeshifted
2016-11-19Core/Scripts: Seal of Corruption/Vengeance shouldn't reset periodic timer on ↵ariel-
reapply
2016-11-19Core/Entities: fix interaction of traps with ffa pvp and sanctuary flagsariel-
- Traps should select ATTACKABLE not UNFRIENDLY targets (it shouldn't attack unfriendly targets on sanctuary zones for example) - Made more readable the nasty oneliner in Unit::_IsValidAttackTarget Closes #6464 Closes #18271
2016-11-19Core/Entities: better support of absorb, resist and block procsariel-
2e457b3be418ce75b0e0ca901e84ebcdaf02ad18 followup Closes #18275
2016-11-19Core/Spell: restore old proc system behaviour on auras self proc.ariel-
- Use Spell::m_triggeredByAuraSpell and compare against trigger aura, it requires scripts to set triggeredByAura parameter. - Fixed existing scripts lacking it DB/Spell: Anger Capacitor (Tiny Abomination in a Jar) proc Closes #18269
2016-11-18Core/Spell: register items received through SPELL_EFFECT_SUMMON_CHANGE_ITEM ↵ariel-
for quest credit - Also sends proper SMSG_ITEM_PUSH_RESULT packet Closes #3505
2016-11-18Core/Spell: Fixed Drain Soul incorrectly downscaling ranks when targetting ↵ariel-
lower level enemies
2016-11-18Core/Spell: Added the possibility to explicitly disable auraEffect procs ↵ariel-
using attributes - Renamed IsProcTriggeredOnEvent to GetProcEffectMask, since long ago this function returned bool, new name should better reflect its use
2016-11-16Core/Spell: spells with ignore hit result should pierce damage immunitiesariel-
2016-11-16Core/Gameobject: fixed sometimes not found linked trapariel-
Closes #18256
2016-11-16Core/Spell: Fixed irregular handling of SPELLMOD_DOTariel-
- Applied twice for some dots - Missing for Health Leech Periodic - Missing in a few scripts Closes #17463
2016-11-16Core/Unit: fix some SPELL_AURA_MOD_DAMAGE_PERCENT_DONE effects being applied ↵ariel-
more than once No more overpowered dps for you Closes #16755
2016-11-15Core/Unit: fix buildariel-
Ctrl-S failure
2016-11-15Core/Unit: damage immune improvements ↵ariel-
(9f5df023b746d324588f175e264c62205b69e165 follow up) - Handling checked in sniffs: Spell 63710 Void Barrier vs 49143 Frost Strike * Send spell miss immune only if spell consists of damage effects - Checked with 348 Immolate: * No packets sent if damage immune, aura is applied normally Also... who the fuck uses 0 to compare against pointers
2016-11-15Core/Spell: fix a potential null dereference crashariel-
2016-11-14Core/Unit: don't use damage immunity to calculate hit result for the whole ↵ariel-
spell. Should be used only for damage
2016-11-14Core/Spell: perform charmer check against player controlling unit. Fixes ↵ariel-
spellcasts while charmed
2016-11-14Core/Spell: fix typoariel-
Closes #18248
2016-11-14Core/Unit: improved handling of some spell attributesariel-
- SPELL_ATTR1_UNAFFECTED_BY_SCHOOL_IMMUNE - SPELL_ATTR2_UNAFFECTED_BY_AURA_SCHOOL_IMMUNE - SPELL_ATTR3_IGNORE_HIT_RESULT
2016-11-14Core/Spell: fix typosariel-
2016-11-14Core/Utils: build fixariel-
2016-11-14Core/GameObject: use a friendly trigger for positive spells.ariel-
Fixes an issue with Skadi Harpoons. Note to self: should actually implement GameObject casting already :/
2016-11-14Core/Scripts: add checks to Master's Call scriptariel-
Closes #8403
2016-11-14Core/Spell: do not fail triggered Charge effects in case a root is present.ariel-
Fixes Master's call when pet is rooted
2016-11-14Core/Spell: Fix warrior Enrage stacking with Wrecking Crew and Imp. ↵ariel-
Defensive Stance
2016-11-14Core/Globals: Load spellspecific and aurastate after loading spell ranksariel-
Was breaking functionality (eg: stacking scroll auras)
2016-11-14Core/Spell: use SpellEntry to select implicit targets in case RadiusEntry ↵ariel-
wasn't set for the current effect. Closes #15388
2016-11-14Core/Spell: Fixed immunities for some spells (they were broken before ↵ariel-
rewrite too) - Warlord's Presence, Uncontrollable Frenzy, Free Friend - Overload, Lightning Tendrils - Fervor, Berserk - Determination
2016-11-14Core/Unit: consider creatures with same faction to be on the same party/raid ↵ariel-
for the purposes of spell/aura targets Ref #18233
2016-11-14Core/SpellScript: allow optional parameters to be passed to FinishCastariel-
followup of 50a3ce5703bdaa4fe16e2e773eabafa9a4818083
2016-11-14Core/ScriptMgr: use vector instead of list to contain Spell and Aura scripts ↵ariel-
and hooks
2016-11-14Core/Battleground: Fix issue reported by static analysisariel-
2016-11-13Core/Misc: codestyle fixes in GridNotifiers.hariel-
- Removed dead code, outdated comments - Fixed indentation - Explicitly delete copy ctors - const'd the operator() definitions
2016-11-13Core/Scripts: Cleanup in instance_black_temple and added missing datas (#18246)Keader
* Core/Scripts: Cleanup in instance_black_temple and added missing datas * Fixed door timing issue * Remove redundant call
2016-11-13Core/Auras: Fixed removing auras triggered by aurastatesShauren
Closes #17868 (cherry picked from commit f94e6cee38241e10daed711247a18b8706cb8924)
2016-11-12Core/Unit: misc codestyleariel-
use typedef for constant reference
2016-11-12Core/Spell: fix warningariel-
2016-11-12Core/Spell: revamp of immunities systemariel-
- Spell attributes research - Container optimization - Do not skip damage immunity checks on SPELL_ATTR0_UNAFFECTED_BY_INVULNERABILITY present - Added additonal arguments support to SendCastResult / CheckCast, spells can now send proper error messages - Loads spell immune masks/states/effects at startup. - This cached info is used whenever a spell cast requires immunities to be known beforehand (to see if an aura could be applied for example) Closes #16658 Closes #16901 Closes #18114
2016-11-12Core/Spell: move attribute helpers to spellInfoariel-
- Renamed CheckEffectExecuteData to AssertEffectExecuteData and made const, better reflects its purpose - Added missing attribute check to IsNextMeleeSwingSpell - Reworked SPELL_ATTR4_CAST_ONLY_IN_OUTLAND attr check (researched behavior)