diff options
author | Tristan 'Natrist' Cormier <natrist@users.noreply.github.com> | 2023-11-08 15:53:43 -0500 |
---|---|---|
committer | GitHub <noreply@github.com> | 2023-11-08 21:53:43 +0100 |
commit | f1cb3bfb3b372820e191bb9ca2d48bd7775b51c9 (patch) | |
tree | c12b10a3d23aef1ad5ebcf53cc9adcd655cb4bcc | |
parent | ef09d4b63f9e3eb5221c1234c87a28c10c541a5d (diff) |
refactor(Core/Network): remove redundant logging calls from some message handlers (#17565)
chore: removed redundant logging calls from some message handlers
-rw-r--r-- | src/server/game/Handlers/ArenaTeamHandler.cpp | 4 | ||||
-rw-r--r-- | src/server/game/Handlers/AuctionHouseHandler.cpp | 12 | ||||
-rw-r--r-- | src/server/game/Handlers/BankHandler.cpp | 2 | ||||
-rw-r--r-- | src/server/game/Handlers/CharacterHandler.cpp | 4 | ||||
-rw-r--r-- | src/server/game/Handlers/DuelHandler.cpp | 1 | ||||
-rw-r--r-- | src/server/game/Handlers/GroupHandler.cpp | 33 | ||||
-rw-r--r-- | src/server/game/Handlers/ItemHandler.cpp | 4 | ||||
-rw-r--r-- | src/server/game/Handlers/MiscHandler.cpp | 29 | ||||
-rw-r--r-- | src/server/game/Handlers/NPCHandler.cpp | 3 | ||||
-rw-r--r-- | src/server/game/Handlers/QueryHandler.cpp | 4 | ||||
-rw-r--r-- | src/server/game/Handlers/QuestHandler.cpp | 9 | ||||
-rw-r--r-- | src/server/game/Handlers/Socialhandler.cpp | 6 | ||||
-rw-r--r-- | src/server/game/Handlers/TaxiHandler.cpp | 10 | ||||
-rw-r--r-- | src/server/game/Server/WorldSession.cpp | 11 |
14 files changed, 3 insertions, 129 deletions
diff --git a/src/server/game/Handlers/ArenaTeamHandler.cpp b/src/server/game/Handlers/ArenaTeamHandler.cpp index e48b6bbbf5..e982f61fc4 100644 --- a/src/server/game/Handlers/ArenaTeamHandler.cpp +++ b/src/server/game/Handlers/ArenaTeamHandler.cpp @@ -62,8 +62,6 @@ void WorldSession::HandleInspectArenaTeamsOpcode(WorldPacket& recvData) void WorldSession::HandleArenaTeamQueryOpcode(WorldPacket& recvData) { - LOG_DEBUG("network", "WORLD: Received CMSG_ARENA_TEAM_QUERY"); - uint32 arenaTeamId; recvData >> arenaTeamId; @@ -76,8 +74,6 @@ void WorldSession::HandleArenaTeamQueryOpcode(WorldPacket& recvData) void WorldSession::HandleArenaTeamRosterOpcode(WorldPacket& recvData) { - LOG_DEBUG("network", "WORLD: Received CMSG_ARENA_TEAM_ROSTER"); - uint32 arenaTeamId; // arena team id recvData >> arenaTeamId; diff --git a/src/server/game/Handlers/AuctionHouseHandler.cpp b/src/server/game/Handlers/AuctionHouseHandler.cpp index 9f8856792a..d4c05d3a5c 100644 --- a/src/server/game/Handlers/AuctionHouseHandler.cpp +++ b/src/server/game/Handlers/AuctionHouseHandler.cpp @@ -395,8 +395,6 @@ void WorldSession::HandleAuctionSellItem(WorldPacket& recvData) //this function is called when client bids or buys out auction void WorldSession::HandleAuctionPlaceBid(WorldPacket& recvData) { - LOG_DEBUG("network", "WORLD: Received CMSG_AUCTION_PLACE_BID"); - ObjectGuid auctioneer; uint32 auctionId; uint32 price; @@ -528,8 +526,6 @@ void WorldSession::HandleAuctionPlaceBid(WorldPacket& recvData) //this void is called when auction_owner cancels his auction void WorldSession::HandleAuctionRemoveItem(WorldPacket& recvData) { - LOG_DEBUG("network", "WORLD: Received CMSG_AUCTION_REMOVE_ITEM"); - ObjectGuid auctioneer; uint32 auctionId; recvData >> auctioneer; @@ -603,8 +599,6 @@ void WorldSession::HandleAuctionRemoveItem(WorldPacket& recvData) //called when player lists his bids void WorldSession::HandleAuctionListBidderItems(WorldPacket& recvData) { - LOG_DEBUG("network", "WORLD: Received CMSG_AUCTION_LIST_BIDDER_ITEMS"); - ObjectGuid guid; //NPC guid uint32 listfrom; //page of auctions uint32 outbiddedCount; //count of outbidded auctions @@ -683,8 +677,6 @@ void WorldSession::HandleAuctionListOwnerItems(WorldPacket& recvData) void WorldSession::HandleAuctionListOwnerItemsEvent(ObjectGuid creatureGuid) { - LOG_DEBUG("network", "WORLD: Received CMSG_AUCTION_LIST_OWNER_ITEMS"); - _lastAuctionListOwnerItemsMSTime = GameTime::GetGameTimeMS(); // pussywizard Creature* creature = GetPlayer()->GetNPCIfCanInteractWith(creatureGuid, UNIT_NPC_FLAG_AUCTIONEER); @@ -716,8 +708,6 @@ void WorldSession::HandleAuctionListOwnerItemsEvent(ObjectGuid creatureGuid) //this void is called when player clicks on search button void WorldSession::HandleAuctionListItems(WorldPacket& recvData) { - LOG_DEBUG("network", "WORLD: Received CMSG_AUCTION_LIST_ITEMS"); - std::string searchedname; uint8 levelmin, levelmax, usable; uint32 listfrom, auctionSlotID, auctionMainCategory, auctionSubCategory, quality; @@ -773,8 +763,6 @@ void WorldSession::HandleAuctionListItems(WorldPacket& recvData) void WorldSession::HandleAuctionListPendingSales(WorldPacket& recvData) { - LOG_DEBUG("network", "WORLD: Received CMSG_AUCTION_LIST_PENDING_SALES"); - recvData.read_skip<uint64>(); uint32 count = 0; diff --git a/src/server/game/Handlers/BankHandler.cpp b/src/server/game/Handlers/BankHandler.cpp index a353cf8a06..d31ce3bb6f 100644 --- a/src/server/game/Handlers/BankHandler.cpp +++ b/src/server/game/Handlers/BankHandler.cpp @@ -46,8 +46,6 @@ void WorldSession::HandleBankerActivateOpcode(WorldPacket& recvData) { ObjectGuid guid; - LOG_DEBUG("network", "WORLD: Received CMSG_BANKER_ACTIVATE"); - recvData >> guid; Creature* unit = GetPlayer()->GetNPCIfCanInteractWith(guid, UNIT_NPC_FLAG_BANKER); diff --git a/src/server/game/Handlers/CharacterHandler.cpp b/src/server/game/Handlers/CharacterHandler.cpp index d55e1ecae2..247a81dcbc 100644 --- a/src/server/game/Handlers/CharacterHandler.cpp +++ b/src/server/game/Handlers/CharacterHandler.cpp @@ -1244,8 +1244,6 @@ void WorldSession::HandlePlayerLoginToCharOutOfWorld(Player* /*pCurrChar*/) void WorldSession::HandleSetFactionAtWar(WorldPacket& recvData) { - LOG_DEBUG("network.opcode", "WORLD: Received CMSG_SET_FACTION_ATWAR"); - uint32 repListID; uint8 flag; @@ -1292,7 +1290,6 @@ void WorldSession::HandleTutorialReset(WorldPacket& /*recvData*/) void WorldSession::HandleSetWatchedFactionOpcode(WorldPacket& recvData) { - LOG_DEBUG("network.opcode", "WORLD: Received CMSG_SET_WATCHED_FACTION"); uint32 fact; recvData >> fact; GetPlayer()->SetUInt32Value(PLAYER_FIELD_WATCHED_FACTION_INDEX, fact); @@ -1300,7 +1297,6 @@ void WorldSession::HandleSetWatchedFactionOpcode(WorldPacket& recvData) void WorldSession::HandleSetFactionInactiveOpcode(WorldPacket& recvData) { - LOG_DEBUG("network.opcode", "WORLD: Received CMSG_SET_FACTION_INACTIVE"); uint32 replistid; uint8 inactive; recvData >> replistid >> inactive; diff --git a/src/server/game/Handlers/DuelHandler.cpp b/src/server/game/Handlers/DuelHandler.cpp index 160f1a499c..77f496111c 100644 --- a/src/server/game/Handlers/DuelHandler.cpp +++ b/src/server/game/Handlers/DuelHandler.cpp @@ -52,7 +52,6 @@ void WorldSession::HandleDuelAcceptedOpcode(WorldPacket& recvPacket) void WorldSession::HandleDuelCancelledOpcode(WorldPacket& recvPacket) { - LOG_DEBUG("network", "WORLD: Received CMSG_DUEL_CANCELLED"); Player* player = GetPlayer(); ObjectGuid guid; diff --git a/src/server/game/Handlers/GroupHandler.cpp b/src/server/game/Handlers/GroupHandler.cpp index e239f61053..d8d7186191 100644 --- a/src/server/game/Handlers/GroupHandler.cpp +++ b/src/server/game/Handlers/GroupHandler.cpp @@ -60,8 +60,6 @@ void WorldSession::SendPartyResult(PartyOperation operation, const std::string& void WorldSession::HandleGroupInviteOpcode(WorldPacket& recvData) { - LOG_DEBUG("network", "WORLD: Received CMSG_GROUP_INVITE"); - std::string membername; recvData >> membername; recvData.read_skip<uint32>(); @@ -229,8 +227,6 @@ void WorldSession::HandleGroupInviteOpcode(WorldPacket& recvData) void WorldSession::HandleGroupAcceptOpcode(WorldPacket& recvData) { - LOG_DEBUG("network", "WORLD: Received CMSG_GROUP_ACCEPT"); - recvData.read_skip<uint32>(); Group* group = GetPlayer()->GetGroupInvite(); @@ -291,8 +287,6 @@ void WorldSession::HandleGroupAcceptOpcode(WorldPacket& recvData) void WorldSession::HandleGroupDeclineOpcode(WorldPacket& /*recvData*/) { - LOG_DEBUG("network", "WORLD: Received CMSG_GROUP_DECLINE"); - Group* group = GetPlayer()->GetGroupInvite(); if (!group) return; @@ -314,8 +308,6 @@ void WorldSession::HandleGroupDeclineOpcode(WorldPacket& /*recvData*/) void WorldSession::HandleGroupUninviteGuidOpcode(WorldPacket& recvData) { - LOG_DEBUG("network", "WORLD: Received CMSG_GROUP_UNINVITE_GUID"); - ObjectGuid guid; std::string reason, name; recvData >> guid; @@ -389,8 +381,6 @@ void WorldSession::HandleGroupUninviteGuidOpcode(WorldPacket& recvData) void WorldSession::HandleGroupUninviteOpcode(WorldPacket& recvData) { - LOG_DEBUG("network", "WORLD: Received CMSG_GROUP_UNINVITE"); - std::string membername; recvData >> membername; @@ -436,8 +426,6 @@ void WorldSession::HandleGroupUninviteOpcode(WorldPacket& recvData) void WorldSession::HandleGroupSetLeaderOpcode(WorldPacket& recvData) { - LOG_DEBUG("network", "WORLD: Received CMSG_GROUP_SET_LEADER"); - ObjectGuid guid; recvData >> guid; @@ -457,8 +445,6 @@ void WorldSession::HandleGroupSetLeaderOpcode(WorldPacket& recvData) void WorldSession::HandleGroupDisbandOpcode(WorldPacket& /*recvData*/) { - LOG_DEBUG("network", "WORLD: Received CMSG_GROUP_DISBAND"); - Group* grp = GetPlayer()->GetGroup(); if (!grp) return; @@ -480,8 +466,6 @@ void WorldSession::HandleGroupDisbandOpcode(WorldPacket& /*recvData*/) void WorldSession::HandleLootMethodOpcode(WorldPacket& recvData) { - LOG_DEBUG("network", "WORLD: Received CMSG_LOOT_METHOD"); - uint32 lootMethod; ObjectGuid lootMaster; uint32 lootThreshold; @@ -544,8 +528,6 @@ void WorldSession::HandleLootRoll(WorldPacket& recvData) void WorldSession::HandleMinimapPingOpcode(WorldPacket& recvData) { - LOG_DEBUG("network", "WORLD: Received MSG_MINIMAP_PING"); - if (!GetPlayer()->GetGroup()) return; @@ -581,8 +563,6 @@ void WorldSession::HandleRandomRollOpcode(WorldPackets::Misc::RandomRollClient& void WorldSession::HandleRaidTargetUpdateOpcode(WorldPacket& recvData) { - LOG_DEBUG("network", "WORLD: Received MSG_RAID_TARGET_UPDATE"); - Group* group = GetPlayer()->GetGroup(); if (!group) return; @@ -620,8 +600,6 @@ void WorldSession::HandleRaidTargetUpdateOpcode(WorldPacket& recvData) void WorldSession::HandleGroupRaidConvertOpcode(WorldPacket& /*recvData*/) { - LOG_DEBUG("network", "WORLD: Received CMSG_GROUP_RAID_CONVERT"); - Group* group = GetPlayer()->GetGroup(); if (!group) return; @@ -647,8 +625,6 @@ void WorldSession::HandleGroupRaidConvertOpcode(WorldPacket& /*recvData*/) void WorldSession::HandleGroupChangeSubGroupOpcode(WorldPacket& recvData) { - LOG_DEBUG("network", "WORLD: Received CMSG_GROUP_CHANGE_SUB_GROUP"); - // we will get correct pointer for group here, so we don't have to check if group is BG raid Group* group = GetPlayer()->GetGroup(); if (!group) @@ -686,8 +662,6 @@ void WorldSession::HandleGroupChangeSubGroupOpcode(WorldPacket& recvData) void WorldSession::HandleGroupAssistantLeaderOpcode(WorldPacket& recvData) { - LOG_DEBUG("network", "WORLD: Received CMSG_GROUP_ASSISTANT_LEADER"); - Group* group = GetPlayer()->GetGroup(); if (!group) return; @@ -707,8 +681,6 @@ void WorldSession::HandleGroupAssistantLeaderOpcode(WorldPacket& recvData) void WorldSession::HandlePartyAssignmentOpcode(WorldPacket& recvData) { - LOG_DEBUG("network", "WORLD: Received MSG_PARTY_ASSIGNMENT"); - Group* group = GetPlayer()->GetGroup(); if (!group) return; @@ -741,8 +713,6 @@ void WorldSession::HandlePartyAssignmentOpcode(WorldPacket& recvData) void WorldSession::HandleRaidReadyCheckOpcode(WorldPacket& recvData) { - LOG_DEBUG("network", "WORLD: Received MSG_RAID_READY_CHECK"); - Group* group = GetPlayer()->GetGroup(); if (!group) return; @@ -986,7 +956,6 @@ void WorldSession::BuildPartyMemberStatsChangedPacket(Player* player, WorldPacke /*this procedure handles clients CMSG_REQUEST_PARTY_MEMBER_STATS request*/ void WorldSession::HandleRequestPartyMemberStatsOpcode(WorldPacket& recvData) { - LOG_DEBUG("network", "WORLD: Received CMSG_REQUEST_PARTY_MEMBER_STATS"); ObjectGuid Guid; recvData >> Guid; @@ -1127,8 +1096,6 @@ void WorldSession::HandleRequestRaidInfoOpcode(WorldPacket& /*recvData*/) void WorldSession::HandleOptOutOfLootOpcode(WorldPacket& recvData) { - LOG_DEBUG("network", "WORLD: Received CMSG_OPT_OUT_OF_LOOT"); - uint32 passOnLoot; recvData >> passOnLoot; // 1 always pass, 0 do not pass diff --git a/src/server/game/Handlers/ItemHandler.cpp b/src/server/game/Handlers/ItemHandler.cpp index dae3a05a0b..655418b48a 100644 --- a/src/server/game/Handlers/ItemHandler.cpp +++ b/src/server/game/Handlers/ItemHandler.cpp @@ -727,7 +727,6 @@ void WorldSession::HandleReadItem(WorldPacket& recvData) void WorldSession::HandleSellItemOpcode(WorldPacket& recvData) { - LOG_DEBUG("network", "WORLD: Received CMSG_SELL_ITEM"); ObjectGuid vendorguid, itemguid; uint32 count; @@ -908,7 +907,6 @@ void WorldSession::HandleSellItemOpcode(WorldPacket& recvData) void WorldSession::HandleBuybackItem(WorldPacket& recvData) { - LOG_DEBUG("network", "WORLD: Received CMSG_BUYBACK_ITEM"); ObjectGuid vendorguid; uint32 slot; @@ -964,7 +962,6 @@ void WorldSession::HandleBuybackItem(WorldPacket& recvData) void WorldSession::HandleBuyItemInSlotOpcode(WorldPacket& recvData) { - LOG_DEBUG("network", "WORLD: Received CMSG_BUY_ITEM_IN_SLOT"); ObjectGuid vendorguid, bagguid; uint32 item, slot, count; uint8 bagslot; @@ -1006,7 +1003,6 @@ void WorldSession::HandleBuyItemInSlotOpcode(WorldPacket& recvData) void WorldSession::HandleBuyItemOpcode(WorldPacket& recvData) { - LOG_DEBUG("network", "WORLD: Received CMSG_BUY_ITEM"); ObjectGuid vendorguid; uint32 item, slot, count; uint8 unk1; diff --git a/src/server/game/Handlers/MiscHandler.cpp b/src/server/game/Handlers/MiscHandler.cpp index 51d78c57e7..507244dcca 100644 --- a/src/server/game/Handlers/MiscHandler.cpp +++ b/src/server/game/Handlers/MiscHandler.cpp @@ -622,14 +622,6 @@ void WorldSession::HandleBugOpcode(WorldPacket& recv_data) recv_data >> typelen >> type; - if (suggestion == 0) - LOG_DEBUG("network", "WORLD: Received CMSG_BUG [Bug Report]"); - else - LOG_DEBUG("network", "WORLD: Received CMSG_BUG [Suggestion]"); - - LOG_DEBUG("network", "{}", type); - LOG_DEBUG("network", "{}", content); - CharacterDatabasePreparedStatement* stmt = CharacterDatabase.GetPreparedStatement(CHAR_INS_BUG_REPORT); stmt->SetData(0, type); @@ -640,8 +632,6 @@ void WorldSession::HandleBugOpcode(WorldPacket& recv_data) void WorldSession::HandleReclaimCorpseOpcode(WorldPacket& recv_data) { - LOG_DEBUG("network", "WORLD: Received CMSG_RECLAIM_CORPSE"); - ObjectGuid guid; recv_data >> guid; @@ -676,8 +666,6 @@ void WorldSession::HandleReclaimCorpseOpcode(WorldPacket& recv_data) void WorldSession::HandleResurrectResponseOpcode(WorldPacket& recv_data) { - LOG_DEBUG("network", "WORLD: Received CMSG_RESURRECT_RESPONSE"); - ObjectGuid guid; uint8 status; recv_data >> guid; @@ -857,8 +845,6 @@ void WorldSession::HandleAreaTriggerOpcode(WorldPacket& recv_data) void WorldSession::HandleUpdateAccountData(WorldPacket& recv_data) { - LOG_DEBUG("network", "WORLD: Received CMSG_UPDATE_ACCOUNT_DATA"); - uint32 type, timestamp, decompressedSize; recv_data >> type >> timestamp >> decompressedSize; @@ -912,8 +898,6 @@ void WorldSession::HandleUpdateAccountData(WorldPacket& recv_data) void WorldSession::HandleRequestAccountData(WorldPacket& recv_data) { - LOG_DEBUG("network", "WORLD: Received CMSG_REQUEST_ACCOUNT_DATA"); - uint32 type; recv_data >> type; @@ -950,7 +934,6 @@ void WorldSession::HandleRequestAccountData(WorldPacket& recv_data) void WorldSession::HandleSetActionButtonOpcode(WorldPacket& recv_data) { - LOG_DEBUG("network", "WORLD: Received CMSG_SET_ACTION_BUTTON"); uint8 button; uint32 packetData; recv_data >> button >> packetData; @@ -992,26 +975,18 @@ void WorldSession::HandleSetActionButtonOpcode(WorldPacket& recv_data) void WorldSession::HandleCompleteCinematic(WorldPacket& /*recv_data*/) { -{ - LOG_DEBUG("network", "WORLD: Received CMSG_COMPLETE_CINEMATIC"); -} // If player has sight bound to visual waypoint NPC we should remove it GetPlayer()->GetCinematicMgr()->EndCinematic(); } void WorldSession::HandleNextCinematicCamera(WorldPacket& /*recv_data*/) { -{ - LOG_DEBUG("network", "WORLD: Received CMSG_NEXT_CINEMATIC_CAMERA"); -} // Sent by client when cinematic actually begun. So we begin the server side process GetPlayer()->GetCinematicMgr()->BeginCinematic(); } void WorldSession::HandleFeatherFallAck(WorldPacket& recv_data) { - LOG_DEBUG("network", "WORLD: CMSG_MOVE_FEATHER_FALL_ACK"); - // no used recv_data.rfinish(); // prevent warnings spam } @@ -1046,8 +1021,6 @@ void WorldSession::HandleInspectOpcode(WorldPacket& recv_data) ObjectGuid guid; recv_data >> guid; - LOG_DEBUG("network", "WORLD: Received CMSG_INSPECT"); - Player* player = ObjectAccessor::GetPlayer(*_player, guid); if (!player) { @@ -1133,8 +1106,6 @@ void WorldSession::HandleWorldTeleportOpcode(WorldPacket& recv_data) recv_data >> PositionZ; recv_data >> Orientation; // o (3.141593 = 180 degrees) - LOG_DEBUG("network", "WORLD: Received CMSG_WORLD_TELEPORT"); - if (GetPlayer()->IsInFlight()) { LOG_DEBUG("network", "Player '{}' ({}) in flight, ignore worldport command.", GetPlayer()->GetName(), GetPlayer()->GetGUID().ToString()); diff --git a/src/server/game/Handlers/NPCHandler.cpp b/src/server/game/Handlers/NPCHandler.cpp index 9794ca8d98..237ccf1661 100644 --- a/src/server/game/Handlers/NPCHandler.cpp +++ b/src/server/game/Handlers/NPCHandler.cpp @@ -215,7 +215,6 @@ void WorldSession::HandleTrainerBuySpellOpcode(WorldPacket& recvData) uint32 spellId = 0; recvData >> guid >> spellId; - LOG_DEBUG("network", "WORLD: Received CMSG_TRAINER_BUY_SPELL Npc {}, learn spell id is: {}", guid.ToString(), spellId); Creature* unit = GetPlayer()->GetNPCIfCanInteractWith(guid, UNIT_NPC_FLAG_TRAINER); if (!unit) @@ -273,8 +272,6 @@ void WorldSession::HandleTrainerBuySpellOpcode(WorldPacket& recvData) void WorldSession::HandleGossipHelloOpcode(WorldPacket& recvData) { - LOG_DEBUG("network", "WORLD: Received CMSG_GOSSIP_HELLO"); - ObjectGuid guid; recvData >> guid; diff --git a/src/server/game/Handlers/QueryHandler.cpp b/src/server/game/Handlers/QueryHandler.cpp index fca5fc9b7b..df6f4ff271 100644 --- a/src/server/game/Handlers/QueryHandler.cpp +++ b/src/server/game/Handlers/QueryHandler.cpp @@ -219,8 +219,6 @@ void WorldSession::HandleGameObjectQueryOpcode(WorldPacket& recvData) void WorldSession::HandleCorpseQueryOpcode(WorldPacket& /*recvData*/) { - LOG_DEBUG("network", "WORLD: Received MSG_CORPSE_QUERY"); - if (!_player->HasCorpse()) { WorldPacket data(MSG_CORPSE_QUERY, 1); @@ -356,8 +354,6 @@ void WorldSession::HandleNpcTextQueryOpcode(WorldPacket& recvData) /// Only _static_ data is sent in this packet !!! void WorldSession::HandlePageTextQueryOpcode(WorldPacket& recvData) { - LOG_DEBUG("network", "WORLD: Received CMSG_PAGE_TEXT_QUERY"); - uint32 pageID; recvData >> pageID; recvData.read_skip<uint64>(); // guid diff --git a/src/server/game/Handlers/QuestHandler.cpp b/src/server/game/Handlers/QuestHandler.cpp index 5f29273038..18ce2e57d1 100644 --- a/src/server/game/Handlers/QuestHandler.cpp +++ b/src/server/game/Handlers/QuestHandler.cpp @@ -380,8 +380,6 @@ void WorldSession::HandleQuestgiverRequestRewardOpcode(WorldPacket& recvData) void WorldSession::HandleQuestgiverCancel(WorldPacket& /*recvData*/) { - LOG_DEBUG("network", "WORLD: Received CMSG_QUESTGIVER_CANCEL"); - _player->PlayerTalkClass->SendCloseGossip(); } @@ -535,7 +533,6 @@ void WorldSession::HandleQuestgiverCompleteQuest(WorldPacket& recvData) void WorldSession::HandleQuestgiverQuestAutoLaunch(WorldPacket& /*recvPacket*/) { - LOG_DEBUG("network", "WORLD: Received CMSG_QUESTGIVER_QUEST_AUTOLAUNCH"); } void WorldSession::HandlePushQuestToParty(WorldPacket& recvPacket) @@ -624,8 +621,6 @@ void WorldSession::HandleQuestPushResult(WorldPacket& recvPacket) uint8 msg; recvPacket >> guid >> questId >> msg; - LOG_DEBUG("network", "WORLD: Received MSG_QUEST_PUSH_RESULT"); - if (_player->GetDivider() && _player->GetDivider() == guid) { if (Player* player = ObjectAccessor::GetPlayer(*_player, _player->GetDivider())) @@ -641,9 +636,7 @@ void WorldSession::HandleQuestPushResult(WorldPacket& recvPacket) void WorldSession::HandleQuestgiverStatusMultipleQuery(WorldPacket& /*recvPacket*/) { - LOG_DEBUG("network", "WORLD: Received CMSG_QUESTGIVER_STATUS_MULTIPLE_QUERY"); - - _player->SendQuestGiverStatusMultiple(); + _player->SendQuestGiverStatusMultiple(); } void WorldSession::HandleQueryQuestsCompleted(WorldPacket& /*recvData*/) diff --git a/src/server/game/Handlers/Socialhandler.cpp b/src/server/game/Handlers/Socialhandler.cpp index adb1f60e6b..5a0860cca5 100644 --- a/src/server/game/Handlers/Socialhandler.cpp +++ b/src/server/game/Handlers/Socialhandler.cpp @@ -31,15 +31,11 @@ void WorldSession::HandleContactListOpcode(WorldPacket& recv_data) uint32 flags; recv_data >> flags; - LOG_DEBUG("network", "WORLD: Received CMSG_CONTACT_LIST - Unk: {}", flags); - _player->GetSocial()->SendSocialList(_player, flags); } void WorldSession::HandleAddFriendOpcode(WorldPacket& recv_data) { - LOG_DEBUG("network", "WORLD: Received CMSG_ADD_FRIEND"); - std::string friendName = GetAcoreString(LANG_FRIEND_IGNORE_UNKNOWN); std::string friendNote; @@ -49,8 +45,6 @@ void WorldSession::HandleAddFriendOpcode(WorldPacket& recv_data) if (!normalizePlayerName(friendName)) return; - LOG_DEBUG("network", "WORLD: {} asked to add friend : '{}'", GetPlayer()->GetName(), friendName); - ObjectGuid friendGuid = sCharacterCache->GetCharacterGuidByName(friendName); if (!friendGuid) return; diff --git a/src/server/game/Handlers/TaxiHandler.cpp b/src/server/game/Handlers/TaxiHandler.cpp index e3678168a7..7a979981fe 100644 --- a/src/server/game/Handlers/TaxiHandler.cpp +++ b/src/server/game/Handlers/TaxiHandler.cpp @@ -27,8 +27,6 @@ void WorldSession::HandleTaxiNodeStatusQueryOpcode(WorldPacket& recvData) { - LOG_DEBUG("network", "WORLD: Received CMSG_TAXINODE_STATUS_QUERY"); - ObjectGuid guid; recvData >> guid; @@ -61,8 +59,6 @@ void WorldSession::SendTaxiStatus(ObjectGuid guid) void WorldSession::HandleTaxiQueryAvailableNodes(WorldPacket& recvData) { - LOG_DEBUG("network", "WORLD: Received CMSG_TAXIQUERYAVAILABLENODES"); - ObjectGuid guid; recvData >> guid; @@ -168,8 +164,6 @@ void WorldSession::SendDiscoverNewTaxiNode(uint32 nodeid) void WorldSession::HandleActivateTaxiExpressOpcode(WorldPacket& recvData) { - LOG_DEBUG("network", "WORLD: Received CMSG_ACTIVATETAXIEXPRESS"); - ObjectGuid guid; uint32 node_count; @@ -209,8 +203,6 @@ void WorldSession::HandleActivateTaxiExpressOpcode(WorldPacket& recvData) void WorldSession::HandleMoveSplineDoneOpcode(WorldPacket& recvData) { - LOG_DEBUG("network", "WORLD: Received CMSG_MOVE_SPLINE_DONE"); - ObjectGuid guid; // used only for proper packet read recvData >> guid.ReadAsPacked(); @@ -263,8 +255,6 @@ void WorldSession::HandleMoveSplineDoneOpcode(WorldPacket& recvData) void WorldSession::HandleActivateTaxiOpcode(WorldPacket& recvData) { - LOG_DEBUG("network", "WORLD: Received CMSG_ACTIVATETAXI"); - ObjectGuid guid; std::vector<uint32> nodes; nodes.resize(2); diff --git a/src/server/game/Server/WorldSession.cpp b/src/server/game/Server/WorldSession.cpp index 3ab5e7a31c..5ff13beca4 100644 --- a/src/server/game/Server/WorldSession.cpp +++ b/src/server/game/Server/WorldSession.cpp @@ -205,12 +205,6 @@ ObjectGuid::LowType WorldSession::GetGuidLow() const /// Send a packet to the client void WorldSession::SendPacket(WorldPacket const* packet) { - if (packet->GetOpcode() == NULL_OPCODE) - { - LOG_ERROR("network.opcode", "{} send NULL_OPCODE", GetPlayerInfo()); - return; - } - if (!m_Socket) return; @@ -255,7 +249,6 @@ void WorldSession::SendPacket(WorldPacket const* packet) return; } - LOG_TRACE("network.opcode", "S->C: {} {}", GetPlayerInfo(), GetOpcodeNameForLogging(static_cast<OpcodeServer>(packet->GetOpcode()))); m_Socket->SendPacket(*packet); } @@ -316,6 +309,7 @@ bool WorldSession::Update(uint32 diff, PacketFilter& updater) ClientOpcodeHandler const* opHandle = opcodeTable[opcode]; METRIC_DETAILED_TIMER("worldsession_update_opcode_time", METRIC_TAG("opcode", opHandle->Name)); + LOG_DEBUG("network", "message id {} ({}) under READ", opcode, opHandle->Name); try { @@ -332,8 +326,7 @@ bool WorldSession::Update(uint32 diff, PacketFilter& updater) requeuePackets.push_back(packet); deletePacket = false; - LOG_DEBUG("network", "Re-enqueueing packet with opcode {} with with status STATUS_LOGGEDIN. " - "Player {} is currently not in world yet.", GetOpcodeNameForLogging(static_cast<OpcodeClient>(packet->GetOpcode())), GetPlayerInfo()); + LOG_DEBUG("network", "Delaying processing of message with status STATUS_LOGGEDIN: No players in the world for account id {}", GetAccountId()); } } else if (_player->IsInWorld()) |