Commit Graph

453 Commits

Author SHA1 Message Date
megamage
07cf71fdd4 Some cleanup of add/remove to/from map. 2011-11-11 17:50:26 -05:00
Shocker
c2a2a4f713 Merge pull request #3872 from Bootz/master
Codestyle clean-up
2011-11-09 02:31:18 -08:00
megamage
462a2b9876 Change more ace_guard to trinity_guard 2011-11-08 10:48:49 -05:00
Bootz
d1334624da Core: Codestyle clean-up
"pl"->"player"

 Note: codestyle methods needs maintained, Player* player.
still to do properly clean-up chat.cpp.
2011-11-07 11:18:00 -06:00
Bootz
f75ec5ba2b Core: Codestyle clean-up
"plr"->player

Note: codestyle methods needs maintained, Player* player.
2011-11-07 11:06:39 -06:00
Yelvann
75edf63341 Revert commit ab023e8 (Add GM tag to gms in Who)
Closes #3783
2011-11-03 18:10:11 +01:00
megamage
e3fa04823d Use TRINITY_GUARD to replace ACE_GUARD. ASSERT(false) if failed to acquire the lock. 2011-10-31 17:25:12 -04:00
megamage
c9c5c2a355 Use read/write thread mx guard instead of general guard for HashMapHolder. 2011-10-21 17:29:09 -04:00
kaelima
be0b2fcf97 Core/Grid:
- Simplified CellArea calculation (Original author: SilverIce)

- Removed unused code in Cell class (Original author: SilverIce)

- Improve some Visit functions.
2011-10-19 17:40:44 +01:00
megamage
c29ff41001 Rename some classes in grid system.
Note: The naming of classes is still confusing. "cell" usually refers to class "Grid", and "grid" usually refers to class "NGrid". But it requires a lot of changes to clean this up.
2011-10-18 10:53:34 -04:00
Spp
b5e8a192b1 Core/Calendar: Send map raid reset only once
Also some minor changes here and there
2011-10-18 14:23:08 +02:00
Spp
ee69fc940e Core/Items: Split SetSoulboundTradeable in two functions (Set and Clear)
Note: this is mostly for clarify action being done: ClearSoulboundTradeable better than SetSoulboundTradeable(..., ..., false)
2011-10-18 10:44:45 +02:00
kaelima
3fd58b7b30 Core/Group: Fix recent issues with displaying group members on minimap.
Update GroupMemberOnlineStatus enum (creds to TOMRUS)
Also fix reduant GetVehicle() check in BuildPartyMemberStatsChangedPacket
2011-10-11 23:09:49 +02:00
megamage
8ce5177f74 Pass low guid instead of guid to DeleteCharaceterNameData.
Thanks to Studioworks for pointing out.
2011-10-10 18:03:19 -04:00
megamage
3ba22d0d06 Rename Map::Add to Map::AddToMap, Map::Remove to Map::RemoveFromMap for better management. 2011-10-10 17:39:34 -04:00
megamage
d156e066cf Rename "SetPosition" to "UpdatePosition".
Replace CreatureRelocation in scripts with new Creature::SetPosition.
2011-10-10 17:08:01 -04:00
megamage
765a6f2e19 Remove duplicated code for SendNameQueryOpcode 2011-10-10 12:47:33 -04:00
megamage
45de1f01e0 Update char name data when create/delete char. 2011-10-08 16:24:07 -04:00
megamage
0bb86a3e97 Update code related to character name data.
Note: need to add/delete data when character is created/deleted.
2011-10-08 16:09:12 -04:00
megamage
1e44044a8f Merge pull request #3281 from n4ndo/master
Fix Crash in ProcessQueryCallbacks
2011-10-07 15:19:21 -07:00
Bootz
81c0a3a847 REPO: code-style clean-up
* Fixed pPlayer->player
* Fixed pCreature->creature

~DevNote: codestyle for Player should be (*player), not *plr or *p...
same goes for Creatures (*creature)... more cleaning needed.
We've way too many codestyles happening here.
2011-10-07 11:08:09 -05:00
Bootz
96d7a1e970 REPO: code-style clean-up
* Fixed pGuild->guild
* Fixed pGroup->group
* Fixed pOwner->owner
2011-10-07 10:54:53 -05:00
Shauren
cde2427cab Core/Movement: Players should not get instantly teleported to graveyard when falling under map 2011-09-30 18:40:09 +02:00
Shauren
da54fb92d5 Core/Movement: Fixed knockback visibility for other players (no more "teleport") and knockback strength from creature spells (this does not fix knocking creatures back) 2011-09-30 18:24:12 +02:00
n4ndo
49afe79ddf code style 2011-09-30 11:02:17 -05:00
n4ndo
d1370a5e0a Fix Crash in ProcessQueryCallbacks 2011-09-30 10:57:02 -05:00
Spp
b16d2245bb Cosmetic: Multiple cosmetic changes
- Added missing space to 'if', 'for', 'while' and 'switch' when it's followed by '('
- Added missing space after a comma and remove space before comma (with some exceptions)
- Remove trailing spaces
- Convert tab to spaces

Note: Only affects files with extension "cpp" and "h" under /src/server
2011-09-29 12:43:05 +02:00
Spp
8b820baa73 Core/Battleground: Use a general solution for MSG_BATTLEGROUND_PLAYER_POSITIONS 2011-09-29 10:21:33 +02:00
Spp
be12603150 Configuration/ConfigMgr: converted from singleton to namespace with free functions. 2011-09-28 13:00:43 +02:00
Spp
cc06c41887 Core: Move FormationMgr to namespace
Also...
- Warning fixes
- Make Singleton constructors private
2011-09-28 11:11:38 +02:00
Spp
8484b004dd Core/Handler: Move couple of msgs to Debug 2011-09-26 09:52:17 +02:00
Spp
ab023e847a Core/Misc: Add <GM> tag to GMs in Who list 2011-09-23 11:23:22 +02:00
Aokromes
055b9c7574 Remove 2 useless logs 2011-09-18 09:29:09 +03:00
QAston
c0b1823524 Core/Entities: Replace Unit::canAttack usage with more accurate Unit::IsValidAttackTarget 2011-09-16 23:49:31 +02:00
Spp
6c943bfb08 Core: Cleanup in MiscHandler::SendAreaTriggerMessage and warning fixes 2011-09-16 10:53:24 +02:00
Spp
af05915b9e [Cosmetic] Apply codestyle "XXX * " and "XXX *" changed to "XXX* " (with some exceptions) 2011-09-15 14:12:57 +02:00
Spp-
49686075c3 Core/Dungeon Finder: Use areatrigger coords when trying to get out from a lfg dungeon using the portal after player have been disconnected and original coords have not been saved 2011-09-14 10:16:14 +02:00
QAston
1fef67187b Core/Protocol: Define more opcode names - thanks to TOM_RUS. 2011-09-11 11:41:55 +02:00
Spp-
45af1238cf Conditions/DisableMgr: converted from singleton to namespace with free functions. 2011-09-09 14:27:23 +02:00
Spp-
c4c9165428 Core/ArenaTeam: Use full captain guid instead of low guid on team creation and some code cleanup 2011-09-09 13:05:51 +02:00
Spp-
327fe7c247 Core: Define helper functions to know if an account is Player, Moderator, GM, Admin or Console 2011-09-08 15:11:55 +02:00
Spp-
eddcb8ffbf AccountMgr singleton converted to namespace with free functions as it has no internal state 2011-09-08 10:49:58 +02:00
VladimirMangos
5823b0379b Core/Loot:
- SMSG_LOOT_MONEY_NOTIFY is sent after SMSG_LOOT_CLEAR_MONEY.
- Fixed chat message displayed when looting gold with > 1 member in group.
2011-09-07 00:04:27 +02:00
Nay
990ab77b82 Core/PacketIO: Remove most calls to hexlike()
These are not needed in production code (even in debug logging)
2011-09-06 19:32:06 +01:00
Spp-
30fb856ea3 Fix typo (Rename SPELL_AURA_PREVENT_RESSURECTION to SPELL_AURA_PREVENT_RESURRECTION) 2011-09-06 14:23:53 +02:00
Spp-
4560991144 Core/Handler: Do now use dynamic memory allocation in character creation 2011-09-06 10:41:10 +02:00
kaelima
f8023d912d Core/PacketIO: Fix some more "unprocessed tail data" errors.
Also some cleanup.
2011-09-05 14:54:19 +02:00
kaelima
35680c2f1f Core/Channels: Properly fix "opcode CMSG_MESSAGECHAT have unprocessed tail data". 2011-09-05 13:58:49 +02:00
kaelima
18af717a0f Core/Channels: Fix crash in HandleJoinChannel introduced with commit bbde479f4a. 2011-09-05 13:53:14 +02:00
Nay
bbde479f4a Core/Channels: Fix the console error "opcode CMSG_MESSAGECHAT have unprocessed tail data" and some logic problems when joining/leaving some channels (like only be able to join LFG inside a city) 2011-09-04 18:56:04 +01:00