Commit Graph

33052 Commits

Author SHA1 Message Date
Keader
19602c2e83 Core/Spells: Removed duplicated check
unitTarget was checked twice in Spell::EffectTaunt

(cherry picked from commit 3a0417f712)
2020-06-14 23:49:05 +02:00
ariel-
1881088744 Core/AI: Factory functions cleanup
- Get rid of fugly void pointers
- Streamlined AI selection code, using Permissible as it should've been instead of harcoded checks on the selector code
- Moved IdleMovementGenerator singleton to factory code

(cherry picked from commit ce3787f190)
2020-06-14 23:49:05 +02:00
ariel-
43339e6840 Core/Players: fix null dereference crash
(cherry picked from commit c3176a8143)
2020-06-14 23:49:04 +02:00
treeston
57e3a67c94 Fix an issue where CanSpawn would never get invoked on creatures without per-guid script.
(cherry picked from commit aeaa8ecfab)
2020-06-14 23:49:04 +02:00
treeston
803012cc40 Add another helper to ScriptedGossip.h for resolving listId -> action.
(cherry picked from commit 302a039b7c)
2020-06-14 23:49:04 +02:00
sirikfoll
c99963b023 Core/Scripts Properly set Freya's BossState do DONE and avoid some loot exploits
Closes #19823

(cherry picked from commit 1cc0458b11)
2020-06-14 23:49:04 +02:00
Treeston
aa811d57b6 Partial revert of 15a207f, which was causing issues (ref #4943 and #19768). Instead, fix the underlying issue from 15a207f one level further down - Unit::getAttackerForHelper() shouldn't return units that we aren't in combat with (victim can be such a unit for players/player pets, which can startattack from a distance without entering combat). (#19814)
Fixes the following issues:
- Player pets would aggro neutral mobs as soon as they start autocasting (Imp's Firebolt) if they're in react range (due to victim != null, autocast counts as autoattack and sets victim)
- Neutral mobs would randomly evade when aggro switched between targets.

Closes #19768, #19485 and #10921.

(from PR #19814)

(cherry picked from commit 69fd6245dc)
2020-06-14 23:49:04 +02:00
Dr-J
e782799c30 DB/Conditions: Charles Worth
Correct conditions for gossip

closes #19516

(cherry picked from commit 607686a912)
2020-06-14 23:49:04 +02:00
Killyana
c8901a52ee DB/Creature: Remove double spawns from Death Knights area
(cherry picked from commit 7f1315f77d)
2020-06-14 23:49:04 +02:00
Dr-J
800d664502 DB/SAI: Add some missing charmed flags
DB/SAI: Add missing charmed flags to blight geists which is required for when they are charmed as part of it roll's downhill.

(cherry picked from commit f2c351158b)
2020-06-14 23:49:04 +02:00
ForesterDev
7211c6e51d Scripts/Command: implement .debug play music command
Closes #19809

(cherry picked from commit dd4ff1fe54)
2020-06-14 23:49:04 +02:00
Killyana
3f83c9dd1d DB: Add some missing Broadcast Text
(cherry picked from commit 60a69bcd3d)
2020-06-14 23:49:04 +02:00
Treeston
496263fccb Fix evade issues when a spell hits the target just before evading. (#19815)
- Creatures should no longer get stuck in evade mode following a target if a spell hits the creature just as it's entering evade mode.
- Fixes and closes #4943. Finally.

(cherry picked from commit 1945874f96)
2020-06-14 23:49:04 +02:00
ariel-
b1f1cc4514 Core/Spell: in case of immunity, check all effects to choose correct procFlags, as none has technically hit
(cherry picked from commit 63e502a67d)
2020-06-14 23:49:04 +02:00
treeston
6f73960480 Instances/Ulduar: Fix a super edge case bug where Algalon would evade if his tank successfully tanked a Cosmic Smash and got knocked up. Shadow priests everywhere rejoiced.
(cherry picked from commit b6a4e9f3f9)
2020-06-14 23:49:04 +02:00
ariel-
444754e65a Core/SmartAI: allow SMART_ACTION_SEND_GOSSIP_MENU to override default gossip
Closes #19769

(cherry picked from commit f2b0819e53)
2020-06-14 23:49:04 +02:00
treeston
250aef5186 Quickfix a bug introduced by 2f19d97 which prevented GTAoE from being cast.
(cherry picked from commit 1c528c30f8)
2020-06-14 23:49:04 +02:00
ariel-
f1eb73001c Core/Spell: fixed some problems with per caster aura states
- Update clients whenever target has more than one application of an aura that applies such aurastate
- Update again when one application gets removed
- Fixed Fire and Brimstone computing damage if any warlock applied the Immolate (should only count for own)

Closes #19790

(cherry picked from commit e27c385b48)
2020-06-14 23:49:04 +02:00
ariel-
6fa8b8e1d5 Core/Creature: fix _DespawnAtEvade saving wrong respawn time
Closes #19557

(cherry picked from commit 47d387d6b0)
2020-06-14 23:49:04 +02:00
ariel-
25f47e4680 Core/Spell: abort channeling if no valid targets are found after searching
Closes #17624

(cherry picked from commit 2f19d97d21)
2020-06-14 23:49:03 +02:00
ariel-
b161447b47 Scripts/VioletHold: fix stack overflow when reflecting 'Splash'
Closes #19514

(cherry picked from commit d9a1c82ab4)
2020-06-14 23:49:03 +02:00
Keader
a3439b6555 DB/Spells: Fixed Paladin T8 Holy 2P Bonus proc
Close #19796

(cherry picked from commit 4fcea41519)
2020-06-14 23:49:03 +02:00
Killyana
8c6d28f72d DB/GamObject: Sons of Hodir Gameobject quest givers Visibility
Closes #19787

(cherry picked from commit 66bd3459e4)
2020-06-14 23:49:03 +02:00
Aokromes
ce1dc8b3de Fix build
(cherry picked from commit 195db7c7bb)
2020-06-14 23:49:03 +02:00
Dr-J
e9dc775686 DB/SAI: Tormenting the softknuckles
Fix script so that if player does not sucessfully kill the hardknuckle matriach it does not remain hostile as an invisible mob to players doing damage to players who get in agro range.

(cherry picked from commit a261056f58)
2020-06-14 23:49:03 +02:00
ariel-
412af93a28 Core/Player: update interaction checks, some info taken from client
(cherry picked from commit d03e97d53f)
2020-06-14 23:49:03 +02:00
Aokromes
282e1f152d DB/Commands: Typo in account set gmlevel help field
Closes #19448 by Heaven31415

(cherry picked from commit 3b8f85fd81)
2020-06-14 23:49:03 +02:00
ForesterDev
c34b83a467 Core/Defines: define faction templates and replace magic numbers from scripts
(cherry picked from commit abea8bf4cb)
2020-06-14 23:49:03 +02:00
Killyana
607c5ad554 DB/Creature: Blightguard spawns
(cherry picked from commit d96482b2d4)
2020-06-14 23:49:03 +02:00
Killyana
afad6a7f7d DB: Fix some DB errors
(cherry picked from commit 586cc0e0b4)
2020-06-14 23:49:03 +02:00
Killyana
732ad0f2eb DB/Quest: Blowing Hodir's Horn requirement
Ref #19787

(cherry picked from commit b90fc70c20)
2020-06-14 23:49:03 +02:00
ccrs
205d8bf591 Scripts/ICC: add missing cases for Dark Martyrdom difficulty entries
how come nobody noticed this?

(cherry picked from commit 7afe0b7fb0)
2020-06-14 23:49:03 +02:00
ariel-
e2bc8c5383 Core/Scripts: improvements on the Thorim script
Improvements done to initial work by joschiwald:

- Fixed stormhammer casting and visuals
- Fixed spell credits
- Implemented removal of Impale when HP is higher than 90%
- Corrected faction templates for the pre combat creatures
- Implemeted Leap on the arena adds (thanks to joschiwald for implementing conditions)
- Scripted lighting charge using AuraScript periodic
- Fixed timings
- Corrections on the hallway encounters (added knockback immunity to minibosses too)
- Fixed multiple blizzards issue
- Lever will now reset properly, should players fail to get inside. This allows the door to be opened more than once during the combat
- Corrections in the outro event
- Implemented paralytic field traps on the hallway.
- Implemented Ancient Gate of the Keepers opening.
- Changed blizzard bunny targetting to conditions entirely.
- Removed obsolete scripts
- Standards: delete spell script names by ScriptName instead of spell_id
- Swapped factions for pre-adds (alliance should get horde trash and vs)
- Fixed Leap setting home position for adds
- Removed a bunch of magic numbers
- Runic Colossus should finish current Runic Explosion before beginning to attack
- Fixed UpdateAI logic to put it in line with other scripts (ie don't stop casts)

Special thanks to:
- chaodhib for the blizzard trigger waypoints and investigation on spell radius
- Malcrom for creating the Conditions Creator :P

Closes #15008
Closes #17072

(cherry picked from commit 4a69f5bda5)
2020-06-14 23:49:01 +02:00
joschiwald
d50dccbfce Scripts/Ulduar: Initial implementation of the Thorim Encounter
Closes #7651

Fix logic fail in achievement:
SPELL_LIGHTNING_CHARGE aka 62279 is casted on Thorim itself to buff him, not the damage spell tracked by the achievement.

(cherry picked from commit 5e90c76fd4)
2020-06-14 23:46:44 +02:00
Chaouki Dhib
a7e0bd06b3 Core/Spells: Change the radius of PBAoEs following the feedback received on (#16290)
(cherry picked from commit 2ff76e828f)
2020-06-14 22:51:44 +02:00
Dr-J
7f43529e17 DB/SAI: A Righteous Sermon
Fix bad target for script for move to position which was using target 1 instead of 8 which was causing npc to walk through wall and dissapear on quest accept

(cherry picked from commit e263654c77)
2020-06-14 22:51:40 +02:00
TecDian
4015c02a42 Scripts/Events: Add missing line for "Love is in the air" boss fight (#19521)
(cherry picked from commit 4b8644d6e6)
2020-06-14 22:48:17 +02:00
Rochet2
d4a356a0ba Core/Gossip: Fix gossip bug on modify money (#19551)
(cherry picked from commit 6e3a48c873)
2020-06-14 22:47:27 +02:00
ariel-
19eeca684f Core/Unit: don't clear low health aura states on death
- Confirmed with sniffs, healthless states aren't cleared
- Prevents some procs from happening

Closes #19754

(cherry picked from commit 05b42eef7e)
2020-06-14 22:47:27 +02:00
Kittnz
058e880d55 DB/GameObjects: Add missing gobs for map 450, 560, 329
Mostly chairs and random stuff

(cherry picked from commit d04bc1339a)
2020-06-14 22:47:00 +02:00
Killyana
b5ca81855b DB/Gameobject: Add a missing cosmetic Yellow Teleport
(cherry picked from commit cadea4f183)
2020-06-14 22:46:22 +02:00
Killyana
9a6c2a4da2 DB/Creature: Arcatraz Sentinel
Closes #10647

(cherry picked from commit e036d2232d)
2020-06-14 22:45:29 +02:00
Killyana
a74d233ccc DB/Creature: Fallen Earthen Warrior
Closes #16559

(cherry picked from commit ccf75008de)
2020-06-14 20:15:24 +02:00
xinef1
9e954295c5 Core/Quests: Display quest objective explore completion message
- Game client should show an on-screen message for explored quest objectives
  (AreaExploredOrEventHappens) when the objective has been completed.

Closes #19543

(cherry picked from commit 538f60a880)
2020-06-14 20:14:41 +02:00
Aokromes
6a76d5c851 DB/Misc: Fix PK for gossip_menu_option_locale
(cherry picked from commit c06f0bea9a)
2020-06-14 20:14:34 +02:00
Aokromes
8ded7e576e Typo fix
(cherry picked from commit 9ae53d2577)
2020-06-14 20:13:19 +02:00
ariel-
3698f3a262 Core/Entities: allow guardian pets to inherit spellmods
(cherry picked from commit 97e608b053)
2020-06-14 20:09:45 +02:00
Chazy Chaz
e21e7cd2e2 Scripts/Commands: Update reload commands names
(cherry picked from commit 4843544c21)
2020-06-14 20:09:40 +02:00
Chaouki Dhib
419689b485 Core/Spells: change to the way the spell effect SPELL_EFFECT_JUMP work
(cherry picked from commit d625c0f619)
2020-06-14 20:04:17 +02:00
ccrs
55576d20d8 Core/Creature: drop method SetPosition
eeeevil, use UpdatePosition. It was there just for old scripts compatibility.

(cherry picked from commit 17579f8d91)
2020-06-14 20:04:17 +02:00