Commit Graph

4159 Commits

Author SHA1 Message Date
Keader
1f83412e4d Core/Scripts: XT002 improvements in Hard Mode. Closes #17141. (PR #17900) 2016-09-22 03:18:43 +02:00
Treeston
7860da0de6 Code style follow-up, I blame Notepad++. 2016-09-20 20:28:59 +02:00
treeston
2170541a51 Core/Unit: Standardize SetFacingTo and SetFacingToObject behavior while moving. Both now fail while moving unless arg2 bool is true.
Movement/SplineChain: Bump value range for DB chainId up to uint16 (0 to 65535) from uint8 (0 to 255). Turns out sniffs generate far more chains than I expected.
2016-09-20 20:19:15 +02:00
treeston
3298a5f65d 5952752 follow-up: Member declaration now matches order of usage. 2016-09-20 14:25:48 +02:00
treeston
59527521e6 Instance/Naxxramas: Loatheb no longer instantly murders you. Five spam casts of Doom tend to do that to raids. 2016-09-20 14:13:42 +02:00
tkrokli
a475033c76 Core/Scripts: simplified npc_pet_trainer gossip script
This is what the script changes should have been in PR #17746
(also updates issue #14719 with a correct solution).

- remove OnGossipHello() to use DB conditions
- replace OnGossipSelect() with sGossipSelect()
- focus script on the confirming gossip option
- let the other gossip menus be handled in DB
2016-09-17 05:20:40 +02:00
Treeston
cf628880d5 Map/Instances: Greatly simplify PermBindAllPlayers logic. (#17940) 2016-09-16 13:09:16 +02:00
treeston
5d87e4af8c Instance/UtgardePinnacle: Fix Svala Sorrowgrave timings (from sniff). 2016-09-12 10:49:05 +02:00
SnapperRy
2f493430c9 Script/Quest: fix and use proper serverside summon spell for quest "Red Snapper - Very Tasty!". 2016-09-10 02:30:22 +02:00
SnapperRy
0479f08c3c Script/Quest: replace wrong test spell used for quest "Red Snapper - Very Tasty!" with actual summoning.
The spell does not appear in sniffs, and the summoned NPC's spawn time was far too short to be appropriate (15 seconds).
2016-09-10 01:13:35 +02:00
Rochet2
c52566a888 Core/Scripts: Enhance quest status hook by making it catch more status changes (#17865) 2016-09-09 21:11:36 +02:00
ariel-
47a43b21c8 Core/Scripts: move Icehowl unroot after movement (MotionMaster does not update if unit is Rooted)
Closes #17864
2016-09-04 18:19:43 -03:00
ariel-
bc4b4f656c Core/Scripts: Implement Flag of Ownership. Closes #12265
Core/Spells: Implemented TARGET_CORPSE_SRC_AREA_ENEMY. Closes #12803
2016-09-04 07:09:04 -03:00
ariel-
be9ef83340 Core/Scripts: more 746b838870 follow-up, shouldn't trigger marker aura if proc was prevented 2016-09-04 05:26:57 -03:00
ariel-
7cc91dc45b Core/Scripts: add missing check removed in 746b838870 2016-09-04 04:56:05 -03:00
ariel-
746b838870 Core/Spells / Scripts: Fix Lock and Load. Closes #16731 2016-09-04 04:21:04 -03:00
ariel-
31399d5f34 Core/Scripts: Implement Glyph of Backstab. Closes #7500 2016-09-04 01:31:02 -03:00
ariel-
14445d2202 Core/Misc: calculate rotation fields from orientation in some places it's impossible to get:
- SmartScripts: SMART_ACTION_SUMMON_GO
- Spell Effects:
  * SPELL_EFFECT_DUEL
  * SPELL_EFFECT_SUMMON_OBJECT_WILD
  * SPELL_EFFECT_SUMMON_OBJECT_SLOT1
  * SPELL_EFFECT_SUMMON_OBJECT_SLOT2
  * SPELL_EFFECT_SUMMON_OBJECT_SLOT3
  * SPELL_EFFECT_SUMMON_OBJECT_SLOT4
- Command Scripts: .gobject add

Closes #17891
2016-09-03 17:31:29 -03:00
treeston
ed83a35fbe Drycoding is bad, mmkay? 2016-09-03 17:29:50 +02:00
treeston
ac62d7156f Scripts/Events: Globally fix all ExecuteEvent loops to check UNIT_STATE_CASTING after each iteration, instead of just checking it once initially.
Fixes and closes #17892.
2016-09-03 17:21:22 +02:00
treeston
d55426f5b4 Entities/Gossip: The Big One™ that gets rid of all uses of The Bad™ and The Ugly™, e.g. gossip preprocessor macros, and replaces them with the new-and-shiny gossip functions. 2016-08-31 00:59:04 +02:00
tkrokli
068656af06 Core/Scripts: remove forgotten #define in boss_kalecgos.cpp
This #define was originally supposed to be removed in my PR #17832,
but for some reason it remained undeleted. This commit corrects it.

Also aligned all the enum values to the same column for readability,
based on a common multiple of 4 spaces.
2016-08-30 23:34:28 +02:00
Gustavo
6ee35734e4 Whitespace clean-up 2016-08-29 01:11:04 +02:00
Gustavo
e1761a24ce Core/Spells Make credit for quests "The Grand Melee" and "Among the Champions" a triggered cast (#17870)
Fix a problem where the credit wasn't casted due to CGD
2016-08-28 23:34:23 +02:00
ariel-
27590fbb98 Core/Scripts: Professor Putricide oozes, reapply passive proc auras on reset, and register them as PP summons since they're summoned by a trigger. (f183ed3c50 follow-up) 2016-08-28 02:22:50 -03:00
ariel-
cd9226e755 Core/Scripts: fix math error that would not select points on the entire circle 2016-08-25 08:53:35 -03:00
ariel-
7e4abce820 Update boss_kelthuzad.cpp 2016-08-25 08:21:27 -03:00
Aokromes
92876278fe travis is lazy 2016-08-25 10:39:17 +02:00
Gustavo
40114cacd3 Core/Scripts Boss Skadi the Ruthless rework 2016-08-25 09:13:02 +02:00
tkrokli
8df4706992 Core/Scripts: move npc_experience hardcoded text to DB 2016-08-25 09:07:45 +02:00
tkrokli
8bc00e8952 Core/Scripts: move #define to enum in boss_kalecgos.cpp 2016-08-25 09:03:41 +02:00
tkrokli
537074a809 Core/Scripts: move forge_of_souls gossip to DB 2016-08-25 08:49:09 +02:00
Gustavo
b459c6607f Core/Scripts Implement Pit of Saron Cavern event 2016-08-25 08:40:02 +02:00
Gustavo
989aaaa8b5 Scripts/Pet Implemented Argent Squire/Gruntling and Argent Pony Bridle 2016-08-25 08:31:48 +02:00
treeston
2d7dec0d39 Was Travis completely napping on this one? 2016-08-24 18:25:30 +02:00
treeston
93a68d5881 ...Huh. Wonder how this one didn't make travis complain on the PR. 2016-08-24 18:22:54 +02:00
treeston
47a9cb1e56 Merge remote-tracking branch 'Treeston/3.3.5-kelthuzad' into 3.3.5 (PR #16634) 2016-08-24 18:17:50 +02:00
treeston
5da3ae0489 Scripts/HallsOfLightning: Fix Volkhan healing. 2016-08-24 01:27:17 +02:00
tkrokli
f3dc97f263 Core/Scripts: set correct unit_flags on Scarlet Mine Car (#17844)
Closes #17816
2016-08-23 20:07:16 -03:00
SnapperRy
894378f867 Event/Brewfest: implement relay race (#17603) 2016-08-23 13:36:57 +02:00
tkrokli
8a0990376d Core/Scripts: npc_wormhole #define text moved to DB (#17805)
Another core script hardcoded text removal:
- removed #define text from script
- added the text to gossip_menu_option
- added and renamed enum to match DB entries
- minor additional adjustments and comments

Closes #6841
2016-08-23 13:30:27 +02:00
Gustavo
5661b4686b Improve scripts for quests Breakfast Of Champions and A Bear of an Appetite (#17780)
Properly despawn the related GameObjects after use of the quest item, avoiding multiple use and summon
2016-08-23 13:21:03 +02:00
SnapperRy
433beb77e3 Scripts/ArgentTournament: improve training dummy script
Now the ranged and charge target dummies will cast their spells and behave correctly for the related quests
2016-08-23 13:14:38 +02:00
jackpoz
b7306f06f5 Core/Misc: Fix static analysis issues 2016-08-22 14:17:24 +02:00
treeston
2a1232ca1a Scripts/Naxxramas: Full Kel'thuzad rework.
- Sniffed timers
- Sniffed spawn behavior
- Sniffed everything else
- Sniffed sniff. Mmmm
 - In all seriousness though:
    - Fixed P2 cast behavior, now obeys category cooldowns as intended
    - Fixed P1 pathing and abomination behavior
    - Fixed P1 passive minion aggro logic
    - Fixed P1->P2 transition logic
    - Fixed P3 guardian spawn/despawn logic
    - Fixed all minions' cast behavior
    - Fixed melee hitbox for Kel'thuzad, abominations, banshees and guardians
    - Fixed reset behavior
    - Fixed post-Sapphiron event to no longer open the KT door for a few seconds before slamming it closed again
2016-08-21 11:27:18 +02:00
Treeston
6f85422f0b Core/Spells: Fix orientation- and targeting-related issues if the creature isn't currently engaged in combat. (#17120)
Also disable spell focus system for vehicle control auras.

Closes #16572
Closes #17016
2016-08-21 11:07:38 +02:00
Alan Deutscher
061b62a97d Scripts: UNIT_FLAG_REMOVE_CLIENT_CONTROL no longer used as a method for preventing a unit from moving
UNIT_FLAG_REMOVE_CLIENT_CONTROL (formerly UNIT_FLAG_DISABLE_MOVE) is a client-only feature that should not be used for NPC scripting. All applications of this flag in scripts/ have been replaced with applications/removals of the UNIT_STATE_ROOT state.

Closes #17311
2016-08-21 11:04:59 +02:00
jackpoz
eb9bf314c4 Core/Commands: Code cleanup
Remove commented out code
2016-08-20 20:53:08 +02:00
treeston
8c690f9edc Pet/DK: Make Risen Ghoul and Bloodworms no longer suicidally charge into not-yet-engaged mob packs. 2016-08-17 11:38:31 +02:00
tkrokli
730680430d [3.3.5] Core/Scripts: move npc_loramus_thalipedes to DB
Another chapter in core script hardcoded text removal:
- remove core script `npc_loramus_thalipedes` from zone_azshara.cpp
- add gossip, SAI script and conditions to database
- remove redundant SD2 comments from file header
2016-08-17 05:12:04 +02:00