Commit Graph

13932 Commits

Author SHA1 Message Date
Wyrserth
22b222b44e Script/CoS: fix DB error and remove wrong on-death text for Chrono-Lord Epoch. 2019-06-26 12:06:45 +02:00
Aokromes
fe744977c9 Coding standards (#23514)
* Coding standards

* revert part
2019-06-26 08:56:20 +02:00
Treeston
63383da36e fix comment, 3cdf274 follow-up 2019-06-26 01:06:01 +02:00
Treeston
3cdf27494f Core/AI: Actually accurately reproduce the logic from before 849943 that determines what summons start following on appearance. Third time's the charm?
Closes #23513.
2019-06-26 01:04:27 +02:00
ccrs
ca62280675 Script/CoS: full instance rewrite (#23388) 2019-06-25 20:56:43 +02:00
Wyrserth
c95531595e Core/SAI: silence wrong SAI error when using SMART_ACTION_SET_DATA on a creature using CreatureAI.
This behavior is fully allowed and should not report any kind of error.
2019-06-25 18:06:20 +02:00
Shauren
c0b25c9a83 Core/Creatures: Fixed crash in CreatureAI::JustAppeared caused by scripted summons without SummonProperties
Closes #23507
2019-06-24 18:47:04 +02:00
ccrs
337de2b61e Core/Player: 72fc79a followup
safer approach, please report any returning issue
2019-06-24 14:32:59 +02:00
Aokromes
9817bb55a3 Core/Groups: Delete duplicate semicolon
thx elon.
2019-06-24 13:54:56 +02:00
ccrs
4a8736b829 Scripts/Misc: couple corrections to the recent PRs 2019-06-24 13:32:43 +02:00
ccrs
3c77c04b05 Core/AI: remove extra empty line 2019-06-24 12:52:35 +02:00
ccrs
ebd438883e Core/AI: minimize further undesired behaviours (e3e4b97 followup)
Those Category checks come from checking all Spell::SummonGuardian uses
2019-06-24 12:49:15 +02:00
Treeston
e3e4b975ce AI/TotemAI: Tell Shaman Totems to stay put and stop moving. Closes #23498. 2019-06-24 02:30:07 +02:00
Treeston
854a113fc7 AI/SmartAI: Properly forward to inherited CreatureAI::JustAppeared in SmartAI::JustAppeared. Fixes #23491. 2019-06-23 23:32:21 +02:00
Treeston
1158f267df Combat/Threat: Split ThreatManager::NotifyDisengaged off from ThreatManager::ClearAllThreat. NotifyDisengaged signifies intent to clear the engagement flag, and should only be called from AI. Fixes #23490. 2019-06-23 23:31:51 +02:00
jackpoz
00575221e3 Core/Misc: Code cleanup
(cherry picked from commit eeced9ae15)
2019-06-23 22:27:28 +02:00
Treeston
37fc38b917 AI/SmartAI: Move SMART_EVENT_RESPAWN invocation from ::InitializeAI() to ::JustAppeared(). Closes #23313. 2019-06-23 17:37:35 +02:00
Treeston
8499434340 Core/AI: Remove EnterEvadeMode calls from Guardian/Summon spell handlers. Add follow logic to CreatureAI::JustAppeared. Closes #23270. 2019-06-23 17:18:42 +02:00
Treeston
aeed616c22 Entities/Unit: Adjust an overzealous assert to not catch self references, and add the inverse assert too. 396f87c follow-up. 2019-06-23 16:56:15 +02:00
Treeston
f4b06fd0b7 Entities/Unit: Fix an issue where Unit pointers could be left dangling if a channeled Charm was interrupted by a control aura application. Closes #23440. 2019-06-23 16:45:32 +02:00
Treeston
396f87c30d Entities/Unit: Cleanup all the direct accesses to m_unitMovedByMe. Refactor the field to be protected. Add assertions to catch dangling pointers. 2019-06-23 16:44:37 +02:00
Treeston
b3ee407707 Core/Misc: Add static versions of GetGUID and ToX methods to Object. The static versions return Empty/nullptr for null objects. 2019-06-23 16:01:51 +02:00
Treeston
00728cef15 some more cleanup, a5f8c0d follow-up 2019-06-23 13:28:45 +02:00
Treeston
a5f8c0d30c Core/Creature: Attach out-of-combat health regen to the Engaged system, not the Combat flag. Closes #21571. 2019-06-23 13:27:29 +02:00
Treeston
632a300dd2 Core/Misc: Rename Unit::AttackedTarget to Unit::AtTargetAttacked to match naming scheme for these notifiers 2019-06-23 00:32:59 +02:00
Treeston
dbe3bbefe7 Core/Entities: Kick engagement logic upstairs to Unit (from ThreatManager), since all Units with AI need it (not just those with threat list). Fixes #17981. 2019-06-23 00:32:13 +02:00
Treeston
c06330acf2 Revert "Core/AI: Fix Guardians not following the owner after finishing combat (#23466)"
This reverts commit c234604e82.
2019-06-22 22:21:09 +02:00
jackpoz
eeced9ae15 Core/Misc: Code cleanup 2019-06-22 21:07:41 +02:00
Giacomo Pozzoni
c234604e82 Core/AI: Fix Guardians not following the owner after finishing combat (#23466)
CreatureAI::UpdateVictim() was not triggering EnterEvadeMode() after the Creature ended combat because IsEngaged() would return false.
These changes save the value of IsEngaged() to be used next tick to check if the Creature was in combat, is not anymore now and needs to evade (or select another enemy).
EnterEvadeMode() sets the stored previous value to false to ensure the Creature will not try to evade while already evading.
2019-06-22 20:03:49 +02:00
zartech22
678e0e606a Core/Instance : Fix instance resetting exploit (#23263)
* Push offline players out of instance

Push offline players out of instance when reseting dungeon with a raid mode group

* Add SQL request to character

Add a SQL request to update the position of a player in a specified map

* Teleport to graveyard instead
2019-06-22 19:23:42 +02:00
Sorikoff
ac7c72d633 Scripts/Spells: Portal to Orgrimmar & Portal to Stormwind (#23463)
* Scripts/Spells: Portal to Orgrimmar & Portal to Stormwind

* Revert "Scripts/Spells: Portal to Orgrimmar & Portal to Stormwind"

This reverts commit a8055960

* Revert "Revert "Scripts/Spells: Portal to Orgrimmar & Portal to Stormwind""

This reverts commit a5be792b

* Fix NoPCH

* Clean up

* Clean up

* fixup! Clean up

* Caster -> Target

* Rename 9999_99_99_99_world.sql to 2019_06_22_01_world.sql
2019-06-22 16:36:53 +02:00
Sorikoff
40b09e3df1 Scripts/Spells: Ultra-Advanced Proto-Typical Shortening Blaster (#23456)
* Scripts/Spells: Ultra-Advanced Proto-Typical Shortening Blaster

* Fix NoPCH

* Correct header

* fixup! Clean up

* Rename 9999_99_99_99_world.sql to 2019_06_22_00_world.sql
2019-06-22 09:44:23 +02:00
Wyrserth
8163ea60c8 Core/RBAC: add permission that prevents accounts from earning all achievements or only realm firsts (#23459)
* Core/RBAC: add permission that prevents accounts from earning all achievements or only realm firsts.

* Kill evil spaces.

* Rename 9999_99_99_99_auth.sql to 2019_06_21_00_auth.sql

* Update auth_database.sql
2019-06-21 20:17:37 +02:00
Sorikoff
e9d803ccee Scripts/Spells: Migrate Teleporting to Script (#23458)
* Scripts/Spells: Migrate Teleporting to Script

* Rename 9999_99_99_99_world.sql to 2019_06_21_02_world.sql
2019-06-21 19:25:51 +02:00
Sorikoff
a4cd4d8b87 Scripts/Spells: Migrate Lightwell to Script (#23455)
* Scripts/Spells: Migrate Lightwell to Script

* Add newline to SQL file

* Misc

* Rename 9999_99_99_99_world.sql to 2019_06_21_01_world.sql
2019-06-21 19:21:49 +02:00
Keader
f9a366628a Build fix 2019-06-20 21:20:58 -03:00
Keader
3b0743ea67 Scripts/Icecrown Citadel: Fixed some bugs on Blood Orb object and trash mobs around him
Followup: 394b119664
2019-06-20 21:11:56 -03:00
Killyana
8d6295559d DB/Quest: "Where Kings Walk" and "Warchief's Blessing"
The script was deleted by 5f928f7949 But it wasn't done properly via the spell_area anyway
2019-06-20 20:57:57 +02:00
Killyana
a3dec9068b DB/Quest: A Visit With The Ancestors
Closes #23284
2019-06-20 11:51:18 +02:00
Wyrserth
9083fc149d Spell/Fishing: ensure that the fishing bobber expires when the Fishing channeling ends, and don't allow fish to be hooked in the instant the spell is cast. (#23448) 2019-06-20 08:16:25 +02:00
Wyrserth
4320cd7d37 Core/Loot: don't allow to regenerate chest loot inside instances and raids. (#23449) 2019-06-20 08:13:38 +02:00
Wyrserth
72b1f2e7a4 Core/Conditions: fix mistake in CONDITION_QUEST_OBJECTIVE_PROGRESS that would behave wrongly if the player did not have the quest in the quest log. (#23447) 2019-06-20 08:11:29 +02:00
Giacomo Pozzoni
0f8a926485 Core/Misc: Fix a warning 2019-06-19 15:57:26 +02:00
Wyrserth
a88d5f54d6 Core/Conditions: implement CONDITION_QUEST_OBJECTIVE_PROGRESS to allow to apply conditions based on the player's quest objective progress (#23438)
* Core/Conditions: implement CONDITION_QUEST_OBJECTIVE_PROGRESS to allow to apply conditions based on the player's quest objective progress.

* Update ConditionMgr.cpp
2019-06-19 15:19:17 +02:00
Wyrserth
6a0a800535 Core/FlightPath: teleport players at destination on floor Z when the flight ends (#23428)
* Core/FlightPath: teleport players at destination on floor Z when the flight ends, instead of having them fall from the air.

Closes #10051.

* Use the path destination's mapheight instead of the player position's.

* Update FlightPathMovementGenerator.cpp
2019-06-19 15:17:21 +02:00
Wyrserth
d6e3660115 Core/SAI: allow to start waypoint movement for a creature that is in combat. (#23426) 2019-06-18 20:04:34 +02:00
DanVS
0197a2f990 Core/Spell: Jump Speed Calculations (#22886)
* Jump Speed Calculations

* Fix
2019-06-18 12:57:23 +02:00
Wyrserth
015870bfe1 Core/Misc: don't allow FindNearestCreature() and FindNearestGameObject() searches to return the entity that called them. (#23437)
Closes #23334.
2019-06-18 10:34:08 +02:00
Wyrserth
cb8b1069c4 Core/Packet: send SMSG_QUESTGIVER_STATUS_MULTIPLE when the player levels up. (#23434)
Ensures that nearby questgivers are properly updated and will offer quests unlocked at the new level reached.
2019-06-18 08:58:06 +02:00
Keader
70cbedd75d Core/Scripts: Fixed a reference error introduced in 394b119664 2019-06-17 13:06:24 -03:00