Mirror/TrinityCore
1
0
Fork 0
mirror of https://github.com/TrinityCore/TrinityCore.git synced 2026-01-22 10:05:32 +01:00
Code Issues Packages Projects Releases Wiki Activity
20,796 Commits 4 Branches 146 Tags
29610b250dd5017f068264d9b1a37748c9f30feb
Commit Graph

3064 Commits

Author SHA1 Message Date
joschiwald
29610b250d Core/Spells: fixed Throw Shield Visual and Clone Weapon 2014-04-05 00:37:07 +02:00
jackpoz
0930482fa4 Core/Misc: Fix uninitialized values 
Fix Position members not being always initialized.
Valgrind log:
 at : Position::NormalizeOrientation(float) (Object.h:388)
 by : Position::SetOrientation(float) (Object.h:315)
 by : Position::Relocate(Position const&) (Object.h:310)
 by : spell_ulduar_stone_grip::spell_ulduar_stone_grip_AuraScript::OnRemoveVehicle(AuraEffect const*, AuraEffectHandleModes) (boss_kologarn.cpp:592)
 2014-04-02 20:42:46 +02:00
jackpoz
10ba63cf3d Core/Misc: Fix typo in f47962f670 2014-03-31 21:10:29 +02:00
jackpoz
f47962f670 Core/Misc: Fix some static analysis issues 
Add some asserts and additional NULL checks as sanity checks.
 2014-03-31 20:59:33 +02:00
Vincent-Michael
0b615ec159 Scripts/Misc: Small code optimizations 2014-03-29 20:58:49 +01:00
jackpoz
8c44259fae Core/Misc: Fix some static analysis issues 
Fix uninitialized values, most of which are false positives, always initialized before being accessed.
Add some asserts and additional NULL checks as sanity checks. Use SpellMgr::EnsureSpellInfo() if the spell id is valid and always supposed to return a valid not-NULL SpellInfo* .
 2014-03-27 21:43:59 +01:00
Gacko
46b8bc8882 Fix non-pch build and remove blank line 2014-03-26 18:51:09 +01:00
Gacko
808a1998c6 Quest: The Power of the Elements 
Remove hack SAI, use aura script
 2014-03-26 18:36:39 +01:00
Shauren
84365f43b4 Scripts/Icecrown Citadel: Fixed Muradin/Saurfang attacking each other during Gunship Battle 
Closes #11786
 2014-03-25 22:20:45 +01:00
Shauren
cd20be2cc9 Scripts/Icecrown Citadel 
* Deathbringer Saurfang will now evade if any player stands on the gunship
* Fixed players being stuck in combat after defeating gunship
* Fixed players not sticking to gunships
 2014-03-24 00:58:37 +01:00
Shauren
e469ff5e88 Fixed build without PCH 2014-03-23 12:54:09 +01:00
Shauren
a4d8a26dc7 Scripts/Icecrown Citadel: Icecrown Gunship Battle 2014-03-23 02:01:13 +01:00
MitchesD
d9d088421d Scripts/ZulAman/Halazzi: convert text to create_text and fixed despawn of cat 2014-03-22 22:30:20 +01:00
Shauren
529cabea68 Core/Map: Save weather, light and music overrides in map to send them to players logging in 2014-03-22 19:40:36 +01:00
jackpoz
6dcd8c8545 Core/Misc: Fix some static analysis issues 
Fix some static analysis issues about:
- uninitialized values, most of which are false positives, always initialized before being accessed
- unchecked return values
- dead code never executed
- bad formatting leading to wrong behavior

Please ensure EventMap is never used with event id set to 0 or those events will never execute.
 2014-03-22 14:54:32 +01:00
MitchesD
e40d4e6f16 Scripts/Spells: fix logic fail in q9874 2014-03-22 10:04:43 +01:00
jackpoz
9e99db035f Core/Misc: Fix some static analysis issues 
Add some asserts and additional NULL checks as sanity checks.
 2014-03-21 22:47:58 +01:00
Aokromes
33316bde38 Merge pull request #11747 from untaught/Trinity1 
Core/Scripts: Move 'The Defias Traitor' script to SAI
 2014-03-21 00:55:49 +01:00
Aokromes
bcf6edd50b Merge pull request #11749 from untaught/Trinity2 
Core/Scripts: Move condition for 'npc_marin_noggenfogger' gossip menu op...
 2014-03-21 00:55:30 +01:00
Aokromes
9ad8c32e3d Merge pull request #11757 from untaught/Trinity3 
Core/Scripts: Move 'npc_deathly_usher' scripts to SAI.
 2014-03-21 00:53:55 +01:00
Aokromes
a9121c6038 Merge pull request #11746 from untaught/Trinity0 
Core/Scripts: Move condition for 'npc_skorn_whitecloud' gossip menu opti...
 2014-03-21 00:53:12 +01:00
jackpoz
4c27c83efa Core/Misc: Fix some static analysis issues 2014-03-20 21:34:05 +01:00
untaught
8a9bfbba48 Core/Scripts: Move 'npc_deathly_usher' scripts to SAI. 2014-03-20 20:29:06 +02:00
untaught
f59eabdf8f Core/Scripts: Move condition for 'npc_marin_noggenfogger' gossip menu option to DB and remove 'npc_marin_noggenfogger' script 2014-03-19 18:43:39 +02:00
untaught
38c33f687c Core/Scripts: Move condition for 'npc_skorn_whitecloud' gossip menu option to DB and remove 'npc_skorn_whitecloud' script 2014-03-19 12:12:59 +02:00
Gacko
4bcbcf53d8 Core/Script: Logical fixes 2014-03-19 10:05:02 +01:00
untaught
c31ffd774e Core/Scripts: Move 'The Defias Traitor' script to SAI 2014-03-18 08:31:23 +02:00
Aokromes
f8938c2092 Merge pull request #11718 from untaught/master 
Instance Script/Stratholme: Correct logic in Baron Run event and add SAI...
 2014-03-16 21:40:35 +01:00
jackpoz
f26a028d97 Core/Misc: Fix some static analysis issues 
Fix some static analysis issues about uninitialized values. Most of them are false positives, always initialized before being accessed.
 2014-03-16 14:18:33 +01:00
untaught
5f7e0f6929 Instance Script/Stratholme: Correct logic in Baron Run event and add SAI for Ysida Harmon 2014-03-16 08:47:27 +02:00
jackpoz
a1aa4547b3 Scripts/Krikthir the Gatewatcher: Fix EVENT_ANUBAR_CHARGE event not being triggered 
Fix EVENT_ANUBAR_CHARGE not being triggered due to value 0 being set to the EVENT_ANUBAR_CHARGE enum, even if 0 is a special value for EventMap to specify no event was triggered.
Issue added in a127c0e1a7
 2014-03-15 20:08:55 +01:00
jackpoz
e30b471f8e Scripts/AhnKahet: Fix some uninitialized values 
Initialize all class fields in the constructor, even if they are set in Reset() and they shouldn't be accessed before Reset() is called.
This fixes 2 Coverity reports.
 2014-03-15 20:04:59 +01:00
jackpoz
3b247f6bca Scripts/ZulGurub/Jeklik: Add missing "break" 2014-03-15 19:45:44 +01:00
jackpoz
ba28b16d2e Scripts/TheStormPeaks: Possible crash fix 
Apply safe NULL checks added in 7d881a0739 to similar code in same script
 2014-03-09 17:17:12 +01:00
jackpoz
d357597270 Scripts/Commands: Fix crash in ".kick" command 
Fix a NULL dereference exception happening when using .kick command caused by a strtok(NULL) call without a previous call to the string to be tokenized.
Issue added in 101cad1f28
 2014-03-09 17:09:15 +01:00
joschiwald
3a40d8a887 Core/Player: delete queststatus (weekly/monthly/seasonal) on deleting character thx @Expecto 
- also rename some prepared statements

Closes #11658
 2014-03-02 00:00:39 +01:00
jackpoz
61890bce7c Scripts/Onyxia Lair: Fix debug assertions about iterators 2014-02-26 21:44:51 +01:00
w1sht0l1v3
50d99005a5 Scripts/Ulduar: Fix Algalon the Observer outro phase(fixes kill credit and some achieves). 2014-02-16 02:27:44 +02:00
joschiwald
b72273014f Core/DB/Achievements: 
- fixed arena season title achievements and rewards
- added mailtemplate support for `achievement_reward` table
- fixed typo in GetBattleMasterBG which causes achievement reward mail expire in 1 day

Ref #8777
 2014-02-10 00:14:29 +01:00
Vincent_Michael
a5a6799b4e Scripts: Added missing stuff in 1d1aeda86c 2014-02-09 19:15:17 +01:00
Vincent_Michael
1d1aeda86c Core: Fix build 2014-02-09 19:01:56 +01:00
joschiwald
6688370513 Merge pull request #11457 from MitchesD/krikthir 
Scripts/Krikthir the Gatewatcher: converted to EventMap and small optimalization
 2014-02-09 18:46:26 +01:00
MitchesD
a127c0e1a7 Scripts/Krikthir the Gatewatcher: converted to EventMap and small optimization 2014-02-09 18:41:37 +01:00
jackpoz
aaa4b3a124 Scripts/Eastern Plaguelands: Fix flypath exploit 
Fix npc id 17209 in Eastern Plaguelands enabling taxi cheat to players just by talking to it.
 2014-02-08 17:22:29 +01:00
joschiwald
b000fdca70 Core/Entities: allow interaction with gameobject questgivers if player can take or return quests 
Closes #11269
Closes #8898
Closes #10204
Closes #11410
Closes #7053
Closes #6189
Closes #9474
 2014-02-06 21:23:18 +01:00
w1sht0l1v3
2df3fe3a00 Core/Scripts: Fix quest The Totem of Kar'dash alliance version. 
Remove some hungarian notation for horde side version.

Closes #11035
 2014-02-01 19:07:48 +02:00
Discover-
a242662ae6 Core/Spells: Fix DK Ghoul's damage after ad8eb434c0. I misread 'SpellScript::m_damage' for 'SpellScript::damage'. 
By @joschiwald
 2014-01-31 10:37:55 +01:00
jackpoz
856e0933b5 Scripts/HoR: Fix log error 
Fix "DoZoneInCombat called for creature that has empty threat list" error caused by DoZoneInCombat() called by IsSummonedBy() in a script before the Creature is allowed to enter combat.
 2014-01-30 21:29:37 +01:00
Discover-
ad8eb434c0 Core/Misc: Missing changes and get rid of useless method in acd46085d1 2014-01-30 10:28:05 +01:00
joschiwald
acd46085d1 Core/Spells: drop last leftovers of hardcoded spell target selection and move it into spellscripts 
Closes #1719
Closes #3186
 2014-01-30 02:40:12 +01:00