tkrokli
2acaa6fb4a
Core/Misc: corrections and indentations in Language.h
...
- corrected the comment "1205-2002 - free" to "1205-1999 - free"
- increased the main indent by 2 spaces to get more lines aligned
- corrected the enum LANG_DO_NOT_USE_6X_DEBUG_AREATRIGGER_LEFT from 1999 to 1199
Ref. commit 5f54149107ba5f6a8616
2021-06-16 16:25:40 +02:00
Treeston
14bda72751
Core/Unit: Remove a superfluous threat state update in SetPhaseMask.
...
(cherry picked from commit 2c86c78f04
2021-06-16 14:37:58 +02:00
Kittnz
cd3425f6a6
Scripts/Outland: Fix logical error in Hellfire event in Honor Hold
...
(cherry picked from commit 8f64612cb1
2021-06-16 14:32:07 +02:00
Treeston
73bf0e3a0b
Core/Threat: Assistance threat (healing, buffs, etc.) is now properly split (instead of copied) between all creatures threatened by the action. Thanks to Foereaper for help with testing, and my apologies to healers everywhere.
...
(No apologies for charm AI though. You deserve that one.)
(cherry picked from commit 013d4560c7
2021-06-16 14:29:45 +02:00
Treeston
9f91cf23ab
Core/Threat: Passive creatures now properly become engaged when adding an offline threat entry. Fixes RoS and Thaddius, maybe more. Closes #21269 .
...
(cherry picked from commit a373275612
2021-06-16 14:26:10 +02:00
ariel-
85ffcd9826
Core/Scripts: fix wrong uses of SetHitDamage hook.
...
This hook modifies damage AFTER it has been reduced by target auras/armor/resistances etc, it's useful if you want to scale damage by a factor, but not to add flat bonuses.
We're fixing those by moving calculation to Launch phase, where target taken bonuses haven't been used yet.
- Bronjahm: Magic's Bane
- BPC: Shadow Prison
- Oculus: Shock Lance
- Ymiron: Dark Slash (extra fix, it was wrongly damaging half of total health, it's supposed to be half of CURRENT health!)
- DK: Raise Ally Thrash spell (also extra fix: corrected formula)
- Warrior: Bloodthirst (shouldn't matter much as it's damage class none and those don't get bonuses by default)
- Warrior: Concussion Blow
- Warlock: extra fix for Haunt, healing part shouldn't scale with spell power
Closes #9560
(cherry picked from commit 9f5d1e2b10
2021-06-16 14:26:09 +02:00
tje3d
d4359bb560
DB/Quest: A Rough Ride & The Black Knight's Orders
...
Closes #21248
Closes #21249
(cherry picked from commit 946856258c
2021-06-16 12:56:20 +02:00
Keader
18b0135bf7
Scripts/Utgarde Keep: Fixed Ingvar evade in phase 2 (again)
...
Closes #21264
(cherry picked from commit 96983fc6bb
2021-06-16 12:45:57 +02:00
ariel-
2ef2fee3e7
Core/Auras: fixed EquippedItemClass check
...
follow-up to 29c3b7d8f6f1896144c0
2021-06-16 12:45:18 +02:00
ariel-
d0a766f14f
Core/Auras: Don't remove shield only dependant auras on disarm
...
Closes #19782
(cherry picked from commit b8c281f497
2021-06-16 12:34:40 +02:00
ariel-
b27e741096
Core/Auras: define and implement attribute SPELL_ATTR3_NO_PROC_EQUIP_REQUIREMENT
...
Closes #20148
(cherry picked from commit 29c3b7d8f6
2021-06-16 12:20:14 +02:00
ariel-
62c571076e
Core/Scripts: added nullptr checks to DamageTaken hooks
...
Since cb9e72e5210db5c2df3f
2021-06-16 12:02:14 +02:00
Treeston
ea79b55698
Scripts/AzjolNerub: Missing nullptr check in Hadronox. Closes #21258 .
...
(cherry picked from commit d9d26200f7
2021-06-16 11:49:03 +02:00
Treeston
015a46ea5d
DB/Quest: Allow starting Amphitheater of Anguish (12932) without having completed The Champion's Call (12974)
...
(cherry picked from commit 666bc16325
2021-06-16 11:48:34 +02:00
Treeston
6fb45e31c2
DB/SpawnGroup: instance_spawn_group data for map 576 (The Nexus)
...
(cherry picked from commit 0319c713a4
2021-06-16 11:46:50 +02:00
Moein
6d7288356a
Scripts/Spells: quest "That's Abominable" ( #21253 )
...
- scripted spell "Burst At The Seams" (59576)
- added Pet Bar
Closes #10876
(cherry picked from commit e519e14df8
2021-06-16 11:32:25 +02:00
sirikfoll
3ff61beafa
Core/CombatAI: Npcs with TurretAI will be able to attack again
...
Needed after the new Threat system
(cherry picked from commit e12e0ad582
2021-06-16 11:26:22 +02:00
sirikfoll
78577afa49
Core/Player: Pass correct Zone ID to HandlePlayerLeaveZone
...
This will fix some issues with Wintergrasp, like phasing auras getting stuck and missing group invites for the battle, among others
(cherry picked from commit ed9e220991
2021-06-16 11:23:01 +02:00
ariel-
bb7869b31f
Core/Scripts: fix some spells double dipping from done/taken bonuses
...
Closes #21007
(cherry picked from commit ab3307fc23
2021-06-16 11:22:10 +02:00
ariel-
3bc3b3eeeb
Core/Globals: revert back to unordered_map for templates
...
Partial revert of commit b64c504314b64c504314b75ff7d4bf
2021-06-16 01:29:25 +02:00
ariel-
21556667c1
Core/Globals: throw some RAII into ObjectMgr, and load templates into vectors
...
Ref #14274
(cherry picked from commit b64c504314
2021-06-16 01:00:11 +02:00
sirikfoll
5b5bc4c5c7
Scripts/Scarlet Enclave: Quest The Endless Hunger will work correctly after Unworthy Initiate Respawn
...
Due to dynamic spawns, we need to be able to update the Npc GUID after the respawn, otherwise the quest can only be completed by the first player
(cherry picked from commit 72ff2e30c3
2021-06-15 23:43:17 +02:00
ariel-
d0fa8c72a3
Core/Unit: check remaining instead of full duration for Bounced by DR auras
...
(cherry picked from commit ccf0807be0
2021-06-15 23:42:10 +02:00
Keader
ca07b1a25d
Scripts/Pit of Saron: Tyrannus followup
...
fix new issue caused by 947cb6a4530b09e9ee4e
2021-06-15 23:41:11 +02:00
Keader
ed8d57e72d
Scripts/Pit of Saron: Fixed Tyrannus not working after evade
...
(cherry picked from commit 947cb6a453
2021-06-15 23:40:47 +02:00
Moein
172df39350
Core/SAI: Extended SMART_TARGET_VEHICLE_PASSENGER to allow specifying seat mask instead of single seat index (can now target all passengers) ( #21245 )
...
(cherry picked from commit 891bca934e
2021-06-15 23:37:25 +02:00
Keader
6ba82b56dc
Scripts/Trial Of The Crusader: Lord Jaraxxus rework ( #21216 )
...
(cherry picked from commit a41cd41695
2021-06-15 23:32:57 +02:00
Treeston
56fcd8ba1d
Core/Threat: Fix a potential crash that would occur in specific edge cases of AI being a bit naughty.
...
(cherry picked from commit 1847555c8c
2021-06-15 23:22:50 +02:00
ariel-
08ac27d959
Core/Auras: fix static analysis issues
...
CID 1384433
CID 1384436
(cherry picked from commit 5153f464d8
2021-06-15 23:22:01 +02:00
ariel-
bf4330bfb5
Core/Unit: fix mess-up with CalcArmorReducedDamage parameter order
...
(cherry picked from commit 01537e1dfb
2021-06-15 23:08:27 +02:00
ariel-
431a326e69
Core/Entities: Port some refactors from f1986c6aaf
2021-06-15 00:48:02 +02:00
ariel-
6ab410b926
Core/Unit: allow miss chance to exceed 60% cap with certain auras
...
(cherry picked from commit 688e96fb4f
2021-06-14 18:52:48 +02:00
ariel-
770367a514
Core/Unit: fix Sanctified Wrath (again)
...
- Actually only rank 1 was affected because of 50% reduction on rank 2
(cherry picked from commit 0e9b1635e0
2021-06-14 18:50:10 +02:00
ariel-
84a29d8077
Core/Unit: fixed crash
...
Closes #21231
(cherry picked from commit 22b24d8dae
2021-06-14 01:19:38 +02:00
ariel-
bec829df0a
Core/Unit: simplified and arranged spell bonus calculation
...
- Remove duplicated SPELLMOD_BONUS_MULTIPLIER handling (both on done and taken)
- Handle properly bonus data, don't apply bonus by default, only player spells should take into account spell power
- Moved Earthliving Weapon coefficient to DB
- Refactored Avenging Wrath handling
Closes #13287
Closes #21230
(cherry picked from commit d570e2af3e
2021-06-14 01:17:43 +02:00
ariel-
5fbddef85f
Core/Spell: SpellValueOverrides encapsulation
...
- No sense to let scripts use SpellValueOverrides, we already have modifiers in CastSpellExtraArgs struct
(cherry picked from commit 3b01cccd7e
2021-06-14 00:19:50 +02:00
Kittnz
267aeddc05
Scripts/EasternKingdoms: implement Children of Goldshire event ( #20745 )
...
* Script: Implement Childeren of Goldshire
Notes: Need to update waypoints and default location of the childeren
http://wowwiki.wikia.com/wiki/Children_of_Goldshire
(cherry picked from commit a9c853ee3f
2021-06-13 22:30:10 +02:00
Shauren
cc94c3eb50
Core/Sockets: Initialize _sessionKey variable in constructor
2021-06-13 01:00:22 +02:00
Shauren
bda948fc5c
Core/Auras: Implemented EstimatedPoints for SMSG_AURA_UPDATE
2021-06-13 00:59:15 +02:00
Shauren
31ef525ecd
Core/Misc: Add container utility function Trinity::Containers::EnsureWritableVectorIndex to replace if (i >= vec.size()) vec.resize(i + 1) copypaste everywhere
2021-06-13 00:59:15 +02:00
ariel-
fccf1a8c62
Core/Auras: removed caster dependency from core
...
- Decoupled Unit logic: split of spell critical chance into done (caster bonuses) and taken (target bonuses), this allows to precalculate caster bonuses on aura apply and then check victim's auras on damage/healing calc
- Made static a bunch of methods (they no longer have this pointer because they are now called from periodic handlers which may or may not have an active caster in world)
- Simplified all AuraEffect bonuses into AuraEffect::_amount, no more duplicated code
- Critical chance and whether or not caster is player owned unit (for resilience calcs) is now saved one level upper, on Aura itself (it's impossible as of 3.3.5 to have different effects with different critical chances)
- Minor cleanup of SPELL_DAMAGE_CLASS_NONE and Arcane Potency (#18813 ) crit handling
Closes #19876
(cherry picked from commit cb9e72e521
2021-06-13 00:59:13 +02:00
Shauren
fa4e2d3935
Core/Quests: Fixed quests that should have objectives immediately marked as complete
...
Closes #26566
2021-06-08 00:02:58 +02:00
Shauren
d0be92ec0a
Core/Achievements: Defined all modifier tree types and implemented many of them
2021-06-07 15:37:34 +02:00
Matan Shukry
626c8f5de1
Core/Player: Add helper function to determine if war mode can be enabled in area
2021-06-06 21:06:21 +02:00
Shauren
5134622a75
Core/DataStores: Load QuestLineXQuest.db2
2021-06-06 20:57:09 +02:00
Shauren
2f8e411ac7
Core/Reputation: Corrected sorting of friendship rep reactions
2021-06-06 19:22:47 +02:00
Shauren
8d5356cdea
Core/DataStores: Load PvpTier.db2
2021-06-06 19:06:08 +02:00
Shauren
b607bb0a93
Core/DataStores: Load ItemModifiedAppearanceExtra.db2
2021-06-06 17:56:11 +02:00
Shauren
c2751f9195
Core/Players: Add PlayerExtraFlags for tracking race change, level boost, and raf level grant usage
2021-06-06 14:19:28 +02:00
Shauren
b01fba4bd9
Core/Reputation: Implemented paragon reputation
2021-06-06 00:11:06 +02:00
