Commit Graph

674 Commits

Author SHA1 Message Date
ariel-
2ff855054f Core/Scripts: Convert spells to new proc system
- Converted Unit::HandleDummyAuraProc function to AuraScripts
  * Extra: DMC: Madness now uses DB texts. yay!
  * Extra: improvements on Imp. Spell Reflection (range and max targets, filter caster with conditions)

- Fixed Glyph of Succubus. (Closes #6599)

- Changed old (not-blizz) behavior of Vampiric Embrace:
  * Before: party heal affected the priest too and self heal was reduced by that amount to not over-heal
  * Now: self heal amount not affected, rather filter the priest out of the party heal using conditions :)

- Solve bug in AQ 3p set bonus, it should only trigger when healing others, not self heals.
- Priest T10 2p bonus (heal) now rolls its effect properly

- Use brand new GetEffectiveHeal to fix #17142
- While we're at it, also close #17034 for good
- Converted Unit::HandleAuraProc function to AuraScripts (#17941)
- Converted Unit::HandleAuraProc function to AuraScripts (cont'd) (#17955)
- Corrected Flametongue weapon damage formula
- Actually check offhand weapon for flametongue in Lava Lash script
- Implemented halved proc chance for Missile Barrage on Arcane Barrage, Fireball, Frostbolt and Frostfire Bolt cast
- Converted Unit::HandleProcTriggerSpell function to AuraScripts (#17956)
- De-hack Earth shield. Fixes #13808
- Updated Honor among Thieves
- Implemented mana proc for Mark of Conquest in case of ranged attack
- Fixed Scent of Blood giving more stacks than the talent rank currently learnt.
- Ported old proc table. Proc system is dead. Long live the proc system!
- Recklessness should get charges removed per cast. Closes #15529
- Use proc system to remove Molten Core charges on Incinerate/Soul Fire cast. Closes #15942

Closes #3463
Closes #5401
Closes #15595
Closes #15974
Closes #16679
Closes #17925
2016-10-04 20:21:58 -03:00
treeston
84cf239fda Various: Fix coverity reported issues. 2016-10-04 13:49:05 +02:00
ariel-
0c24e4ee0e Core/Unit: rewrite of the attack table system
- Removed a bunch of duplicated code
- Fix off-by-one errors in Unit::RollMeleeOutcomeAgainst and Unit::MeleeSpellHitResult (TC's combat table was actually of 100.01%)
- Implemented boss-level hit table (6.5% dodge/14% parry), bosses only had 5.6% of each until now
- Updated formula for chance and damage of Glancing hits

Sources:
- http://wow.gamepedia.com/index.php?title=Attack_table&oldid=2071465
- http://web.archive.org/web/20100903145646/http://www.mmo-champion.com/threads/650071-Expertise-Hit-for-Paladins-%28updated-for-3.3%29?daysprune=60
2016-10-04 01:26:34 -03:00
ariel-
b54042d68f Core/Spells: Flag of Ownership shouldn't target creatures 2016-10-02 22:15:09 -03:00
SnapperRy
2f493430c9 Script/Quest: fix and use proper serverside summon spell for quest "Red Snapper - Very Tasty!". 2016-09-10 02:30:22 +02:00
SnapperRy
0479f08c3c Script/Quest: replace wrong test spell used for quest "Red Snapper - Very Tasty!" with actual summoning.
The spell does not appear in sniffs, and the summoned NPC's spawn time was far too short to be appropriate (15 seconds).
2016-09-10 01:13:35 +02:00
ariel-
bc4b4f656c Core/Scripts: Implement Flag of Ownership. Closes #12265
Core/Spells: Implemented TARGET_CORPSE_SRC_AREA_ENEMY. Closes #12803
2016-09-04 07:09:04 -03:00
ariel-
be9ef83340 Core/Scripts: more 746b838870 follow-up, shouldn't trigger marker aura if proc was prevented 2016-09-04 05:26:57 -03:00
ariel-
7cc91dc45b Core/Scripts: add missing check removed in 746b838870 2016-09-04 04:56:05 -03:00
ariel-
746b838870 Core/Spells / Scripts: Fix Lock and Load. Closes #16731 2016-09-04 04:21:04 -03:00
ariel-
31399d5f34 Core/Scripts: Implement Glyph of Backstab. Closes #7500 2016-09-04 01:31:02 -03:00
Gustavo
e1761a24ce Core/Spells Make credit for quests "The Grand Melee" and "Among the Champions" a triggered cast (#17870)
Fix a problem where the credit wasn't casted due to CGD
2016-08-28 23:34:23 +02:00
Gustavo
989aaaa8b5 Scripts/Pet Implemented Argent Squire/Gruntling and Argent Pony Bridle 2016-08-25 08:31:48 +02:00
SnapperRy
894378f867 Event/Brewfest: implement relay race (#17603) 2016-08-23 13:36:57 +02:00
Gustavo
5661b4686b Improve scripts for quests Breakfast Of Champions and A Bear of an Appetite (#17780)
Properly despawn the related GameObjects after use of the quest item, avoiding multiple use and summon
2016-08-23 13:21:03 +02:00
ariel-
62bfee37cb Core/Entities: debloat SummonGameObject parameter list using proper wrappers and enable GO rotation in scripts
- There's still an overload allowing for x, y, z, o to be passed directly
- Fixed default animstate for GameObject creation in many places, it should be 255, not 100 (checked in sniffs)
2016-07-30 18:50:44 -03:00
Keader
cee1c0789a Core/Scripts: Hallow's End Pumpkin Treat
Add all 6 spells available from item 20557,
Hallow's End Pumpkin Treat:
- Hallow's End Candy, Orange Giant (24924)
- Hallow's End Candy, Skeleton (24925)
- Hallow's End Candy, Pirate (24926)
- Hallow's End Candy, Ghost (24927)
- Hallow's End Candy, Female Defias Pirate (44742)
- Hallow's End Candy, Male Defias Pirate (44743)

Thanks @Keader for creating the new spell scripts & SQL,
 saved me a lot of time! :-)
2016-07-16 16:15:19 +02:00
ariel-
6988407b43 Core/Spells: Fix Roar of Sacrifice damage part (#17519) 2016-07-16 02:52:32 -03:00
Gustavo
23e89b8aef Core/Spells GameObjects needs to be spawned in order to be acceptable as a SpellFocus (#17594) 2016-07-15 23:45:50 +02:00
SnapperRy
03b15d968b Event/Midsummer: improve pole ribbon functionality (#17464)
Event/Midsummer: improve pole ribbon functionality:

- Bunny creature should hover, which puts it in the intended position.
- Use correct visual and internal spells to handle cosmetics and timers.
2016-07-05 15:19:30 +02:00
Aokromes
b0e5f6de47 Scripts/Midsummer: Burning hot pole dance (#17445)
* Scripts/Midsummer: Burning hot pole dance
By  zwerg, closes #6876
2016-06-26 00:27:19 +02:00
JamminWidYou
3002839bfe [3.3.5] Core/Quest: A life without regret (#16067)
* Life without Regret

* misc changes to sql

* sql changes
2016-06-14 12:48:28 +01:00
mik1893
3d31e2a157 Core/Spells: fix issue with Illumination talent (broken in #17122) (#17350) 2016-06-12 10:47:29 +01:00
Shauren
b36da77185 Core/Units: Renamed and documented UNIT_FLAG_DISABLE_MOVE to prevent people from trying to use this flag to root a creature leaving them wondering why it doesn't do anything 2016-05-27 14:45:06 +02:00
ForesterDev
c73c51d7b1 Merge branch '3.3.5' into creature_family 2016-05-27 12:51:28 +04:00
Shauren
9612ac0e27 Core/Spells: Fixed Eclipse after recent proc cooldown changes
Closes #17166
2016-05-24 18:37:46 +02:00
mik1893
5b8e68ee63 Core/Spells: Proc handler script converions (#17122)
* Blazing Speed (Mage)
* Blessed Recovery (Priest)
* Druid Forms Trinket
* Idol Of Mutilation
* Nature's Guardian (Shaman)
* Nether Protection (Warlock)
* Piercing Shots and Bonus 4P T9 Hunter
* Lightning Shield (Shaman)
* Acclimation (DK)
* Move DK T10 4P Melee Bonus
* Move DK Improved Blood Presence triggered heal (DK)
* Rogue T10 2P Bonus
* Illumination (Paladin)
* Soul Preserver
* Death Choice trinket
* stack trinket scripts (ToC25 Caster Trinket, Lightning Capacitor, Thunder Capacitor)
* Battle Experience (ICC - Gunship)
* Blood Reserve (enchant proc)
* Darkmoon Card Greatness
* Charm of the Amani Witch Doctor
* Mana Drain
2016-05-20 19:27:15 +02:00
ForesterDev
d5dd8e8926 fix build 2016-05-16 19:16:40 +04:00
joschiwald
029527365f Scripts/Spells: fixed Decahedral Dwarven Dice and Worn Troll Dice
#Closes 16866
2016-04-23 13:53:07 +02:00
Gustavo
d1a053e4f5 Core/Quests Fix Quests Borrowed Technology, Volatility and The Solution Solution (#16968) 2016-04-16 15:42:07 +02:00
Shauren
3f7e6af49e Properly rename the stand state method... 2016-04-08 22:32:15 +02:00
Shauren
6dfc4771a1 Core/Misc: Renamed getStandState to minimize differences between branches 2016-04-08 22:21:13 +02:00
Shauren
e52878b6b5 Core/Spells: Renamed EnsureSpellInfo to AssertSpellInfo to minimize differences between branches 2016-04-02 17:05:46 +02:00
Shauren
b2bd181a5f Merge pull request #16848 from P-Kito/debuff_remove
[3.3.5/6.x] Scripts/Spells: Add generic spell to handle ClearDebuffs spell
2016-03-27 19:45:23 +02:00
Kito
8de7e12a6e Scripts/Spells: Add generic spell to handle ClearDebuffs spell 2016-03-27 19:30:03 +02:00
joschiwald
2dda0ed36a fixed warning again :( 2016-03-20 21:27:19 +01:00
joschiwald
052603a7e8 fixed build 2016-03-20 20:49:37 +01:00
joschiwald
c498966d23 Core/Spells: cleanup raise ally code
(partial cherry picked from commit 312e8509dd)
2016-03-20 19:50:11 +01:00
joschiwald
ffdf75a233 Scripts/Spells: Glyph of Arcane Shot is affected by own debuffs on target only 2016-02-27 17:55:43 +01:00
treeston
1fbe7979ff Nobody saw that. 2016-02-24 15:47:57 +01:00
Treeston
4e4b2b9a13 Merge pull request #16644 from Treeston/3.3.5-customcharmai
Core/UnitAI: Rework creature-controlled player behavior.
2016-02-24 13:39:31 +01:00
treeston
2f14664340 Core/UnitAI: Rework creature-controlled player behavior.
- Removed hacked control mechanism, use proper PlayerAI instead
- Port old hacky code to new SimpleCharmedPlayerAI class
- Make adjustments to aforementioned code to fix bugs:
    - Properly clean up movement after charm ends
    - Only try to attack a target if charmer is engaged in combat
2016-02-23 13:41:56 +01:00
Naios
9e43365b3d Core/Scripts: Split the huge scriptloader into smaller pieces
* Each subdirectory contains it's own translation unit now
  which is responsible for loading it's directory
* Improves merging & decoupling between 3.3.5 <-> 6.x
* Removes unused Battleground loader
* Ref #15671

(cherry picked from commit 5534915f74)
2016-02-22 16:25:54 +01:00
Shauren
2ee36facad Merge pull request #16622 from P-Kito/3.3.5
[3.3.5] Core/Spells: Fix Glyph of Arcane Shot
2016-02-19 15:02:17 +01:00
MitchesD
408572c472 Merge pull request #16258 from sirikfoll/feast
Core/Spells Implemented SpellScripts Needed for Achievement Pilgrim's…
2016-02-18 21:03:11 +01:00
Kito
ab2b0f4168 Core/Spells: Fix Glyph of Arcane Shot 2016-02-17 22:58:04 +01:00
treeston
ae58f8e616 Revert "Merge pull request #16535 from Eliminationzx/FixWrongSealOfRighteousnessCalculation" while we figure out more details (see discussion in the PR).
This reverts commit 1a213bd921, reversing
changes made to 657adc270a.
2016-02-16 12:34:20 +01:00
Treeston
1a213bd921 Merge pull request #16535 from Eliminationzx/FixWrongSealOfRighteousnessCalculation
[3.3.5] Core/Spells: Fix incorrect Seal of Righteousness calculation.
2016-02-15 14:58:10 +01:00
treeston
3535a9fc7b Core/Spells: Disallow druid flight form while in shapeshift forms that prevent mounting. No more swimming zombies. Closes #16354. 2016-02-12 17:28:35 +01:00
ccrs
983bbe4a4c Core/Spells: Rogue Honor Among Thieves 2016-02-10 14:12:58 +01:00