Commit Graph

13053 Commits

Author SHA1 Message Date
ariel-
303efcf0e4 Core/Spells: remove 'Vanish Purge' hack, the spell is present on DB and is copy of one in vanilla DBC
Thanks to killerwife for the heads-up
2018-02-08 23:18:45 -03:00
Keader
31ad6358fb Core/Scripts: Fixed tabs issues introduced in 5bef3e426a 2018-02-08 10:16:19 -03:00
Keader
5bef3e426a Core/Scripts: Fixed possible crashs related with JustDied 2018-02-08 10:05:08 -03:00
ariel-
b490d3f5ad Core/Scripts: fix non-functional Celestial Planetarium Access GO
- Client only sends CMSG_GAMEOBJ_REPORT_USE for this one

Closes #19982
2018-02-06 13:59:08 -03:00
sirikfoll
cfaa4e6caf Scripts/Magisters Terrace: Removed not allowed ENSURE_AI call from constructor
Closes #20727
2018-02-05 21:27:13 -02:00
sirikfoll
14b6e3bbb3 Scripts/Sunwell Plateau: Fixed and improved spell "Curse of Boundless Agony" target selection (Boss Kalecgos) 2018-02-05 21:14:26 -02:00
Shauren
713bf944ae Build fix 2018-02-05 21:08:09 +01:00
Shauren
2fd9dc2edb Core/Scripts: Fixed ENSURE_AI assertion failures when used in Reset()/InitializeAI() hooks with hotswap
Updates #20727
2018-02-05 20:52:19 +01:00
ariel-
ed931cfa19 Core/ScriptSystem: AfterHit hook can't modify damage/healing, so log it
- Also added const to getter members
2018-02-05 14:43:11 -03:00
ariel-
650a92dc9f Core/Channel: properly notify client about invalid channel names
Closes #16190
2018-02-05 13:45:52 -03:00
Treeston
4bd2d28119 Revert "Scripts/Northrend: Malygos now uses modifiable threat list when teleporting after vortex. Fixes a crash. Closes #21315."
This reverts commit 6bbc95f3a0, which is made unnecessary by 65709e1c30.
2018-02-05 10:14:00 +01:00
ariel-
65709e1c30 Core/Spells: fix logic error causing near teleports to drop combat for players
Closes #21362
2018-02-04 22:47:53 -03:00
ariel-
e979a58d17 Core/Spells: remove duplicated LowerPlayerDamageReq call on reflected spells
- It is already called at Unit::DealDamage
2018-02-04 22:07:10 -03:00
Treeston
6bbc95f3a0 Scripts/Northrend: Malygos now uses modifiable threat list when teleporting after vortex. Fixes a crash. Closes #21315. 2018-02-05 01:38:56 +01:00
Treeston
4cb13af4fa Core/Threat: Custom ThreatListIterator that transparently iterates over the backing map (instead of using heap iterators) when working with the unsorted threat list. This greatly reduces the range of actions that can cause iterator invalidation.
Also some minor adjustments to .debug threat, which no longer hides certain invalid states from view.
2018-02-05 01:33:41 +01:00
ariel-
2d2c43f4b9 Core/Spells: fix SPELLMOD_DAMAGE application order for melee spells
Closes #20597
2018-02-04 21:28:15 -03:00
ariel-
9fc732eb97 Core/Spells: kill unused parameter from Spell constructor
Added in 1f2292af79
2018-02-04 20:15:38 -03:00
jackpoz
71feb2149e Core/Misc: Fix no-pch build 2018-02-04 21:54:06 +01:00
jackpoz
95a76a83fc Core/AI: Fix assertion triggered with PetAI derived scripts (#21254)
* Core/AI: Fix assertion triggered with PetAI derived scripts

Fix an assertion triggered when spawning through ".npc add" or from SQL db table a Creature with AI set to a custom AI inheriting from PetAI.
2018-02-04 21:47:45 +01:00
Treeston
b3e0c89238 Scripts/Ulduar: Flame Leviathan used a very weird mixture of victim logic and REACT_PASSIVE, which broke during transition to the new system. Replaced with a working version.
Closes #21265.
2018-02-04 21:27:48 +01:00
Treeston
8f52664a37 nopch fix 2018-02-04 15:10:31 +01:00
Treeston
6e0df9fce1 AI/SmartAI: Remove a silly incorrect piece of code that was breaking react state swaps on SAI creatures. Fixes #21353. 2018-02-04 15:03:05 +01:00
Treeston
aefc25482f Scripts/ICC: Valithria Dreamwalker's script no longer despawns unrelated mobs in Frostwing Halls, and thus won't get them stuck in a despawned state due to linked_respawn.
Closes #21286.
2018-02-04 01:32:30 +01:00
sirikfoll
a217c0be92 Scripts/Icecrown Citadel: Corrected Val'kyr Shadowguard positioning on heroic mode (Lich King)
Movement was being prevented by spell cast
2018-01-31 00:59:14 -02:00
Killyana
8f71307e56 Spell/Script: Torch 52953 and 58121 must hit only one target 2018-01-30 13:04:25 +01:00
Treeston
1acfefb973 Core/Creature: Adjust SelectVictim behavior: (PR #21324)
- No more automatic combat -> threat promotion. This matches anecdotal retail behavior - spells already in transit will not cause mob to chase you if its primary target vanishes before the spell hits.
- Prevent mobbing by stopping creatures from auto-acquiring a nearby target just because the primary target vanished.
2018-01-29 23:14:46 +01:00
Treeston
03ef79f3d9 Scripts/Pets: Mirror Image re-write, because it's a colossal mess right now. (PR #19818) 2018-01-29 14:27:15 +01:00
Treeston
2402406228 Combat/Threat: Now set engaged state for all units on offline reference registration (vanished/invis'd units). For non-PASSIVE units, this will immediately cause an evade.
This fixes an exploit where creating the reference as offline (by vanishing while a spell was mid-flight) you could damage a creature further without it ever engaging you.
2018-01-29 03:07:43 +01:00
Treeston
c69584a967 Game/AI: Remove some unused old logic. 2018-01-29 01:57:31 +01:00
Shauren
aaab7ba9f4 Scripts/Icecrown Citadel: Added missing cosmetic colors and emotes to Big Ooze (Rotface) 2018-01-28 23:29:33 +01:00
Killyana
52fc5a572b Quest/script: Freedom to Ruul
Follows 4dc91429dd
2018-01-28 15:15:50 +01:00
Killyana
4dc91429dd DB/Quest: Freedom to Ruul
Closes #7262
2018-01-28 14:03:43 +01:00
Treeston
0ee14845ae typo 2018-01-28 02:41:33 +01:00
Treeston
320306554c Core/Creature: add an assertion to guard against infinite loops 2018-01-28 01:51:50 +01:00
Aokromes
4130647bf6 Core/Misc: Sort string 2018-01-27 16:20:41 +01:00
Shauren
21ad8761e9 Core/Spells: Exclude spells with no MaxLevel from coefficient downranking penalty 2018-01-27 13:06:48 +01:00
Shauren
2ab4e6c7aa Core/Spells: Fixed downranking coefficient penalty formula
Closes #21318
2018-01-27 12:19:18 +01:00
ccrs
275c17b4c2 Revert "Core/SmartAI: Remove duplicate OnReset() call"
This reverts commit 42c9289be3.
2018-01-26 23:56:39 +01:00
sirikfoll
42c9289be3 Core/SmartAI: Remove duplicate OnReset() call
It is already called for every creature in SmartAI::InitializeAI(), removing the one from SmartAI::JustAppeared to keep as much as possible of the old behavior, because JustAppeared is called on the next tick after InitializeAI

Closes #20881
Closes #20771
2018-01-26 19:18:10 -02:00
Keader
db525a1401 Scripts/Spells: Fixed Nature's Guardian proc (#21314) 2018-01-26 00:06:50 -02:00
Treeston
51e28ae76a DB/SpawnGroup: Instance spawn group data for Tempest Keep: The Eye and Hellfire Citadel: Ramparts.
(also some minor adjustments to command output for convenience)
2018-01-25 13:45:11 +01:00
Treeston
6c3c200cc5 Misc: assert -> ASSERT 2018-01-25 12:39:19 +01:00
Treeston
6ce078d8e8 Scripts/Commands: new command '.debug instancespawn' 2018-01-24 22:52:42 +01:00
ariel-
b1072faa50 Core/Spell: killed deprecated code which randomly changed powercost for missed spells
Added in 80d3cd43f6

Closes #5954
2018-01-24 13:07:01 -03:00
ariel-
6dd465c441 Core/Scripts: reverted Auriaya spell script logic
Thanks Shauren for spotting it
2018-01-24 12:32:26 -03:00
ariel-
8e0af1b93b Core/Player: only call _ApplyWeaponDamage for actual weapons
Closes #21308
2018-01-24 00:05:25 -03:00
ariel-
c099174ff7 Core/Misc: fix some /W4 warnings and some reported by GCC 6.3 2018-01-22 23:55:33 -03:00
ariel-
7c9722a4ae Core/Entities: killed Creature::SetInCombatWithZone and replaced with AI version
Closes #12108 (again)
2018-01-22 15:00:55 -03:00
ariel-
e315e41d36 Core/Entities: don't allow client control if player is still affected by any lose of control state 2018-01-22 14:13:46 -03:00
ariel-
590d251882 Core/PlayerAI: perform cast checks on auto ranged attack
Closes #19928
2018-01-22 14:02:01 -03:00