Commit Graph

34607 Commits

Author SHA1 Message Date
Treeston
3b635a8a12 Scripts/AzjolNerub: Clean up Hadronox to hopefully avoid any further evade issues. Tag #20310.
(cherry picked from commit fe3b4de1cd)
2021-06-20 20:17:59 +02:00
Killyana
6a0a4a62db DB: Add a missing action_param to the previous commit
Gobs always requires respawn time with the action 41, otherwise they will never respawn

(cherry picked from commit 9f59fb54fc)
2021-06-20 19:18:23 +02:00
Killyana
3ee39ce5b7 SAI/Quest: Sabotage
Closes #20881

(cherry picked from commit c9811a48c4)
2021-06-20 19:17:40 +02:00
Teppic1
ab1e533f3f DB/Loot: Reference template 24064 corrections
Closes #21385

(cherry picked from commit 75b975b4e8)
2021-06-20 19:05:44 +02:00
ccrs
cecb91ad3d Core/Movement: fe1ba18905 followup
ref fe1ba18905 (r27507316)

plus I noticed a logic error on speedchange call

(cherry picked from commit 28c6db0807)
2021-06-20 01:34:48 +02:00
ariel-
a342b86403 Core/Scripts: fix Tenacity Aurascript (target is null on UpdatePeriodic)
- also aura amount increases with stack so we lose spellid info, calculate it from basepoints directly
- aura should be SPELL_AURA_MOD_HEALING_PCT instead of SPELL_AURA_MOD_HEALING_DONE_PERCENT (ie taken instead of done, confusing names)

(cherry picked from commit bc2a4c816d)
2021-06-20 01:15:00 +02:00
ariel-
15810eb579 Core/Unit: kill unused parameter from SpellxxxBonusTaken
(cherry picked from commit c7095375c3)
2021-06-20 01:09:20 +02:00
ariel-
23a88fae6f Core/Scripts: remove Tenacity hack, implemented with proper aura
(cherry picked from commit 404240fb68)
2021-06-20 00:55:53 +02:00
Wilcalaf
e9833447ed Archaedas should properly start now when clicking on the altar. (#21401)
(cherry picked from commit 0c1aaac219)
2021-06-20 00:30:33 +02:00
ariel-
bc6b0c5197 Core/Unit: corrected calculation for SPELL_AURA_MOD_DAMAGE_TAKEN/SPELL_AURA_MOD_HEALING auras
- Spell bonus calculation and penalty was done twice, but it's simply flat +SP, which should be taken into account before other bonuses
- Fixed missing code from SpellDamageBonusDone/SpellHealingBonusDone and killed multiplication by stack amount twice for default coefficient spells (already multiplied on level penalty)

(cherry picked from commit 4d14f613f3)
2021-06-20 00:28:50 +02:00
ariel-
18780206bc Core/Spells: Do not apply SpellModOp::CritChance to spells that can't crit 2021-06-19 23:55:03 +02:00
ariel-
3582bacc4a Core/Spells: add log on load about improper use of attribute PROC_ATTR_REQ_SPELLMOD
(cherry picked from commit dfa861593e)
2021-06-19 23:34:15 +02:00
ariel-
13be704cb4 Core/Spells: implement SPELLVALUE_CRIT_CHANCE
(cherry picked from commit 546a605bd0)
2021-06-19 23:33:44 +02:00
ariel-
85e5509e91 Core/Spells: calculate crit chance only for spells that do damage/healing
Refs #18813

(cherry picked from commit 52873a7072)
2021-06-19 23:33:38 +02:00
Treeston
fbc7e7d5cc Scripts/CoT4: Stratholme Residents should no longer rudely interrupt Arthas by punching him in the face while he's giving a righteous sermon on his reasons for wiping them all out.
(cherry picked from commit bf3973dc61)
2021-06-19 23:33:38 +02:00
Treeston
f4cc76063f Core/AI: EscortAI init logic moved from JustAppeared to InitializeAI. There are no escort NPCs using compatibility mode anymore, so this is equivalent.
As a result, inheriting scripts calling Start in on-create hooks (like JustSummoned) will now work properly again.

Tagging #20310.

(cherry picked from commit e4e6e2209c)
2021-06-19 23:33:38 +02:00
Treeston
3c172ba17c Scripts/AzjolNerub: Hadronox is a big spider mommy, and needs more room to pet her spider pets properly. Hopefully this'll reduce the number of evades happening during the encounter. Tag #20310.
(cherry picked from commit b243a7929b)
2021-06-19 23:33:38 +02:00
Treeston
65172db460 DB/Quest: fix Territorial Trespass SmartScript to use proper target type (tag #20310)
(cherry picked from commit 92a8f65203)
2021-06-19 23:33:38 +02:00
Treeston
6d79b329ac Core/Movement: WaypointMovementGenerator cleanup
(cherry picked from commit fe1ba18905)
2021-06-19 23:33:38 +02:00
Treeston
88c1739e3e Core/Movement: Creatures' idle movement generator can no longer override player mover control.
Tagging #20310, partial fix.

(cherry picked from commit d02f481d9a)
2021-06-19 23:33:38 +02:00
ariel-
a24af55d13 Core/Scripts: implemented Combined Toxins proc only from poisons
(cherry picked from commit 477878630e)
2021-06-19 23:33:38 +02:00
ariel-
c21dc3c1b7 Core/Auras: fix periodic ticks proc after previous commit
(cherry picked from commit 9d0e90829c)
2021-06-19 23:33:38 +02:00
ariel-
91fa279bdf Core/Spells: require phasemask set for periodic damage procflag
Closes #21379

(cherry picked from commit b42ade918a)
2021-06-19 23:33:38 +02:00
jackpoz
cb0672081e Core/Player: Add some asserts
Assert PlayerInfo for race/class pair in a few Player functions

(cherry picked from commit 3576a38f6c)
2021-06-19 23:33:38 +02:00
jackpoz
e63c5f7b0c Scripting/Obsidian Sanctum: Fix crash
Fix crash caused by calling Reset() in constructor (which is not allowed)

(cherry picked from commit 5aba5c7aff)
2021-06-19 23:33:38 +02:00
Killyana
0b5bd43f34 DB/SAI: Mire Hydra
(cherry picked from commit 201b0b3720)
2021-06-19 23:33:38 +02:00
Killyana
f2c36b8634 DB: Fix some DB errors
Ref 3acd9a7c4f

(cherry picked from commit e4817aa822)
2021-06-19 23:33:38 +02:00
jackpoz
66f7e57990 Shared/Database: Improve dead-lock error handling
Improve dead-lock error handling in async transactions by retrying the transaction for up to 60 seconds instead of just 5 times

(cherry picked from commit 54b0b8f5ea)
2021-06-19 23:33:38 +02:00
Killyana
c72fe6a972 DB/Creature: Arcatraz Sentinel
Updates #21156

(cherry picked from commit 6952d0a5ea)
2021-06-19 23:33:37 +02:00
Treeston
e8754cbdaf Scripts/Instance: Transition Gnomeregan to boss states (instance spawn group prep)
(cherry picked from commit a4fc32dd86)
2021-06-19 23:33:37 +02:00
Keader
299f22e3fc Scripts/Icecrown Citadel: Fixed Sindragosa spawn after grid unload
ty sirikfoll :)

(cherry picked from commit 2994abeae6)
2021-06-19 23:33:37 +02:00
Treeston
ef710273d0 Game/AI: InvalidAIException internal cleanup
(cherry picked from commit b456915f9a)
2021-06-19 23:33:34 +02:00
ariel-
3485cb38ed Core/Spells: remove 'Vanish Purge' hack, the spell is present on DB and is copy of one in vanilla DBC
Thanks to killerwife for the heads-up

(cherry picked from commit 303efcf0e4)
2021-06-19 23:33:25 +02:00
Killyana
a22ffcc18a DB: Fix the previous commit
(cherry picked from commit b4c16971cb)
2021-06-19 23:33:25 +02:00
Killyana
328f6f4873 DB/Creature: Remove Tamed Sporebat spawns, summoned as pets by other npcs
(cherry picked from commit 3acd9a7c4f)
2021-06-19 23:33:25 +02:00
ZenoX92
91f1c0b89c DB/Gossip: Zorbin Fandazzle
Closes #21369

(cherry picked from commit 23dd63da98)
2021-06-19 23:33:25 +02:00
ZenoX92
4be4e542cd DB/Quest: Zapped Giants
Closes #21370

(cherry picked from commit fa1db68fec)
2021-06-19 23:33:25 +02:00
ZenoX92
b3e9cd3a14 DB/Quest: Weapons of Spirit
Closes #21371

(cherry picked from commit 58bb542e50)
2021-06-19 23:33:25 +02:00
ZenoX92
09559d51de DB/Misc: Feralas Quest Emotes (Horde)
Closes #21372

(cherry picked from commit c60eef9cda)
2021-06-19 23:33:24 +02:00
ZenoX92
61b31f657a DB/Quest: Tran'rek (breadcrumb quest)
Closes #21373

(cherry picked from commit c705b02a0c)
2021-06-19 23:33:24 +02:00
Teppic1
2bc1f0593b DB/Loot: Set up correct rare drops for Shadowfang Keep exclusive items
Closes #21382

(cherry picked from commit 65237ecea7)
2021-06-19 23:33:24 +02:00
Teppic1
014a77938d DB/Loot: Reference template 24062 corrections
Closes #21368

(cherry picked from commit 3aee76b2d6)
2021-06-19 23:33:24 +02:00
Teppic1
2d08f4ce76 DB/Loot: Dun Morogh - Coldridge Valley loot tables redone
Closes #21364

(cherry picked from commit b17a084ecd)
2021-06-19 23:33:24 +02:00
Teppic1
51a4b60353 DB/Loot: Reference template 24060 corrections
Closes #21363

(cherry picked from commit c49003ac8b)
2021-06-19 23:33:24 +02:00
Keader
9b7f3bff9f Core/Scripts: Fixed tabs issues introduced in 5bef3e426a
(cherry picked from commit 31ad6358fb)
2021-06-19 23:33:24 +02:00
Keader
ad5b0fa9cd Core/Scripts: Fixed possible crashs related with JustDied
(cherry picked from commit 5bef3e426a)
2021-06-19 23:33:24 +02:00
ariel-
4ae29e38ee Core/Scripts: fix non-functional Celestial Planetarium Access GO
- Client only sends CMSG_GAMEOBJ_REPORT_USE for this one

Closes #19982

(cherry picked from commit b490d3f5ad)
2021-06-19 23:33:24 +02:00
sirikfoll
9573987775 Scripts/Magisters Terrace: Removed not allowed ENSURE_AI call from constructor
Closes #20727

(cherry picked from commit cfaa4e6caf)
2021-06-19 23:33:24 +02:00
sirikfoll
e2c72cc02e Scripts/Sunwell Plateau: Fixed and improved spell "Curse of Boundless Agony" target selection (Boss Kalecgos)
(cherry picked from commit 14b6e3bbb3)
2021-06-19 23:33:24 +02:00
ariel-
8c379e920c Core/Spells: fix logic error causing near teleports to drop combat for players
Closes #21362

(cherry picked from commit 65709e1c30)
2021-06-19 23:33:24 +02:00