ariel-
5b42c0b270
Core/Spells: Port refactors from 1826437c09
...
(cherry picked from commit 1826437c09
2021-06-20 22:25:18 +02:00
Treeston
168be492f5
Entities/GO: Add forceRespawnTimer support to DespawnOrUnsummon. Use it in SAI.
...
(cherry picked from commit 264d4e1d30
2021-06-20 22:10:08 +02:00
Killyana
19ed9c971f
DB: Fixing a typo from a previous commit
...
Ref 9f59fb54fc826b3cf09e
2021-06-20 21:51:23 +02:00
Treeston
bccd81e12a
Entities/GO: GameObjects now support (delayed) despawning in a reasonable manner. Closes #21406 .
...
(cherry picked from commit f071fa9e93
2021-06-20 21:49:11 +02:00
Treeston
bd158f6c29
oops, now it builds (and a bonus refactor that annoyed me)
...
(cherry picked from commit 2cd5992f37
2021-06-20 21:42:35 +02:00
Treeston
1f26122528
Scripts/SmartAI: Forward invoker to invoked action list actions. Also JustAppeared -> InitializeAI.
...
(cherry picked from commit 6fb0bc1038
2021-06-20 21:42:35 +02:00
Treeston
83c4aa88ec
Scripts/TheBarrens: Fix "The Escape" (863) - I don't think this one ever worked, honestly.
...
(cherry picked from commit 0e401c7d96
2021-06-20 21:42:35 +02:00
Killyana
121bfa90ed
DB/Condition: Placing Beacon Torch
...
Closes #21244
(cherry picked from commit f91a9f8b14
2021-06-20 21:42:35 +02:00
Killyana
920494d362
DB/Quest: Rescue from Town Square
...
Closes #20102
(cherry picked from commit 2f575f0974
2021-06-20 21:42:35 +02:00
Killyana
8a033c462b
DB/SAI: Runed Stone Giant
...
(cherry picked from commit 40954d0b6a
2021-06-20 21:42:35 +02:00
Treeston
06b5b8d8b7
Scripts/SmartAI: SMART_TARGET_INVOKER cleanup step 1. The core will now log errors on start-up if SMART_TARGET_INVOKER abuse is found, but will continue to load the scripts as deprecated for now.
...
Note that a lot of these scripts may either not currently work, not work reliably, or may be prone to breaking unexpectedly when core internals change. SMART_TARGET_INVOKER is undefined behavior on any event that doesn't directly specify its invoker.
(We are considering options for allowing INVOKER to make sense in timed action lists in a reliable fashion, so they are exempted at this time.)
(cherry picked from commit 482328bddf
2021-06-20 21:42:33 +02:00
Killyana
6c5e170d9f
DB/SAI: Fix wrong event type for npcs summoned by Flight Master
...
Closes #21244
(cherry picked from commit adae429aa0
2021-06-20 20:24:50 +02:00
Treeston
ffce2c1f9a
Core/Spell: Properly remove REACT_PASSIVE on permanent feign death unapply. Fixes and closes #21156 .
...
(cherry picked from commit ac8b9be5d6
2021-06-20 20:22:18 +02:00
Treeston
3b635a8a12
Scripts/AzjolNerub: Clean up Hadronox to hopefully avoid any further evade issues. Tag #20310 .
...
(cherry picked from commit fe3b4de1cd
2021-06-20 20:17:59 +02:00
Killyana
6a0a4a62db
DB: Add a missing action_param to the previous commit
...
Gobs always requires respawn time with the action 41, otherwise they will never respawn
(cherry picked from commit 9f59fb54fc
2021-06-20 19:18:23 +02:00
Killyana
3ee39ce5b7
SAI/Quest: Sabotage
...
Closes #20881
(cherry picked from commit c9811a48c4
2021-06-20 19:17:40 +02:00
Teppic1
ab1e533f3f
DB/Loot: Reference template 24064 corrections
...
Closes #21385
(cherry picked from commit 75b975b4e8
2021-06-20 19:05:44 +02:00
ccrs
cecb91ad3d
Core/Movement: fe1ba18905 followup
...
ref fe1ba18905 (r27507316)28c6db0807
2021-06-20 01:34:48 +02:00
ariel-
a342b86403
Core/Scripts: fix Tenacity Aurascript (target is null on UpdatePeriodic)
...
- also aura amount increases with stack so we lose spellid info, calculate it from basepoints directly
- aura should be SPELL_AURA_MOD_HEALING_PCT instead of SPELL_AURA_MOD_HEALING_DONE_PERCENT (ie taken instead of done, confusing names)
(cherry picked from commit bc2a4c816d
2021-06-20 01:15:00 +02:00
ariel-
15810eb579
Core/Unit: kill unused parameter from SpellxxxBonusTaken
...
(cherry picked from commit c7095375c3
2021-06-20 01:09:20 +02:00
ariel-
23a88fae6f
Core/Scripts: remove Tenacity hack, implemented with proper aura
...
(cherry picked from commit 404240fb68
2021-06-20 00:55:53 +02:00
Wilcalaf
e9833447ed
Archaedas should properly start now when clicking on the altar. ( #21401 )
...
(cherry picked from commit 0c1aaac219
2021-06-20 00:30:33 +02:00
ariel-
bc6b0c5197
Core/Unit: corrected calculation for SPELL_AURA_MOD_DAMAGE_TAKEN/SPELL_AURA_MOD_HEALING auras
...
- Spell bonus calculation and penalty was done twice, but it's simply flat +SP, which should be taken into account before other bonuses
- Fixed missing code from SpellDamageBonusDone/SpellHealingBonusDone and killed multiplication by stack amount twice for default coefficient spells (already multiplied on level penalty)
(cherry picked from commit 4d14f613f3
2021-06-20 00:28:50 +02:00
ariel-
18780206bc
Core/Spells: Do not apply SpellModOp::CritChance to spells that can't crit
2021-06-19 23:55:03 +02:00
ariel-
3582bacc4a
Core/Spells: add log on load about improper use of attribute PROC_ATTR_REQ_SPELLMOD
...
(cherry picked from commit dfa861593e
2021-06-19 23:34:15 +02:00
ariel-
13be704cb4
Core/Spells: implement SPELLVALUE_CRIT_CHANCE
...
(cherry picked from commit 546a605bd0
2021-06-19 23:33:44 +02:00
ariel-
85e5509e91
Core/Spells: calculate crit chance only for spells that do damage/healing
...
Refs #18813
(cherry picked from commit 52873a7072
2021-06-19 23:33:38 +02:00
Treeston
fbc7e7d5cc
Scripts/CoT4: Stratholme Residents should no longer rudely interrupt Arthas by punching him in the face while he's giving a righteous sermon on his reasons for wiping them all out.
...
(cherry picked from commit bf3973dc61
2021-06-19 23:33:38 +02:00
Treeston
f4cc76063f
Core/AI: EscortAI init logic moved from JustAppeared to InitializeAI. There are no escort NPCs using compatibility mode anymore, so this is equivalent.
...
As a result, inheriting scripts calling Start in on-create hooks (like JustSummoned) will now work properly again.
Tagging #20310 .
(cherry picked from commit e4e6e2209c
2021-06-19 23:33:38 +02:00
Treeston
3c172ba17c
Scripts/AzjolNerub: Hadronox is a big spider mommy, and needs more room to pet her spider pets properly. Hopefully this'll reduce the number of evades happening during the encounter. Tag #20310 .
...
(cherry picked from commit b243a7929b
2021-06-19 23:33:38 +02:00
Treeston
65172db460
DB/Quest: fix Territorial Trespass SmartScript to use proper target type (tag #20310 )
...
(cherry picked from commit 92a8f65203
2021-06-19 23:33:38 +02:00
Treeston
6d79b329ac
Core/Movement: WaypointMovementGenerator cleanup
...
(cherry picked from commit fe1ba18905
2021-06-19 23:33:38 +02:00
Treeston
88c1739e3e
Core/Movement: Creatures' idle movement generator can no longer override player mover control.
...
Tagging #20310 , partial fix.
(cherry picked from commit d02f481d9a
2021-06-19 23:33:38 +02:00
ariel-
a24af55d13
Core/Scripts: implemented Combined Toxins proc only from poisons
...
(cherry picked from commit 477878630e
2021-06-19 23:33:38 +02:00
ariel-
c21dc3c1b7
Core/Auras: fix periodic ticks proc after previous commit
...
(cherry picked from commit 9d0e90829c
2021-06-19 23:33:38 +02:00
ariel-
91fa279bdf
Core/Spells: require phasemask set for periodic damage procflag
...
Closes #21379
(cherry picked from commit b42ade918a
2021-06-19 23:33:38 +02:00
jackpoz
cb0672081e
Core/Player: Add some asserts
...
Assert PlayerInfo for race/class pair in a few Player functions
(cherry picked from commit 3576a38f6c
2021-06-19 23:33:38 +02:00
jackpoz
e63c5f7b0c
Scripting/Obsidian Sanctum: Fix crash
...
Fix crash caused by calling Reset() in constructor (which is not allowed)
(cherry picked from commit 5aba5c7aff
2021-06-19 23:33:38 +02:00
Killyana
0b5bd43f34
DB/SAI: Mire Hydra
...
(cherry picked from commit 201b0b3720
2021-06-19 23:33:38 +02:00
Killyana
f2c36b8634
DB: Fix some DB errors
...
Ref 3acd9a7c4fe4817aa822
2021-06-19 23:33:38 +02:00
jackpoz
66f7e57990
Shared/Database: Improve dead-lock error handling
...
Improve dead-lock error handling in async transactions by retrying the transaction for up to 60 seconds instead of just 5 times
(cherry picked from commit 54b0b8f5ea
2021-06-19 23:33:38 +02:00
Killyana
c72fe6a972
DB/Creature: Arcatraz Sentinel
...
Updates #21156
(cherry picked from commit 6952d0a5ea
2021-06-19 23:33:37 +02:00
Treeston
e8754cbdaf
Scripts/Instance: Transition Gnomeregan to boss states (instance spawn group prep)
...
(cherry picked from commit a4fc32dd86
2021-06-19 23:33:37 +02:00
Keader
299f22e3fc
Scripts/Icecrown Citadel: Fixed Sindragosa spawn after grid unload
...
ty sirikfoll :)
(cherry picked from commit 2994abeae6
2021-06-19 23:33:37 +02:00
Treeston
ef710273d0
Game/AI: InvalidAIException internal cleanup
...
(cherry picked from commit b456915f9a
2021-06-19 23:33:34 +02:00
ariel-
3485cb38ed
Core/Spells: remove 'Vanish Purge' hack, the spell is present on DB and is copy of one in vanilla DBC
...
Thanks to killerwife for the heads-up
(cherry picked from commit 303efcf0e4
2021-06-19 23:33:25 +02:00
Killyana
a22ffcc18a
DB: Fix the previous commit
...
(cherry picked from commit b4c16971cb
2021-06-19 23:33:25 +02:00
Killyana
328f6f4873
DB/Creature: Remove Tamed Sporebat spawns, summoned as pets by other npcs
...
(cherry picked from commit 3acd9a7c4f
2021-06-19 23:33:25 +02:00
ZenoX92
91f1c0b89c
DB/Gossip: Zorbin Fandazzle
...
Closes #21369
(cherry picked from commit 23dd63da98
2021-06-19 23:33:25 +02:00
ZenoX92
4be4e542cd
DB/Quest: Zapped Giants
...
Closes #21370
(cherry picked from commit fa1db68fec
2021-06-19 23:33:25 +02:00
