Commit Graph

22263 Commits

Author SHA1 Message Date
ForesterDev
3e54e798e6 Core/Opcodes: updated CMSG_SET_SHEATHED to new packet class (#24393)
* Core/Packets: Added SMSG_LEARNED_SPELLS packet

(cherry picked from commit 51026f28bd)

Co-authored-by: chemicstry <chemicstry@gmail.com>

* Core/Opcodes: updated CMSG_SET_SHEATHED to new packet class

(cherry picked from commit 7eb02e945f)

# Conflicts:
#	src/server/game/Entities/Unit/Unit.cpp
#	src/server/game/Handlers/CombatHandler.cpp
#	src/server/game/Server/Packets/CombatPackets.cpp
#	src/server/game/Server/Packets/CombatPackets.h
#	src/server/game/Server/Protocol/Opcodes.cpp

* rename opcode name CMSG_SETSHEATHED -> CMSG_SET_SHEATHED

* Revert "Core/Packets: Added SMSG_LEARNED_SPELLS packet"

This reverts commit 7beefdfb162f503067a519193f704ac15809779f.

Co-authored-by: chemicstry <chemicstry@gmail.com>
2020-04-11 19:48:16 +02:00
Sorikoff
194691f7c3 Scripts/Pets: Mojo (#24431)
* Mojo

* Update

* Rename 9999_99_99_99_world.sql to 2020_04_11_01_world.sql

Co-authored-by: Giacomo Pozzoni <giacomopoz@gmail.com>
2020-04-11 19:47:09 +02:00
NoName
f9d9440577 Core/PacketIO: Updated CMSG_REQUEST_PET_INFO (#24420)
cherry-picked fd162fb604

Co-authored-by: Carbenium <carbenium@outlook.com>
2020-04-11 18:49:44 +02:00
jackpoz
9cde3ffd14 Core/Pools: Fix crash on startup 2020-04-11 18:17:38 +02:00
Giacomo Pozzoni
4f33fd3932 Core/Pooling: Remove respawn times from the database when despawning a pool (#24422)
* Core/Pooling: Remove respawn times from the database when despawning a pool

Remove respawn times from the database when despawning a pool. This is needed when a Game Event ends but there are still some respawn times saved in the database.

* Remove respawn time of active pool objects even if they are not spawned
2020-04-11 14:07:57 +02:00
jackpoz
eb31ae9b18 Core/Misc: Fix linux build 2020-04-11 11:45:44 +02:00
jackpoz
9c9f4d6d20 Core/Unit: Ceil damage instead of rounding it
a0d5088850 followup, use std::ceil instead of std::round . This ensures at least 1 damage point will be done after applying armor reducing.
2020-04-10 23:24:29 +02:00
Killyana
d0f9ace679 Creature: Gorkun Ironskull & Martin Victus in The Pit of Saron
Still some events are missing in this instance
2020-04-10 20:05:26 +02:00
Shauren
f57b1e27d0 Scripts/Eye of Eternity: Fixed The Focusing Iris not respawning on wipe
Closes #22948
2020-04-10 17:08:25 +02:00
Shauren
18b36734f6 Core/Spells: Fixed checking free inventory space for some spells that have bad dbc data
Closes #24423
2020-04-10 16:38:50 +02:00
jackpoz
a0d5088850 Core/Unit: Round damage instead of truncating it
Round damage instead of truncating it when calculating armor-reduced damage. This fixes some level 1 creatures doing 0 damage (displayed as "Miss" ingame)
2020-04-10 00:11:54 +02:00
Giacomo Pozzoni
90b00288c2 Core/SAI: Allow SMART_TARGET_ACTION_INVOKER to target GameObjects (#24416)
* Core/SAI: Allow SMART_TARGET_ACTION_INVOKER to target GameObjects

* Include new Coalesce(..) template by @Shauren
2020-04-09 11:59:10 +02:00
NoName
566dcfc518 Core/PacketIO: Updated CMSG_DISMISS_CRITTER (#24412)
based on cherry-pick 6fbfc61de1

Co-authored-by: Carbenium <carbenium@outlook.com>
2020-04-08 21:35:01 +02:00
jackpoz
31018c3652 Core/Log: Log all character kicks to "network.kick" category 2020-04-08 21:05:01 +02:00
jackpoz
68fcd592f8 Core/NetworkIO: Adjust more packet throttling values
Thanks @Nefertumm at f5e38a7f57 for the heads-up
2020-04-08 17:43:07 +02:00
jackpoz
67f28adaf7 Core/Movement: Add safety check to avoid C++ undefined behaviour 2020-04-08 14:15:49 +02:00
Shauren
579d41acc5 Core/DBLayer: Fix compilation with mysql 8 2020-04-08 09:44:52 +02:00
Ovah
bea850fb73 Core/Objects: cache current liquid status of objects when updating position data and use it to replace unnecessary vmap lookups (#24399)
* dropped unneeded IsUnderwater override for players since the default position data update considers collision height already so we don't have to rely on that tempfix anymore. This actually fixes breathing bars showing up depending on your characters size (gnomes get their breathing bar earlier, taurens later etc)
2020-04-07 23:28:44 +02:00
myuzhobcplidtkieno
ae553f8966 Added the ability to use TLS when connecting to a database. (#24348)
* Added the ability to use TLS when connecting to a database.

* Trying to kickstart CI checks

* Revert the kickstart change

Co-authored-by: myuzhobcplidtkieno <myuzhobcplidtkieno@github.com>
Co-authored-by: Giacomo Pozzoni <giacomopoz@gmail.com>
2020-04-07 22:08:28 +02:00
ForesterDev
97405ceb01 Core/PacketIO: Updated SMSG_LOGIN_VERIFY_WORLD (#24395)
(cherry picked from commit 7256c7c2c7)

Co-authored-by: Shauren <shauren.trinity@gmail.com>
2020-04-06 15:18:36 +02:00
Lewis Brumby
caf4c4cf2b Update AuthSession.cpp (#24397) 2020-04-06 00:36:56 +02:00
jackpoz
0844ad2ff0 Scripts/Guards: Fix spell cast spam after killing npc_air_force_bots guards 2020-04-05 20:23:46 +02:00
jackpoz
cb41c8828f Core/Misc: Replace tabs with spaces 2020-04-05 19:11:01 +02:00
jackpoz
caae3886d2 Core/Misc: Remove whitespace at the end of lines 2020-04-05 19:11:00 +02:00
Giacomo Pozzoni
3def52c1c4 Core/Logs: Log full guid instead of just low guid, part 2 2020-04-05 19:10:58 +02:00
Giacomo Pozzoni
468ecb7252 Core/Logs: Log full guid instead of just low guid 2020-04-05 19:10:57 +02:00
NoName
fbcd244b2f Core/PacketIO: Handle CMSG_REQUEST_PET_INFO for more cases (#24364)
+ vehicle
+ charm
+ possession

from 87c6cc19e5
2020-04-05 14:53:23 +02:00
jackpoz
d1f9cf84a5 Core/Battleground: Attempt to fix a crash
Please report this error if you get it
2020-04-04 19:50:53 +02:00
ForesterDev
5d70f6ccd4 Core/Packets: update & enabled CMSG_SHOWING_CLOAK, CMSG_SHOWING_HELM (#24394)
(cherry picked from commit a47d57d1db)

Co-authored-by: DJScias <zumbak04@gmail.com>
2020-04-04 18:34:43 +02:00
Rushor
3da8f37ddb Scripts/BlackfathomDeeps: Kelris will now channel his spell (#24300)
* Scripts/BlackfathomDeeps: Kelris will now channel his spell

* Scripts/BlackfathomDeeps: Kelris will now channel his spell
2020-04-04 15:38:23 +02:00
Jozef Dúc
936ff574c5 Fixes #22884 (#24338)
Fix issue 22884 with non stacking necrotic plague debuff after dispell//death
2020-04-04 15:30:55 +02:00
Sorikoff
264a583903 Scripts/Pet: Baby Blizzard Bear & Egbert (#24349)
* Baby Blizzard Bear & Egbert

* SQL

* Update 9999_99_99_99_world.sql

SQL fix

* Rename 9999_99_99_99_world.sql to 2020_04_04_00_world.sql

Co-authored-by: Eridium <6587064+Killyana@users.noreply.github.com>
Co-authored-by: Giacomo Pozzoni <giacomopoz@gmail.com>
2020-04-04 15:29:21 +02:00
Sorikoff
a513922fc1 Core/DB: Add DB error for missing gossip npcflag (#24375)
* Add DB error for missing npcflag

* Improvements

* Update ObjectMgr.cpp

Co-authored-by: Giacomo Pozzoni <giacomopoz@gmail.com>
2020-04-04 15:27:42 +02:00
Eridium
0e2342c169 Core/Movement: Formation Rewrite (#24379)
* Core/Movement: Formation Rewrite

* Add a missing include

* fixed another warning

* meh

Co-authored-by: Ovahlord <Ovahlord@users.noreply.github.com>
Co-authored-by: Ovah <dreadkiller@gmx.de>
2020-04-04 15:08:42 +02:00
ForesterDev
0f506f0dea Core/Locales: Optimize locale loading - move the strings (#24385)
* Core/Locales: Optimize locale loading - move the strings

(cherry picked from commit 5dd686c080)
Signed-off-by: ForesterDev <gmmunchkinbox@gmail.com>

# Conflicts:
#	src/server/game/Globals/ObjectMgr.cpp

* Fix AchievementReward locales build

Co-authored-by: Shauren <shauren.trinity@gmail.com>
2020-04-04 15:05:00 +02:00
Keader
ed1520bda1 Script/Spells: Fixed some codestyle issues of previous commit 2020-04-03 14:00:46 -03:00
Alan Deutscher
2b1b36f561 Scripts/Spells: prevent Drain Soul from cancelling prematurely (#24378)
More info at https://github.com/TrinityCore/TrinityCore/pull/24390#issue-398263036
2020-04-03 13:57:20 -03:00
Jozef Dúc
e61c54dce8 Scripts/Spells: Fixed Bloodlust duplicated hook call 2020-04-03 12:51:17 -03:00
Lewis Brumby
b48c50ba23 Update action_ip_logger.cpp (#24371) 2020-03-31 22:49:18 +02:00
jackpoz
ac61dc6153 Core/DBLayer: Remove unused class forward declarations 2020-03-31 22:13:09 +02:00
Shauren
f7a67099d4 Core/DBLayer: Prevent mixing databases with query holders
(cherry picked from commit 13440434c3)

# Conflicts:
#	src/server/game/Server/WorldSession.cpp
#	src/server/game/Server/WorldSession.h
2020-03-31 13:42:01 +00:00
Shauren
635b8d52d5 Core/DBLayer: Prevent committing transactions started on a different database
(cherry picked from commit f6e2b8cdc1)

# Conflicts:
#	src/server/bnetserver/REST/LoginRESTService.cpp
#	src/server/database/Database/DatabaseWorkerPool.cpp
#	src/server/database/Database/DatabaseWorkerPool.h
#	src/server/database/Database/Implementation/HotfixDatabase.h
#	src/server/database/Database/MySQLConnection.h
#	src/server/database/Database/Transaction.cpp
#	src/server/database/Database/Transaction.h
#	src/server/game/Achievements/AchievementMgr.cpp
#	src/server/game/Achievements/AchievementMgr.h
#	src/server/game/AuctionHouse/AuctionHouseMgr.cpp
#	src/server/game/AuctionHouse/AuctionHouseMgr.h
#	src/server/game/BattlePets/BattlePetMgr.cpp
#	src/server/game/BattlePets/BattlePetMgr.h
#	src/server/game/BlackMarket/BlackMarketMgr.cpp
#	src/server/game/BlackMarket/BlackMarketMgr.h
#	src/server/game/Entities/Creature/Creature.cpp
#	src/server/game/Entities/Item/Item.cpp
#	src/server/game/Entities/Item/Item.h
#	src/server/game/Entities/Player/CollectionMgr.cpp
#	src/server/game/Entities/Player/CollectionMgr.h
#	src/server/game/Entities/Player/Player.cpp
#	src/server/game/Entities/Player/Player.h
#	src/server/game/Garrison/Garrison.cpp
#	src/server/game/Garrison/Garrison.h
#	src/server/game/Groups/Group.cpp
#	src/server/game/Guilds/Guild.cpp
#	src/server/game/Guilds/Guild.h
#	src/server/game/Guilds/GuildFinderMgr.cpp
#	src/server/game/Handlers/BlackMarketHandler.cpp
#	src/server/game/Handlers/CalendarHandler.cpp
#	src/server/game/Handlers/CharacterHandler.cpp
#	src/server/game/Handlers/MailHandler.cpp
#	src/server/game/Handlers/PetHandler.cpp
#	src/server/game/Handlers/PetitionsHandler.cpp
#	src/server/game/Mails/Mail.cpp
#	src/server/game/Pools/PoolMgr.cpp
#	src/server/game/Quests/QuestObjectiveCriteriaMgr.cpp
#	src/server/game/Quests/QuestObjectiveCriteriaMgr.h
#	src/server/game/Scenarios/InstanceScenario.cpp
#	src/server/game/Server/WorldSession.cpp
#	src/server/game/Server/WorldSession.h
#	src/server/game/Spells/SpellHistory.cpp
#	src/server/game/Support/SupportMgr.cpp
#	src/server/game/Tools/PlayerDump.cpp
#	src/server/scripts/Commands/cs_misc.cpp
2020-03-31 13:42:01 +00:00
Shauren
fe1003bdbd Core/DBLayer: Prevent using prepared statements on wrong database
(cherry picked from commit e8e89f58fb)

# Conflicts:
#	src/server/bnetserver/REST/LoginRESTService.cpp
#	src/server/bnetserver/Server/Session.cpp
#	src/server/database/Database/DatabaseWorkerPool.cpp
#	src/server/database/Database/Implementation/HotfixDatabase.h
#	src/server/database/Database/MySQLConnection.cpp
#	src/server/database/Database/MySQLConnection.h
#	src/server/database/Database/PreparedStatement.cpp
#	src/server/database/Database/PreparedStatement.h
#	src/server/database/Database/QueryHolder.cpp
#	src/server/database/Database/SQLOperation.h
#	src/server/database/Database/Transaction.h
#	src/server/game/Accounts/BattlenetAccountMgr.cpp
#	src/server/game/Achievements/AchievementMgr.cpp
#	src/server/game/AuctionHouse/AuctionHouseMgr.cpp
#	src/server/game/AuctionHouseBot/AuctionHouseBot.cpp
#	src/server/game/AuctionHouseBot/AuctionHouseBotBuyer.cpp
#	src/server/game/BattlePets/BattlePetMgr.cpp
#	src/server/game/Battlegrounds/ArenaTeam.cpp
#	src/server/game/BlackMarket/BlackMarketMgr.cpp
#	src/server/game/Chat/Channels/Channel.cpp
#	src/server/game/Entities/Corpse/Corpse.cpp
#	src/server/game/Entities/Creature/Creature.cpp
#	src/server/game/Entities/GameObject/GameObject.cpp
#	src/server/game/Entities/Item/Item.cpp
#	src/server/game/Entities/Pet/Pet.cpp
#	src/server/game/Entities/Player/CollectionMgr.cpp
#	src/server/game/Entities/Player/Player.cpp
#	src/server/game/Garrison/Garrison.cpp
#	src/server/game/Globals/ObjectMgr.cpp
#	src/server/game/Groups/Group.cpp
#	src/server/game/Guilds/Guild.cpp
#	src/server/game/Guilds/GuildFinderMgr.cpp
#	src/server/game/Guilds/GuildMgr.cpp
#	src/server/game/Handlers/AuctionHouseHandler.cpp
#	src/server/game/Handlers/CharacterHandler.cpp
#	src/server/game/Handlers/ItemHandler.cpp
#	src/server/game/Handlers/MailHandler.cpp
#	src/server/game/Handlers/MiscHandler.cpp
#	src/server/game/Handlers/PetitionsHandler.cpp
#	src/server/game/Handlers/SpellHandler.cpp
#	src/server/game/Handlers/TicketHandler.cpp
#	src/server/game/Loot/Loot.cpp
#	src/server/game/Mails/Mail.cpp
#	src/server/game/Maps/Map.cpp
#	src/server/game/Movement/Waypoints/WaypointManager.cpp
#	src/server/game/OutdoorPvP/OutdoorPvP.cpp
#	src/server/game/Pools/PoolMgr.cpp
#	src/server/game/Quests/QuestObjectiveCriteriaMgr.cpp
#	src/server/game/Reputation/ReputationMgr.cpp
#	src/server/game/Scenarios/InstanceScenario.cpp
#	src/server/game/Server/WorldSession.cpp
#	src/server/game/Server/WorldSocket.cpp
#	src/server/game/Spells/SpellHistory.cpp
#	src/server/game/Support/SupportMgr.cpp
#	src/server/game/Tools/PlayerDump.cpp
#	src/server/game/World/World.cpp
#	src/server/scripts/Commands/cs_account.cpp
#	src/server/scripts/Commands/cs_ban.cpp
#	src/server/scripts/Commands/cs_battlenet_account.cpp
#	src/server/scripts/Commands/cs_group.cpp
#	src/server/scripts/Commands/cs_lfg.cpp
#	src/server/scripts/Commands/cs_list.cpp
#	src/server/scripts/Commands/cs_message.cpp
#	src/server/scripts/Commands/cs_misc.cpp
#	src/server/scripts/Commands/cs_npc.cpp
#	src/server/scripts/Commands/cs_tele.cpp
#	src/server/scripts/Commands/cs_wp.cpp
#	src/server/shared/DataStores/DB2DatabaseLoader.cpp
#	src/server/shared/Realm/RealmList.cpp
2020-03-31 13:42:01 +00:00
ForesterDev
3c8622dd83 Core/PacketIO: updated spell "cancel" opcodes to new packet class (#24342)
CMSG_CANCEL_CAST, CMSG_CANCEL_AURA, CMSG_PET_CANCEL_AURA,CMSG_CANCEL_GROWTH_AURA, CMSG_CANCEL_MOUNT_AURA, CMSG_CANCEL_AUTO_REPEAT_SPELL and CMSG_CANCEL_CHANNELLING.
2020-03-30 17:21:40 +02:00
ForesterDev
c2a76efdca Core/Packets: Added SMSG_WORLD_STATE_UI_TIMER_UPDATE (#24312)
(cherry picked from commit 7d88f8c491)

# Conflicts:
#	src/server/game/Handlers/MiscHandler.cpp
#	src/server/game/Server/Protocol/Opcodes.cpp
#	src/server/game/Server/Protocol/Opcodes.h
2020-03-30 17:20:09 +02:00
Ovah
61aec37b4f Core/Spells: fixed a possible client crash when casting pull towards dest spells with misc value 0 (#24365)
* This case is not happening in 335 yet as it barely has any spell with pull towardst dest effects. However, this is very well present in 4.x and beyond so let's add it for future cherrypicks
2020-03-29 21:23:53 +02:00
jackpoz
9244742527 Revert "Core/AI: Fix reset and interruption of non melee spells"
This reverts commit cc0c56ceae.
2020-03-29 21:00:08 +02:00
Killyana
c026b3bad3 Boss/Script: Disable Call assistance for Mr Smite
Closes #19164
2020-03-29 18:44:43 +01:00
Killyana
5b2b221177 Boss/Script: Mr Smith will use the proc aura for Nimble Reflexes instead a script 2020-03-29 17:46:08 +01:00
Killyana
cc0c56ceae Core/AI: Fix reset and interruption of non melee spells 2020-03-22 16:11:19 +01:00