Commit Graph

12735 Commits

Author SHA1 Message Date
click
409ebcca97 Core: Send SSL and ACE version in all logging detailmodes, not just when set in the config 2012-03-31 23:50:32 +02:00
Shocker
37840a882f Merge pull request #5964 from GyxTom/master
Core/Misc: Code style and some rewriting
2012-03-31 14:10:14 -07:00
Nay
0b645a825d Core/DBLayer: More type fixes 2012-03-31 17:47:18 +01:00
Nay
e3ae7ba498 Core/Config: Add SQLDriverQueryLogging to authserver.conf (disabled by default, just like worldserver) 2012-03-31 16:31:42 +01:00
Nay
91c7b5d2ca Core/DBLayer: Delete a triplicated prepared statement (LoginDatabase)
Thanks to Anubiss for spotting it
2012-03-31 15:48:40 +01:00
Nay
c71f75e9ca Core/Logging: Fix a typo in DebugLogFilters - Database & AI
Thanks to Garthog for finding it
2012-03-31 15:13:56 +01:00
Shauren
68fdf2a12f Core/DBLayer: Added missing prepared statement implementation for uint8/16 2012-03-31 14:16:48 +02:00
Gyx
d9088c083c Core/Script: Code style and some rewriting.
JustDied(Unit* Killer) -> JustDied(Unit* killer)
JustDied(Unit* /*Killer*/) -> JustDied(Unit* /*killer*/)
JustDied(Unit* /*unit*/) -> JustDied(Unit* /*killer*/)
JustDied(Unit* /*slayer*/)) -> JustDied(Unit* /*killer*/)
JustDied(Unit* /*victim*/) -> JustDied(Unit* /*killer*/)
JustDied(Unit* victim) -> JustDied(Unit* killer)
JustDied(Unit* /*who*/) -> JustDied(Unit* /*killer*/)
JustDied(Unit* who) -> JustDied(Unit* killer)
JustDied(Unit*) -> JustDied(Unit* /*killer*/)

Signed-off-by: Gyx <2359980687@qq.com>
2012-03-31 18:56:37 +08:00
click
280f88db6b Merge pull request #5649 from Elron103/pull-requests2
Core/Movement: Fix random position finding near edges, avoid big z-coordinate differences
2012-03-30 18:14:58 -07:00
Shocker
b292437989 Merge pull request #5933 from GyxTom/master
Core/Misc: Code style and remove unused define
2012-03-30 14:49:44 -07:00
Shocker
3fb947d955 Merge pull request #5903 from Warpten/ringOfValor
Core/Battlegrounds: Fire lines in Ring of Valor should only be lit when the arena battle begins
2012-03-30 14:46:45 -07:00
Gyx
ba2ee48fc6 Core/Script: Code style(Missing?).
Signed-off-by: Gyx <2359980687@qq.com>
2012-03-30 10:39:33 +08:00
Shauren
5843851559 Core/DBLayer: More prepared statement corrections 2012-03-29 23:22:10 +02:00
Shauren
3ba43cc08a Core/DBLayer: More type fixes
Closes #5936
2012-03-29 18:30:25 +02:00
Kandera
4a0085ad2c Core/DBLayer: more type fixes 2012-03-29 12:21:38 -04:00
leak
5e58905aa0 Core/DBLayer: More types fixes 2012-03-29 17:43:23 +02:00
click
411699b94d Core/DBLayer: Fix stupid mishap from last commit (i need glasses) - thanks nayd for poking me about it 2012-03-29 16:41:42 +02:00
click
af6c70cf99 Core/DBlayer: ... and some more COUNT()-based type-fixing ... 2012-03-29 16:33:54 +02:00
Nay
92d3548f0b Core/DBLayer: Even more types fixes... 2012-03-29 15:08:17 +01:00
click
f80f94809c Core/Group: Fix LoadGroupFromDB type-error 2012-03-29 15:13:19 +02:00
click
766475ea4f Core/Guild: Fix guildbank tab loading after recent changes (returned value of a COUNT() is always BIGINT) 2012-03-29 14:41:55 +02:00
Shauren
022143460a Core/DBLayer: Fixed some crashes caused by incorrect prepared statements usage
Closes #5934
2012-03-29 11:30:37 +02:00
Gyx
391d68be20 Core/Script: Code style.
WaypointReached(uint32 i) -> WaypointReached(uint32 waypointId)
WaypointReached(uint32 uiPointId) -> WaypointReached(uint32 waypointId)
WaypointReached(uint32 /*point*/) -> WaypointReached(uint32 /*waypointId*/)
WaypointReached(uint32 uiI) -> WaypointReached(uint32 waypointId)
WaypointReached(uint32 /*i*/) -> WaypointReached(uint32 waypointId)
WaypointReached(uint32 uiWPointId) -> WaypointReached(uint32 waypointId)
WaypointReached(uint32 /*wp*/) -> WaypointReached(uint32 waypointId)
WaypointReached(uint32 /*point*/) -> WaypointReached(uint32 waypointId)

Signed-off-by: Gyx <2359980687@qq.com>
2012-03-29 15:44:24 +08:00
Gyx
5b7493fc66 Core/Misc: Code style and remove unused define.
Signed-off-by: Gyx <2359980687@qq.com>
2012-03-29 14:43:34 +08:00
Gyx
360014856d Core/Game: Code style.
Signed-off-by: Gyx <2359980687@qq.com>
2012-03-29 13:42:04 +08:00
click
b5fb1b5b64 Core: Fix a minor mistake from previous mistake and adjust some more field-types 2012-03-29 07:10:21 +02:00
click
0ce62a159d Core: Fix type-mismatch in GameEventMgr 2012-03-29 05:23:01 +02:00
click
c65cabb33c Core: Fix some type-errors in the Petitionshandler. Fixes #5916.
Also fixes charterhandling for arenateams, mentioned in #5907.
2012-03-29 05:08:32 +02:00
click
be947eed76 Core: Fix fieldtype-errors in Guild-code - should now allow loading guildtabs etc correctly 2012-03-29 04:45:10 +02:00
click
40c35b095c Core: Adjust fieldtype size for loading completed achievements 2012-03-29 04:09:02 +02:00
click
5e795a61e8 Core/Warden: Fix a startupcrash with warden enabled (another fieldtype-error) 2012-03-29 03:43:46 +02:00
Shocker
a08cb234c0 Merge pull request #5918 from GyxTom/master
Core/Misc: Various cleanups
2012-03-28 18:00:42 -07:00
kaelima
72d3e856de Core/Grid: revert f9caf79b16 - led to some unexpected behavior. 2012-03-29 02:56:18 +02:00
click
cf29214364 Core/AI: Fix some wannabe-invinceable typos here and there... 2012-03-29 00:47:56 +02:00
kandera
d94608777c Core/Scripts: Fix invincibility hp level for smart scripts. 2012-03-28 19:21:40 -03:00
leak
a14aa37585 Core/DBLayer: Fix value list from recent changes 2012-03-28 21:34:26 +02:00
leak
7309ee5621 SQL: Auth db data type cleanup logs, realmcharacters, realmlist, uptime / Storage engine switched to InnoDB Note:
As for the redundant `uptime`.`startstring` being removed, this page might be of interest how to generate time strings from unix timestamps
http://dev.mysql.com/doc/refman/5.1/en/date-and-time-functions.html#function_from-unixtime
2012-03-28 19:46:38 +02:00
click
6237ddac34 Partially revert a36a0a77ef.
Cleaning databases for old/deprecated and expired quests should never be a
developers choice specifically. This should be done by admins, not developers,
through the use of the already existing paramters found in the worldserver config :
CleanCharacterDB / PersistentCharacterCleanFlags

An adjustment to the respective questloader prepared statement has been done to
accomodate for the earlier change (by not loading such quests into memory at all).

Documentation for how this cleanup-procedures work already exists in the core :
doc/CharacterDBCleanup.txt.
2012-03-28 19:31:06 +02:00
Nay
007e9269fe Core/GameEventMgr: Fix a compile warning 2012-03-28 18:56:22 +02:00
Kandera
6763c23777 Core/Spells: attempt to fix penance doing nothing on "friendly" non faction targets. should return invalid targets 2012-03-28 08:29:42 -04:00
Gyx
1544b208da Core/Game: Code style again.
Signed-off-by: Gyx <2359980687@qq.com>
2012-03-28 20:00:29 +08:00
Gyx
72cdcbfced Core/Game: Code style.
Signed-off-by: Gyx <2359980687@qq.com>
2012-03-28 19:11:50 +08:00
Machiavelli
e95d614f52 Core/Misc: Prevent calling ACE_Task_Base::wait() on an invalid handle. WorldSocketMgr::Wait is already called in WorldRunnable post-service hook 2012-03-28 12:50:02 +02:00
Machiavelli
cc0448a017 Core/Battleground/SOTA: Initialize uninitialized variables.
Fixes:

==8111== Conditional jump or move depends on uninitialised value(s)
==8111==    at 0x12B542C: BattlegroundSA::FillInitialWorldStates(WorldPacket&) (BattlegroundSA.cpp:421)
==8111==    by 0xF93CD9: Player::SendInitWorldStates(unsigned int, unsigned int) (Player.cpp:9664)'

And similar.
2012-03-28 13:17:45 +03:00
Machiavelli
91228d2711 Core/Player: Similarly initialize m_SeasonalQuestChanged
Fixes:

==8111== Conditional jump or move depends on uninitialised value(s)
==8111==    at 0xFB7C42: Player::_SaveSeasonalQuestStatus(Trinity::AutoPtr<Transaction, ACE_Thread_Mutex>&) (Player.cpp:19375)
==8111==    by 0xFB56BA: Player::SaveToDB(bool) (Player.cpp:18898)
2012-03-28 13:07:37 +03:00
Machiavelli
c3db19b80b Core/Player: Initialize m_WeeklyQuestChanged
Fixes:

==8111== Conditional jump or move depends on uninitialised value(s)
==8111==    at 0xFB7AD2: Player::_SaveWeeklyQuestStatus(Trinity::AutoPtr<Transaction, ACE_Thread_Mutex>&) (Player.cpp:19352)
2012-03-28 13:06:02 +03:00
Gyx
a20fa23ea6 Core/Script: Code style and remove unused core.
Signed-off-by: Gyx <2359980687@qq.com>
2012-03-28 15:15:48 +08:00
Gyx
e050945c91 Core/Script: Code style and remove unused core.
Signed-off-by: Gyx <2359980687@qq.com>
2012-03-28 11:13:37 +08:00
kaelima
6613cbafa6 Core/Protocol:
- Correct the use of first byte in SMSG_NAME_QUERY_RESPONSE
- Send guid and name in SMSG_CHAR_RENAME for failing results too
2012-03-28 04:02:02 +02:00
kaelima
820f45c424 Core/Protocol:
- Correct and rename response message from creating/updating a ticket
- Prevent some trailing data in CMSG_GMTICKET_CREATE and add comment on stuff missing from its structure.
- Random cleanup
2012-03-28 03:59:03 +02:00