Commit Graph

2017 Commits

Author SHA1 Message Date
MitchesD
43d5d118b2 Core/Misc: fix warning and misc codestyle fixes
(cherry picked from commit 3b90b0368a)
2016-01-15 19:57:34 +01:00
treeston
bac8c4376f Scripts/Naxxramas: Thaddius follow-up:
- Reduce initial spawn timer on the encounter from 30 seconds to 5 seconds
- Rearrange respawn logic to fix the "petrified" visual from not showing properly
- Fix a potential infinite respawn loop that could prevent the encounter from initializing properly (fixes and closes #15898)

(cherry picked from commit bf99630399)
2016-01-15 19:54:49 +01:00
Carbenium
0b0b014fad Script/Naxxramas: Fix a -Winconsistent-missing-override warning reported by clang 3.6
(cherry picked from commit f01ef901ef)
2016-01-15 19:45:24 +01:00
tkrokli
b1a5b9ac75 Scripts/Thaddius: Coverity scan Control flow issues (MISSING_BREAK)
Coverity scan defects CID 1339315, 1339316 and 1339317:
- CID 1339315: boss_thaddius.cpp: 542
- CID 1339316: boss_thaddius.cpp: 811
- CID 1339317: boss_thaddius.cpp: 398

Added missing break; statements.

(cherry picked from commit 95d6f09243)
2016-01-15 19:44:38 +01:00
treeston
43ae580a47 Scripts/Naxxramas: Complete rewrite of the Thaddius encounter.
(cherry picked from commit 29feae5901)
2016-01-15 19:43:42 +01:00
Vincent-Michael
478cc756eb Update copyright note for 2016
Happy new year (Again new year with idiots ...)
2016-01-01 00:34:25 +01:00
jackpoz
baa52438e6 Scripts/EyeOfEternity: Fix crash
Fix crash happening when a player would kill a Melee npc on the disks during Malygos fight and mount it before it ended the waypoint path.
Close #15900

(cherry picked from commit 6e296ddaa2)
2015-12-12 03:08:16 +01:00
Vincent-Michael
00b4e8b6cc Scripts: Added missing overrides 2015-11-15 03:38:02 +01:00
Carbenium
230e820898 Core/Creature: Remove duplicate call to LoadCreatureAddons in Creature::Create
* Add error log for duplicated aura entries in creature_(template_)addon

(cherry picked from commit c5f635b689)

Conflicts:
	src/server/game/Entities/Creature/Creature.cpp
	src/server/game/Globals/ObjectMgr.cpp
2015-11-14 04:22:42 +01:00
Killyana
286f0ea6f3 Scripts/ICC: moved saurfang gossips to db
Closes #14904

(cherry picked from commit 7225b7abf1)
2015-11-06 13:17:54 +01:00
MitchesD
81ce5acb34 Core/Scripts: fix build after recent cherry picks 2015-11-06 11:28:35 +01:00
sirikfoll
d4b3b1d1d2 DB/CORE Minor change in quest Kick, What Kick? and some codestyle
Remove the line that despawns the 'Apple' npc, this despawn is non-blizzlike and breaks the quest.
Thx Killyana for sql and valuable information

Closes #15480

(cherry picked from commit 22f1d26986)
2015-11-06 11:11:16 +01:00
treeston
6d14c4871f Scripts/Naxxramas: Anub'rekhan encounter cleanup.
- Cleaned up events behavior to use phases instead of weird checks for auras.
- Cleaned up Crypt Guard despawn behavior, they should no longer despawn instantly upon death.
- Moved initial greeting from MoveInLineOfSight hack to proper areatrigger script.
- Fixed Crypt Guard respawn behaviour to prevent pulling them before Anub'rekhan has fully reset.
- Fixed Crypt Guard aggro behaviour to call for help on aggro. This prevents pulling the initial pair of Crypt Guards without engaging the boss.
- Added missing boss emotes.
- Code style cleanup.

(cherry picked from commit 91de0322bb)

# Conflicts:
#	src/server/scripts/Northrend/Naxxramas/boss_anubrekhan.cpp
2015-11-06 11:07:31 +01:00
treeston
b6ac8c577c Scripts/Naxxramas: Faerlina cleanup:
- Move greeting to areatrigger instead of MoveInLineOfSight hack
- Clean up add spawn handling to prevent various glitching with combinations of evade state and add aggro
- Ensure all adds are always pulled alongside the boss and vice versa
- Add missing texts.
- Fix a bug in the core that prevents castable-while-dead spells (such as Widow's Embrace) from appearing on possess bars.

(cherry picked from commit 577fcf356e)

# Conflicts:
#	src/server/scripts/Northrend/Naxxramas/boss_faerlina.cpp
2015-11-06 10:59:34 +01:00
jackpoz
5f5ac9630c Scripts/Naxxramax: Fix clang warning
(cherry picked from commit da0671f4fe)
2015-11-06 10:56:27 +01:00
Rushor
9483bd9180 Scripts/IcecrownCitadel: Quest 'Blood Quickening' - Add Killcredit in 25ManRaid
closes #15733

(cherry picked from commit c5641a9a58)
2015-11-06 10:35:29 +01:00
treeston
a37e6e20c8 Scripts/Naxxramas: Loatheb follow-up:
- Fix Deathbloom (for real this time)

(cherry picked from commit 17fdb1e091)
2015-11-06 09:54:40 +01:00
Naios
0b6f784591 Core/AI: Convert the hardcoded variadic RAND functions into one C++11 variadic template version. 2015-11-01 14:33:31 +01:00
joschiwald
92b08fc74b Scripts/VioletHold: rewrote the whole instance
thanks @MitchesD for help

(cherry picked from commit df21162fe4)
(cherry picked from commit 3a4f54197c)
(cherry picked from commit f50df72820)
(cherry picked from commit 95bae7143f)
(cherry picked from commit 5406f82044)
2015-11-01 13:09:30 +01:00
joschiwald
b459b10b0f Core/Scripts: fixed startup errors
Closes #14730

(cherry picked from commit 497aa4425b)

# Conflicts:
#	src/server/scripts/Northrend/Ulduar/Ulduar/boss_flame_leviathan.cpp
2015-10-30 14:01:26 +01:00
treeston
7886fafbdc Heigan cleanup:
- NearTeleportTo hack -> proper spell with DB coordinates
- Add boss emotes
- Some code streamlining using event phases and IN_MILLISECONDS instead of large constants
- Improvement to eruption hitbox and delimiters to match retail layout more closely
- Spell timers adjusted from sniffs

(cherry picked from commit 3e2014a958)
2015-10-30 12:24:26 +01:00
treeston
f3b5bdc0b3 Scripts/Naxxramas: Bugfixes to the Noth encounter.
- Added missing raid boss emotes
- Fixed an issue where Noth would stand idly after blinking if his current target stood still
- Fixed some reset edge cases
- Prevent Noth from dying during Balcony phase
- Fix targeting of 25-man Curse of the Plaguebringer (now has 8 targets, down from 10)
- Fix balcony/ground phase durations to be blizzlike
- Fix an issue where summoned mobs would sometimes not be aggroed automatically
- Get rid of ugly millisecond values in favor of seconds times constant
- Moved the chance to yell on kill to the database
- Prevent AoE abilities from hitting Noth during the balcony phase
- General cleanup of events handling
- Generally make @Nayd happy

(cherry picked from commit 3fc1bb1abf)

# Conflicts:
#	src/server/scripts/Northrend/Naxxramas/boss_noth.cpp
2015-10-30 11:46:37 +01:00
treeston
dba753b0ef Scripts/Naxxramas: Adjustments to the Loatheb encounter
- Adjusted doom cast timings as per boss mod timers.
- Add Deathbloom's final tick using spellscript
- Move Spores' Fungal Creep cast handling to Loatheb's cpp instead of handling it in SmartAI
- Fungal Creep should also be cast if the spore expires (important for Spore Loser achievement)
- Remove Fungal Creep from players on reset to avoid cheesy strats

(cherry picked from commit ea1c783b84)
2015-10-30 11:42:19 +01:00
treeston
12e90350e4 Script/BoreanTundra: Fix dialog and final waypoint for quest 11570: "Escape from the Winterfin Caverns"
This fixes the following bugs:

Escortee NPC quotes are out of order (see #15396 (comment))
Final escort waypoint is located incorrectly and causes the escorted NPC to drop all the way to the bottom of the ocean before quest completion is awarded.

Closes #15396

Signed-off-by: DDuarte <dnpd.dd@gmail.com>
(cherry picked from commit a83437af3d)
2015-10-20 15:39:42 +02:00
joschiwald
2bc4dea4da Core/Misc: renamed sGossipSelect parameters
(cherry picked from commit ad38c27124)

# Conflicts:
#	src/server/scripts/EasternKingdoms/ZulAman/zulaman.cpp
#	src/server/scripts/Kalimdor/zone_azshara.cpp
2015-10-16 11:56:53 +02:00
joschiwald
cf1e80e3d0 Core/Misc: removed some useless map checks 2015-10-04 14:53:05 +02:00
Shauren
3bc3b67a8f Core/Player: Changed ranged weapons to be equipped in main hand slot instead of no longer used ranged slot
Closes #14675
Closes #15296
2015-09-27 00:06:08 +02:00
Shauren
5cf28316ff Merge pull request #15503 from Treeston/3.3.5-patchwerk
Creature/BossAI/Patchwerk: Fix Hateful Strike behavior
(cherry picked from commit ce2aa49715)
2015-09-25 00:09:34 +02:00
treeston
888c4c07b6 Scripts/Naxxramas:
Fixed bugs with Sapphiron encounter:
- Sapphiron will now properly re-engage if the previous attempt ended while he was in flight.
- Sapphiron will now properly be hovering while in the air phase instead of standing idly on the ground.
- Move Frost Resistance achievement check from custom script to spell 60539 (Sapphiron Achievement Check), thanks to @Shauren for the heads up.

(cherry picked from commit a90ae075c9)
2015-09-25 00:07:34 +02:00
jackpoz
f2ca107fc8 Scripts/Ulduar: Fix issue reported by static analysis
Coverity defect ID: 1316690

(cherry picked from commit 4cdab0cdcb)
2015-09-25 00:06:30 +02:00
joschiwald
010b2182c1 Scripts/Ulduar: fixed sara get killed by guardians of yogg saron
(cherry picked from commit 2b21fbb58e)
2015-09-24 23:29:23 +02:00
joschiwald
a3732aea48 Scripts/Ulduar: fixed hodir kill credit
Closes #15303

(cherry picked from commit 30fc4f9f63)
2015-09-24 22:35:33 +02:00
jackpoz
0fad953852 Scripts/Misc: Replace some unsafe WorldObject* class members in scripts with ObjectGuid
Replace some unsafe WorldObject* class members and derived types in scripts with ObjectGuid.
Code cleanup.

(cherry picked from commit 2f92a2f58e)

Conflicts:
	src/server/scripts/Northrend/Nexus/Nexus/boss_keristrasza.cpp
2015-09-24 22:34:18 +02:00
jackpoz
6193b8a28d Scripts/Misc: Fix possible crash
Fix possible NULL-dereference exception happening in PlayerOrPet checks used in Ulduar and Temple Of Ahn Qiraj

(cherry picked from commit 5f0f152345)
2015-09-24 20:39:42 +02:00
joschiwald
d68e3325d5 Scripts/Ulduar/Algalon: fixed achievement "He Feeds On Your Tears"
Ref #6157
2015-09-20 16:03:48 +02:00
Shauren
f0e7ef1f9f Core/PacketIO: Exclude DamageDealt/DamageTaken script hook results from damage sent in SMSG_SPELL_NON_MELEE_DAMAGE_LOG 2015-08-10 17:46:31 +02:00
Shauren
fcc8c2d12c Core/PacketIO: Implemented advanced combat logging 2015-08-08 15:15:14 +02:00
Warpten
0dc6ea161d Scripts/RubySanctum: Widen random angles for meteor flames.
Don't QQ because "OMG you're not testing any of your stuff", I can't build TC atm.

Memo: Meteor Flames have
```
[12] UNIT_CREATED_BY_SPELL: 74689/1.046616E-40
```

which isn't in DBCs, exists, but is not seen in sniffs.
2015-07-28 16:05:09 +02:00
Aokromes
50c23bbcb8 Update boss_halion.cpp 2015-07-27 22:19:49 +02:00
Warpten
982b59d2ec Scripts/RubySanctum: Fixed Meteor Flames 2015-07-27 15:36:29 +02:00
Unholychick
f44364d72a Merge pull request #15164 from LuqJensen/mimiron
Scripts/Ulduar: Fix a visual issue with Mimirons Rocket Strike and Fix Mimiron DB target attacking players
(cherry picked from commit 66bbdfb82c)

Conflicts:
	sql/updates/world/2015_07_26_05_world.sql
2015-07-27 01:31:25 +01:00
joschiwald
2f2fcd2c3d Scripts/Ulduar: fixed freya loot and added missing conditions
thanks @Keader

Closes #15098

(cherry picked from commit 8a9f1b871a)

Conflicts:
	sql/updates/world/2015_07_25_04_world.sql
2015-07-25 19:16:24 +01:00
Warpten
8dd460c0d9 Scripts/RubySanctum: Halion: Correctly spawn X-shaped flames.
(cherry picked from commit a82e55f684)
2015-07-25 16:59:43 +01:00
Shauren
4e83094354 Misc: Removed tabs 2015-07-23 16:50:35 +02:00
Gacko
49a6f7b7bd Fix non pch build. 2015-07-22 20:35:59 +02:00
MitchesD
8167fb433e Core/Scripts: converted leftover of SMSG_CONTROL_UPDATE
* forgot in my last commit, thanks joschi for notice
2015-07-22 20:03:07 +02:00
Shauren
a22e4e121a Core/Misc: Fixing warnings detected by Visual Studio 2015 compiler 2015-07-21 00:33:36 +02:00
jackpoz
31f1169f8a Scripts/VioletHold: Fix build warnings
(cherry picked from commit a22fd7dca5)
2015-07-20 01:11:37 +01:00
Vincent-Michael
5705555f1f Core: Remove whitespaces 2015-07-19 04:53:41 +02:00
Mik1893
f34471f1e1 Scripts/Oculus: Implemented Drake GPS system
(cherry picked from commit 409c8e406d)
2015-07-12 18:30:04 +01:00