Commit Graph

32798 Commits

Author SHA1 Message Date
Aokromes
4aa19b20ff DB/Item: Improved Land Mines
By Rushor, closes #10205

(cherry picked from commit ff816f404d)
2020-04-24 17:18:50 +02:00
Aokromes
4ee1d4b44b DB/Creature: Fix Verifonix faction and reputation
By offl, Closes #19323

(cherry picked from commit 5b38194247)
2020-04-24 17:18:50 +02:00
Aokromes
be0de1ce70 DB/Creature: Fix Guardian of Icecrown creature_text typo
By TecDian
Closes #19226

(cherry picked from commit e4492dd0bd)
2020-04-24 17:18:50 +02:00
ariel-
da12320937 Core/Auras: fix a deleted memory access crash
Closes #19319

(cherry picked from commit 01aaafb083)
2020-04-24 17:18:50 +02:00
Aokromes
054a6a9e2e Rename 2017_03_25_00_world.sql to 2017_03_25_01_world.sql
(cherry picked from commit 9d6902331b)
2020-04-24 17:18:50 +02:00
ccrs
953cdbf205 Fix warning
field '_top' will be initialized after field '_owner'

(cherry picked from commit 2b5c765bcd)
2020-04-24 17:18:50 +02:00
ccrs
f135b7aea1 Core/Movement: 96f4c7c followup
(cherry picked from commit 9be7f5f57b)
2020-04-24 17:18:50 +02:00
ccrs
b2d1b11326 Core/MotionMaster: cleanup use of _expireList
And restore broken _cleanFlag check/use on update (eca3645d8b)

(cherry picked from commit 96f4c7c187)
2020-04-24 17:18:50 +02:00
ccrs
1f0dc07ef1 Core/Unit: cleanup UnitState enum
(cherry picked from commit bf56049f2f)
2020-04-24 17:18:50 +02:00
ccrs
dbe54973fb Core/Movement: cleanup MovementGeneratorType
(cherry picked from commit fce974c3b3)
2020-04-24 17:18:49 +02:00
Gustavo
6f523b4fb6 Core/Scripts: minor fixes in boss_the_lich_king (#19311)
Closes #4427
Closes #7091

(cherry picked from commit 2792046dc7)
2020-04-24 17:18:49 +02:00
ariel-
7a561ad045 Core/Scripts: Updated Ulduar instance model
- Codestyle/indent fixes
- Added ObjectData for some GOs
- Added GetUlduarAI to creatures
- Fixed possible out-of-bounds access in boss_razorscale_controllerAI (boss AI number beyond allocated boss size)

(cherry picked from commit b74cc80859)
2020-04-24 17:18:49 +02:00
Chaouki Dhib
5d076cfe29 Core/Spells: fix wrong distance calculations in AoE spells [Needs testing] (#16290)
Core/Spells: Fix wrong distance calculations in AoE spells.
Pull request #16290 by chaodhib.
God bless, finally.

(cherry picked from commit a1f2f30c14)
2020-04-24 17:18:49 +02:00
S.V
b8b6fd9ca0 Core/Creatures: Fixed GMs being considered in party/raid with nearby creatures without CREATURE_TYPE_FLAG_TREAT_AS_RAID_UNIT
Ref #19340

(cherry picked from commit eea16ce356)
2020-04-24 17:18:49 +02:00
Keader
b234658617 Core/Scripts: Fixed wrong calculation of Aura of Desire
Closes #19322

(cherry picked from commit 333a403409)
2020-04-24 17:18:49 +02:00
xinef1
ca4720662d Core/Items: Fixed durability problems for wrapped item (#19003)
(cherry picked from commit 81d011170d)
2020-04-24 17:18:49 +02:00
ariel-
e44d0c8873 Core/Spell: fix an issue with vehicle spells changing orientation of base vehicle
Closes #17234

(cherry picked from commit 4096b02a56)
2020-04-24 17:18:49 +02:00
ariel-
786bb561ca Core/AchievementMgr: fix integer underflow neglecting already completed realm firsts
Closes #19334

(cherry picked from commit 9cfa7c752e)
2020-04-24 17:18:49 +02:00
ariel-
848f0d1323 Core/Entities: don't finalize movesplines before deleting.
- The whole MotionMaster will be destroyed along with the unit, freeing the allocated memory.

Closes #19324

(cherry picked from commit b53d0530cd)
2020-04-24 17:18:49 +02:00
robinsch
8874a3ac5d Core/Social: Implement FRIEND_STATUS_RAF (#19317)
(cherry picked from commit d209aaa00f)
2020-04-24 17:18:49 +02:00
Golrag
b8c8dcdbfc Core/Object: Fix Line of Sight issue with object edges
Fixes: https://github.com/TrinityCore/TrinityCore/pull/15807#issuecomment-268077802
(cherry picked from commit 020a6b984d)
2020-04-24 17:18:48 +02:00
jackpoz
bfcb276781 Core/Crash: Refactor and fixes
Code cleanup.
Fix buffer overflow crash.
Fix type being truncated to 199 characters.

(cherry picked from commit 9226e21205)
2020-04-24 17:18:48 +02:00
ariel-
6098c4549c Core/Spell: add assert checks on SpellMgr::CheckSpellGroupStackRules
Ref #19319

(cherry picked from commit 36bb4cabae)
2020-04-24 17:18:48 +02:00
Killyana
8b8b6bf319 DB/Creature: Doctor Razorgrin
(cherry picked from commit 957d3cda1e)
2020-04-24 17:18:48 +02:00
ariel-
053d0cfda5 Core/Pet: load template immunities when creating (except for hunters)
Fixes #19275

(cherry picked from commit e33263c677)
2020-04-24 17:18:48 +02:00
ariel-
c16cebca64 Core/Unit: properly reset displayIds when having a shapeshift aura active
Closes #19309

(cherry picked from commit 7a38eaa5a1)
2020-04-24 17:18:48 +02:00
Aokromes
dbb21ea844 DB/Misc: Fix startup errors / typo fix
(cherry picked from commit 3d43a92fb3)
2020-04-24 17:18:48 +02:00
ariel-
1536f01a74 Core/Quests: fixed exclusivegroup interaction with prevquestId and nextQuestId.
- They should work as documented by wiki now.
- Add some consts to Player methods
- Fixed negative PrevQuestID to mean only active quest (ie not rewarded/complete, as those quests are required to complete another)

Closes #19300

(cherry picked from commit 3b27a06265)
2020-04-24 17:18:48 +02:00
ariel-
c03373c59f Core/Quests: changed quest_template_addon.NextQuestID to unsigned
- No reason to keep this anymore after 4349adf0f2, this is a broken functionality.

(cherry picked from commit dca276716f)
2020-04-24 17:18:48 +02:00
ariel-
feb8205d6a Core/Globals: some changes in quest loading
- Made load/reload associated quest tables data-driven, so removed a bunch of similar looking code from ObjectMgr (yay!)
- Codestyle and encapsulation for ExclusiveQuestGroups

(cherry picked from commit 076293f1f2)
2020-04-24 17:18:48 +02:00
ariel-
4472a3cbf3 Core/Globals: Fix Quest codestyle and member variable initialization
(cherry picked from commit 09701b0229)
2020-04-24 17:18:48 +02:00
ariel-
a098b454b8 Core/Entities: virtualize CheckAttackFitToAuraRequirement
- Should've been like this to begin with

(cherry picked from commit 21d95a1d76)
2020-04-24 17:18:47 +02:00
Killyana
f793a43cee DB/Creature: Fix a type on creature text related to Lord Thorval
Ref 80a0c3cfc7

(cherry picked from commit 63236f97af)
2020-04-24 17:18:47 +02:00
ariel-
5979f4f396 Core/Auras: fix more unused parameter warnings
(cherry picked from commit 7de5befbc3)
2020-04-24 17:18:47 +02:00
ariel-
1c4b1ba498 Core/Auras: fix comparison of integers of different signs warning
(cherry picked from commit 9047d8bd6f)
2020-04-24 17:18:47 +02:00
ariel-
e39ea201ce Core/Auras: fix unused parameter warning
(cherry picked from commit 40489b8d57)
2020-04-24 17:18:47 +02:00
ariel-
ebc06b1d04 Core/Auras: reworked multiplicative AuraEffects calculation
- Splitted containers for flat modifiers and pct modifiers, as they now have different handling
- Amount is now multiplied only on apply; on unapply, iterate through auras and reset the counter
- Fixes many cases of rounding error due to applying/unapplying of small factors
- Allows amounts to be zeroed (ie with an AuraEffect of amount -100)
- Do a partial revert of 6dc37a9add, auras should update amounts only for items allowed (ie no more giving crit to a sword while having an axe in the other hand and being Poleaxe spec'd)
- SPELL_AURA_MOD_SCALE now scales additively, rather than multiplicatively (checked in sniffs)

Closes #18687

(cherry picked from commit c69a7d1223)
2020-04-24 17:18:47 +02:00
ariel-
73ea9ecec1 Core/Misc: moved WeaponAttackType definition to SharedDefines to avoid including Unit.h
(cherry picked from commit 6d991e9361)
2020-04-24 17:18:47 +02:00
ariel-
de2cae6a58 DB/Spell: Recently Bandaged debuff shouldn't break stealth
Closes #18951
By Noryad

(cherry picked from commit 5f901d3d75)
2020-04-24 17:18:47 +02:00
Rushor
1abe7530df DB/Creature: Savage Hill Brute/Mystic/Scavenger
Closes #18922

(cherry picked from commit abed5e1586)
2020-04-24 17:18:47 +02:00
ariel-
cdbe16fabe Core/Scripts: implemented Gnomish Harm Prevention Belt
Updates #18542

(cherry picked from commit 2db3e86d9b)
2020-04-24 17:18:47 +02:00
Rushor
2d2cf2533e DB/Creature: Footman Rob, Footman Chuck and Footman George
Closes #18770

(cherry picked from commit 6732c1c2e1)
2020-04-24 17:18:47 +02:00
Rushor
49af1080aa DB/Creature: Bellinger and Bailey
Closes #18908

(cherry picked from commit b9bd4cd198)
2020-04-24 17:18:47 +02:00
Rushor
fb25fccefa DB: Janks's mine event
Closes #18907

(cherry picked from commit 7b578cb142)
2020-04-24 17:18:47 +02:00
Rushor
554a36ae24 DB/Creature: Torseg the Exiled
Closes #18902

(cherry picked from commit 2f19d78b2a)
2020-04-24 17:18:46 +02:00
Rushor
08870077ad DB/Creature: Zalduun
Closes #18886

(cherry picked from commit 5b46f5180c)
2020-04-24 17:18:46 +02:00
Rushor
52f6738cd1 DB/Creature: Gothik the Harvester 2
Closes #18884

(cherry picked from commit 5edd855793)
2020-04-24 17:18:46 +02:00
Rushor
70396c5ad7 DB/Creature: Gothik the Harvester
Closes #18881

(cherry picked from commit f86fa0f526)
2020-04-24 17:18:46 +02:00
Rushor
7597fda20a DB/Creature: Lord Thorval
Closes #18880

(cherry picked from commit 80a0c3cfc7)
2020-04-24 17:18:46 +02:00
Keader
f3d946cee9 Core/Spell: Fixed Val'kyr Target Search exploit
Closes #16347
by ariel-

(cherry picked from commit 28b955bd25)
2020-04-24 17:18:46 +02:00