Keader
c1641642cb
Scripts/Magtheridon: Fixed Magtheridon inaccessible
...
Closes #21693
(cherry picked from commit 99993a7f62 )
2021-09-22 23:29:33 +02:00
Shauren
c34e0f80a0
Core/Items: Disable effects on items marked as legacy
2021-09-22 00:01:47 +02:00
Shauren
f9fb469726
Core/Items: Define new item flags
2021-09-22 00:01:47 +02:00
Mikhail Redko
f8dda8a4fc
Core/Creatures: implement CREATURE_FLAG_EXTRA_NO_SELL_VENDOR ( #21642 )
...
* Add CREATURE_FLAG_EXTRA_NO_SELL_VENDOR and use it for a single no-sell vendor in game (there are more of them in later expansions)
(cherry picked from commit 7c5b69d18b )
2021-09-19 22:54:08 +02:00
Shauren
33bf5d3854
Core/Movement: Fixed chase distance calculation for hovering units
...
Closes #21668
(cherry picked from commit 4af3c33d04 )
2021-09-19 22:43:07 +02:00
ariel-
a54e5bf4c8
Core/Creatures: Minor HasSpell method cleanup
...
Cherry-picked improved from 5734788c02
(cherry picked from commit 3670779e8e )
2021-09-19 22:40:38 +02:00
ariel-
05c9b8c337
Scripts/ICC: use script searchers instead of saving list of creature pointers
...
Closes #21644
(cherry picked from commit f87da3a306 )
2021-09-19 22:21:35 +02:00
ariel-
a8226a1d67
Core/Spells: always initialize hitinfo aura
...
Ref 437c5c7b9d
(cherry picked from commit 07e42f7d41 )
2021-09-19 22:21:04 +02:00
ariel-
6d3a11e1d1
Scripts/Spells: fix Seaforium Blast script crash
...
Closes #21663
(cherry picked from commit 6eb122792c )
2021-09-19 22:20:30 +02:00
ariel-
c8d7289245
Core/Spells: fix delayed hit aura crash
...
Closes #21664
(cherry picked from commit 437c5c7b9d )
2021-09-19 22:19:22 +02:00
Shauren
0b882b2fa4
Core/Spells: Update effect value calculations
2021-09-18 15:00:43 +02:00
Shauren
ee73948a64
Core/AreaTriggers: Rename spell_areatrigger* tables to areatrigger_create_properties* according to last MiscValue research for areatrigger effects
...
* Move areatrigger_template.DataX to areatrigger_create_properties.ShapeDataX
2021-09-16 22:22:14 +02:00
Traesh
c60cb7bab1
Core/AreaTrigger Switch polygon vertices from Template to SpellMisc ( #26827 )
2021-09-12 17:50:13 +02:00
Meji
0a83f74876
Core/Achievements: Update CriteriaType enum ( #26856 )
2021-09-08 22:07:01 +02:00
Shauren
f57cf66dac
Core/Spells: Typo fix
2021-09-07 11:38:24 +02:00
ariel-
50c5284602
Core/Spells: autogenerate miss proc for spells with auras with hit chance -100
...
Closes #21629
(cherry picked from commit 1c8d9af084 )
2021-09-06 21:33:56 +02:00
ariel-
a6e84ebfab
Core/Entities: completely remove 60% melee miss cap as there is no proof of its existence
...
- Auras modifying hit chance should have full effect now
Ref issue #21629
(cherry picked from commit a35d0a5f56 )
2021-09-06 21:32:47 +02:00
ariel-
cfe69470a8
Core/Entities: don't skip immunity checks for positive spells
...
Closes #21626
(cherry picked from commit 9e0a343f72 )
2021-09-06 21:15:01 +02:00
Shauren
376ac0eeba
Buildsystem: Separate strict database type checks from TRINITY_DEBUG/WITH_COREDEBUG option
...
(cherry picked from commit ddd60a948c )
2021-09-06 21:01:48 +02:00
ariel-
4a386b97d2
Core/Player: properly clear m_items array when unequipping items from the bag
...
- Also cleanup weapon damage ap mult when direct destroying a equipped weapon
(cherry picked from commit 9cc109fe3e )
2021-09-06 20:55:06 +02:00
ariel-
bf7a624a34
Core/Entities: cleanup of weapon damage
...
- AP multiplier wasn't correctly reflected after unequipping a weapon
- Correctly set base damages at unequip
Closes #21610
(cherry picked from commit 8cf7eda8c1 )
2021-09-06 20:54:19 +02:00
ariel-
f420a439f9
Core/Spells: fix issues with delayed spells and auras
...
- Was losing info of delayed targets due to remove_if move-assigning targets, it needs to be saved into delayed target vector before returning from lambda
- Delayed auras applying on many targets are now handled gracefully
Closes #21609
Closes #21612
(cherry picked from commit 2828869844 )
2021-09-06 20:40:42 +02:00
ariel-
7c5e23c973
Core/Spells: implemented 'Weakened Spirit' mechanic in Valithria Dreamwalker
...
- Debuff used to prevent multiple priests chaining 40% heal buff (Guardian Spirit)
(cherry picked from commit 7d118f05ba )
2021-09-06 20:38:34 +02:00
ariel-
5491b7f89f
Core/Spells: only apply aura effects when needed. Fixes #21602
...
(cherry picked from commit abb602f7c1 )
2021-09-06 20:10:16 +02:00
ariel-
071d112ed1
Core/Auras: fix auras apply on player when loading. Fixes Ghost aura flags and player deathstate
...
Closes #21472
(cherry picked from commit 214fd579c0 )
2021-09-06 20:06:21 +02:00
ariel-
ad2d904a75
Core/Auras: cleanly remove linked auras when unapplying effect
...
Closes #21588
(cherry picked from commit 8a8c7793c4 )
2021-09-06 20:05:39 +02:00
ariel-
b2de3efb4b
Core/Spells: Fix some issues with channeled spells and aura duration mods
...
Closes #21584
(cherry picked from commit ac97655063 )
2021-09-06 20:05:37 +02:00
Killyana
ffae92edd2
Core/GameObject: Fix linked traps not being despawned properly and remove deprecated code
...
Closes #20159
(cherry picked from commit 8f0af67bcb )
2021-09-06 15:26:50 +02:00
Keader
0de5fbb6c0
Core/Unit: Guardians no longer enter combat before reaching the target ( #19816 )
...
(cherry picked from commit a891eb364e )
2021-09-06 15:23:29 +02:00
Treeston
a88cf958b0
Scripts/Naxxramas: Fix an issue that could cause Sapphiron to stop using Drain
...
(cherry picked from commit 43491ba7f4 )
2021-09-06 15:17:53 +02:00
ariel-
339a2acac8
Core/Entities: fix creatures ignoring immune flags. Closes #21578 for real
...
(cherry picked from commit 02f1399fde )
2021-09-06 15:15:33 +02:00
ariel-
50fe2dc7e3
Core/Spell: fix LoS checks for GameObject spells
...
Closes #21580
(cherry picked from commit f7869ad38b )
2021-09-06 15:10:16 +02:00
Shauren
add2e6d212
Core/Spells: Avoid static analysis false positive
2021-09-05 23:04:33 +02:00
ariel-
60ff73eeba
Core/Spell: fix SendSpellMiss requiring caster Unit
...
(cherry picked from commit 7f947646f9 )
2021-09-05 22:48:28 +02:00
ariel-
a2ea26816e
Core/Spell: fix target checks
...
- Aura will be applied at last moment possible (after damage) to prevent regressions on #18395
- Partial revert of 9b38a6352c as it wasnt handling correctly checks without spells
Closes #21578
Closes #21579
Closes #21581
(cherry picked from commit d6b9f148a7 )
2021-09-05 22:43:48 +02:00
sirikfoll
7c63a99bab
Scripts/Spells: Quest King of the Mountain
...
Added missing jump jets and battle standard visuals
Added allowed area conditions for the vehicle
Fixed Jumpbot's attack spell (thanks @keader for fixing the proc)
(cherry picked from commit e7e46b2a82 )
2021-09-05 22:19:03 +02:00
Shauren
f832a96c4e
Warning fix
2021-09-05 16:30:13 +02:00
Shauren
7e09deea3a
Scripts/Spells: Fixed mage ice block to not heal without aura 320913
2021-09-05 15:58:30 +02:00
ariel-
c07b9188df
Core/Spells: register and apply individual aura effects on hit handler
...
- Remove area aura processing from spell system, they're fully handled by aura owner update now
Closes #21577
(cherry picked from commit 4ca9d6469d )
2021-09-05 15:19:55 +02:00
ariel-
46537c6bcb
Core/Spells: tweak 'neutral' spell positivity
...
- Fixes Mind Control dummy self aura appearing as a debuff
(cherry picked from commit d46f36f773 )
2021-09-05 15:16:05 +02:00
ariel-
9fa95b4b57
Core/Spells: Fix periodic rolling adding bonuses twice
...
Calculation is now done in CalculateAmount
(cherry picked from commit 93eda20d5c )
2021-09-04 22:52:31 +02:00
Shauren
8a4e1119ac
Core/Spells: Unify spell effect access api in both branches
2021-09-04 15:13:15 +02:00
Shauren
6ec73a7659
Core/Misc: Fix windows nopch build
...
Closes #25363
(cherry picked from commit 6ad58d604a )
2021-08-31 13:48:40 +02:00
Shauren
9d7eee1a8c
Core/Auras: Fixed cherry-pick mistakes in Unit::RemoveMovementImpairingAuras and Unit::HasAuraWithMechanic
2021-08-30 23:21:14 +02:00
Shauren
407e5aea1a
Core/Spells: Remove leftover code from old mechanic - default spellpower scaling coefficients
2021-08-30 23:17:12 +02:00
Shauren
6031b95ea7
Core/Spells: Remove outdated damage calculations from Spell::EffectSchoolDMG and Spell::EffectWeaponDmg
2021-08-30 21:21:51 +02:00
Shauren
3af33b9ff9
Warning fixes
2021-08-28 20:24:21 +02:00
Shauren
aebf308368
Core/Spells: Fixed Spell::EffectWeaponDmg for spells with multiple damage effects
...
Closes #26717
2021-08-28 19:53:53 +02:00
Shauren
3dd75a49b1
Core/Spells: Removed SpellEffIndex effIndex argument from spell effect handlers, it was commented out in almost every handler
2021-08-28 19:51:29 +02:00
Shauren
bc2c76a5b8
Core/Spells: Refactor building SMSG_SPELL_EXECUTE_LOG to not create 192 empty vectors on every spell cast
2021-08-28 18:30:45 +02:00