Mirror/TrinityCore
1
0
Fork 0
mirror of https://github.com/TrinityCore/TrinityCore.git synced 2026-01-21 01:37:37 +01:00
Code Issues Packages Projects Releases Wiki Activity
37,010 Commits 4 Branches 146 Tags
57504662593559fd7673b3c49ff9f95f2e28fc37
Commit Graph

26588 Commits

Author SHA1 Message Date
ariel-
8e7a12a87a Core/Auras: restrict target map update only to area auras as player requires to have auras registered on load 
Closes #21472

(cherry picked from commit 7cff1b540c)
 2021-08-08 21:21:34 +02:00
ariel-
b1a76fc756 Core/Unit: clear charmed/possessed state before returning client control. Works like a charm 
Closes #21471

(cherry picked from commit fc678bb3c2)
 2021-08-08 21:21:34 +02:00
ariel-
489b111a8a Core/Vehicles: fix crash 
- Aura could be removed in Unit::SetCharmedBy (StopMoving->Relocate->ProcessTerrainStatusUpdate->RemoveAurasWithInterruptFlags)
- By not passing AuraApplication parameter execution continued with a removed application leaving vehicle in a invalid state (m_sharedVision not empty)

Closes #18281

(cherry picked from commit eb7d22d23e)
 2021-08-08 21:21:34 +02:00
ariel-
70c26d53cb Core/Entities: unit states cleanup 
- Added new UNIT_STATE_FOCUSING for creature focus system, this will stop creatures adding/clearing the UNIT_STATE_CANNOT_TURN mask (eg UNIT_STATE_STUNNED if stunned while focusing a spell)
- Added UNIT_STATE_CHARMED that gets set/removed on any charm type (UNIT_STATE_POSSESSED is only for possess as it's name suggests)
- The new states are checked against mask to know whenever client needs to regain character control

Closes and fixes #21460

(cherry picked from commit ba27711145)
 2021-08-08 21:21:34 +02:00
Wilcalaf
e3941e4199 Scripts/Nexus: Fixed a rare bug when sometimes Magus telestra managed to die while invisible preventing players from looting. (#21436) 
(cherry picked from commit 2dd5735bd9)
 2021-08-08 21:21:34 +02:00
jackpoz
89a232de3a Core/Misc: Add PERFORMANCE_PROFILING CMake option 
Add a new CMake option called PERFORMANCE_PROFILING that should be used only when profiling the performance.
This option is unsupported, do not report any issue happening when enabling this option.

(cherry picked from commit db5c9867e2)
 2021-08-08 21:21:34 +02:00
jackpoz
b7aef385e8 Core/Misc: ASSERT() cleanup 
Move some functions calls out of ASSERT() calls. ASSERT() should only apply checks without modifying any object and without having any side effect.

(cherry picked from commit 572eab1c35)
 2021-08-08 21:21:34 +02:00
sirikfoll
74101eaf7c Scripts/Icecrown Citadel: Prevent Lady Deathwhisper movement during first phase. 
(cherry picked from commit 076bd11002)
 2021-08-08 21:21:34 +02:00
ariel-
64399f58a3 Core/Auras: fixed Drain Mana breaking early if caster has Mana Feed talent but no active pet 
(cherry picked from commit 1ac87b6c60)
 2021-08-08 21:21:34 +02:00
Cannix
64234b35ed Core/Spells: Execute item casts immediately instead (#21396) 
(cherry picked from commit 7e71b4535a)
 2021-08-08 21:21:34 +02:00
Wyreth
8713a62328 Core/Entities: remove grid-wide visibility from setActive and implement another method for it (#20725) 
(cherry picked from commit 56874b44f0)
 2021-08-08 21:21:34 +02:00
jackpoz
efce8ca379 Core/Misc: Fix static analysis issues 
Fix static analysis issues reported by Coverity

(cherry picked from commit d3d0640a8d)
 2021-08-08 21:21:34 +02:00
Jeremy
69edf282fa Partial: Core/Entities: Reduce the probability of units dropping under the map (#21322) 
Reduce the probabilty of going under the map

(cherry picked from commit 9e0faace9a)

Revert "Core/Entities: Reduce the probability of units dropping under the map (#21322)"

(cherry picked from commit 2dadbda24a)
 2021-08-08 21:21:34 +02:00
Shauren
fcead0b4ea Core/Spells: Use caster as chat source in Spell::EffectSendChatMessage 2021-08-08 18:15:00 +02:00
Jeremy
58be6007fb Core/Battlegrounds: Remove duplicate info from GroupQueueInfo (#26759) 
- BgTypeId
- ArenaType
- IsRated

Those are fields that are already present in the field m_queueId
 2021-08-08 18:06:29 +02:00
Shauren
193233286d Core/Misc: ASSERT() cleanup - followup of cherry pick 572eab1c35 2021-08-08 15:22:55 +02:00
Shauren
9067eb22ce Core/Units: Fixed crash in Unit::CalcArmorReducedDamage when called from periodic aura tick if caster is no longer in world 
Closes #26776
 2021-08-08 13:03:57 +02:00
Shauren
262ee285db Core/Misc: Updated SpellCastResult, GameError and HotfixStatus enums 2021-08-08 00:18:10 +02:00
Shauren
ce1046a8fd Core/DataStores: 9.1.0 db2 structures 2021-08-08 00:18:10 +02:00
Shauren
cd5357dc18 Core/PacketIO: 9.1.0 opcodes and packet structures 2021-08-08 00:18:05 +02:00
Shauren
07f51437fc Core/Auras: Fix incorrect use of GetUnitOwner() in DynObjAura::FillTargetMap 
Closes #26735
 2021-07-22 10:38:23 +02:00
Shauren
515d3da181 Core/Auras: Skip estimated points calculation for SPELL_EFFECT_PERSISTENT_AREA_AURA 
Closes #26731
 2021-07-21 16:19:14 +02:00
Shauren
0bbf3f7300 Core/AuctionHouse: Fixed paying for commodities 
Closes #26621
 2021-06-24 16:04:51 +02:00
Shauren
61a7026f17 Core/AuctionHouse: Fixed buying commodities 
Closes #26110
Closes #26619
 2021-06-23 22:44:39 +02:00
Killyana
f6f098171f Core/SAI: Move enum to the correct file 
(cherry picked from commit 8aa10f6c65)
 2021-06-22 13:19:36 +02:00
ariel-
5714e89ccf Core/Events: update holiday code and remove misleading log (event date is the one from game_event) 
- add siign to DBC struct member CalendarFilterType as it was being used as such
- kill localtime usage as it's deprecated

Closes #18542

(cherry picked from commit 5b4287e683)
 2021-06-22 13:19:03 +02:00
ariel-
d36f8bb754 Core/Scripts: implemented Fungal Decay & Tail Sting 
Refs #18542

(cherry picked from commit 7dc78d8e3f)
 2021-06-22 13:15:11 +02:00
ariel-
1fe817a995 Core/Auras: remove obsolete check that was preventing some auras to proc even if they met conditions otherwise 
(cherry picked from commit 5f38b92340)
 2021-06-22 13:07:03 +02:00
Keader
ab8f8e1ffb Scripts/Ulduar: Fixed amount of Mole Machines in Razorscale 10 man 
(cherry picked from commit f609589e22)
 2021-06-22 13:06:33 +02:00
Killyana
4b6e76a5ef Core/SAI: Add an action_param3 to "summon gob" to control when the object will despawn 
0 - For despawn when creature dies or time runs out
1 - For despawn after time
Closes #11601

(cherry picked from commit ca4f1e334a)
 2021-06-22 12:51:28 +02:00
Treeston
f0823eb048 Scripts/TotC: Reduce Twin Val'kyr berserk timer from 10 minutes to 8 minutes on normal mode (match DBM). This closes #15367, no matter what ccrs' bong says. 
(cherry picked from commit 789f3c5d37)
 2021-06-22 12:47:40 +02:00
ariel-
d91e099b10 Core/Spells: prevent creatures to focus channeled spells without SPELL_ATTR1_CHANNEL_TRACK_TARGET 
- Creatures stuck here wouldn't try attacking because of this
- Remove one workaround in halion script, now it's unneeded

Ref #11311

(cherry picked from commit 29f7258dc8)
 2021-06-21 12:47:03 +02:00
Gooyeth
493be0c888 Scripts/Commands: add AI/ScriptName to .gobject info (PR #21419) 
(cherry picked from commit 42a11e97d5)
 2021-06-21 00:10:39 +02:00
Treeston
f982f3019a Core/Combat: Unify combat permitted checks between CvC and PvC - only require "not friendly" in all cases. Fixes Yogg-Saron encounter. Closes #21380. 
Also some bonus cleanup to Yogg's script to make transition cleaner.

(cherry picked from commit 4da9321d2b)
 2021-06-21 00:07:24 +02:00
Treeston
37298ca99c Scripts/SmartAI: SetData now has an invoker (if the setting is done by something using SmartAI). 
Also, some refactors. SMARTAI IS SUCH A FUCKING CLUSTERFUCK I SWEAR.

(cherry picked from commit cfc77fd843)
 2021-06-21 00:06:41 +02:00
Gooyeth
17004c4121 Core/Scripts: Add bossId in state error log. (#21421) 
(cherry picked from commit b9aec3b4d3)
 2021-06-21 00:06:41 +02:00
ariel-
1f3e365ff6 Core/Auras: make area and dynauras condition compliant by using the spellarea searcher instead of script searchers 
Closes #17317

(cherry picked from commit f1f6976f91)
 2021-06-21 00:06:41 +02:00
ariel-
16b1f5c7f6 Core/Handlers: fix bogus check that skipped CMSG_CAST_SPELL packet under certain conditions, missing a target change 
Closes #21390

(cherry picked from commit a145a14166)
 2021-06-21 00:06:41 +02:00
ariel-
5323a7d386 Core/Spells: fixed server being too overzealous with autoshot 
- Interrupting it when casting another spell and switching targets

Ref #21390

(cherry picked from commit 93cbe815cb)
 2021-06-21 00:06:41 +02:00
Keader
cb8ea03175 Core/Scripts: Fixed some delayed enrage 
Closes #15367

(cherry picked from commit 63c436f5fb)
 2021-06-21 00:06:41 +02:00
ariel-
e9ddf644b0 Core/Scripts: implemented Seed of Corruption scaling damage tolerance 
(cherry picked from commit df5afca278)
 2021-06-21 00:06:39 +02:00
ariel-
5b42c0b270 Core/Spells: Port refactors from 1826437c09 
(cherry picked from commit 1826437c09)
 2021-06-20 22:25:18 +02:00
Treeston
168be492f5 Entities/GO: Add forceRespawnTimer support to DespawnOrUnsummon. Use it in SAI. 
(cherry picked from commit 264d4e1d30)
 2021-06-20 22:10:08 +02:00
Treeston
bccd81e12a Entities/GO: GameObjects now support (delayed) despawning in a reasonable manner. Closes #21406. 
(cherry picked from commit f071fa9e93)
 2021-06-20 21:49:11 +02:00
Treeston
bd158f6c29 oops, now it builds (and a bonus refactor that annoyed me) 
(cherry picked from commit 2cd5992f37)
 2021-06-20 21:42:35 +02:00
Treeston
1f26122528 Scripts/SmartAI: Forward invoker to invoked action list actions. Also JustAppeared -> InitializeAI. 
(cherry picked from commit 6fb0bc1038)
 2021-06-20 21:42:35 +02:00
Treeston
83c4aa88ec Scripts/TheBarrens: Fix "The Escape" (863) - I don't think this one ever worked, honestly. 
(cherry picked from commit 0e401c7d96)
 2021-06-20 21:42:35 +02:00
Treeston
06b5b8d8b7 Scripts/SmartAI: SMART_TARGET_INVOKER cleanup step 1. The core will now log errors on start-up if SMART_TARGET_INVOKER abuse is found, but will continue to load the scripts as deprecated for now. 
Note that a lot of these scripts may either not currently work, not work reliably, or may be prone to breaking unexpectedly when core internals change. SMART_TARGET_INVOKER is undefined behavior on any event that doesn't directly specify its invoker.

(We are considering options for allowing INVOKER to make sense in timed action lists in a reliable fashion, so they are exempted at this time.)

(cherry picked from commit 482328bddf)
 2021-06-20 21:42:33 +02:00
Treeston
ffce2c1f9a Core/Spell: Properly remove REACT_PASSIVE on permanent feign death unapply. Fixes and closes #21156. 
(cherry picked from commit ac8b9be5d6)
 2021-06-20 20:22:18 +02:00
Treeston
3b635a8a12 Scripts/AzjolNerub: Clean up Hadronox to hopefully avoid any further evade issues. Tag #20310. 
(cherry picked from commit fe3b4de1cd)
 2021-06-20 20:17:59 +02:00