Killyana
4d84eb8643
DB/Quest: Towers of Certain Doom
...
From 784e41131c
By Grz3s
(cherry picked from commit d470ebaf04 )
2021-12-04 00:31:32 +01:00
Killyana
bdb728a165
Spell/Script: Throw Torch must hit only one target
...
(cherry picked from commit ce562415ed )
2021-12-04 00:31:32 +01:00
Wyrserth
238726b824
Core/Achievement: fix mistake related to ACHIEVEMENT_CRITERIA_TYPE_OWN_ITEM. ( #23252 )
...
(cherry picked from commit b76bcc836c )
2021-12-04 00:31:32 +01:00
Killyana
a2ee0f1aef
DB/Quest: Burn Skorn, Burn!
...
From 98bf88325c by Grz3s
(cherry picked from commit 8e0cf3bc2a )
2021-12-04 00:31:32 +01:00
Wyrserth
3264ef1f75
Core/Achievement: correctly credit progress for skill-related achievements when learning a new skill. ( #23249 )
...
(cherry picked from commit 0a25069db4 )
2021-12-04 00:31:32 +01:00
jackpoz
ccc8d679d8
Core/Misc: Log Map name in asserts
...
(cherry picked from commit 991b2a11bd )
2021-12-04 00:31:32 +01:00
jackpoz
6be185e6a2
Core/Misc: Log Spell/Aura name in Spell/Auras asserts
...
(cherry picked from commit 4130384f2e )
2021-12-04 00:31:28 +01:00
ZenoX92
8385356abe
DB/Texts: Twilight Idolater
...
Closes #23245
(cherry picked from commit 84c5be936d )
2021-12-03 23:26:14 +01:00
ZenoX92
f693411ac1
DB/SAI: Seradane
...
Closes #23241
(cherry picked from commit 3c23ac03f0 )
2021-12-03 22:26:55 +01:00
Killyana
f273d4944c
DB/Creature: Tormented Citizen & Tormented Soul
...
From 49cc891e4a by Grz3s
(cherry picked from commit 00e98a34c1 )
2021-12-03 22:22:35 +01:00
jackpoz
8dd1f39153
Dep/Jemalloc: Update to Jemalloc 5.2.0
...
(cherry picked from commit 5d986f0be4 )
2021-12-03 22:02:24 +01:00
jackpoz
a855e6221d
Core/Vehicles: Fix accessories disappearing on reset
...
(cherry picked from commit 6dae4a747d )
2021-12-03 22:02:13 +01:00
jackpoz
eb25fbd485
Core/Misc: Apply fatigue when flying too
...
Fix #22856
(cherry picked from commit a76d01278a )
2021-12-03 22:01:02 +01:00
Killyana
19ce65c01b
Remove deprecated code
...
(cherry picked from commit fe311260f7 )
2021-12-03 22:00:47 +01:00
Killyana
1ced6d2192
Remove Deprecated code
...
(cherry picked from commit fd166025c8 )
2021-12-03 22:00:39 +01:00
Killyana
7c50e300ba
DB/GameObject: Fissure Plant
...
(cherry picked from commit 758814f909 )
2021-12-03 21:59:23 +01:00
Killyana
b2d1a6e610
DB/Quest: The Stagnant Oasis
...
(cherry picked from commit a720b7cacc )
(cherry picked from commit 1f3ef1d6f5 )
2021-12-03 21:58:50 +01:00
Shauren
768ed2cbdc
Core/Spells: Use 3D distance for calculating speed from movement time instead of 2D
2021-12-03 16:12:10 +01:00
Giacomo Pozzoni
910e0b70ef
Core/Vehicles: Fix multiple vehicle join events on same seat ( #23233 )
...
(cherry picked from commit d4414af2d4 )
2021-12-03 00:23:24 +01:00
Jozef Dúc
a13a765610
Core/Object: Range check vol. 2 ( #23226 )
...
* Core/Object: Fix all missing parts for #23062
* Update GameObject.cpp
(cherry picked from commit 78070163dc )
2021-12-03 00:21:19 +01:00
sirikfoll
03e03f3fc6
Core/Scripts: Fix Skadi dismount issue
...
Closes #23005
(cherry picked from commit fe3bf57aba )
2021-12-02 23:51:51 +01:00
Giacomo Pozzoni
46170fdf01
Scripts/Spells: Fix implementation of #22332 ( #23228 )
...
Change the way #22332 moved spell damage calculations from SpellEffectDMG to scripts, using OnEffectLaunchTarget and SetEffectValue instead
(cherry picked from commit 20772dbf5d )
2021-12-02 23:46:00 +01:00
jackpoz
97be87b7d5
Core/LFG: Remove dungeon cooldown when completing random dungeons
...
(cherry picked from commit 24fbbee4b9 )
2021-12-02 23:45:29 +01:00
ccrs
c22431936e
Core/Creature: couple refactors/renaming
...
(cherry picked from commit 69c15f5ae7 )
2021-12-02 23:45:14 +01:00
PolarCookie
fcd78193f2
DB/Loot: White Tuxedo Shirt
...
Closes #23223
(cherry picked from commit 2dffb85762 )
2021-12-02 23:40:23 +01:00
ZenoX92
6b24a6f3a8
DB/Quest: The Calling
...
Closes #23222
(cherry picked from commit 2084bcbecc )
2021-12-02 23:39:25 +01:00
Killyana
f65898016b
DB/Creature: A some missing auras
...
By ZenoX92 and AnonXS from 33b6252f8c
Closes #23221
(cherry picked from commit 9dda85bfd7 )
2021-12-02 23:35:58 +01:00
ZenoX92
6944f59496
DB/Creature: Prince Thunderaan
...
Closes #23220
(cherry picked from commit f0028c888f )
2021-12-02 23:08:22 +01:00
ZenoX92
51e6a95a3b
DB/Gossip: Highlord Demitrian
...
Closes #23219
(cherry picked from commit a3a883e3aa )
2021-12-02 23:07:27 +01:00
Sorikoff
5f916b039b
DB/SAI: Isle of Spears
...
Closes #23217
Closes #23218
(cherry picked from commit 38d911d4ed )
2021-12-02 21:24:55 +01:00
ZenoX92
44ae5c34a7
DB/Quest: Quest Emotes (Silithus)
...
Closes #23214
(cherry picked from commit c82ef1261b )
2021-12-02 21:23:23 +01:00
ZenoX92
5321d57038
DB/Quest: Securing the Supply Lines
...
Closes #23213
(cherry picked from commit ea6213c458 )
2021-12-02 19:36:34 +01:00
Killyana
5163559c1e
Quest/Script: Breakfast Of Champions
...
Set both Earthshaker Drum Events to 50%
(cherry picked from commit 14445088ea )
2021-12-02 19:35:47 +01:00
Killyana
fcff93e725
DB/Creature: Deathless Watcher
...
(cherry picked from commit 0b66c46af1 )
2021-12-02 19:26:13 +01:00
Shauren
a4d40c9e34
Core: Updated allowed build to 9.1.5.41288
2021-12-02 11:59:23 +01:00
ccrs
1ba002ef3d
Core/Object: re-change faction template related logs
...
(cherry picked from commit dfa54d3bf4 )
2021-12-02 00:39:28 +01:00
ccrs
356358ee15
Core/Misc: standarize a couple logs
...
(cherry picked from commit aee26eb467 )
2021-12-02 00:39:28 +01:00
jackpoz
57411da5b2
Core/Pet: Change assert to error log
...
Change assert added in 43dec9e4d0 to error log since charmed creatures lose their AI until next map update
(cherry picked from commit 70fcdc687d )
(cherry picked from commit f45ebe71b0 )
2021-12-02 00:39:28 +01:00
jackpoz
49414acaef
Core/CrashHandler: Remove sensitive data from crashlogs
...
(cherry picked from commit 25bcb1a0b2 )
(cherry picked from commit 37478c5ac1 )
2021-12-02 00:39:28 +01:00
jackpoz
cf979de813
Core/Misc: Fix some GCC 8 warnings
...
(cherry picked from commit 26b6cb0584 )
2021-12-02 00:39:28 +01:00
jackpoz
841f0452a4
Core/MMaps: Revert PATHFIND_INCOMPLETE handling change in ChaseMovementGenerator in 386b5a6fd9 since the current hp reset code in Creature::Update() will reset the hp of bosses as soon as CanNotReachTarget() is true. In case of boss mechanics like Abub'Rekhan at Naxx where the boss throws the player in the air, a PATHFIND_INCOMPLETE path is returned.
...
The code in Creature::Update() should be modified to wait a few seconds before resetting the hp. PATHFIND_NOPATH / PATHFIND_INCOMPLETE don't really mean that the Creature can't attack the player anyway either.
(cherry picked from commit d910ffd779 )
2021-12-02 00:39:28 +01:00
jackpoz
a4fcfbb3af
Core/Scripts: Rename recent GameObject spell overloads to fix GCC warnings
...
Rename recent GameObject spell overloads (they used to accept only Unit as parameters) to fix GCC warnings about partial function override.
(cherry picked from commit e3a9a9bfb2 )
2021-12-02 00:39:28 +01:00
jackpoz
c73fd0e6e3
Scripts/Commands: Add .debug asan commands
...
Add ".debug asan memoryleak" and ".debug asan outofbounds" commands to trigger Address Sanitizer warnings at runtime (or other dynamic analysis tools)
(cherry picked from commit 71d15ea25b )
2021-12-02 00:39:20 +01:00
jackpoz
dc2fed13c8
Shared/Metric: Fix a rare memory leak
...
Fix a memory leak in Metric happening only when enabling/disabling Metric from configs at runtime, leaking the metric added between last SendBatch() call and the ScheduleSend() call in the same function. The only way to reproduce this is to actually freeze the thread calling SendBatch(), disable metric, reload config, unfreeze the thread.
(cherry picked from commit 0d1ff7446d )
2021-12-02 00:39:20 +01:00
jackpoz
98863659bb
Scripts/Guards: Fix infinite loop in npc_air_force_bots
...
Fix infinite loop in npc_air_force_bots happening when aura 38067 was removed, triggering MoveInLineOfSight() that would add back the aura. Only 1 aura add/remove for guard for player is allowed now.
(cherry picked from commit 844e7ee926 )
2021-12-02 00:39:20 +01:00
jackpoz
519e3c9ab7
Core/Commands: Fix .cheat god command letting you die
...
Fix .cheat god command still letting you die with Area Aura like Slime near Thaddius, broken since 777b287dff
(cherry picked from commit f26f716714 )
2021-12-02 00:39:20 +01:00
jackpoz
dd825c5614
Core/Maps: Fix crash caused by setActive(false) called after DespawnOrUnsummon()
...
Fix crash caused by WorldObject::setActive(false) called after WorldObject::DespawnOrUnsummon() happening because the WorldObject would be set as not active but then Map::RemoveFromActiveHelper() would not be called because of not being in world anymore.
Whenever setActive() gets desync'd with what Map actually contains a rare crash would happen since Map only reads a few values of the active WorldObject, making it hard to reproduce. If this happens again some ASSERT calls should be added (or a check in Map::RemoveFromMap() could be added about if the WorldObject is in Map::m_activeNonPlayers container).
(cherry picked from commit 1c833f28e4 )
2021-12-02 00:39:20 +01:00
Killyana
36e009baf2
Core: Restore reset in EscortAI::InitializeAI ( #23197 )
...
Closes #23008
(cherry picked from commit 56b65329e5 )
2021-12-02 00:39:20 +01:00
Jozef Dúc
b717603a9b
Core/Object: Range check ( #23179 )
...
* Should solve #23062 . All credits to @xvwyh
* Remove unused variables
* Remove unused variable
* Cast int32 to uint32
* Remove G3D headers from core header file
* Change door distance
* Update GameObject.cpp
Add newline
* Update GameObject.h
Indentation
(cherry picked from commit 32e1de39a2 )
2021-12-02 00:39:20 +01:00
jackpoz
73c6c13ace
Core/GameObject: Code cleanup
...
(cherry picked from commit 16a154c4e8 )
2021-12-02 00:39:20 +01:00