Commit Graph

15930 Commits

Author SHA1 Message Date
Gildor
61eba44d4a Scripts/Trial of the Crusader: Update Read and Write Save Data (#29293) 2023-08-29 21:59:34 +02:00
Shauren
8e7b6c54e4 Core/Logging: Fixed missing log format changes
(cherry picked from commit 150ba27eb1)
2023-08-27 12:51:53 +02:00
Shauren
451314241d Core/Misc: Modernize comparison operators
(cherry picked from commit f0a862e71b)
2023-08-24 11:48:45 +02:00
Shauren
343d09bc95 Core/Battlefields: Added missing virtual destructor (and delete copy and move operations) 2023-08-23 16:32:15 +02:00
Shauren
edca91b408 Core/Misc: Add missing virtual destructors
(cherry picked from commit f4297aa3c6)
2023-08-23 14:25:14 +02:00
Shauren
ca03ecf3e6 Build: Support ASAN on msvc
(cherry picked from commit 0a0b420d86)
2023-08-23 14:23:56 +02:00
Shauren
6a304a82b1 Core/Units: Fixed possible use after free in ThreatManager
Closes #28830

(cherry picked from commit 3e3968b63c)
2023-08-23 11:04:14 +02:00
Shauren
8d43d2bafc Core/Movement: Fixed use after free in WaypointMovementGenerator
Closes #29274
2023-08-22 19:34:21 +02:00
Shauren
deec17d8ec Core/Logging: Fixed a few missed log format statements 2023-08-17 11:15:15 +02:00
Shauren
4e6118c919 Core/Misc: Replace std::abort with our ABORT macro
* libmysql is not a well behaved library on windows, it installs its own SIGABRT handler every time a new connection is opened, overriding our own

(cherry picked from commit 09dea76fb5)
2023-08-15 22:02:39 +02:00
Shauren
24fc0dcb1e Core/DBLayer: Relaxed restrictions on which Field class member function can be used to access column value from "strict match" to "must not truncate"
(cherry picked from commit eadafb0347)
2023-08-15 22:00:22 +02:00
Shauren
a4299c2a4b Core/Misc: Replace string to int conversion functions from Common.h with c++17 std::from_chars based ones Trinity::StringTo
(cherry picked from commit 3260b94dd6)
2023-08-15 21:59:52 +02:00
Shauren
aaa6e73c8c Core/Logging: Switch from fmt::sprintf to fmt::format (c++20 standard compatible api)
(cherry picked from commit d791afae1d)
2023-08-15 20:10:04 +02:00
Shauren
825c697a76 Core/Misc: Removed structure bitfield definitions that don't do anything 2023-08-15 13:00:43 +02:00
Shauren
3144566584 Core/Misc: Include cleanup, 2023 edition
(cherry picked from commit 92ed5e8af1)
2023-08-12 17:56:16 +02:00
Shauren
27cd5a90f4 Core/Misc: Replace enable_if overload selection with if constexpr
(cherry picked from commit a53e4a5756)
2023-08-12 17:56:16 +02:00
Shauren
d251ab647d Core/Misc: Migrate our c++20 advstd to standard features
(cherry picked from commit 7830e5a7a1)
2023-08-12 17:56:16 +02:00
Shauren
777b001d2d Core/Misc: Use boost/circular_buffer forward declaration headers in our headers
(cherry picked from commit 1afec8be63)
2023-08-12 17:56:16 +02:00
Shauren
ad3fc81db9 Core/Misc: Add missing Containers.h include where neccessary 2023-08-12 17:56:16 +02:00
Shauren
cccc062ea0 Core/Misc: Remove boost::heap::fibonacci_heap from header files
(cherry picked from commit e8e330addd)
2023-08-12 17:56:15 +02:00
Shauren
f5a2e2ae13 Core/Misc: Replaced boost::container::static_vector in packet classes with plain vector with custom static storage allocatlr
(cherry picked from commit b65c3f5f4a)
2023-08-12 17:56:15 +02:00
Shauren
30adff16ae Core/Utils: Replace boost flat_set with our own
(cherry picked from commit 42fbcf2fc5)
2023-08-12 17:56:15 +02:00
Shauren
b8dc87a0e0 Core/Spells: Hide spell effect immunity info implementation details
(cherry picked from commit dcb589946b)
2023-08-12 17:56:11 +02:00
Shauren
b7287e85e4 Core/Misc: Fixed deprecation warnings for c++20
(cherry picked from commit ba9bbbc9d0)
2023-08-12 14:24:24 +02:00
Shauren
f9033a5dbd Scripts/Forge of Souls: Fixed achievement_bronjahm_soul_power script registration 2023-07-19 13:45:17 +02:00
Shauren
04aab7b540 Core/Spells: Cleanup player typeid checks and casts in WorldSession::HandleCastSpellOpcode 2023-07-12 14:55:38 +02:00
Shauren
0a34290484 Core/Spells: Corrected client control checks in spell packets
Closes #26510
Closes #27863
2023-07-09 14:45:49 +02:00
Shauren
d1c6b9d253 Core/Items: Mirror client logic when determining whether to apply feral attack power bonuses or not
Closes #28674
2023-06-13 18:56:22 +02:00
Gildor
2cd8b6a575 Core/Players: Fix inactive reward quests on faction change (#29073)
* Fix query order
* Quest with AllowableRace 0 shouldn't be inactive on faction change
2023-06-13 14:24:09 +02:00
Renn
0aa9b1cd5d Proper assignment of quest loot for group loot & round robin (#28831)
* Proper assignment of quest loot for group loot / round robin

* Update src/server/game/Loot/Loot.cpp

Co-authored-by: Giacomo Pozzoni <giacomopoz@gmail.com>

---------

Co-authored-by: Giacomo Pozzoni <giacomopoz@gmail.com>
2023-06-11 12:30:26 +02:00
Shauren
2a587e5ac4 Core/Misc: Remove unwanted position converstions from a single float 2023-06-04 18:27:05 +02:00
Shauren
fb699dc641 Core/Loot: Fixed loot roll exploit
Closes #29042
2023-05-30 21:28:02 +02:00
robinsch
d5ef68bc9b Core/StatSystem: Fixed missing calls to set negative attack power mods (#28883)
* Core/StatSystem: Fixed missing calls to set negative attack power mods

(cherry picked from commit 5ab14c14e70e516278b94a9e61e8475ffec86774)

* Added missing calls in Player::InitStatsForLevel

* Fixed typo

* Fixed typo

* Fixed typo
2023-05-28 17:12:34 +02:00
Shauren
47b1de526e Core/Units: Corrected AURA_INTERRUPT_FLAG_NOT_SEATED implementation to only interrupt when actually standing (flag not renamed but its correct name is SpellAuraInterruptFlags::Standing) 2023-05-13 18:35:54 +02:00
Shauren
dd10ac27fe Core/Auras: Don't force sitting state from non-standing state when applying auras with SpellAuraInterruptFlags::Standing
Closes #28973
2023-05-12 22:26:16 +02:00
Shauren
2f4c412f4c Core/Units: Don't make force stand state on periodic damage taken
Closes #28950
2023-05-11 22:51:43 +02:00
Shauren
3993c45a04 Core/GameObjects: Fixed traps not being able to trigger for friendly targets
Closes #27210
Closes #28945
2023-05-08 19:25:44 +02:00
Shauren
83d70425c8 Core/Objects: Removed default argument value from WorldObject::IsNeverVisible 2023-05-07 20:04:26 +02:00
Shauren
aa96aa4783 Core/Misc: Cleanup Expression is converted to bool and can be replaced with 'boolean constant' 2023-05-07 18:52:34 +02:00
Shauren
7e0b28c70c Scripts/Undercity: Fixed NPC_HIGHBORNE_BUNNY being told to MoveJump to { target->GetPositionX(), 0, 0 } with speedXY = target->GetPositionY() and speedZ = target->GetPositionZ() 2023-05-07 18:35:53 +02:00
Gildor
046c6b6a3a Core/Cinematic: Fix crash CinematicMgr::UpdateCinematicLocation (#28953)
* Core/Cinematic: Fix crash CinematicMgr::UpdateCinematicLocation

* typo fix, thx jackpoz
2023-05-03 17:47:34 +02:00
Gildor
431a59eae1 Scripts/Trial Of The Crusader: Fix application of spell Surge of Adrenaline (Icehowl) (#28933)
* Scripts/Trial Of The Crusader: Fix application of spell Surge of Adrenaline (Icehowl)
2023-04-25 08:35:38 +02:00
Gosha
71b7cc6361 Change Map::Visit to not call EnsureGridLoaded if cell.NoCreate is true (#28884)
Remove Map::setGridObjectDataLoaded/Map::isGridObjectDataLoaded helpers, we have NGridType object to use methods directly
2023-04-13 11:52:34 +02:00
Adam B
63790adbfe Add code that changes the faction of Tortheldrin in Dire Maul (#28581)
* Add code that changes the faction of Tortheldrin

Per WoW Classic, Tortheldrin becomes hostile after Immolthar is killed. This code implements an event that does this.

* Bug fix.

Fixed a bug where the server would crash if the bosses were already dead and the player zoned in.

* Recommited with the correct path.

Signed-off-by: Adam Bajac <adam@asblab.work>

* Removed wrong file.

Signed-off-by: Adam Bajac <adam@asblab.work>

* Made changes requested by jackpoz.

Signed-off-by: Adam Bajac <adam@asblab.work>

* Corrected a syntax error after testing.
- Tested in game and confirmed all is working.

Signed-off-by: Adam Bajac <adam@asblab.work>

* Removed whitespace changes.

Signed-off-by: Adam Bajac <adam@asblab.work>

* Changed the script to use OnUnitDeath rather than an event.

Signed-off-by: Adam Bajac <adam@asblab.work>

* Removed the IMMO_DEAD_CHECK event.

Signed-off-by: Adam Bajac <adam@asblab.work>

* Removed redundant comma.

Signed-off-by: Adam Bajac <adam@asblab.work>

---------

Signed-off-by: Adam Bajac <adam@asblab.work>
Co-authored-by: Adam B <adam@avalonglobal.com>
2023-04-11 23:11:48 +02:00
lee
60b75e3b6e Scripts/Misc:fix npc_professions locale text (#27894)
* fix npc_professions locale text

fix npc_professions locale text load from db

* fix dup sql

fix dup sql

* add condition and gossip option

add condition and gossip option for money cost depends on player level

* add missing update statements

* Rename 9999_99_99_world.sql to 2023_03_24_00_world.sql

---------

Co-authored-by: Giacomo Pozzoni <giacomopoz@gmail.com>
2023-03-24 10:52:44 +01:00
Meji
4672200adc Warning fix 2023-03-23 21:28:23 +01:00
Meji
19ea4c416a Core/Spells: Allow implicit targeting of serverside WorldObjects (#28827)
(cherry picked from commit 5d5ca30b23)
2023-03-23 20:22:29 +01:00
robinsch
c8f7dd13b8 Core/Groups: Implement MSG_RAID_READY_CHECK_FINISHED response (#28811) 2023-03-12 17:37:20 +01:00
Gildor
3dda65c53a Core/Players: Remove player from group on faction change if two side interaction group is not allowed. (#28835) 2023-03-11 19:17:00 +01:00
robinsch
13fa60ab86 Core/Item: Fixed incorrect damage mod for Heirloom 2H weapons (#28836) 2023-03-11 14:07:03 +01:00