jackpoz
71feb2149e
Core/Misc: Fix no-pch build
2018-02-04 21:54:06 +01:00
jackpoz
95a76a83fc
Core/AI: Fix assertion triggered with PetAI derived scripts ( #21254 )
...
* Core/AI: Fix assertion triggered with PetAI derived scripts
Fix an assertion triggered when spawning through ".npc add" or from SQL db table a Creature with AI set to a custom AI inheriting from PetAI.
2018-02-04 21:47:45 +01:00
Treeston
b3e0c89238
Scripts/Ulduar: Flame Leviathan used a very weird mixture of victim logic and REACT_PASSIVE, which broke during transition to the new system. Replaced with a working version.
...
Closes #21265 .
2018-02-04 21:27:48 +01:00
Treeston
8f52664a37
nopch fix
2018-02-04 15:10:31 +01:00
Treeston
6e0df9fce1
AI/SmartAI: Remove a silly incorrect piece of code that was breaking react state swaps on SAI creatures. Fixes #21353 .
2018-02-04 15:03:05 +01:00
Treeston
3491aa44b7
nopch fix
2018-02-04 14:45:18 +01:00
Treeston
aefc25482f
Scripts/ICC: Valithria Dreamwalker's script no longer despawns unrelated mobs in Frostwing Halls, and thus won't get them stuck in a despawned state due to linked_respawn.
...
Closes #21286 .
2018-02-04 01:32:30 +01:00
sirikfoll
a217c0be92
Scripts/Icecrown Citadel: Corrected Val'kyr Shadowguard positioning on heroic mode (Lich King)
...
Movement was being prevented by spell cast
2018-01-31 00:59:14 -02:00
Killyana
8f71307e56
Spell/Script: Torch 52953 and 58121 must hit only one target
2018-01-30 13:04:25 +01:00
Treeston
1acfefb973
Core/Creature: Adjust SelectVictim behavior: (PR #21324 )
...
- No more automatic combat -> threat promotion. This matches anecdotal retail behavior - spells already in transit will not cause mob to chase you if its primary target vanishes before the spell hits.
- Prevent mobbing by stopping creatures from auto-acquiring a nearby target just because the primary target vanished.
2018-01-29 23:14:46 +01:00
Treeston
03ef79f3d9
Scripts/Pets: Mirror Image re-write, because it's a colossal mess right now. (PR #19818 )
2018-01-29 14:27:15 +01:00
Treeston
2402406228
Combat/Threat: Now set engaged state for all units on offline reference registration (vanished/invis'd units). For non-PASSIVE units, this will immediately cause an evade.
...
This fixes an exploit where creating the reference as offline (by vanishing while a spell was mid-flight) you could damage a creature further without it ever engaging you.
2018-01-29 03:07:43 +01:00
Treeston
c69584a967
Game/AI: Remove some unused old logic.
2018-01-29 01:57:31 +01:00
Shauren
aaab7ba9f4
Scripts/Icecrown Citadel: Added missing cosmetic colors and emotes to Big Ooze (Rotface)
2018-01-28 23:29:33 +01:00
Killyana
52fc5a572b
Quest/script: Freedom to Ruul
...
Follows 4dc91429dd
2018-01-28 15:15:50 +01:00
Killyana
4dc91429dd
DB/Quest: Freedom to Ruul
...
Closes #7262
2018-01-28 14:03:43 +01:00
Treeston
0ee14845ae
typo
2018-01-28 02:41:33 +01:00
Treeston
320306554c
Core/Creature: add an assertion to guard against infinite loops
2018-01-28 01:51:50 +01:00
Aokromes
4130647bf6
Core/Misc: Sort string
2018-01-27 16:20:41 +01:00
Shauren
21ad8761e9
Core/Spells: Exclude spells with no MaxLevel from coefficient downranking penalty
2018-01-27 13:06:48 +01:00
Shauren
2ab4e6c7aa
Core/Spells: Fixed downranking coefficient penalty formula
...
Closes #21318
2018-01-27 12:19:18 +01:00
ccrs
275c17b4c2
Revert "Core/SmartAI: Remove duplicate OnReset() call"
...
This reverts commit 42c9289be3
2018-01-26 23:56:39 +01:00
sirikfoll
42c9289be3
Core/SmartAI: Remove duplicate OnReset() call
...
It is already called for every creature in SmartAI::InitializeAI(), removing the one from SmartAI::JustAppeared to keep as much as possible of the old behavior, because JustAppeared is called on the next tick after InitializeAI
Closes #20881
Closes #20771
2018-01-26 19:18:10 -02:00
Keader
db525a1401
Scripts/Spells: Fixed Nature's Guardian proc ( #21314 )
2018-01-26 00:06:50 -02:00
Treeston
51e28ae76a
DB/SpawnGroup: Instance spawn group data for Tempest Keep: The Eye and Hellfire Citadel: Ramparts.
...
(also some minor adjustments to command output for convenience)
2018-01-25 13:45:11 +01:00
Treeston
6c3c200cc5
Misc: assert -> ASSERT
2018-01-25 12:39:19 +01:00
Treeston
6ce078d8e8
Scripts/Commands: new command '.debug instancespawn'
2018-01-24 22:52:42 +01:00
ariel-
b1072faa50
Core/Spell: killed deprecated code which randomly changed powercost for missed spells
...
Added in 80d3cd43f6Closes #5954
2018-01-24 13:07:01 -03:00
ariel-
6dd465c441
Core/Scripts: reverted Auriaya spell script logic
...
Thanks Shauren for spotting it
2018-01-24 12:32:26 -03:00
ariel-
8e0af1b93b
Core/Player: only call _ApplyWeaponDamage for actual weapons
...
Closes #21308
2018-01-24 00:05:25 -03:00
ariel-
c099174ff7
Core/Misc: fix some /W4 warnings and some reported by GCC 6.3
2018-01-22 23:55:33 -03:00
ariel-
7c9722a4ae
Core/Entities: killed Creature::SetInCombatWithZone and replaced with AI version
...
Closes #12108 (again)
2018-01-22 15:00:55 -03:00
ariel-
e315e41d36
Core/Entities: don't allow client control if player is still affected by any lose of control state
2018-01-22 14:13:46 -03:00
ariel-
590d251882
Core/PlayerAI: perform cast checks on auto ranged attack
...
Closes #19928
2018-01-22 14:02:01 -03:00
ariel-
514c847881
Core/Unit: fixed Global cooldown cancelation on spell interrupt
...
Thanks to Nyeriah for the heads up
2018-01-22 03:55:14 -03:00
ariel-
73cc613dc8
Core/Formations: update codestyle and fix crash
...
Closes #21288
2018-01-22 02:43:34 -03:00
ariel-
4402f71eb7
Core/Spells: fix Spirit of Redemption
...
- Who would have suspected GetAuraEffect (iconId override) did a check against null spellfamilyflags?
- Remove mirror timers hack (triggered spell already allows underwater breathing)
2018-01-21 21:18:02 -03:00
tkrokli
3feb8a6955
Core/Misc: 2 comment corrections in Language.h
...
- comments adjusted to match the unordered enum LANG_DO_NOT_USE_6X_DEBUG_AREATRIGGER_LEFT
2018-01-21 23:31:40 +01:00
Shauren
ef014d0832
Core/Misc: Revert LANG_DO_NOT_USE_6X_DEBUG_AREATRIGGER_LEFT change from ba5f6a8616
...
* It may be out of place but at least matches db value and matches master branch
2018-01-21 23:21:43 +01:00
tkrokli
ba5f6a8616
Core/Misc: corrections and indentations in Language.h
...
- corrected the comment "1205-2002 - free" to "1205-1999 - free"
- increased the main indent by 2 spaces to get more lines aligned
- corrected the enum LANG_DO_NOT_USE_6X_DEBUG_AREATRIGGER_LEFT from 1999 to 1199
Ref. commit 5f54149107
2018-01-21 23:11:05 +01:00
Treeston
2c86c78f04
Core/Unit: Remove a superfluous threat state update in SetPhaseMask.
2018-01-21 15:34:39 +01:00
Kittnz
8f64612cb1
Scripts/Outland: Fix logical error in Hellfire event in Honor Hold
2018-01-21 14:40:56 +01:00
joschiwald
5f54149107
Core/Battleground: Dropped battleground texts from trinity_string and replaced them with proper BroadcastText
...
(cherry picked from commit ed318fdc466eff69818b3039f4bf86
2018-01-21 13:41:02 +01:00
Treeston
013d4560c7
Core/Threat: Assistance threat (healing, buffs, etc.) is now properly split (instead of copied) between all creatures threatened by the action. Thanks to Foereaper for help with testing, and my apologies to healers everywhere.
...
(No apologies for charm AI though. You deserve that one.)
2018-01-21 02:14:17 +01:00
Treeston
a373275612
Core/Threat: Passive creatures now properly become engaged when adding an offline threat entry. Fixes RoS and Thaddius, maybe more. Closes #21269 .
2018-01-21 01:16:35 +01:00
ariel-
9f5d1e2b10
Core/Scripts: fix wrong uses of SetHitDamage hook.
...
This hook modifies damage AFTER it has been reduced by target auras/armor/resistances etc, it's useful if you want to scale damage by a factor, but not to add flat bonuses.
We're fixing those by moving calculation to Launch phase, where target taken bonuses haven't been used yet.
- Bronjahm: Magic's Bane
- BPC: Shadow Prison
- Oculus: Shock Lance
- Ymiron: Dark Slash (extra fix, it was wrongly damaging half of total health, it's supposed to be half of CURRENT health!)
- DK: Raise Ally Thrash spell (also extra fix: corrected formula)
- Warrior: Bloodthirst (shouldn't matter much as it's damage class none and those don't get bonuses by default)
- Warrior: Concussion Blow
- Warlock: extra fix for Haunt, healing part shouldn't scale with spell power
Closes #9560
2018-01-20 21:09:22 -03:00
ariel-
cb75105434
Core/Scripts: fix Wild Growth losing info about caster bonuses
...
Closes #21281
2018-01-20 19:08:03 -03:00
ariel-
fa3eb754cb
Core/Unit: fixed Lava Burst crit when Flame Shock is present on target
...
Closes #21268
2018-01-20 00:15:48 -03:00
Keader
96983fc6bb
Scripts/Utgarde Keep: Fixed Ingvar evade in phase 2 (again)
...
Closes #21264
2018-01-19 20:56:27 -02:00
ariel-
f1896144c0
Core/Auras: fixed EquippedItemClass check
...
follow-up to 29c3b7d8f6
2018-01-18 19:14:38 -03:00
