SmartAI uses that same method internally, so there's no need to handle it in two different ways.
Does not affect functionality, but prevents useless SAI error log in case the target creature is not using SAI.
True Believers and Still Believing (leftover from previous commit), A Terrible Purpose, Wrath of Neptulon (still missing the 100 gold attached), A Letter for Home (Alliance and Horde), Tactical Clemency, Abandoned Mail, Hammershout the Elder and various Lunar Festival mails.
Unit::IsControlledByPlayer is a expected value for TempSummons (like some triggers used in quests, summoned by spells).
Previous logic broke a lot of quests which use triggers to do stuff.
Allow JustSummoned and events linked from other events with flag set also in charmed (prevents breaking event chains)
Allow vehicles (needed for vehicles with SmartAI, eg Iron Rune Constructs and You: Rocket Jumping)
Turns out epic and legendary items are excluded from this limitation (or it could be just instanced content that is immune to this). Other qualities are affected as normal. Sorry for the mishap.
Fixes issues with quests that rely on this behaviour (eg Free your Mind)
Also updated SetSpawnHealth so it doesn't do anything in case spawn is manual (SetHealth(GetHealth()) does modify things depending on deathstate)
- Quest Nessa Shadowsong and following steps are only available to Night Elves.
- Fix offer reward text for quest Elanaria.
- NPC Webwood Spider should be neutral.
- Small cosmetic fix for quest Force Commander Danath's end event.
- Prevent NPCs Gnarlpine Shaman and Elder Timberling from spamming healing spells.
* Fixed unintentional typo?
Seemed to fix the issues related to the effect for the spells I tried.
Sometimes the caster triggers leapback onto targets, and with the old
code, it instead made the caster leap back instead of its targets
(cherry picked from commit 08aab73c7f)
Those two, together with the two workshop in the Keep, always belong to the defender team. The SouthEast and SouthWest ones always belong to the attacker team.