Commit Graph

23319 Commits

Author SHA1 Message Date
Shauren
7440c9cf19 Core/Spells: Removed SpellEffIndex effIndex argument from spell effect handlers 2021-08-30 23:51:37 +02:00
Kelno
462e11c96f Remove combo points on a creature when it evades (#26836) 2021-08-30 11:27:51 +02:00
trickerer
8729bec844 Core/Combat Fix first autoattack being skipped after charging (#26860)
Fixes #25014
Fixes #24626
2021-08-30 11:26:37 +02:00
Giacomo Pozzoni
cb764a932d Core/SAI: Change error to warning for unused parameters (#26848)
Change error to warning for unused parameters and load the scripts instead of skipping them
2021-08-30 11:20:31 +02:00
Gildor
0fad28e4ab Core/Unit: improve SPELL_AURA_MOD_IMMUNE_AURA_APPLY_SCHOOL immunities (#26849) 2021-08-30 11:19:32 +02:00
Shauren
5ccf7164cb Build fix 2021-08-29 22:14:34 +02:00
Keader
1fd95cef7c Scripts/Black Temple: Removed Illidari Council Enconter Frame 2021-08-29 17:09:48 -03:00
Keader
551c2c2de7 Core/Spells: Fixed Travel time of Scatter Shot / Silencing Shot
Proofs:
https://www.youtube.com/watch?v=GwTc98-X60E (06:52, 09:15) - original link: https://www.warcraftmovies.com/movieview.php?id=158811
https://www.youtube.com/watch?v=G_m9hwU75No (00:46, 01:36)
https://www.youtube.com/watch?v=zLBpEslWusw (04:58) - original link: https://www.warcraftmovies.com/movieview.php?id=136161
2021-08-29 16:59:58 -03:00
Shauren
6573395f24 Core/Spells: Spell effect info access refactoring part 2 - passing SpellEffectInfo as arguments directly instead of SpellInfo + effect index 2021-08-29 21:12:49 +02:00
ccrs
505e91a016 Scripts/VioletHold: f661bc6 follow-up - remove remnants of SetVisible calls from npc_sinclari_vh 2021-08-29 13:42:51 +02:00
ccrs
4c0ff09171 Scripts/VioletHold: corrections to violet_hold_trashAI to prevent trash npcs being stuck in place forever if SPELL_DESTROY_DOOR_SEAL is no longer being casted for w/e reason 2021-08-29 13:33:45 +02:00
Shauren
4c59532865 Core/Spells: Begin unifying spell effect access api with master branch
* Introduce SpellInfo::GetEffects and SpellInfo::GetEffect functoins
2021-08-28 23:42:25 +02:00
Shauren
203f175ec9 Core/Vehicles: Remove unused field 2021-08-28 13:35:21 +02:00
Giacomo Pozzoni
d9a0db79a8 Core/DB: Improve MySQL version check messages (#26866)
* Core/DB: Improve MySQL version check messages

* Make it more clear that any version above the required one is supported

* Implement feedback
2021-08-27 18:40:20 +02:00
offl
afafff57a8 DB/Quest: Rework 'Bitter Departure' (12832) 2021-08-24 23:27:14 +03:00
offl
2f02c2fb86 DB/Creature: Get rid of more flags
Ref #25764
2021-08-23 00:08:36 +03:00
offl
354a45b09d DB/Creature: Get rid of more Feign Death flags
Ref #25764
2021-08-22 19:18:54 +03:00
Ovah
a0aa9730e2 Core/Quests: check PreviousQuestID values as well when trying to make quest groups available to players (#26769)
* Core/Quests: check PreviousQuestID values as well when trying to make a quest available to support quest group requirements for another quest group

* checking for previous quests via NextQuestID only works for single followup quests. However, if we want to make multiple quests available after rewarding all quests of an exclusive group we have to consider PreviousQuestID values as well as every single quest of the next quest group has to check the rewarded exclusive group

* only check for previous quests that must be rewarded instead of being active
2021-08-22 09:58:46 +02:00
jackpoz
b64ef1a39a Scripts/Commands: Fix ".wp show info" showing wrong event chance values 2021-08-21 14:38:27 +02:00
ccrs
b226c88ba2 Revert "Scripts/ICC: add missing break in npc_frostwing_ymirjar_vrykul script"
This reverts commit 31ea74b96e.

They do actually both cast the spell, my mistake
2021-08-20 20:52:42 +02:00
ccrs
31ea74b96e Scripts/ICC: add missing break in npc_frostwing_ymirjar_vrykul script 2021-08-20 20:37:57 +02:00
ccrs
3e886c5561 Scripts/Pet: implement Dance Rune Weapon + minor tweaks to npc_pet_mage_mirror_image script
damage is now halved, years ago it wasn't, so we got that going at least
stat scaling missing - the low damage might even come from this instead of the aura
periodic auras still unknown
2021-08-20 03:41:49 +02:00
Anton Popovichenko
1ddd9dc19c Core/Config: Implement config override with env vars (#26811)
* Core/Config: Implement config override with env vars

Implement overriding of configuration from the .conf file with environment variables.
Environment variables keys are autogenerated based on the keys defined in .conf file.
Usage example:
$ export TC_DATA_DIR=/usr
$ TC_WORLD_SERVER_PORT=8080 ./worldserver

* Core/Config Fix typo in logs

Co-authored-by: Giacomo Pozzoni <giacomopoz@gmail.com>

* Core/Config Fix code style in EnvVarForIniKey

Co-authored-by: Shauren <shauren.trinity@gmail.com>

* Update tests/common/Config.cpp

* Apply suggestions from code review

Co-authored-by: Peter Keresztes Schmidt <carbenium@outlook.com>

* Apply suggestions from code review

Co-authored-by: Peter Keresztes Schmidt <carbenium@outlook.com>

Co-authored-by: Anton Popovichenko <anton.popovichenko@mendix.com>
Co-authored-by: Giacomo Pozzoni <giacomopoz@gmail.com>
Co-authored-by: Shauren <shauren.trinity@gmail.com>
Co-authored-by: Peter Keresztes Schmidt <carbenium@outlook.com>
2021-08-19 22:26:16 +02:00
ccrs
0bdc55b07c Scripts/Ahnkahet: adjust timer on Conjure Flame Spheres in Prince Taldaram encounter
values sniffed
2021-08-19 19:36:22 +02:00
ccrs
b00486e108 Scripts/Ahnkahet: 57fe05f2 followup
cause staging is hard
2021-08-19 18:43:02 +02:00
ccrs
994227fbb3 Build: fix no-pch build 2021-08-19 18:34:52 +02:00
ccrs
57fe05f270 Scripts/Ahnkahet: rescript Ahn'kahar Spell Flinger SAI + spell scripts + spelldifficulty_dbc entries 2021-08-19 18:20:50 +02:00
Shauren
50ab4254a3 Scripts: Fix warnings introduced in 7360c2d156 2021-08-19 16:28:39 +02:00
Kelno
e2f20aff8a Don't count character pending deletion towards character per account limit (#26837)
* Don't count character pending deletion towards character per account limit

* Never show more than 10 characters char enum

* Use constants
2021-08-19 16:07:54 +02:00
ccrs
7360c2d156 Scripts/Ahnkahet: implement Herald Volazj's Twisted Visage AI + small corrections to Herald's own AI
sorry about indentation
timers are guessed
summoning logic unchanged, remains not blizzlike
visage's spells missing spelldifficulty_dbc entries
2021-08-19 03:16:46 +02:00
offl
32282b7326 Revert "Core/SAI: Remove no longer used event types & params (#26833)" (#26840)
This reverts commit 2cb877ea66.
2021-08-18 22:00:34 +03:00
offl
2cb877ea66 Core/SAI: Remove no longer used event types & params (#26833)
* Core/SAI: Remove no longer used event types & params

* Move SMART_EVENT_RESPAWN to 'no params'

Co-authored-by: offl <offl@users.noreply.github.com>
2021-08-18 17:24:34 +02:00
Aokromes
3c84972a36 Core/DB: Updated missing check (#26834)
* Core/DB: Updated missing check

TrinityCore does not support MySQL versions below 5.7, please update your MySQL server
2021-08-18 10:16:06 +02:00
Shauren
7c7b4760d8 Scripts/Commands: Avoid copies of RBACCommandData
Silences the PVS V1002 warning:
"The 'RBACCommandData' class, containing pointers, constructor and destructor, is copied by the automatically generated copy constructor."
2021-08-16 22:42:23 +02:00
ccrs
f8f50bef50 Scripts/Ahnkahet: small corrections to boss_prince_taldaram script 2021-08-16 02:15:42 +02:00
ccrs
f087850508 Scripts/Ahnkahet: corrections to boss_jedoga_shadowseeker script 2021-08-16 01:51:52 +02:00
Keader
9153ad621e Scripts/Misc: Moved Submerge script to spell_generic 2021-08-15 16:35:59 -03:00
Carbenium
b90a4f1798 Scripts/Commands: Convert argument parsing of instance commands to new system 2021-08-15 19:17:30 +02:00
Keader
bea682f95c Scripts/Spells: Fixed Anti-Magic Zone amount calculation
Spell is casted by a trigger, not a player, so script need get owner instead caster
2021-08-14 21:12:46 -03:00
Keader
c8f2056b17 Core/Spells: Fixed Sacred Cleansing range
- It was not working into friends/pets
2021-08-14 21:12:46 -03:00
Keader
8014054ef9 Scripts/Ulduar: Moved UNIT_FLAG_NOT_SELECTABLE to inside XT002 Script
Spell is used for some world quests too
2021-08-14 21:12:46 -03:00
Carbenium
cd1ef2de06 Scripts/Commands: Convert title commands to new system 2021-08-14 14:00:05 +02:00
Jinnaix
6bcda49e98 Core/Script: fix Silithus Wind Stone exploit (#26808)
* Core/Script: fix Silithus Wind Stone exploit

* corrections

Closes #23577
2021-08-14 13:34:51 +02:00
Carbenium
f620befc37 Scripts/Commands: Convert rbac commands to new system
Note: To enable rbac commands for administrators permissions 202-206 have to be linked to permission 196.

Sample SQL for auth DB:
INSERT INTO `rbac_linked_permissions` VALUES (196, 202), (196, 203), (196, 204), (196, 205), (196, 206);
2021-08-14 12:50:18 +02:00
Carbenium
8ee92147a5 Core/ChatCommands: AccountIdentifier from current target 2021-08-14 12:50:18 +02:00
Jinnaix
7050a5ccb6 Server/Config - Change default settings for saving gm logs. (#26804)
* Server/Config - Change default settings for saving gm logs.

* update

Prefix Timestamp to the text
2021-08-13 16:59:43 +02:00
offl
ff8663ca15 Core/SAI: Remove SMART_ACTION_INSTALL_AI_TEMPLATE (#26797) 2021-08-12 23:46:03 +03:00
offl
1c174987c8 DB/Quest: Rework 'Relief for the Fallen' (12937) 2021-08-12 21:26:59 +03:00
ccrs
2870a99d1a Scripts/Ahnkahet: corrections to boss_elder_nadox script 2021-08-11 15:18:23 +02:00
offl
2d2b73c905 DB/Quest: Rework 'The Tome of Divinity' (1783,1786) 2021-08-11 00:49:55 +03:00