* Core/Taxis: teleport players to the destination taxi node location instead of straight to their current ground position
* fixed a typo
(cherry picked from commit 7fcb77ecd1)
Fix an issue that wouldn't allow to re-queue after joining a dungeon, having 1 member leave/get kicked, queue, leave, queue.
In this case a message "One or more dungeons was not valid" would be displayed because LFG would try to queue the group as "continue dungeon" but the current group was not marked as "in dungeon" state anymore.
(cherry picked from commit abcad7cda5)
* Scripts/PitOfSaron: Fix Martin Victus combat in crossfaction groups
Fix Martin Victus attacking players in crossfaction groups because it was spawned as summon of the boss, triggering DoCombatInZone()
* Scripts/ForgeOfSouls: Fix guards combat in crossfaction groups
Fix Devourer of Souls guardians attacking players in crossfaction groups because they were spawned as summons of the boss, triggering DoCombatInZone()
* Scripts/Misc: Fix no PCH build
(cherry picked from commit ef694cc251)
* Core/Movement: fixed taxi pathings getting finalized earlier than intended
Since we handle the intial starting point of a spline properly now the update logic was still expecting the old handling which resulted in incrementing the current node index earlier than intended
* apply a missing change
(cherry picked from commit c1e3d79a4f)
* Core/Movement: provide an extra spline path vertex for taxi pathings so the first path point wont get lost.
* Update FlightPathMovementGenerator.cpp
(cherry picked from commit cf3277c641)
* Core/Calendar: Add some additional validation when creating events
Allow only 30 player events and 100 guild events to be created.
Don't allow to create guild events if player is not in guild.
Send some more error messages to the client (not blizzlike errors but better than nothing).
* Core/Calendar: Add some additional validation/checks
Add guild id check in GetPlayerEvents().
Change error message in HandleCalendarCopyEvent() to be the same as in HandleCalendarAddEvent() when creating an event in the past.
* Core/Calendar: Add some additional validation/checks
Reduce the number of CMSG_CALENDAR_ADD_EVENT packets a seconds allowed from 10 to 3.
* Core/Calendar: Add some additional validation/checks
Implement 5 seconds cooldown between the creation of calendar events
* Core/Calendar: Add some additional validation/checks
Don't allow to copy events of a different player/guild
* Core/Calendar: Implement automatic deletion of old events
Implement automatic deletion of events older than 1 month (30 days).
Fix debug assertion triggered when deleting a character with calendar events.
Avoid double std::set lookup when deleting events when deleting a character.
NB: The whole CalendarMgr/CalendarHandler code should be checked line by line for bugs/crashes/exploits.
(cherry picked from commit fb059722fd)
Add Line of Sight checks to ChaseMovementGenerator::Update(), fixing to ChaseMovementGenerator not reaching a point with valid LoS to the target.
Fix re-implements 8927a04253 after 2a84562dc8 partially removed it.
Fix#23724
(cherry picked from commit 215a6cee24)
Fix a crash in taxi paths happening when joining a battleground/dungeon while on a taxi path after second last node but close to last node, then leaving/finishing the battleground.
(cherry picked from commit 680e1cbd6c)
* Should check victim that do a parry instead of the unit that deal the damage (Wrong implementation of this commit: 4a46fee03e )
Closes#23754
(cherry picked from commit f8d7b26047)
* Scripts/Outlands: Fix npc_ancestral_wolf not starting waypoint, and also add a way to not follow owner automatically in CreatureAI::JustAppeared() for tempsummons
* fix nopch
(cherry picked from commit 0b3a9e2a2b)
* Fix spell_area not checking for zoneID for quests
* Addendum to bdffe0a4a6
* Fix spell_area handle same spell with the same quests
Also fix not checking for quest_end at all.
* Addendum to 2d6b0545e3
* Better commenting for 7a50189de3
* Addendum to 2d6b0545e3
(cherry picked from commit 92d83c3c2e)
Fix mobs evading when target is out of MMap meshes causes by an overzealous check added in c602220e02 when trying to fix an infinite loop in Recast.
If the target is outside of the MMap mesh (for example very close to a wall which is an un-walkable area with current TrinityCore settings and that might be changed in the future) Detour will not be able to find the height of the poly and getPolyHeight() will return DT_FAILURE | DT_INVALID_PARAM . Most of the time this is ok and can be ignored and it's still better than having the Unit evade.
Fix#23613
(cherry picked from commit 5a98022649)
Issue 1: Drain soul was always negative, but effect2 need be positive.
Issue 2: Drain soul was interrupted if someone in your group die. Caused by negative effects proccing in creature.
Issue 3: Since effect2 is positive, it was down-ranking in low level targets and should never happens (fixed before by ariel, transforming everything in negative in 2c8a6fb771 but it's wrong)
(cherry picked from commit 43c08b1761)
