Commit Graph

19310 Commits

Author SHA1 Message Date
Shauren
86f3ee9949 Core/Instances: Explicitly unload InstanceSaveMgr before MapManager, fixes invalid memory access at shutdown
Closes #12635
2014-07-28 23:32:53 +02:00
Shauren
7a888d03bd Core/Network: Fixed packets being properly received only by the first player when broadcasted to everyone
Closes #12675
2014-07-28 16:37:42 +02:00
DDuarte
440fff54b8 Core/Startup: Change an error about "broken zone-data" on guild loading to debug
This "error" happens when player is on zone 0 or transport.
2014-07-28 13:26:03 +01:00
DDuarte
100fd82b2b Core/Networking: Attempt to fix some exceptions
Call the non-throwing versions of socket.remote_endpoint in GetRemoteIpAddress
and GetRemotePort. Sh*t will still be broken tho
2014-07-28 02:58:03 +01:00
leak
e502e01f5d Fixed a rare crash case when authserver socket was forcefully closed during read
Closes #12634
2014-07-27 18:36:03 +02:00
DDuarte
eabf0f44dd Tools/mmaps: Change the PCQ queue to uint32 again
6f272ea5b7 re-added support for non-pointer types
2014-07-27 17:33:42 +01:00
Shauren
6f272ea5b7 Core/Network: Optimized packet sending by removing unneccessary memory copying 2014-07-27 17:46:46 +02:00
DDuarte
8a05231994 Conf/World: Disable player limit by default 2014-07-27 15:46:34 +01:00
Shauren
e77c0b6ed4 Core/Network: Allow storing any packet types in Socket write queue to reduce the amount of copying going on 2014-07-27 14:59:46 +02:00
Shauren
26715795b4 Fixed gcc build 2014-07-27 01:26:03 +02:00
Shauren
c1b1ba44ba Core/Network: Refactored socket code, moved common operations to base Socket class 2014-07-26 23:26:01 +02:00
Shauren
e1c400250c Added comments to 6961f957c9 to make sure noone decides that storing the result in a variable is unneccessary 2014-07-26 16:14:18 +02:00
Shauren
6961f957c9 Core/DBLayer: Fixed possible crashes with async queries retrieving result
Closes #12655
2014-07-26 16:10:05 +02:00
Subv
a03c879565 Core/PreparedStatements: Fixed a change I missed in the World prepared statements for waypoints. 2014-07-25 20:18:43 -05:00
Subv
b5d025938e Core/Waypoints: Allow the table waypoint_data to use Takeoff and Land waypoints. 2014-07-25 19:05:25 -05:00
Shauren
a98737d5d9 Core/Threading: Fixed lock type used in HashMapHolder::Insert - a write lock is needed there, not a read lock 2014-07-26 01:36:54 +02:00
Vincent-Michael
e516265703 Core: Fix non pch build 2014-07-25 21:52:41 +02:00
DDuarte
dcfa3bfa90 Core/Network: Fix build 2014-07-25 19:49:43 +01:00
Shauren
db6be5927f Core/Realmlist: Force resolving realm addresses to ipv4
Closes #12640
2014-07-25 20:13:13 +02:00
DDuarte
4f1d247dfb Core/Network: Fix some possible exceptions on socket.close()
Ref #12634
2014-07-25 18:06:43 +01:00
DDuarte
63e1cc6276 Tools/mmaps: Fix build when building only tools
Closes #12631
2014-07-25 15:23:40 +01:00
DDuarte
0b75e38755 Core/Shared: Change rand32 to return uin32 instead of int32
Fixes a crash that happened when rand32 returned negative values.
Also updated some related comments that were outdated since we changed to SFMT.

Closes #12638
2014-07-25 15:00:40 +01:00
DDuarte
baf9922350 Tools/mmaps: Fix a possible mem leak and a compile warning 2014-07-25 14:04:39 +01:00
DDuarte
8e385ca6d9 Core/Spells: Fix an issue with previous commit (a309ca9727) 2014-07-25 14:04:12 +01:00
Warpten
a309ca9727 Core/Spells: Fixed issues with Death and Decay and similar spells not ticking if players stepping in the AoE are not in LoS with the caster.
Not exactly sure if that behavior should *exactly* be as such, but until more informations ...
2014-07-25 14:47:07 +02:00
leak
90bc6f1e39 Restore mmaps gen build
Closes #12631
2014-07-24 21:55:37 +02:00
Shauren
b5f0b85b48 Core/Misc: Fixed a possible crash in ProducerConsumerQueue::Cancel 2014-07-24 18:05:54 +02:00
DDuarte
3de1714350 Scripts&DB/Feralas Convert npc_screecher_spirit to SAI
SAI by @Rushor and gossip by @malcrom

Closes #12630
2014-07-24 16:38:18 +01:00
Shauren
f1a41eabae Core/NetworkIO: Fixed boost::asio::async_write usage - packets will now be sent properly 2014-07-24 17:09:45 +02:00
untaught
3009bb4808 Scripts/Darkshore: Fix an issue with the quest Gyromast's Revenge
TODO: Rewrite the script in SAI

Closes #11987

Signed-off-by: DDuarte <dnpd.dd@gmail.com>
2014-07-24 15:18:04 +01:00
untaught
e48c37cc10 Scripts/AreaTriggers: Fix an issue with an AT for the quest The Etymidian (Sholazar Waygate)
Closes #12178

Signed-off-by: DDuarte <dnpd.dd@gmail.com>
2014-07-24 15:15:18 +01:00
Vincent-Michael
296956e06e Revert "Core/Spells: Death and Decay"
This reverts commit 02d56e00bc.
2014-07-24 16:14:25 +02:00
Trisjdc
b9b8d83eb6 Core/BGs: Reputation gained in BGs should be affected by SPELL_AURA_MOD_REPUTATION_GAIN
An example would be Diplomacy (Racial Passive)
2014-07-24 04:16:36 +01:00
Trisjdc
2ae9afa9e8 Core/BGs: Reputation gained in BGs should be affected by SPELL_AURA_MOD_FACTION_REPUTATION_GAIN 2014-07-24 04:09:38 +01:00
Trisjdc
e2d6b9bf8c Core/Units: Properly remove auras that don't pass IsHighestExclusiveAura 2014-07-24 04:06:49 +01:00
Ergar
40c5737200 Scripts/Karazhan: Boss Maiden of Virtue - rewrite to events and timer adjustments
Closes #12513 (PR)

Signed-off-by: DDuarte <dnpd.dd@gmail.com>
2014-07-24 03:58:39 +01:00
Trisjdc
f79e7d7640 Core/Spells: Unrelenting Assault shouldn't proc if the target isn't explicitly casting (turns out that UNIT_STATE_CASTING even a instant cast has a 'cast time') 2014-07-24 03:52:19 +01:00
DDuarte
73df8f8381 Scripts/IoC: Rename spell_gen_* spells to spell_ioc_*
(Additions to 6bb63ab7db679d9c)

Closes #12414 (PR)
2014-07-24 03:49:30 +01:00
karn
26496375f8 Script/IoC: Move some spell scripts from spell_generic to isle_of_conquest cpp
Signed-off-by: DDuarte <dnpd.dd@gmail.com>
2014-07-24 03:49:07 +01:00
Trisjdc
c541f4f5de Scripts/Four Horsemen: Horsemen's main spells should only explicitly target players 2014-07-24 03:48:35 +01:00
Trisjdc
3f9f2e3ee5 Core/Units: IsNonMeleeSpellCast will no longer return false if there's an instant cast spell still arriving at the target with the caster doing a channel 2014-07-24 03:47:04 +01:00
Trisjdc
0e91a0e54c Core/Spells: Solving the double dips in Hammer of the Righteous 2014-07-24 03:40:05 +01:00
nelegalno
7524e2dfda Scripts/WesternPlaguelands: Fix conditions to show gossip of Myranda the Hag (In Dreams quest)
Ref #7519

Signed-off-by: DDuarte <dnpd.dd@gmail.com>
2014-07-24 03:25:33 +01:00
Rushor
79c83dc4db Scripts/Feralas: Make Screecher Spirit disappear after clicking on them
This is a temporary solution, the script should be rewritten in SAI

Closes #12298

Signed-off-by: DDuarte <dnpd.dd@gmail.com>
2014-07-24 03:25:32 +01:00
Exodius
02d56e00bc Core/Spells: Death and Decay
Solves problems with Death and Decay doing LoS check using the caster instead of the center of AOE.
Fix by @PKX
Closes #6345
2014-07-24 03:08:49 +02:00
Foldy
9e81b23a57 Scripts/ICC: Summon Sealed Chest quest npc's upon the Lich King's Death
TODO: template updates for these npcs and gossips

Closes #10554
Closes #12591 (PR)

Signed-off-by: DDuarte <dnpd.dd@gmail.com>
2014-07-24 01:23:45 +01:00
DDuarte
737c3aa9f6 Core/Common: Remove the no longer finite(x) macro for MSVC
Use std::isinfinite(f) instead.
2014-07-24 01:01:03 +01:00
Jared P. Jones
11ecd851a1 Core/Misc: Silenced 500 OS X Warnings and removed deprecated finite() method.
*Mac OS X fires off over 200 warnings related to gsoap about the deprecated register method. CMake has been patched to remove this warning.
*Updated all occurences of finite() to std::isfinite. The method finite() is not standardized by anyone aside from BSD. std::isfinite() however is standarized by C++
*Removed -ncurses and -pthread from OS X compilation. Now that we use Boost and C++11 there is no longer a need for pthread in OS X. All it does is throw a warning. However, ncurses isn't needed either as it's built into the OS X SDK and linked by default.

Note: There are only 5 remaining warnings left when compiling on OS X. I did not attempt to fix these as they were related to 3rd party libraries statically linked into the code. The 5 warnings left are all related to unused variables.
2014-07-23 17:30:45 -05:00
Shauren
42eeec12bf Core/Mains: Handle SIGBREAK to achieve clean shutdown when users click X button on windows 2014-07-23 19:04:07 +02:00
joschiwald
b5975c2817 Scripts/ICC: fixed Festergut Malleable Goo (thx @ManuFe)
Closes #12023
2014-07-23 17:24:50 +02:00