Commit Graph

341 Commits

Author SHA1 Message Date
joschiwald
7ef1f0738b Core/Battlegrounds/IoC: fix fortress teleport pads
(and replace a hack with an other hack)

Closes #5846
Closes #7993
Ref #8984
2013-09-05 00:59:22 +02:00
Shauren
4f44cdf2b5 Core/Scripts: Fixed uninitialized variable and memory leaks 2013-08-26 17:38:02 +02:00
Nay
12973de799 Core&Tools: Fix multiple issues found by a static code coverage tool 2013-08-24 22:57:22 +01:00
joschiwald
7e3a52bb42 Scripts/HallsOfLightning: reworked InstanceScript 2013-08-20 18:11:41 +02:00
Shauren
a647d3590c Core/Spells: Fixed Execute rolling for procs twice 2013-08-15 16:38:35 +02:00
joschiwald
73f7c1118d Core/Spells: implemented SPELL_ATTR0_CU_TRIGGERED_BY_CASTER to correct some triggered spells, which will wrongly triggered by target instead of caster
Closes #1972
2013-08-14 18:22:28 +02:00
Vincent-Michael
eefdceea71 Core/Spells: Fix client crash on pressing ESC at Using Steam Tonk Controller / Steam Tonk Controller
Closes #3010
2013-08-11 18:26:53 +02:00
Vincent-Michael
795e9327f7 Core/Spells: Fix hunter talent "Rapid Killing"
Close #1166
2013-08-11 18:19:17 +02:00
Spp
b05665660a Core/Battleground: Get rid of dinamic casts BattlegroundXX outside Battleground scope by implementing generic functions (1/2)
- HandleQuestComplete, CanActivateGO and IsSpellAllowed
2013-08-07 10:31:13 +02:00
Discover-
7f744de746 Core/Misc: Implement reinterpret casts for all battleground classes and use them. 2013-08-06 13:26:52 +02:00
Shauren
d26afd7703 Core/Spells: Fixed crashes happening with spells that had their dbc targets overriden
Closes #10395
2013-07-29 19:00:34 +02:00
joschiwald
c4a1ad2810 Merge pull request #10342 from joschiwald/spellinfo_corrections
Core/Spells: operate spell correction on SpellInfo store instead of dbc ...
2013-07-24 15:18:24 -07:00
joschiwald
8a87ab04ee Merge pull request #10331 from joschiwald/spell_proc_ranks
Core/Spells: allow to use ranked spells in `spell_proc_event` table (lik...
2013-07-24 15:00:14 -07:00
joschiwald
e6a146aba8 Core/Spells: allow to use ranked spells in spell_proc_event table (like in spell_proc table) 2013-07-24 23:52:06 +02:00
joschiwald
9fb45ef64c Core/Spells: load spell ranks for talents from dbc 2013-07-24 15:38:19 +02:00
joschiwald
10390465f2 Core/Spells: add some logs for loading spell_script_names 2013-07-24 15:18:42 +02:00
joschiwald
00f3b01ea7 Core/Spells: operate spell correction on SpellInfo store instead of dbc (picked from 77b85b2ea0) 2013-07-24 00:06:21 +02:00
Spp
9664c0ab5c Core/Misc: Another batch of fixes for issues found by static analysis 2013-05-30 13:18:29 +02:00
horn
0a0698b1d4 Scripts/Ulduar: Yogg-Saron
Known issues:
- encounter doesn't start immediately after you enter the room, you need to go closer
- players standing outside of the room are not turned Insane after 15 seconds
- encounter resets if the last living player is gripped by Constrictor Tentacle or encased in Hodir's Flash Freeze
- Hodir won't freeze multiple players when they die at the same moment
- Flash Freeze missile (64176) won't hit anybody, probably cast too soon (cosmetic issue)
- there are some unused spells, don't know when or why they should be cast
- some spell animations hit multiple players, but they shouldn't do that
2013-05-14 17:52:37 +02:00
Spp
d1677b2db0 Core/Logging: Performance-related tweaks to logging system
All sLog->out* functions (except outCommand atm) are replaced with TC_LOG_* macros.
    Memleak fix
2013-05-13 15:07:36 +02:00
Vlad
78195b3c54 Allow use effectIndex in spell_target_position. 2013-05-13 11:30:48 +03:00
Shauren
e2f8abd48d Core/Spells
* Removed area MiscValue check for spells with SPELL_EFFECT_BIND, it's purpose is only to be sent in packets, not determine real area player will be bound to.
* Corrected guid sent in SMSG_PLAYERBOUND, it should be caster's guid, not player's
* Also updated position for Teach: Death Gate

Closes #9661
2013-05-11 12:16:36 +02:00
Nay
26efbacfab Core/Spells: Fix a logging message error 2013-05-02 03:56:34 +02:00
Nefarion
49fd11ab5a First step of comment style refactoring to doxygen-style. 2013-03-08 21:55:37 +01:00
Trista
a108a9026a Scripts/Eye of Eternity: Rewrite Arcane Barrage mechanic
* Note that even after last changes happens I'm not sure exactly how the timers are controlled. The wipe chance should be a lot smaller now.. Any further change I can think of is beyond what I see. The main problem is currently. In theory there is chance, If timers get to be same with delay lesser than 2 seconds and if target randomisations select same target for shit out of luck reason. And if starting different timers were matching you can be hit atleast 2-3 times and on 25 mode maybe more. The timers are not with fixed difference for sure is all I know.
2013-03-03 03:16:17 +02:00
Trista
d1853f693b Scripts/Eye of Eternity: Remove some flags, fix some timers and some misc
* Starting timers were a bit slower
* Destroy platform proper timing for drake casting mount spell to player (trigger)
* Remove IMMUNITY_PC flag after Iris is triggered (thx to Expecto) and readd it on evade
* Remove NOT_SELECTABLE flag since shouldn't be present at starting event
* Fix misc of id of Static Field added to LOS attributes
2013-03-01 16:25:58 +02:00
Trista
6801314881 Scripts/Eye of Eternity: Rewrite most of it.
Closes: #1133,  #8212, #1150, #5003, #6794

* More stuff will be done, a lot to clean maybe, as of raiding it's good to go now pretty much*.
* Big thx to Shauren, Horn, manuel, Machiavelli, Nay, Krofna and rest who helped.
2013-02-28 18:44:07 +02:00
QAston
6403e3fbfe Core/SpellsMgr: remove unneeded functions from spellmgr, add some const modifiers for methods 2013-02-26 11:05:10 +01:00
Shauren
e49aaab6f6 Scripts/Icecrown Citadel: Improvements to Shadowmourne quest line 2013-02-17 02:10:08 +01:00
Vincent_Michael
49e196e6b0 Misc/Spells:
- Add some ulduar teleport pos for spells
- Add target hack for ulduar teleport spells
2013-02-16 03:26:26 +01:00
Shauren
817f5b3648 Scripts/Icecrown Citadel:
* Fixed Coldflame dealing double damage
* Targets hit by Bone Slice will now be immune to Bone Spike Graveyard
* Fixed healing players on Bone Spike

Closes #1091
Closes #4473
Closes #5854
Closes #7060
2013-02-01 18:06:51 +01:00
Malcrom
ace7bbeddf Core/Zul'Grub: Fix up Mandokir Boss 2013-01-16 00:41:03 -03:30
Spp
d36c4a91ba Core/Misc: Use equal_range instead of lower_bound/upper_bound calls where possible. 2013-01-02 09:53:43 +01:00
Vincent_Michael
cc65aba789 Update copyright note for 2013.
Happy new year.
2013-01-01 00:41:01 +01:00
Faq
e04275984e Core/Spells: fix self-damage caused by Glyph of Chains of Ice. oMadMano
Closes #7270
Closes #644

Signed-off-by: Nay <dnpd.dd@gmail.com>
2012-12-28 02:24:01 +00:00
joschiwald
3288d7024a Core/Spells: fix possible crash when loading spell_proc table 2012-12-27 06:04:45 +01:00
Gacko
2302b04a06 Core/Spell: Last work on Shadows Fate
- Shadows Fate can now be applied by more than just one player at the same
   time. So on everyone who hits the unit the credit spell with the visual
   will be casted on death.
- The AOE credit spells for the three infusion quests will be casted by
  the boss once. If this would be done on proc, these AOE spells could be
  casted up to 25 times.
  -> 25 AOE credit spells plus 25 Soul Feast credit spells equals Sh**
2012-12-22 17:49:51 +01:00
Vincent_Michael
3199c9d563 SQL:
- Fix startup errors
- Rename SQLs in correct name
2012-12-07 18:11:28 +01:00
PitCrawler
5c3431337a DB/Various Fixes:
Add SAI support for Quests 11984, 12255, 12259 Closes #4787
Fix quest Seeking the Windserpent Godess, Setting the Stage Closes #8577
Fix quest Quest I Sense a Disturbance Closes #8515
2012-12-07 16:08:29 +01:00
Vincent-Michael
0a3972db7c Core/Quest: Removed table quest_start_scripts 2012-12-04 11:23:10 +01:00
Warpten
ff1ca5522e Core/Spells:
* Bryntroll's Drain Life should not crit.
* Bestial Wrath can be used while under CC since patch 3.3.2

Patch 3.2.2 (2009-09-22): "Bestial Wrath and The Beast Within Changed to function like PvP Trinkets, removing any movement impairing effects, and giving immunity to these effects for 10 seconds.", also the tooltip doesn't say this, but it now breaks all forms of CC that a PvP trinket would break (including Cyclone,Sap, etc.).
2012-12-01 14:21:44 +01:00
Spp
2251d1bfae Core/Misc: Set mode 0644 for files 2012-11-27 13:03:12 +01:00
tibbi
1f9db80b69 Scripts/ToC: Trial of the Crusader rewrite
Closes #8272
Closes #7013
Closes #7552
Closes #5561
Closes #4221
Closes #2701
Closes #2079
Closes #5082
Closes #6503
Closes #6784

Signed-off-by: Nay <dnpd.dd@gmail.com>
2012-11-19 00:42:25 +00:00
Spp
b99c347747 Core: Remove Player.h dependency from all the possible headers 2012-11-17 05:18:37 +01:00
Kaelima
1ff5b83657 Merge pull request #8074 from Warpten/halionUpdate
Scripts/Ruby Sanctum: Misc fixes.
2012-10-23 03:58:48 -07:00
Warpten
a664a356e2 Scripts/Ruby Sanctum:
* Fixed a crash caused by the grid.
* Update spawnmasks.
* Misc updates and corrections.

Closes #8079.
Closes #8078.
Closes #8081.
Closes #8077.
2012-10-22 21:18:21 +02:00
Subv
27f091806a Core/SpellAreas: Changed the way quest_start and quest_end works.
They now follow this rule:
The player's quest status of quest_start must have the mask defined in quest_start_status in order for the spell to be applied/kept.
The player's quest status of quest_end must _NOT_ have the mask defined in quest_end_status in order for the spell to be removed
To generate the mask:
Take the QuestStatus enum in QuestDef.h, use (1 << theValueYouWant) to obtain a mask and you can use | to combine masks.
This expands the usage of the spell_area table, making possible to give a player an aura while he has a quest, but remove it as soon as the quest is completed (not rewarded).
Feature request by @Svannon
2012-10-16 21:44:28 -05:00
Nay
6f0a8040d8 Core/SpellMgr: Replace magic number by constant
Thanks 2010phenix
2012-10-13 17:36:19 +02:00
Elron103
ae4f5f3dee Core/Spells: Fix power drain effect for heroic versions of spell 70759 (72015, 72016) - thanks to Shauren 2012-10-13 00:43:20 +02:00
kaelima
8c013955ac Core/Misc: Fix some possible issues detected by static code analysis 2012-10-07 01:31:43 +02:00