Commit Graph

2566 Commits

Author SHA1 Message Date
Keader
80dbecbd56 Scripts/ICC: Fixed Valithria Archmages casting while dead
After 9c603ea87f, dead creatures will tick UpdateAI
Closes: #24012

(cherry picked from commit 2f31119ea3)
2021-12-19 15:51:30 +01:00
Keader
b9def15aa7 Scritps/ICC: Fixed resistance calculation for Mutated Transformation (Professor Putricide) (#23858)
More Info in: #23837

(cherry picked from commit 9f7b464a6a)
2021-12-19 15:33:41 +01:00
Shauren
e30683fda4 Scripts: Add missing killer nullptr checks in JustDied hooks
(cherry picked from commit 175eba74ae)
2021-12-19 13:12:42 +01:00
jackpoz
7fb3b89d1d Scripts/Misc:Code cleanup
(cherry picked from commit 68fa3091a2)
2021-12-19 13:12:05 +01:00
Killyana
22e088351d Creature/Script: Fire Bomb
Closes #23977

(cherry picked from commit c5c46fed6a)
2021-12-19 13:11:06 +01:00
Killyana
8c6216eaab Creature/Script: Toravon Frozen Orb Stalker
(cherry picked from commit 9bed0aa8d8)
2021-12-19 13:10:28 +01:00
Killyana
ff30b0751e Spell: Move Crystal Spike aura to the cpp
(cherry picked from commit 26faca51cd)
2021-12-19 13:09:42 +01:00
Killyana
a8cbaa33ac Spell: Move Shadow Trap aura to the cpp
(cherry picked from commit 462b63957a)
2021-12-19 13:04:08 +01:00
Killyana
41b7b39e3c Spell: Move Column of Frost & Mana Void to the cpp
(cherry picked from commit 74f92d776b)
2021-12-19 12:33:59 +01:00
Killyana
eb36b2f2f7 Spell/Script: Move the spell "Flame Sphere Spawn Effect" from the DB to the cpp
(cherry picked from commit 4d89da56c1)
2021-12-19 12:25:17 +01:00
Keader
8ed57e95d5 Scripts/Azjol-Nerub: Fixed Gatewatcher pets evading when kill a player
Making Aokromes happy

(cherry picked from commit 58b5ea9f95)
2021-12-19 01:42:18 +01:00
Killyana
884eeaed8d DB/Spawns: Rampart of skulls
Closes #23966

(cherry picked from commit 366ec08160)
2021-12-19 01:34:59 +01:00
Gildor
5004a8a4ec Scripts/VioletHold: Minor improvements (#23961)
* Scripts/VioletHold: Minor improvements
* Now we can teleport inside with gossip if event is in progress
* Improve HavePlayers() check logic

* Remove a pointless comment
suggested by shauren

* Move CheckWipe function to execute every 3 seconds instead every map update
suggested by Riztazz

* I supose Riztazz forgot add this to repeat every 3 seconds

(cherry picked from commit f661bc6c39)
2021-12-19 01:27:48 +01:00
ccrs
5d1281edda Scripts/PoS: a7a96d4 followup
cause edge cases may exist
ty Aokromes

(cherry picked from commit a58ed271c9)
2021-12-18 23:36:44 +01:00
ccrs
bb1a4e884a Scripts/PoS: a7a96d4 followup
we cant despawn all summons since vehicle spawn their passengers as regular summons
ty Aokromes

(cherry picked from commit fcbcb43b2b)
2021-12-18 23:23:08 +01:00
ccrs
b7346bac48 Scripts/PoS: a7a96d4 followup
(cherry picked from commit 40116f1025)
2021-12-18 23:22:54 +01:00
ccrs
7594ae72d7 Scripts/PoS: little implementation cleanup in boss_krickandick with, you guessed it, movement related corrections
also, never forgetti  -->
                                     ¨¨Ç*^¿?_:;_^!"·Ç!Ñ·$%/(/)/()(=)(=]]{
Unit::StopMoving() is evil, and so is MotionMaster::Clear()

the first can really mess up existing movement generators
the second can interrupt "controlled" movements... can do it literally mid-air

(cherry picked from commit a7a96d4271)
2021-12-18 23:22:38 +01:00
ccrs
a73e6a7438 Scripts/PoS: move boss_krickandick into new script definition
(cherry picked from commit d27fd717c1)
2021-12-18 23:22:08 +01:00
ccrs
d3ddb3726a Core/AI: 06443e3 followup
cause its not "that" horrible

(cherry picked from commit a71c5f4c7f)
2021-12-18 23:03:00 +01:00
jackpoz
d5d04a6c55 Core/Misc: Fix C++17 build errors
(cherry picked from commit 30823f9b79)
2021-12-18 22:51:50 +01:00
ForesterDev
4a47e1c6be Core/Defines: define UNIT_FLAG_SWIMMING (#23630)
(cherry picked from commit c03c88d0c0)
2021-12-18 22:50:52 +01:00
Giacomo Pozzoni
3da3683a90 Scripts/Kologarn: Fix "stuck in combat" issues (#23866)
Fix players stuck in combat with NPC_ARM_SWEEP_STALKER and/or both arms after killing the boss.

(cherry picked from commit fed030da19)
2021-12-18 22:47:49 +01:00
Keader
db03975a57 Scripts/ICC: Fixed some issues with Rotface Oozes (#23845)
(cherry picked from commit a108f2ba61)
2021-12-18 22:40:29 +01:00
Keader
e5accfa71a Scripts/ICC: Fixed Death Plague (Frost Giant) (#23847)
(cherry picked from commit 8210b4a539)
2021-12-18 22:40:16 +01:00
Keader
03a1b03633 Scripts/Forge of Souls: Fixed spell Soul Sickness (#23843)
(cherry picked from commit 34ee2effc8)
2021-12-18 22:37:30 +01:00
Keader
9abdc4ee3d Scripts/ICC: Fixed Tear Gas not getting removed of Abomination in phase change of PP (#23846)
(cherry picked from commit 16fde1ffad)
2021-12-18 22:33:47 +01:00
Giacomo Pozzoni
02c2ee9a43 Scripts: Fix crossfaction combat issue (#23818)
* Scripts/PitOfSaron: Fix Martin Victus combat in crossfaction groups

Fix Martin Victus attacking players in crossfaction groups because it was spawned as summon of the boss, triggering DoCombatInZone()

* Scripts/ForgeOfSouls: Fix guards combat in crossfaction groups

Fix Devourer of Souls guardians attacking players in crossfaction groups because they were spawned as summons of the boss, triggering DoCombatInZone()

* Scripts/Misc: Fix no PCH build

(cherry picked from commit ef694cc251)
2021-12-18 22:27:40 +01:00
Killyana
f6e176b7d7 Instance/Script: Gorkun Ironskull & Martin Victus
(cherry picked from commit 8e3862cfbd)
2021-12-18 22:21:41 +01:00
Gildor
6c239a8612 Scripts/Icecrown Citadel: Remove duplicated Spell enum (#23810)
(cherry picked from commit a392216d20)
2021-12-18 22:19:35 +01:00
Artamedes
e3cb89c168 Scripts/PitOfSaron: Make sure ick stops moving when casting Explosive Barrage (#23768)
(cherry picked from commit 88e74ac385)
2021-12-18 21:45:15 +01:00
Artamedes
a2e792f0bc Scripts/PitOfSaron: Fix Krick sometimes stuck in combat after finish kill Ick (#23767)
(cherry picked from commit a17c83bde8)
2021-12-18 21:45:06 +01:00
Artamedes
8fbaab7337 Scripts/Ulduar: Fix Stormcaller Brundir walking into walls (#23755)
* Scripts/Ulduar: Fix Stormcaller Brundir walking into walls

* Cleanup and fix logic + review

* Review: remove autos

(cherry picked from commit 876a848730)
2021-12-18 21:44:43 +01:00
Treeston
0bffed380d Scripts/ICC: Professor Putricide no longer tries to add threat on units it cannot add threat on because of immunity flags. Instead, its AI manually controls the engagement state. Should close #23727.
(cherry picked from commit 23fd193e4e)
2021-12-18 21:31:31 +01:00
Keader
9d3dd3db84 nopch fix
(cherry picked from commit 10f6e38185)
2021-12-18 21:18:56 +01:00
Keader
f2e03dc9e5 Core/Scripts: Proper fix Gal'Darah Puncture remove
(cherry picked from commit cbc01f35b6)
2021-12-18 21:18:44 +01:00
Keader
b7503b6c76 Fix nopch build
(cherry picked from commit 1886507e7f)
2021-12-18 21:16:51 +01:00
Keader
2d0d0a3e58 Scripts/Gundrak: Fixed Puncture when Gal'darah die
(cherry picked from commit 130a3859ec)
2021-12-18 21:16:40 +01:00
Keader
7c2665bdca Scripts/Gundrak: Added a missing entry in Gal Darah Stampede Charge script
Noob Keader, Shame !

(cherry picked from commit 61ad87d106)
2021-12-18 21:15:40 +01:00
Treeston
51fbda4223 Core/Pooling: Quest pooling rewrite: (PR#23627)
- Split quest pooling from PoolMgr (into QuestPoolMgr)
- Proper saving/restoring on server restart
- No more hacking into sObjectMgr to insert/remove available quests

(cherry picked from commit a5e73e41c0)
2021-12-18 15:28:45 +01:00
Treeston
14c38a1c52 Core/Unit: Spell focusing now no longer nonsensical. HasSpellFocus always const. Error logs for various stuff.
(cherry picked from commit 4a219eda07)
2021-12-18 11:36:50 +01:00
ccrs
a58881d6da Core/Unit: rename more methods
Workaround prework till actual facing system rework arrives

(cherry picked from commit 85ad0befc5)
2021-12-18 00:29:38 +01:00
ccrs
be4ed9152c Core/Unit: rename IsFocusing method
Workaround prework till actual facing system rework arrives

(cherry picked from commit ec9f15a5ff)
2021-12-18 00:25:14 +01:00
Treeston
917d9b7621 Scripts/ICC: Prevent Professor Putricide from displaying weird behavior during the Rotface/Festergut encounters as a result of his boss boundary
(cherry picked from commit 7fa990edc6)
2021-12-17 22:46:06 +01:00
ForesterDev
529ca2dd5d Scripts/Defines: cleanup some magic numbers in factions (#23631)
(cherry picked from commit 0c317498a5)
2021-12-17 20:48:31 +01:00
Treeston
c13d83796f Core/AI: Finally move the "is creature engaged" flag to be a property of the creature AI, where it honestly always belonged. Fixes #17981 and #23602 for real this time.
(cherry picked from commit 0e7c66cb4c)
2021-12-17 00:23:33 +01:00
Wyrserth
96bca1fe2b Script/BoreanTundra: move Pile of Fake Furs' script (related to quest Unfit for Death) from ItemScript to SpellScript.
Closes #21890.

(cherry picked from commit e7cf24d263)
2021-12-16 21:20:39 +01:00
Treeston
eee950cdd7 Core/Misc: Various dynspawn cleanup and refactors split off from pooling rewrite:
- Map::RemoveRespawnTime(SpawnObjectType, LowType, doRespawn) split into Map::Respawn and Map::RemoveRespawnTime, without the extra boolean
- Map::RemoveRespawnTime(RespawnInfo*) merged into Map::DeleteRespawnInfo(RespawnInfo*) and is now private
- Map::DeleteRespawnInfo(void) renamed to Map::UnloadAllRespawnInfos to properly describe what it does
- Map::ProcessRespawns now actually saves the delayed respawn time to DB if the respawn was delayed
- Map::AddRespawnInfo now takes const reference, and returns success as a boolean
- Map::AddRespawnInfo no longer offers an unused "replace" parameter
- Map::DeleteRespawnInfo no longer offers a variety of unused private overloads
- Map::SaveRespawnTime no longer offers a tantalizing writeDB parameter. Parameter is now called "startup" to properly describe what it does.
- Map::SaveRespawnInfoDB now takes RespawnInfo reference instead of all the various fields. Still public because compatibility mode. QQ.
- Map::GetWorldObjectBySpawnId sanitized
- Map::GetXRespawnTime methods sanitized to all go through Map::GetRespawnTime

(cherry picked from commit d60082ae86)
2021-12-16 01:33:09 +01:00
Treeston
fc9908d163 warning fix f2cd721 follow-up
(cherry picked from commit be96d8242c)
2021-12-15 00:17:32 +01:00
Treeston
9491650401 Scripts/Naxxramas: Thaddius no longer evades on transition, and some general cleanup to that script. Fixes #23026.
(cherry picked from commit f2cd721d53)
2021-12-15 00:17:32 +01:00
Wyrserth
569660a933 Script/TheOculus: adapt Mage-Lord Urom's script to use EventMap, fix various issues with Teleport and Empowered Arcane Explosion, add missing heroic-mode spell Frost Buffet.
Closes #19452.

(cherry picked from commit 37862942ce)
2021-12-14 22:13:56 +01:00