Commit Graph

24375 Commits

Author SHA1 Message Date
xinef1
8df577ebfe Corrected points per level calculation for some spells (#19105)
(cherry picked from commit 9142c778dd)
2020-04-27 12:25:52 +02:00
Xinef
6f7ff9a3ef Core/Achievements: Optimized resetting achievement criteria by condition and changed the functionality to properly reset all possible criteria with given condition
Closes #18905

(cherry picked from commit 7c7b877c3f)
2020-04-26 22:58:51 +02:00
Shauren
0763844fb6 Core/Misc: Improve enum flags with type safe operators 2020-04-26 15:27:48 +02:00
Ujp8LfXBJ6wCPR
d994707ba1 Core/Misc: Remove redundant copy constructor for Position and WorldLocation (#24151)
* Default compiler generated ones do the same

(cherry picked from commit b92e4af460)
2020-04-26 11:42:47 +02:00
Shauren
7272508cb4 Core: Fix clang 10 warnings 2020-04-26 01:25:50 +02:00
jackpoz
70c2b4e5ba Scripts/GruulsLair: Fix indentation
(cherry picked from commit 9d77b2be3b)
2020-04-26 00:51:55 +02:00
Ovah
030d942efe Scripts/Antorus: implement Garothi Worldbreaker encounter for normal and heroic difficulty
* added base script support for the encounter for normal and heroic difficulty
* added instance script for Antorus the Burning Throne
* added sniffed template data for involved gameobjects
* added encounter related spawns to Antorus the Burning Throne
* added instance encounter entry for Garothi Worldbreaker
2020-04-25 19:04:31 +02:00
Shauren
af76dc6b88 Core/DataStores: Speedup loading hotfix database and change hotfix database character set to utf8mb4 2020-04-25 17:01:26 +02:00
Shauren
96ec1f16d4 Core/Misc: Fixed wrong db field accessor functions use 2020-04-25 00:30:45 +02:00
Shauren
d6d67a9766 Core/DBLayer: Fix build using TRINITY_DEBUG 2020-04-25 00:15:26 +02:00
Shauren
ac671cc7ec Core/Items: Updated heart of azeroth level cap and knowledge starting date for 8.3 2020-04-24 22:16:25 +02:00
Giacomo Pozzoni
60b338881d Core/Grid: Code cleanup
Remove unused method that should not be used anyway
2020-04-24 19:40:26 +02:00
Ovah
fb0d2ed2b9 Core/Spells: implement SMSG_MOUNT_RESULT and use it for transformed mounting cases (#24404) 2020-04-24 19:00:19 +02:00
Shauren
72ffe65dac Core/Units: Fixed bug in source of cherry-picked commit 2020-04-24 18:44:06 +02:00
ariel-
3d79b5bdea Revert "Core/Battlegrounds: disable health regen for battleground vehicles (#19183)"
This reverts commit 85af0a0630.

(cherry picked from commit 006e90339e)
2020-04-24 17:18:51 +02:00
ariel-
6490095520 Core/Scripts: Fix a logic fail that overriden the script of an entity that changed entry
Closes #19389

(cherry picked from commit dafa726773)
2020-04-24 17:18:51 +02:00
Gustavo
53f79acda9 Core/Battlegrounds: disable health regen for battleground vehicles (#19183)
Updates issue #950

(cherry picked from commit 85af0a0630)
2020-04-24 17:18:51 +02:00
tkrokli
b259614778 Scripts: minimize duplicated enum names in header files (#19377)
* Scripts: Minimize duplicated enum names in header files

This reduces the number of cache resets with the Zapcc compiler

- Standard followed is instance/raid TLA + DataTypes/CreaturesIds/etc
- Partial cherry-pick of master commit 7eb4512eee
- Removed unused defines in sunken_temple.h (the core scripts using these have been moved to SAI)

(cherry picked from commit f6f36be004)
2020-04-24 17:18:51 +02:00
ariel-
cbcc4601ad Core/AI: Build fix
- Stop exposing DoublePosition constructor versions, they're only used for internal representation
- Moved IsInBounds function to public scope

(cherry picked from commit 83162fafa4)
2020-04-24 17:18:51 +02:00
ariel-
3f79c9f696 Core/AI: AreaBoundary refactor
- Added an auxiliary function IsInBounds to base CreatureAI
- Changed container to vector. Set had no sense because we're storing new pointers, they have different addresses even if the boundary is the same

(cherry picked from commit 2f99fa09c9)
2020-04-24 17:18:51 +02:00
ariel-
ea0bb7c65e Core/Creature: added CREATURE_FLAG_EXTRA_GHOST_VISIBILITY to allowed db flags_extra mask
- Cleaned up the mask to be a much nicer enum definition

(cherry picked from commit 66a70088f4)
2020-04-24 17:18:51 +02:00
ariel-
4ec50b35ea Core/Global: reserve storage for script names vector
(cherry picked from commit c8bf1ab5f7)
2020-04-24 17:18:50 +02:00
xinef1
70d5775d3f Added new creature extra flag which makes npc visible only to dead units
closes #19333

* Rename 9999_99_99_99_world.sql to 2017_99_99_99_world_335.sql

- file affects creature removed in patch 4.0.3a

* Update Creature.cpp

(cherry picked from commit e72b380b93)
2020-04-24 17:18:50 +02:00
ariel-
5348db2200 Core/Gameobject: remove virtual from GetScriptId, it's not overriden
(cherry picked from commit 00b547146d)
2020-04-24 17:18:50 +02:00
tkrokli
a0feff65be Game/AI: SMART_ACTION_JUMP_TO_POS should resume path when reached jump location (#19029)
SmartAI NPCs using SMART_ACTION_JUMP_TO_POS
should resume their path when they have reached the jump location.

The changes in this PR makes the action work as intended.

Closes #18760

(cherry picked from commit 6e08051825)
2020-04-24 17:18:50 +02:00
ariel-
da12320937 Core/Auras: fix a deleted memory access crash
Closes #19319

(cherry picked from commit 01aaafb083)
2020-04-24 17:18:50 +02:00
ccrs
953cdbf205 Fix warning
field '_top' will be initialized after field '_owner'

(cherry picked from commit 2b5c765bcd)
2020-04-24 17:18:50 +02:00
ccrs
f135b7aea1 Core/Movement: 96f4c7c followup
(cherry picked from commit 9be7f5f57b)
2020-04-24 17:18:50 +02:00
ccrs
b2d1b11326 Core/MotionMaster: cleanup use of _expireList
And restore broken _cleanFlag check/use on update (eca3645d8b)

(cherry picked from commit 96f4c7c187)
2020-04-24 17:18:50 +02:00
ccrs
1f0dc07ef1 Core/Unit: cleanup UnitState enum
(cherry picked from commit bf56049f2f)
2020-04-24 17:18:50 +02:00
ccrs
dbe54973fb Core/Movement: cleanup MovementGeneratorType
(cherry picked from commit fce974c3b3)
2020-04-24 17:18:49 +02:00
Gustavo
6f523b4fb6 Core/Scripts: minor fixes in boss_the_lich_king (#19311)
Closes #4427
Closes #7091

(cherry picked from commit 2792046dc7)
2020-04-24 17:18:49 +02:00
ariel-
7a561ad045 Core/Scripts: Updated Ulduar instance model
- Codestyle/indent fixes
- Added ObjectData for some GOs
- Added GetUlduarAI to creatures
- Fixed possible out-of-bounds access in boss_razorscale_controllerAI (boss AI number beyond allocated boss size)

(cherry picked from commit b74cc80859)
2020-04-24 17:18:49 +02:00
Chaouki Dhib
5d076cfe29 Core/Spells: fix wrong distance calculations in AoE spells [Needs testing] (#16290)
Core/Spells: Fix wrong distance calculations in AoE spells.
Pull request #16290 by chaodhib.
God bless, finally.

(cherry picked from commit a1f2f30c14)
2020-04-24 17:18:49 +02:00
S.V
b8b6fd9ca0 Core/Creatures: Fixed GMs being considered in party/raid with nearby creatures without CREATURE_TYPE_FLAG_TREAT_AS_RAID_UNIT
Ref #19340

(cherry picked from commit eea16ce356)
2020-04-24 17:18:49 +02:00
Keader
b234658617 Core/Scripts: Fixed wrong calculation of Aura of Desire
Closes #19322

(cherry picked from commit 333a403409)
2020-04-24 17:18:49 +02:00
xinef1
ca4720662d Core/Items: Fixed durability problems for wrapped item (#19003)
(cherry picked from commit 81d011170d)
2020-04-24 17:18:49 +02:00
ariel-
e44d0c8873 Core/Spell: fix an issue with vehicle spells changing orientation of base vehicle
Closes #17234

(cherry picked from commit 4096b02a56)
2020-04-24 17:18:49 +02:00
ariel-
786bb561ca Core/AchievementMgr: fix integer underflow neglecting already completed realm firsts
Closes #19334

(cherry picked from commit 9cfa7c752e)
2020-04-24 17:18:49 +02:00
ariel-
848f0d1323 Core/Entities: don't finalize movesplines before deleting.
- The whole MotionMaster will be destroyed along with the unit, freeing the allocated memory.

Closes #19324

(cherry picked from commit b53d0530cd)
2020-04-24 17:18:49 +02:00
robinsch
8874a3ac5d Core/Social: Implement FRIEND_STATUS_RAF (#19317)
(cherry picked from commit d209aaa00f)
2020-04-24 17:18:49 +02:00
Golrag
b8c8dcdbfc Core/Object: Fix Line of Sight issue with object edges
Fixes: https://github.com/TrinityCore/TrinityCore/pull/15807#issuecomment-268077802
(cherry picked from commit 020a6b984d)
2020-04-24 17:18:48 +02:00
jackpoz
bfcb276781 Core/Crash: Refactor and fixes
Code cleanup.
Fix buffer overflow crash.
Fix type being truncated to 199 characters.

(cherry picked from commit 9226e21205)
2020-04-24 17:18:48 +02:00
ariel-
6098c4549c Core/Spell: add assert checks on SpellMgr::CheckSpellGroupStackRules
Ref #19319

(cherry picked from commit 36bb4cabae)
2020-04-24 17:18:48 +02:00
ariel-
053d0cfda5 Core/Pet: load template immunities when creating (except for hunters)
Fixes #19275

(cherry picked from commit e33263c677)
2020-04-24 17:18:48 +02:00
ariel-
c16cebca64 Core/Unit: properly reset displayIds when having a shapeshift aura active
Closes #19309

(cherry picked from commit 7a38eaa5a1)
2020-04-24 17:18:48 +02:00
ariel-
1536f01a74 Core/Quests: fixed exclusivegroup interaction with prevquestId and nextQuestId.
- They should work as documented by wiki now.
- Add some consts to Player methods
- Fixed negative PrevQuestID to mean only active quest (ie not rewarded/complete, as those quests are required to complete another)

Closes #19300

(cherry picked from commit 3b27a06265)
2020-04-24 17:18:48 +02:00
ariel-
c03373c59f Core/Quests: changed quest_template_addon.NextQuestID to unsigned
- No reason to keep this anymore after 4349adf0f2, this is a broken functionality.

(cherry picked from commit dca276716f)
2020-04-24 17:18:48 +02:00
ariel-
feb8205d6a Core/Globals: some changes in quest loading
- Made load/reload associated quest tables data-driven, so removed a bunch of similar looking code from ObjectMgr (yay!)
- Codestyle and encapsulation for ExclusiveQuestGroups

(cherry picked from commit 076293f1f2)
2020-04-24 17:18:48 +02:00
ariel-
4472a3cbf3 Core/Globals: Fix Quest codestyle and member variable initialization
(cherry picked from commit 09701b0229)
2020-04-24 17:18:48 +02:00