Commit Graph

35972 Commits

Author SHA1 Message Date
jackpoz
97401a2997 Core/Commands: Don't re-add active quests with ".quest add" command
(cherry picked from commit f17120cc78)
2021-11-24 00:02:13 +01:00
Killyana
ead8e2f534 DB/Script: Update arcane-containers script to despawn once clicked
Closes #21094

(cherry picked from commit d2bff6dcec)
2021-11-24 00:02:13 +01:00
jackpoz
b8396f682c Core/MapScripts: Add support to GameObjects to SCRIPT_COMMAND_DESPAWN_SELF
(cherry picked from commit da19ad117e)
2021-11-24 00:02:08 +01:00
Aokromes
49e1ff34b7 Core/mmaps: add category to 2 logs
(cherry picked from commit a2f910fe5c)
2021-11-23 23:44:00 +01:00
jackpoz
291ee6416c Dep/Recast: Validate input values more consistently and completely, including that points are finite
Merge https://github.com/recastnavigation/recastnavigation/pull/374 .
This should fix infinite loops happening with degenerated triangles with 0 area.
Fix #23028

(cherry picked from commit a75fbe527a)
2021-11-23 23:44:00 +01:00
Aokromes
2dfba1f703 DB/Commands: Fix typo on chat commands
Closes #23065 by jackpoz

(cherry picked from commit 3157a6c6f3)
2021-11-23 23:44:00 +01:00
jackpoz
2318013278 Core/MMaps: Add rcMedianFilterWalkableArea() to mmaps generation process
Add rcMedianFilterWalkableArea() to mmaps generation process to simplify some ground/water areas

(cherry picked from commit 7ddbc18aaf)
2021-11-23 23:43:55 +01:00
jackpoz
abb36a1e5b Core/Spells: Add range checks to GameObject targets
Close #23062
Patch by robinsch

(cherry picked from commit 76cc94f325)
2021-11-23 23:34:27 +01:00
ZenoX92
35074d0b42 DB/Quest: Rescue From Jaedenar
Closes  #17227

(cherry picked from commit 809f8c43e5)
2021-11-23 23:33:43 +01:00
Gustavo
10c915dd34 Core/Units: Only update height in SetHover if unit is bellow HoverHeight (#23061)
(cherry picked from commit 2dfea54533)
2021-11-23 23:18:58 +01:00
Serpaa
0f334265c0 DB/Creature: Dying Blood Elf
Closes #23063

(cherry picked from commit f86d453651)
2021-11-23 23:18:40 +01:00
Ovah
2dda5fb477 Scripts/MGT: Kael'thas intro can now be skipped when not killing the trash pack in his room
Scripts/MGT: Kael'thas will now despawn at evade

Cherry picked from
f6e9ff5ca4
ed8c1830f5

(cherry picked from commit c10c8c6bba)
2021-11-23 23:17:08 +01:00
Shauren
7a413ae543 Core/Spells: Fixed spells using MovePositionToFirstCollision for selecting target position getting Z coord offset by caster or target collision height (depending on spell target type)
(cherry picked from commit d63d15c505)
2021-11-23 23:16:49 +01:00
Keader
dba7e2507f Scripts/Illidan: Fixed Parasitic shadowfiends reproducing like rabbits
(cherry picked from commit a617cc4097)
2021-11-23 23:16:43 +01:00
jackpoz
ef04a26bf4 Core/Pet: Add assert
Add additional assert to check if it's possible for a Pet not to have an active AI when the Player owner kills an enemy.
Ref #23036

(cherry picked from commit 43dec9e4d0)
2021-11-23 23:10:45 +01:00
Heaven31415
0ea3fe545c Refactor SendSysMessage, SendGlobalSysMessage, SendGlobalGMSysMessage (#23029)
(cherry picked from commit 9db50f05cb)
2021-11-23 23:07:23 +01:00
Sorikoff
ee0662ca3d Scripts/Scarlet Enclave: Stable Master Kitrik's spell Repo (#23023)
(cherry picked from commit f0f4d0280d)
2021-11-23 23:04:34 +01:00
Killyana
2f21c11979 DB/SAI: Shoveltusks
Closes #23040
Closes #23041

(cherry picked from commit 7dc893fcf2)
2021-11-23 23:03:02 +01:00
Shauren
c14cf5a892 Core/Misc: Added lambda support to EventProcessor
Closes #22909

(cherry picked from commit 813f693768)
2021-11-23 23:01:47 +01:00
Giacomo Pozzoni
ed5ba915f1 Core/Scripts: Change PlayerScript and CreatureScript inheritance (#23048)
Remove UnitScript from PlayerScript and CreatureScript classes as that's how the original system that was PR'd worked, see https://github.com/TrinityCore/TrinityCore/pull/7867 for reference.
Please note these are used as global hooks and should really just invoke stateless functions.
If you need to hook methods from PlayerScript/CreatureScript and UnitScript, just define 2 different scripts (this is how the original system worked and how it was designed to work)

(cherry picked from commit 5b7ead65bb)
2021-11-23 22:54:24 +01:00
TheWinchesters
47adf2e4c8 [3.3.5] Commands: lookup player shows which character is online (#23039)
* Show 'online' for every online player in lookup player commands

(cherry picked from commit a0056951f7)
2021-11-23 22:52:53 +01:00
Giacomo Pozzoni
31dca39c05 3.3.5 threat assert (#23034)
* Core/Creature: Change assert about Threat to log

(cherry picked from commit cb8ff7976b)
2021-11-23 22:48:39 +01:00
Giacomo Pozzoni
24f9b41622 Shared/Utilities: Handle string format exceptions
Handle StringFormat() exceptions in case of malformed string format to avoid causing unhandled exception crashes

(cherry picked from commit c79811de4f)
2021-11-23 22:48:28 +01:00
Aokromes
95b8c9df84 Misc/Extractor: Clarify a bit
(cherry picked from commit 58c5dfac1d)
2021-11-23 22:48:17 +01:00
Rushor
bc3dc38d17 Creature/Script: Move "Bartleby" script to SAI
(cherry picked from commit d69ef2ab1d)
2021-11-23 22:48:03 +01:00
Killyana
254df28c1e DB/Creature: Add night spawns for Dwarf mounts
(cherry picked from commit 59682bbd9b)
2021-11-23 22:45:32 +01:00
jackpoz
b0703f943c Core/MMaps: Change infinite loop fix in Detour
Change the infinite loop fix in Detour to allow looping through all the m_nodePool nodes max once, otherwise it most likely means that we entered an infinite loop. This is currently set to 1024.

(cherry picked from commit 12e6faa0fa)
2021-11-23 22:29:58 +01:00
Aokromes
2682bf0fca Core/Misc: Add categories to 3 logs
(cherry picked from commit 2d22c027fe)
2021-11-23 22:29:21 +01:00
Aokromes
f5827770fc Core/Spells: Add categories to 2 logs
(cherry picked from commit 1cba363360)
2021-11-23 22:29:01 +01:00
Aokromes
c5720e37c1 Core/Entities: Add categories to 2 logs
Closes #22922

(cherry picked from commit 578c796625)
2021-11-23 22:28:38 +01:00
jackpoz
23489568db Core/MMaps: Fix infinite loop in Detour
Fix an infinite loop in Detour happening in Dalaran Sewers.
This is more of an emergency patch until we figure out why dtNodes have a circular reference (A -> B -> C -> A) happening quite often in this place

(cherry picked from commit c8ec2dd95d)
2021-11-23 22:28:28 +01:00
Killyana
cefd1f94d7 DB/Creature: Add invisibility auras related Roanauk Icemist
(cherry picked from commit 3a83dc60d5)
2021-11-23 22:27:15 +01:00
Killyana
15e844b854 DB/Quest: The Might of the Horde
Add missing texts and despawn action

(cherry picked from commit 7514c3106d)
2021-11-23 22:26:07 +01:00
illfated
98be760151 DB/Creature: Warsong Battle Standard
Closes #23024

(cherry picked from commit 6443dee286)
2021-11-23 22:25:36 +01:00
jackpoz
3ddbf02dc7 Core/Misc: Fix issues reported by static analysis
Fix issues reported by Coverity Scan

(cherry picked from commit 2fda1572d2)
2021-11-23 22:20:39 +01:00
jackpoz
9807f32334 Core/Misc: Fix issues reported by dynamic analysis
Closes #23021

(cherry picked from commit 9942047c72)
2021-11-23 22:19:06 +01:00
Killyana
aa9b86a90e DB/Misc: Plaguelands: The Scarlet Enclave
From 8c647dcfb8
By Grz3s

(cherry picked from commit b54b372a39)
2021-11-23 22:18:49 +01:00
Killyana
f6a89f4b42 DB/Creature: Fix phase for one Scourge Necromancer spawn
(cherry picked from commit 42edba699d)
2021-11-23 22:01:48 +01:00
jackpoz
927e62e88e Core/Group: Fix memory leak
Fix memory leak happening when disbanding a group with an ongoing roll.
Please note this is not blizz-like but at least we don't leak memory anymore.

(cherry picked from commit f04e90f638)
2021-11-23 21:28:23 +01:00
Sorikoff
fc9106054b Scripts/Scarlet Enclave: Grand Theft Palomino (#22967)
* Grand Theft Palomino

* Cosmetic issues

* Address CR

(cherry picked from commit d5f565f429)
2021-11-23 21:28:03 +01:00
Chaouki Dhib
4507a02ada Core/Movement: Implement move time skipped handler (#22994)
* Implement CMSG_MOVE_TIME_SKIPPED handler and move it to MovementHandler.cpp

* Add better error handling

* Update MovementHandler.cpp

(cherry picked from commit f9ed72e351)
2021-11-23 21:18:07 +01:00
jackpoz
e475cac631 Core/Spells: Fix assert triggered
Fix assert triggered when a spell would trigger another spell in OnEffectHitTarget that would kill the aura owner, then processing the main spell effects. The triggered spell can kill the aura owner, changing its death state to CORPSE and removing auras created.

Fix #21856
Ref 518e6299ca

(cherry picked from commit 46c7446bd4)
2021-11-23 20:47:31 +01:00
Sorikoff
31f4bb1436 DB/Quest: Sniff Out the Enemy
Closes #23006

(cherry picked from commit 806dd940ce)
2021-11-23 20:46:27 +01:00
Killyana
13aef5574b DB/Creature: Fix Saviana Ragefire movements
Closes #18773

(cherry picked from commit b1604ba0cd)
2021-11-23 20:44:33 +01:00
Killyana
a482f97a5a DB/Creature: Fix Val'kyr Herald movements
Closes #23004

(cherry picked from commit a19c21d4eb)
2021-11-23 20:42:38 +01:00
Killyana
ce6a6acc5c DB/Creature: Fix some spawns in Ogri'la
(cherry picked from commit 9c6e838083)
2021-11-23 20:40:46 +01:00
Killyana
4cdecf0076 DB/Quest: Improvements for "Bombing Run"
(cherry picked from commit 9d37d39511)
2021-11-23 20:38:24 +01:00
Killyana
ffa427b7e4 DB/Creature: Remove Priestess Tyriona wrong spawn
(cherry picked from commit 6679e3010e)
2021-11-23 20:35:29 +01:00
Killyana
8d13e41bf2 DB/Spell: Freezing Circle
Updates #11312

(cherry picked from commit 3432edf3dc)
2021-11-23 20:34:37 +01:00
Killyana
d410971d89 DB/Creature: Blockade Cannon and blockade pirate
Closes #22489
By illfated and ZenoX92

(cherry picked from commit e21a1a6825)
2021-11-23 20:33:09 +01:00