Commit Graph

4542 Commits

Author SHA1 Message Date
treeston
a37e6e20c8 Scripts/Naxxramas: Loatheb follow-up:
- Fix Deathbloom (for real this time)

(cherry picked from commit 17fdb1e091)
2015-11-06 09:54:40 +01:00
Naios
0b6f784591 Core/AI: Convert the hardcoded variadic RAND functions into one C++11 variadic template version. 2015-11-01 14:33:31 +01:00
joschiwald
92b08fc74b Scripts/VioletHold: rewrote the whole instance
thanks @MitchesD for help

(cherry picked from commit df21162fe4)
(cherry picked from commit 3a4f54197c)
(cherry picked from commit f50df72820)
(cherry picked from commit 95bae7143f)
(cherry picked from commit 5406f82044)
2015-11-01 13:09:30 +01:00
jackpoz
7b684e8813 Script/Commands: Add new "debug loadcells" command
Closes #15292

(cherry picked from commit 5e1722c2f4)
2015-11-01 12:30:45 +01:00
jackpoz
ee5eb215e9 Scripts/Commands: Change few commands to target current Player by default
(cherry picked from commit d1efb90ae8)
2015-11-01 12:00:48 +01:00
Vincent-Michael
23bb45bfe9 Core/Misc: Fix issues reported by static analysis
Coverity defect IDs: 1296295, 1296294

(cherry picked from commit 5745c880fd)
2015-11-01 10:44:39 +01:00
Shauren
5da3079471 Build fix 2015-11-01 00:43:56 +01:00
Kittnz
2cd545849c Scripts/Uldaman: Fix build & fix some movement suggested by josch
(cherry picked from commit cf286ea9cd)
2015-11-01 00:31:18 +01:00
Kittnz
c094e49e74 Scripts/Uldaman: Instance update
- Fixup Boss Ironaya
- Add the freeze animation for minions and archaedas
- Fix attack target for minions who wake up

(cherry picked from commit 9cb4cb52d8)
2015-11-01 00:31:00 +01:00
w1sht0l1v3
43cf01d510 Core/LFG: Fix crash in ".lfg group <playername>" in case of offline player and
extend the output to display the offline members of the group also.Atm if members are offline no info is displayed.

Note: all the new code is mostly copy/paste from ".group list <playername>" command.
(cherry picked from commit 4e0dec7fd2)
2015-11-01 00:29:31 +01:00
Kittnz
e4d0652e7f Core/Script: Make 2 remaining bridge parts active in Serpent Shrine
(cherry picked from commit 6e1113a810)
2015-10-31 18:12:59 +01:00
MitchesD
26d362febc Revert "DB/NPC: Stable Masters" Please in the future mark 335 only commits with *_335 in the end of SQL file, if it has any.
This reverts commit 18f511431a.
2015-10-30 14:46:14 +01:00
Killyana
18f511431a DB/NPC: Stable Masters
Closes #15505

(cherry picked from commit a513abc02c)

# Conflicts:
#	src/server/scripts/World/npcs_special.cpp
2015-10-30 14:34:46 +01:00
joschiwald
b459b10b0f Core/Scripts: fixed startup errors
Closes #14730

(cherry picked from commit 497aa4425b)

# Conflicts:
#	src/server/scripts/Northrend/Ulduar/Ulduar/boss_flame_leviathan.cpp
2015-10-30 14:01:26 +01:00
treeston
7886fafbdc Heigan cleanup:
- NearTeleportTo hack -> proper spell with DB coordinates
- Add boss emotes
- Some code streamlining using event phases and IN_MILLISECONDS instead of large constants
- Improvement to eruption hitbox and delimiters to match retail layout more closely
- Spell timers adjusted from sniffs

(cherry picked from commit 3e2014a958)
2015-10-30 12:24:26 +01:00
treeston
f3b5bdc0b3 Scripts/Naxxramas: Bugfixes to the Noth encounter.
- Added missing raid boss emotes
- Fixed an issue where Noth would stand idly after blinking if his current target stood still
- Fixed some reset edge cases
- Prevent Noth from dying during Balcony phase
- Fix targeting of 25-man Curse of the Plaguebringer (now has 8 targets, down from 10)
- Fix balcony/ground phase durations to be blizzlike
- Fix an issue where summoned mobs would sometimes not be aggroed automatically
- Get rid of ugly millisecond values in favor of seconds times constant
- Moved the chance to yell on kill to the database
- Prevent AoE abilities from hitting Noth during the balcony phase
- General cleanup of events handling
- Generally make @Nayd happy

(cherry picked from commit 3fc1bb1abf)

# Conflicts:
#	src/server/scripts/Northrend/Naxxramas/boss_noth.cpp
2015-10-30 11:46:37 +01:00
treeston
dba753b0ef Scripts/Naxxramas: Adjustments to the Loatheb encounter
- Adjusted doom cast timings as per boss mod timers.
- Add Deathbloom's final tick using spellscript
- Move Spores' Fungal Creep cast handling to Loatheb's cpp instead of handling it in SmartAI
- Fungal Creep should also be cast if the spore expires (important for Spore Loser achievement)
- Remove Fungal Creep from players on reset to avoid cheesy strats

(cherry picked from commit ea1c783b84)
2015-10-30 11:42:19 +01:00
tkrokli
3d9b2d8de2 Core/Scripts: The Endless Hunger & Death's Challenge, creature text
This PR solves the following say text issues:
In quest ID 12733, Death's Challenge, the creature script npc_death_knight_initiate is supposed to target the player and refer to the player character's name in the following 2 lines from `creature_text`.`entry` 28406:

- "You don't stand a chance, $n." (`BroadcastTextId` 29267)
- "Remember this day, $n, for it is the day that you will be thoroughly owned." (`BroadcastTextId` 29270)

In quest ID 12848, The Endless Hunger, the creature script npc_unworthy_initiate is supposed to target the player and refer to the player character's race in the following 2 lines from `creature_text`.`entry` 29519, 29520, 29565, 29566 and 29567:

- "You are hopelessly outmatched, $r."  (`BroadcastTextId` 30212)
- "Sate your hunger on cold steel, $r!" (`BroadcastTextId` 30214)

The untargeted variables $r and $n appear in the say lines because the existing script assigns the text to the player character instead of the creatures. This does not produce any race or name information in /say or chat.

This Pull Request closes issue #14700 and replaces PR  #15678.

(cherry picked from commit 89107c3a8e)
2015-10-30 11:33:40 +01:00
Shauren
2d942ddcc5 Core/Commands: Refactored chat command script hook, fixes a crash when building with gcc 5
Closes #15616
Closes #15740
2015-10-22 20:26:56 +02:00
Shauren
a3814d4937 Core/Player: Removed currency precision flag value manipulations, this is all handled clientside 2015-10-20 17:03:37 +02:00
treeston
12e90350e4 Script/BoreanTundra: Fix dialog and final waypoint for quest 11570: "Escape from the Winterfin Caverns"
This fixes the following bugs:

Escortee NPC quotes are out of order (see #15396 (comment))
Final escort waypoint is located incorrectly and causes the escorted NPC to drop all the way to the bottom of the ocean before quest completion is awarded.

Closes #15396

Signed-off-by: DDuarte <dnpd.dd@gmail.com>
(cherry picked from commit a83437af3d)
2015-10-20 15:39:42 +02:00
StormBytePP
e4cf0a0a58 Core/Scripts: Fix noPCH compile
(cherry picked from commit 68e6c95f16)
2015-10-16 13:15:06 +02:00
Nyeriah
07c10ded2e Scripts/TheEye: Update Kael'thas Sunstrider's script
Closes #4180
Closes #4181
Closes #8479
Updates #1885

(cherry picked from commit fe07614916)

# Conflicts:
#	src/server/scripts/Outland/TempestKeep/Eye/boss_kaelthas.cpp
2015-10-16 13:13:09 +02:00
sirikfoll
59742469fb Core/Scripts: Friend or Fowl Achievement
Change AURA_EFFECT_HANDLE_REAL to AURA_EFFECT_HANDLE_REAL_OR_REAPPLY_MASK, the hook needs to be called on every apply/reapply to keep tracking the stack amount.

(cherry picked from commit f877b6af0a)
2015-10-16 12:50:51 +02:00
MitchesD
68d725e211 Scripts/ZulAman: fix build after cherry pick 2015-10-16 12:49:25 +02:00
joschiwald
2bc4dea4da Core/Misc: renamed sGossipSelect parameters
(cherry picked from commit ad38c27124)

# Conflicts:
#	src/server/scripts/EasternKingdoms/ZulAman/zulaman.cpp
#	src/server/scripts/Kalimdor/zone_azshara.cpp
2015-10-16 11:56:53 +02:00
Shauren
63def8aa32 Core/Battle.net:
* Changed packet structures to mirror client names
* Simplified ToString Building
* Removed deprecated structures

World: Cleaned up duplicate realm info 'realm' and 'realmHandle' variables (realmHandle was removed, that data is fully contained in realm)
2015-10-06 00:30:47 +02:00
joschiwald
fe0c07a6fe Core: fixed warning introduced in last commit 2015-10-05 00:12:38 +02:00
joschiwald
cf1e80e3d0 Core/Misc: removed some useless map checks 2015-10-04 14:53:05 +02:00
Shauren
cd27fd38b9 Core/Maps: Moved corpse management to map level 2015-09-28 17:20:27 +02:00
Shauren
3bc3b67a8f Core/Player: Changed ranged weapons to be equipped in main hand slot instead of no longer used ranged slot
Closes #14675
Closes #15296
2015-09-27 00:06:08 +02:00
Shauren
5cf28316ff Merge pull request #15503 from Treeston/3.3.5-patchwerk
Creature/BossAI/Patchwerk: Fix Hateful Strike behavior
(cherry picked from commit ce2aa49715)
2015-09-25 00:09:34 +02:00
treeston
888c4c07b6 Scripts/Naxxramas:
Fixed bugs with Sapphiron encounter:
- Sapphiron will now properly re-engage if the previous attempt ended while he was in flight.
- Sapphiron will now properly be hovering while in the air phase instead of standing idly on the ground.
- Move Frost Resistance achievement check from custom script to spell 60539 (Sapphiron Achievement Check), thanks to @Shauren for the heads up.

(cherry picked from commit a90ae075c9)
2015-09-25 00:07:34 +02:00
jackpoz
f2ca107fc8 Scripts/Ulduar: Fix issue reported by static analysis
Coverity defect ID: 1316690

(cherry picked from commit 4cdab0cdcb)
2015-09-25 00:06:30 +02:00
jackpoz
2f0079410d Core/Dungeon Finder: Improve ".lfg queue debug" command
Log roles of every combinations in ".lfg queue debug" output

(cherry picked from commit 16e9882aa8)
2015-09-24 23:43:01 +02:00
joschiwald
7a2b87cefb Merge pull request #15385 from Tonghost/3.3.5
Core/Scripts: Remove duplicate code
(cherry picked from commit 5c68223ab6)
2015-09-24 23:30:42 +02:00
joschiwald
010b2182c1 Scripts/Ulduar: fixed sara get killed by guardians of yogg saron
(cherry picked from commit 2b21fbb58e)
2015-09-24 23:29:23 +02:00
Nyeriah
e5eea44e0a Scripts/OnyxiasLair: Force Onyxia to enter evade mode if pulled out of her room
(cherry picked from commit b28849003c)
2015-09-24 22:56:14 +02:00
Nyeriah
4a37edef51 Scripts\MoltenCore: Disable Ragnaros' combat movement
(cherry picked from commit 8b27b61978)
2015-09-24 22:55:34 +02:00
joschiwald
a3732aea48 Scripts/Ulduar: fixed hodir kill credit
Closes #15303

(cherry picked from commit 30fc4f9f63)
2015-09-24 22:35:33 +02:00
jackpoz
0fad953852 Scripts/Misc: Replace some unsafe WorldObject* class members in scripts with ObjectGuid
Replace some unsafe WorldObject* class members and derived types in scripts with ObjectGuid.
Code cleanup.

(cherry picked from commit 2f92a2f58e)

Conflicts:
	src/server/scripts/Northrend/Nexus/Nexus/boss_keristrasza.cpp
2015-09-24 22:34:18 +02:00
jackpoz
cacf184822 Core/Misc: Remove unneeded ToCreature() casts
Remove some ToCreature() casts not needed anymore after 1ee90e1022 changes that moved IsPet() from Creature to Unit

(cherry picked from commit d243630acf)

Conflicts:
	src/server/game/Entities/Player/Player.cpp
	src/server/game/Spells/Spell.cpp
	src/server/game/Spells/SpellEffects.cpp
2015-09-24 21:04:46 +02:00
jackpoz
6193b8a28d Scripts/Misc: Fix possible crash
Fix possible NULL-dereference exception happening in PlayerOrPet checks used in Ulduar and Temple Of Ahn Qiraj

(cherry picked from commit 5f0f152345)
2015-09-24 20:39:42 +02:00
joschiwald
d68e3325d5 Scripts/Ulduar/Algalon: fixed achievement "He Feeds On Your Tears"
Ref #6157
2015-09-20 16:03:48 +02:00
Shauren
3109ab2da0 Core/DBLayer: Allowed using GetDouble for SUM results instead of requiring string conversions 2015-09-13 11:13:04 +02:00
Shauren
f515e9ea67 Merge pull request #15257 from StormBytePP/6.x_fix_four_horsemen_evade
Scripts/Stratholme : Fix closed door at Baron Rivendare by @cr4st
2015-09-11 17:27:43 +02:00
Shauren
1efb3f08e2 Core/Spells: Improved spell category cooldown handling
* Category cooldown is stored with the spell that started the cooldown (and only resetting cooldown on that spell will clear cooldowns on entire category - this fully mirrors client behavior)
* This significantly reduces the amount of data saved to database for cooldowns
* Spell casts from items that have a different category specified than on spell will now check for cooldown during the cast

Closes #15349
2015-09-10 19:39:30 +02:00
Shauren
b564c10b13 Core/Players: Implemented serverside validation of reserved/profane names
Closes #15357

New library dependency: Boost.Regex
2015-08-30 00:17:08 +02:00
StormBytePP
ba2e9fbe95 Core/BuildSystem: Merged crypto into common, cleaned include directory lists (to mimic 3.x buildsystem) 2015-08-24 03:35:19 +02:00
David Girón
15dec9a76c Script/Commands: Add some sanity checks to cast commands
Closes #15061
2015-08-22 00:33:59 +02:00