Commit Graph

30382 Commits

Author SHA1 Message Date
Dr-J
a5b41b4b49 DB/Misc: Updates
1) http://www.wowhead.com/item=24330 should drop if player is on or is rewarded for http://www.wowhead.com/quest=9720/balance-must-be-preserved not only if rewarded for it
2) http://www.wowhead.com/quest=7170/earned-reverence http://www.wowhead.com/quest=7171/legendary-heroes and http://www.wowhead.com/quest=7172/the-eye-of-command should not be repeatable, especially when they require insignia from previous quest and when set as repeatable since quest status never gets saved in database player cannot proceed and when player already turned quest in and received next tier insignia the quest can never be repeated.
3) Fix a issue with http://www.wowhead.com/npc=3771/bleakheart-hellcaller spamming summons
4) Fix timed action list for http://www.wowhead.com/quest=11429/drop-it-then-rock-it
(cherry picked from commit 5d5753c8bc)
2017-03-03 22:57:54 +01:00
SnapperRy
50309e66ba DB/SAI: add yell for NPC Sergeant Lorric.
(cherry picked from commit 960b2ab0f4)

Rename 2016_09_26_00_worl to 2016_09_26_00_world.sql
(cherry picked from commit 6dda015cb7)
2017-03-03 22:56:48 +01:00
SnapperRy
6b8cb42b1e Script/Quest: Trail of Fire (#17939)
(cherry picked from commit 31e495f44c)

Rename 9999_99_99_99_world.sql to 2016_09_25_03_world.sql
(cherry picked from commit 28968c6162)

DB/SAI: fix db errors introduced in 31e495f.
(cherry picked from commit 2452fb977b)

Core/Scripts: Fix build
(cherry picked from commit 6174091d76)
2017-03-03 22:55:23 +01:00
SnapperRy
e5381f64fe DB/Creature: fix creature_text for Gordok Brew Barker.
NPC is spawned in both Alliance and Horde Brewfest locations. Should not speak only Orcish.
(cherry picked from commit a6fd97389a)
2017-03-03 22:49:04 +01:00
joschiwald
2dfdaa49b4 Core/Auth: removed unneeded sub query
(cherry picked from commit ec221c5500)

# Conflicts:
#	src/server/authserver/Server/AuthSession.cpp
2017-03-03 22:48:04 +01:00
SnapperRy
30a7a48ed8 DB/SAI: close gossip when selecting a gossip option from NPC Wing Commander Brack.
(cherry picked from commit 8c5d39437d)
2017-03-03 22:45:58 +01:00
SnapperRy
852a3c895e DB/Conditions: limit targets for spell Dropping Heavy Bomb.
(cherry picked from commit 645d9251ed)
2017-03-03 22:35:31 +01:00
tkrokli
e13fadf8e9 Core/Scripts: move #define to enum/boss emote to DB (#17967)
boss_lurker_below.cpp : remove deprecated #define entries
- remove hardcoded text, use creature_text/broadcast_text
- move #define value & text reference to enum section
- replace TextEmote() with Talk() pointing to DB entry
(cherry picked from commit cd6fcce84b)
2017-03-03 22:31:29 +01:00
jackpoz
9d09307e34 Scripts/ICC: Fix chest loot exploit
Fix an exploit at chest loot bosses Valithria and Deathbringer that allowed the first played to hit them to leave party at low hp % and loot the whole chest alone, without the party being able to loot anything.

(cherry picked from commit c4865fe63e)

# Conflicts:
#	src/server/game/Entities/GameObject/GameObject.cpp
2017-03-03 22:31:28 +01:00
SnapperRy
df3e8cab12 Script/Quest: improvements for Let Them Eat Crow. (#17948)
(cherry picked from commit 275a53b34d)

Rename 9999_99_99_99_world.sql to 2016_09_24_06_world.sql
(cherry picked from commit 7a1f41077f)
2017-03-03 22:31:28 +01:00
SnapperRy
3897de67a4 Core/Creature: update health/mana/damage/armor when changing a creature's entry while keeping the original level.
Fixes an issue introduced in a6ef9d4.

(cherry picked from commit 3d075da504)
2017-03-03 22:01:47 +01:00
SnapperRy
3b0e6250ad DB/Quest: fix creature text for Force Commander Danath Trollbane when quest The Fall of Magtheridon is turned in.
(cherry picked from commit c152a5e654)
2017-03-03 22:01:08 +01:00
SnapperRy
6f94fe8f0a DB/Quest: Weaken the Ramparts, The Longbeards and Unyielding Souls require completion of Expedition Point.
(cherry picked from commit 6e0569aabc)
2017-03-03 22:00:11 +01:00
SnapperRy
757f2c1985 DB/Quest: The Legion Reborn and Know your Enemy require completion of Force Commander Danath.
(cherry picked from commit b55d84483f)
2017-03-03 21:59:15 +01:00
SnapperRy
42824f30f3 DB/Quest: The Exorcism of Colonel Jules:
- Fix quest item Ritual Prayer Beads.
- Proper gossip texts for Colonel Jules.

By Killyana, updates #15370
(cherry picked from commit e8cf1a4daf)
2017-03-03 21:58:28 +01:00
tkrokli
958665ab2e Core/Scripts: move npc_lunaclaw_spirit to SAI
This PR moves the core script `npc_lunaclaw_spirit` to SAI, removing hardcoded text.
The quests 6001 + 6002 are druid class quests to get bear form, removed in patch 4.0.3a

Changes in this PR:
- remove core script, including hardcoded text (with typo)
- use gossip_menu_option for each faction (Alliance & Horde)
- add SAI script to complete quest 6001 or 6002 based on option
- add gossip option conditions for team A (469) or team H (67)
- add gossip option conditions for quest 6001/6002 not completed

(cherry picked from commit 3ad76dea7b)
2017-03-03 21:57:23 +01:00
SnapperRy
6ad12301b4 Script/Quest: The Exorcism of Colonel Jules:
- Summoned NPCs will no longer give experience on kill.
- Require quests Fel Spirits and Digging for Prayer Beads to be completed.
- Reduce number of Foul Purges spawned in a single wave (only two should spawn each time).
- Properly give quest credit when talking with Colonel Jules after the exorcism.

(cherry picked from commit 0d70a7349d)
2017-03-03 21:55:01 +01:00
treeston
6a7ef793ca Scripts/IcecrownCitadel: Fix an issue where Deathbringer Saurfang's exit door could get stuck in a closed state. Fixes and closes #15018.
(cherry picked from commit 429700e614)
2017-03-03 21:51:36 +01:00
Keader
f6c9aff606 Core/Scripts: XT002 improvements in Hard Mode. Closes #17141. (PR #17900)
(cherry picked from commit 1f83412e4d)
2017-03-03 21:51:16 +01:00
Shauren
16698e5b25 Core/Movement: Defined many unknown MovementFlags2 2017-03-03 20:26:45 +01:00
joschiwald
660a46e20a Fixed sql typo
thx @ViserionLIVE
2017-03-02 23:05:53 +01:00
treeston
8dc441ce49 Movement/SplineChain: Fix a potential critical bug where resume info returned during an edge case could fail an assertion when used.
(cherry picked from commit 55ac0186cc)
2017-03-02 21:13:34 +01:00
Dr-J
852b7f8264 DB/Quest: Steamtank Suprise
event flags again
(cherry picked from commit 068ade35b6)
2017-03-02 21:13:17 +01:00
Dr-J
64f3c5c4ef DB/Quest: Bury Those Cockroaches
event flags again.
(cherry picked from commit 2730576823)

Remove space
(cherry picked from commit c07bd6d467)
2017-03-02 21:12:27 +01:00
treeston
b12f19f066 Movement/SplineChain: Streamline the script workflow for resume info a bit, provide static method that does all the ugly pointer casts for you. Also prevent a nullptr dereference crash if scripts mishandle motionmaster, and canonize Chain == nullptr to signify "no resume info".
(cherry picked from commit d3214a0012)

d3214a0 follow-up for code style.
(cherry picked from commit 4deeee66bd)
2017-03-02 21:10:00 +01:00
treeston
ec9c5b19ac Map/InstanceMap: Ease up on a somewhat overzealous error message regarding instance saves.
(cherry picked from commit 820e843391)

# Conflicts:
#	src/server/game/Maps/Map.cpp
2017-03-02 21:09:24 +01:00
Dr-J
02cfa86f8e DB/Quest: The Sum is Greater than the Parts
(cherry picked from commit 9804bb252a)
2017-03-02 20:54:07 +01:00
Dr-J
f204e758d5 DB/Quest: Escape from Silverbrook
Even though this was meant to have been fixed once the last commit did not actually fix this
also condition for the periodic spell so that it only targets silverbrook worgen rather than agroing neutral deers and stags, hostile npcs like bears and conquest hold guards will still attack the horse but the condition prevents the periodic threat spell from hitting anything other than silverbrook worgen.
(cherry picked from commit f7f00d2f08)
2017-03-02 20:53:21 +01:00
Dr-J
86ecdaf44a DB/SAI: Krolmir, Hammer of storms
Fix targeting for credit spell and invoker texts during event.
(cherry picked from commit 1cc75eb924)
2017-03-02 20:52:34 +01:00
treeston
019fc08feb Core/Movement: Fix a DB spline chain overload I missed in 2170541
(cherry picked from commit 3ec1b2f27e)
2017-03-02 20:51:25 +01:00
Dr-J
23fb555391 DB/SAI: More event flags
* Dark Horizon/Reunited
* Kickin' Nass and Takin' Manes
* Load'er Up
* Magic Carpet Ride
(cherry picked from commit fc494f1f47)
2017-03-02 20:51:15 +01:00
treeston
0920ffb7e8 DB/Creature: Re-sniffed Blighted Elk and Rabid Grizzly spawns. Closes #17958. (Thanks, Malcrom!)
(cherry picked from commit 17dfcc0b27)
2017-03-02 20:50:17 +01:00
treeston
205ec4c3bf Core/Unit: Standardize SetFacingTo and SetFacingToObject behavior while moving. Both now fail while moving unless arg2 bool is true.
Movement/SplineChain: Bump value range for DB chainId up to uint16 (0 to 65535) from uint8 (0 to 255). Turns out sniffs generate far more chains than I expected.

(cherry picked from commit 2170541a51)

Code style follow-up, I blame Notepad++.
(cherry picked from commit 7860da0de6)
2017-03-02 20:47:29 +01:00
treeston
b94642fb49 Instance/Naxxramas: Loatheb no longer instantly murders you. Five spam casts of Doom tend to do that to raids.
(cherry picked from commit 59527521e6)

5952752 follow-up: Member declaration now matches order of usage.
(cherry picked from commit 3298a5f65d)
2017-03-02 20:44:41 +01:00
Dr-J
c07ee298dc DB/SAI: A Rough Ride
Fix event flags
(cherry picked from commit ab2acb2c0c)
2017-03-02 20:44:18 +01:00
Shauren
2c27c5b5b9 Core/DataStores: Fixed crash in hotfix packet building
Closes #19218
2017-03-02 19:48:58 +01:00
treeston
59d48ce7e4 Core/Movement: Add new SplineChainMovementGenerator that allows accurate replication of sniffed waypoints in static sequences, along with DB facilities that allow loading of waypoints from DB.
(cherry picked from commit 6d00d3f283)

Merge remote-tracking branch 'Treeston/3.3.5-splinechains' into 3.3.5 (PR #17946)
(cherry picked from commit 20f483967f)

Core/Movement: Add a convenience default ctor to SplineChainResumeInfo, and fix PCH build in some configurations (zzz why do we even keep Appveyor and Travis around).
(cherry picked from commit 4fa646c0b2)

PCH build fix. Again.

(( Alright, you made me waste 20 minutes of my life on a full nonPCH rebuild of the core now. ))
(( I hope you're happy. ))
(cherry picked from commit 4a1a460241)
2017-03-01 22:03:35 +01:00
SnapperRy
9aa4b6d10f DB/Loot: Burning Legion Missive (Alliance version) should always drop.
(cherry picked from commit 7bce4d12a6)
2017-03-01 21:27:33 +01:00
SnapperRy
1bed93ca7c DB/Loot: item Bog Lord Tendril is not a quest item.
(cherry picked from commit 1812a57b4e)
2017-03-01 21:26:38 +01:00
SnapperRy
30105cd522 DB/Quest: Arzeth's Demise:
- Fix yell on quest item use.
- Restore original entry on reset.
- Quest item can only be used on specific NPC.
(cherry picked from commit e2981e1060)
2017-03-01 21:25:29 +01:00
Killyana
05776111e3 DB/Creature: Fix unit flag for Tatjana (Unconscious)
Closes  #15618

(cherry picked from commit 56d20584c7)
2017-03-01 21:24:32 +01:00
Dr-J
59d22ade76 DB/Quest: Anatoly will talk
Fix event flags
(cherry picked from commit f27efa5957)
2017-03-01 21:21:25 +01:00
Dr-J
59590b5395 DB/Misc: Misc Fixes
* Appeasing the Great Rainstone/Gods like Shiny Things update so sai actually works on sholazar guardians so sai runs on charmed creature, also rescript glinting dirt as previous had stopped working
* Teleport This! Charmed flags are needed here so that credit spell is cast when payer uses controlled npc to blow up teleporter.
* Updates to blueleaf tubers as previous fix stopped working due to negative respawn time on spell focus objects
(cherry picked from commit ebc0190d3b)
2017-03-01 21:19:22 +01:00
treeston
c2a7857c8a DB/SmartAI: Fix charm SAI for Quest 12308 "Escape from Silverbrook"
(cherry picked from commit 8d2f17b2a8)
2017-03-01 21:17:07 +01:00
treeston
8ad043ba69 DB/Creature: Add missing IMMUNE_TO_NPC to Dahlia Suntouch.
(cherry picked from commit 8389991275)
2017-02-28 20:41:40 +01:00
tkrokli
e4e1f4152f Core/Scripts: simplified npc_pet_trainer gossip script
This is what the script changes should have been in PR #17746
(also updates issue #14719 with a correct solution).

- remove OnGossipHello() to use DB conditions
- replace OnGossipSelect() with sGossipSelect()
- focus script on the confirming gossip option
- let the other gossip menus be handled in DB

(cherry picked from commit a475033c76)
2017-02-28 20:40:49 +01:00
SnapperRy
953eef9761 DB/Quest: fix prevquests required for Gretta the Arbiter's daily quests.
(cherry picked from commit 0b658f789c)
2017-02-28 20:40:30 +01:00
SnapperRy
d119872589 DB/Quest: Dragonblight/Borean Tundra:
- Fix next quest for The Taunka and the Tauren.
- Fix requirements for Patience is a Virtue that We Don't Need, Taken by the Scourge and the three versions of The Defense of Warsong Hold.
(cherry picked from commit fd6cf2bca6)
2017-02-28 20:39:37 +01:00
SnapperRy
4ea38046b1 DB/Quest: Dragonblight part 2:
- To Dragon's Fall requires completion of Wanted: Magister Keldonus, Wanted: Gigantaur and Wanted: Dreadtalon.
- Black Blood of Yogg-Saron, Marked for Death: High Cultist Zangus and Containing the Rot require completion of Agmar's Hammer.
- Strengthen the Ancients requires completion of The Focus on the Beach.
- Message from the West requires completion of Hellscream's Champion.
- Only one between A Tauren Among Taunka and The Taunka and the Tauren can be completed.
(cherry picked from commit b90afa8857)
2017-02-28 20:38:41 +01:00
SnapperRy
a893855e07 DB/Quest: Dragonblight:
- Victory Nears... requires Agmar's Hammer.
- Strength of Icemist requires From the Depths of Azjol-Nerub.
- Only one between To Venomspite! and Imbeciles Abound! can be completed.
(cherry picked from commit e07f68a032)
2017-02-28 20:37:47 +01:00