Commit Graph

7107 Commits

Author SHA1 Message Date
Carbenium
a6f7bb029c Merge pull request #15023 from robinsch/combatMovement
SmartAI: Incorrect removal of movement at SetCombatMove
2015-07-10 00:38:01 +02:00
jackpoz
fae8269589 Core/Instances: Fix some Instance Lock chat messages
Always send a Welcome type Instance Lock chat message when entering an instance instead of changing type based on remaining time.
Fix scheduled warning message to always send "Your instance lock for ... will expire in 0 minutes." even if there are hours left, issue added in 4193806dba , closes #11519 .
Update warning messages based on remaining time so that the most meaning is always used (6 hours left, 59 minutes left, etc).
2015-07-08 23:32:04 +02:00
robinsch
2b3ea2e181 SmartAI: Fixed a bug where creatures would clear movement flags when they shouldn't at SetCombatMove. 2015-07-07 10:32:49 +02:00
jackpoz
e5258f92c8 Core/Spells: Normalize Z for last point in a charge path
Normalize the new point that 124398feef adds to a charge path.
2015-07-05 11:49:05 +02:00
jackpoz
6681b3600c Core/Misc: Fix build warnings
Fix build warning reported by clang 3.6
2015-07-04 19:28:11 +02:00
Kaev
f3246f65d1 Update BattlegroundWS.cpp
Changed timer check from 900000 to 15*MINUTE*IN_MILLISECONDS for better readability.
2015-07-04 09:53:49 +02:00
DDuarte
dfc71765f8 Core/ObjectMgr: Fix 3 -Wunused-private-field warnings in TempSummonGroupKey
Replace a memcmp by a lexicographical comparison with std::tie

(cherry picked from commit 1df20a2134dbb84d1eb30024171ccd7e8b103e47)
2015-07-04 01:50:35 +01:00
jackpoz
a328a11978 Core/Spells: Fix Charge "no path" error with huge targets
Fix Charge returning "no path found" error when targeting targets with Object Size of 8 like Festergut by changing how the target Z coordinate is set, using only half object size.
It is unclear why the CalculatePath() call in Charge handler is using target object size, maybe for corner cases where the target is slightly below the ground.
2015-07-03 23:16:34 +02:00
mik1893
94bb71e5a1 Merge pull request #14797 from czw/3.3.5
Core/Spells: Fix DK Death rune selection
2015-07-02 14:23:33 +02:00
ShinDarth
5178395a4f DB/World schema backport: split quest_template and quest_template_addon
Closes #14982

Signed-off-by: DDuarte <dnpd.dd@gmail.com>
2015-07-02 00:27:38 +01:00
jackpoz
55681666b3 Core/Misc: Fix build warnings 2015-07-01 20:57:20 +02:00
robinsch
2263cb9e10 Core/Unit: Fix issue with Divine Shield immunities
Closes #14910
2015-07-01 17:37:36 +02:00
mik1893
551c61b7ce Merge pull request #14898 from tkrokli/improved_devouring_plague
[3.3.5] Core/Spells: Improved Devouring Plague spell direct damage
2015-06-30 13:46:18 +02:00
Shauren
efad3a3123 Core/Spells: Implemented CAST_FLAG_IMMUNITY 2015-06-30 11:44:11 +02:00
Carbenium
adb5d3ea5f Merge pull request #14941 from ShinDarth/db_backports3
DB/World schema backport: move questItem* fields to *_questitem tables
2015-06-29 20:03:11 +02:00
mik1893
aacd8feb61 Merge pull request #14969 from chaodhib/taunt_threat_fixes
[Spell] Fix bugged amount of threat given by Taunt
2015-06-29 19:53:28 +02:00
ShinDarth
1c0b0f825c DB/World schema backport: move questItem* fields to *_questitem tables 2015-06-29 19:21:00 +02:00
chaodhib
00788c6f01 [SpellEffect] Fix bugged amount of threat given by Taunt
1) doAddThreat call instead of AddThreat. ThreatCalcHelper shouldnt be called. Otherwise, the value of the threat that will be added to the caster will be multiplied by a threatModifier (about 1.6)
2) Taunt should give the caster the same threat as the one in the top of the list. If player A has aggro with 1000 threat, player B has 1050 threat and if player C taunts, player C should have 1050 threat after the taunt and not 1000 (the difference can be much bigger with ranged players).
2015-06-29 17:39:55 +02:00
robinsch
7fbd035620 Core/WorldState: Send BATTLEFIELD_WG_WORLD_STATE_ACTIVE when sending initial world states for Wintergrasp. This will fix issue #14913 2015-06-29 10:49:43 +02:00
jackpoz
dfa556aaa2 Core/Dependencies: Update recast
Update recast to 1dd5cf1883
Fix 2 warnings.

These changes have no effect on MMAPs and it's not needed to re-extact them.
2015-06-28 21:20:01 +02:00
Mik1893
accab5451d Core/Creature: Fix UNIT_FLAG_IMMUNE_TO_PC validity for player pets
related to #14780 and #14744
2015-06-26 16:52:40 +02:00
Shauren
2538a84d0c Core/Units: Changed SPELL_AURA_MOD_MINIMUM_SPEED to always be applied, not only if under a slow aura (SPELL_AURA_MOD_MINIMUM_SPEED can set the minimum speed higher than base speed)
(cherry picked from commit d2142ac380)
2015-06-26 01:26:22 +01:00
DDuarte
24b5dfcb4d Core/BattlegroundIC: Removed 1 hack:
* Parachute spell is now blizzlike
* Also restored "The battle will begin in 2 minutes."

(cherry picked from commit 8a4afad63a)

Conflicts:
	sql/updates/world/2015_05_01_00_world.sql
	src/server/game/Miscellaneous/Language.h

Rename 2015_05_01_00_world.sql to 2015_06_13_00_world.sql

(cherry picked from commit 74eeefa5be)
2015-06-26 01:24:21 +01:00
Shauren
5fe819462f Core/GameObject: Removed unneeded argument from GameObjectModel::Relocate and renamed it to UpdatePosition
(cherry picked from commit 6e9ab38fcc)
2015-06-26 00:53:12 +01:00
DDuarte
80695181b9 Core/LootMgr: Remove dead validation code from LoadLootTable
CID 1288389 Operands don't affect result

(cherry picked from commit 47a119e4fa)
2015-06-26 00:51:16 +01:00
DDuarte
ae64c11b28 Core: Fix multiple Coverity issues
(cherry picked from commit b8c681c776)

Conflicts:
	src/server/game/Garrison/Garrison.cpp
	src/server/game/Server/Packets/CharacterPackets.h
	src/server/game/Server/Packets/MovementPackets.h
	src/server/game/Spells/SpellInfo.cpp
2015-06-26 00:49:38 +01:00
ShinDarth
f8230a59a9 DB/Characters: Backport schema changes from 6.x branch (renames)
Closes #14951
2015-06-26 00:28:32 +01:00
jackpoz
cb4d1574e0 Core/Instances: Make achievements and loot rolls instance-wide
Make achievements, loot rolls, master loot at money loot instance-wide, removing the previous limit for 74.f yards
2015-06-24 22:40:57 +02:00
Rushor
8f3a9b7fe3 Game/GameObject: Fix Spellcast for 'Silithyst'
by @Whoami
updates #14637
2015-06-23 15:28:51 +02:00
ShinDarth
6b43e72f01 DB/World: Backport schema changes from 6.x branch (renames)
Closes #14899
2015-06-23 00:16:15 +01:00
MitchesD
a35ec4c35a Core/Creature: fixed loading of creature auras on respawn, deathState needs to be set to ALIVE before trying to AddAuras (which fails with different deathState than ALIVE)
Closes https://github.com/TrinityCore/TrinityCore/issues/4150

(cherry picked from commit 530074f453)
2015-06-21 13:44:01 +02:00
jackpoz
c6c09423fd Scripts/Commands: Fix memory leak in ".reload command"
Free commandTableCache object before assigning it the result of malloc()
2015-06-20 22:42:30 +02:00
robinsch
9147c12114 [3.3.5] Core/Spells: Improved Devouring Plague spell direct damage
by @robinsch; closes #14869 (Improved Devouring Plague error in direct damage)

Pct damage bonus is not applied because in SpellDamageBonusDone,
it just returns 1.0f for DamageType DoT. Because Improved Devouring Plague direct damage
is based on DoT damage from plague, it should also be modified when DoT damage is.
2015-06-18 20:22:03 +02:00
jackpoz
c544e88437 Core/Players: Fix converting quests on faction change
Fix quests not being converted on faction change due to table world.player_factionchange_quests not loaded on startup
2015-06-17 21:36:04 +02:00
jackpoz
91c399cad2 Core/Spells: Fix Charge pathing
Fix charge allowing to run to unreachable places
Close #13847
2015-06-17 19:39:37 +02:00
jackpoz
6d7339e7a3 Merge pull request #14728 from kelno/fixes
Core/SAI: Fixed a math error overflow in SmartScript::DecPhase(int32)
2015-06-14 18:34:11 +02:00
jackpoz
5b666ee393 Merge pull request #14611 from ariel-/spells
Core/Spell: Spell logging corrections
2015-06-14 18:09:22 +02:00
jackpoz
81cec13a58 Merge pull request #14250 from xjose93/SPELL_AURA_USE_NORMAL_MOVEMENT_SPEED
Core/Unit: Fix snare/daze immunities versus SPELL_AURA_USE_NORMAL_MOVEMENT_SPEED

Fix SPELL_AURA_USE_NORMAL_MOVEMENT_SPEED modifying speeds of bosses that are immune to changes of speeds.
2015-06-14 16:34:49 +02:00
xjose93
6f2b086048 Core/Unit: Fix snare/daze immunities versus SPELL_AURA_USE_NORMAL_MOVEMENT_SPEED. 2015-06-14 13:45:29 +02:00
jackpoz
d123c81162 Core/Texts: Fix race conditions in CreatureTextMgr repeat group
Fix race conditions in CreatureTextMgr repeat group happening with MapThreads > 1 reported by helgrind by moving Creature-GUID-base data from CreatureTextMgr to Creature.
Issues added in bbf86641a1
2015-06-13 12:27:19 +02:00
MitchesD
f166dc3cab Merge pull request #14838 from Rushor/stop
Scripts/SmartScripts: Clear Movement on Death
2015-06-11 10:57:10 +02:00
pete318
f9cba93985 Core/Spells: Support for targetting spells onto in flight units
* This adds support to spell_custom_attr to allow a spell to be cast
  upon a unit on a taxi/in flight.
* This will allow the Issue #11880 with Horde quest Test At Sea (11170) to be corrected.
* closes #14235

Signed-off-by: Naios <naios-dev@live.de>
2015-06-04 13:35:05 +02:00
jackpoz
239f0b4ad0 Core/Player: Don't allow to join bg/lfg when frozen by a GM 2015-06-03 22:08:01 +02:00
robinsch
cb280ec5dd Scripts/SmartScripts: Clear Movement on Death 2015-06-03 14:54:01 +02:00
pjasicek
6a637f6b1c Core/Matchmaking: Fix Discard Time overflow on server start
Description:

When server starts and RatingDiscardTimer config is set to some value, discardTime being unsigned int overflows for the time of RatingDiscardTimer value and causing all rated arena matches ignore matchmaking rating for that time.
2015-06-03 02:44:36 +02:00
Carbenium
fa6a063329 Core/Creature Fix compiler warning 2015-06-02 20:13:12 +02:00
jackpoz
83cf1e6aec Core/Player: Fix resurrection exploit
Fix an exploit that allowed to resurrect even if corpse was not in range (teleport hack was required too)
2015-06-02 19:16:42 +02:00
Carbenium
52ea75c735 Merge pull request #14811 from tkrokli/Knockback_flying_mount
Core/Movement: Knockback Effect on Flying Mount
2015-06-02 15:14:03 +02:00
Carbenium
125d839a18 Merge pull request #14780 from mik1893/immune_to_npc_flag
Core/Creature: UNIT_FLAG_IMMUNE_TO_NPC check only vs non-player targets
2015-06-02 14:40:11 +02:00
robinsch
81111116fa Core/Movement: Knockback Effect on Flying Mount
by @robinsch; closes #6099

Keep the mounted player flying after the knockback effect cast on mounted player.

Before these changes, the flying mount behaves like a ground mount after the knockback.
From large enough heights, the fall causes damage or death to the falling (mounted) character.
2015-06-02 04:26:40 +02:00